PDA

View Full Version : [SRL-OSR] Mafia Miles Fly Fisher[SMART]



mafia miles
04-02-2013, 06:14 AM
http://s11.postimg.org/7fvtr0r9f/RSFLYFISH.png
Mafia Miles Fisher
Introducing my Barbarian Village Fly Fisher.

As soon as it recognizes that there is a fish in the inventory it will drop it. Later versions will include cooking and dropping the cooked fish. I might add a banking feature if SPSWALK on rs Gets fixed.

IMPORTANT
Only keep 7 items in first 7 inventory spots. Fly fish rod BRING MULTIPLE, feathers
Only Afk if your willing to die. Randoms appear, No antirandom yet.
BabySit Your Bot!

Realeasing because I can only use SRL-OSR in my simba. The other fly fisher has a p07 include that I cant get to run.



program Fisher1;
{$DEFINE SMART8}
{$I SRL-OSR/SRL.Simba}
{$I SRL-OSR/SRL/Misc/Debug.Simba}

var x, y, i: integer;
const
AccountLogin = '';
AccountPass = '';
CharacterName = '';
version = '1.1'; //fish1drop1 Wont Drop Featers or Rod When Placed In
//the 1st-7th spot. Fill 1-7 invy spot with feathers and Rods :)

//Declare your username and password
procedure DeclarePlayer;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name := AccountLogin;
Players[0].Pass := AccountPass;
Players[0].Nick := CharacterName; //Important for antirandoms
Players[0].Active := True;
end;

Procedure AntiBan;
begin
//writeln('antiban debug!');
Case Random(130) Of
1: HoverSkill(skill_fishing, false);
3: Boredhuman;
4: Wait(2500 + random(4500));
5: PickUpMouse;
6: RandomMovement;
7: RandomRClick;
8: MakeCompass('random');
end;
end;



Procedure DebugShiftCount;
Var
PBox: TBox;

Begin
PBox := IntToBox(245, 130, 285, 195);
Writeln(IntToStr(AveragePixelShift(PBox, 250, 500)));
End;


Function isfishing: Boolean; //Average PixelShift from Flights TuT (THANKS FLIGHT!!)
var
PBox: TBox;
begin
PBox := IntToBox(230, 165, 290, 260);
Result := (AveragePixelShift(PBox, 300, 600) > 100); //Only 50 cause you are the only thing moving, so a little movement means chopping :)
end;



Procedure DropFish;
var
i: Integer;
begin
Writeln('Inventory full! Dropping Fishys!');
if(InvFull) then
for i := 7 to 28 do
begin
if ExistsItem(i) then
DropItem(i);
wait(50+random(50));
end;
end;

procedure Fish;
var
x, y, i: integer;
begin
if not(isfishing) then
wait(500);
if (FindObjCustom(x, y, ['ure', 'ishin', 'ot'], [14597535, 15123609, 14794914, 14858129, 13216647, 14597268, 15123625, 14398100, 14729121], 3) ) then
begin
wait(600 + random(500));
mouse(x,y,1,1,1)
wait(5000 + random(100));

Repeat
if(InvFull) then
DropFish;
Until not(isfishing)
end;
end;




begin
SetupSRL;
activateclient;
DeclarePlayer;
LoginPlayer;
wait(500);
repeat
begin
Antiban;
Fish;
end;
until(false);
end.
20452
20515

matthew1993
04-02-2013, 06:28 AM
Seems like a really nice script, will test!

May I ask does it work on other fishing spots?

Bicep
04-02-2013, 03:24 PM
will test it :)

Riley
04-02-2013, 07:02 PM
Its pretty nice, wouldnt it gain more xp if you wait until inv is full then drop?

mafia miles
04-02-2013, 07:34 PM
Yes it would, but I am having trouble getting it to drop every time its full. So I went with a more simple dropper.

Bicep
04-02-2013, 07:56 PM
Yes it would, but I am having trouble getting it to drop every time its full. So I went with a more simple dropper.

hey mate, your script runs great. With some help I was able to adjust it to drop after a full inventory. Now I need to get it to recognize when it's fishing and when not to prevent mass clicking on fishing spots. When I got it done perfectly I will let you know ;)

mafia miles
04-02-2013, 08:34 PM
Thanks, feel free to post the code here, and with you permission Ill add your adjusted code into the script(with credits ofc)!

Bicep
04-02-2013, 08:39 PM
Thanks, feel free to post the code here, and with you permission Ill add your adjusted code into the script(with credits ofc)!

Sure will do mate. :)

redd228
04-02-2013, 10:53 PM
Exception in Script: Unable to find file 'SRL-OSR/SRL.Simba' used from ''

Riley
04-02-2013, 11:22 PM
I think if you add a wait ( Amount of time it takes for full inv + random (some number)); it would work for full inv But thats a maybe.

matthew1993
04-02-2013, 11:40 PM
I think you could use InvFull to detect if the inventory is full then DropAllExcept the first 2 slots. Works nice except the dropping of fish and some randoms!

Good job man!

Riley
04-02-2013, 11:45 PM
Exception in Script: Unable to find file 'SRL-OSR/SRL.Simba' used from ''



You need to download SRL-OSR and put it in your includes folder. and rename it to SRL-OSR

the_king5100
04-02-2013, 11:55 PM
Changing between fishing spots all the time, thats only thing that bugging me.

adeghati
04-03-2013, 12:18 AM
nice script, its functional but not flawsless. Looking forward to cooking support.

tsaopower
04-03-2013, 01:28 AM
Script doesnt detect randoms and lost my fly fishing rod :(

mafia miles
04-03-2013, 01:31 AM
As stated before you need to babysit. Its not perfect. Ill add random detection and spot changing after more randoms are solved by the community.

matty521521
04-03-2013, 01:41 AM
Is there any anti-ban? even simple? it doesnt seem like it, im scared ill get banned lol

mafia miles
04-03-2013, 01:58 AM
Dont Bot if your not willing to get banned. Last I heard Bottings not very bannable right now. Yes theres a antiban but it is simple and not very evolved. There are not very many people using my scripts so the ban chance is low. Go for it in my opinion.

matthew1993
04-03-2013, 11:20 AM
Script doesnt detect randoms and lost my fly fishing rod :(

To get around this you could do this:



begin
oo:= RandomRange(200, 400)
for i:= 4 to 28 do
if ExistsItem(i) then
begin
MouseItem(i, mouse_right);
WaitOptionEx('rop', 'action', ClickLeft, oo);
end;
end;

Change that to:



begin
oo:= RandomRange(200, 400)
for i:= 8 to 28 do
if ExistsItem(i) then
begin
MouseItem(i, mouse_right);
WaitOptionEx('rop', 'action', ClickLeft, oo);
end;
end;

Now you can get 1 slot feathers and 7 slots rod's. You will need a couple more randoms to loose all your rods.

Hoodz
04-03-2013, 11:46 AM
HoverSkill(skill_hitpoints, false) should be changed to hoverskill(skill_fishing, false). Right? It seems odd when you keep watching your hp xp while you are fishing. Other than that, nice basic script keep updating it and it will turn in a flawless and awesome fisher :)

mafia miles
04-04-2013, 09:34 PM
Updating Script to 1.1. Now Hovers over fishing skill occasionally. Will now DETECT if fishing, so it will NOT spam click :) No Random support yet, please link me on how to detect if in a area, or if randoms are around. Thank You and Fish On!

the_king5100
04-05-2013, 12:05 AM
Still jumps from spot to spot :( if that worked the bot would be very good.

mafia miles
04-05-2013, 12:53 AM
I'll look at it.

dieg0
04-05-2013, 01:23 PM
hi, i would really like the silk thiever since i need 53 thiefing haha,
does it drop full inventory when its full? because that would be the best.
you should release it ! or share with me haha XD

the_king5100
04-05-2013, 09:40 PM
What is happening with the bot?

mafia miles
04-06-2013, 12:16 AM
What do you mean? It should work fine.

flynn1
04-06-2013, 11:24 AM
Hi, I get this error, could anybody help me please I would appriciate it [Error] C:\Simba\Includes\SRL-OSR/SRL/misc/SmartParams.Simba(229:203): Invalid number of parameters at line 228
Compiling failed.

the_king5100
04-06-2013, 09:41 PM
No it dont, it stills hops from spot to spot :(

It stills spamclick so it changes spots. Yes i have 1.1

mafia miles
04-07-2013, 04:29 AM
How often does it click? mine clicks < one time every ten seconds. it should detect if fishing and not to click if so. You realize you cant constantly fish without clicking right?

dzpliu
04-07-2013, 04:45 AM
change your fish procedure to something like below for better results.
it ensures that it will only look for new spot when your not fishing.
i cant test your script cos i dont play 07.
procedure Fish;
var
x, y, i: integer;
begin
if not(isfishing) then
begin
wait(500);
if (FindObjCustom(x, y, ['ure', 'ishin', 'ot'], [14597535, 15123609, 14794914, 14858129, 13216647, 14597268, 15123625, 14398100, 14729121], 3) ) then
begin
wait(600 + random(500));
mouse(x,y,1,1,1)
wait(5000 + random(100));

Repeat
if(InvFull) then
DropFish;
Until (InvCount=7);
end;
end;
end;

mafia miles
04-08-2013, 12:09 AM
Thanks Man! Will test and update script with credit.

reimo992
04-10-2013, 12:05 AM
Script is awesome, but the bad thing is its spamming the pool like every 10 secs and it makes script change pools very often and makes it pretty easily detectable. If you could fix it somehow it would be good. : p

Neznam
04-10-2013, 12:29 AM
Hi, I get this error, could anybody help me please I would appriciate it [Error] C:\Simba\Includes\SRL-OSR/SRL/misc/SmartParams.Simba(229:203): Invalid number of parameters at line 228
Compiling failed.

Remove the number 8 from {$DEFINE SMART8} at the top of the script.

Seek
04-10-2013, 03:27 PM
Lots of problems with this. It hops fishing spots constantly, I've had it drop my feathers twice now (I was babysitting, looked away for 3 minutes, came back to no feathers) Also it doesn't change from the one location (Fish icon on minimap) to the other when the spots are gone 90% of the time. Even babysitting seems useless; every time I look back I'm either tele'd by a random or have no feathers. And before you ask, yes my feathers are in the first slot. Appreciate the work you've put into this but it needs many fixes to be useable.

mafia miles
04-10-2013, 11:14 PM
make a video of yourself doing that. your the only one to report dropping feathers.

Seek
04-10-2013, 11:37 PM
I'll try to

karl00111
04-12-2013, 05:37 AM
pretty well written just doesnt move between fishing spots

dzpliu
04-12-2013, 05:53 AM
Lots of problems with this. It hops fishing spots constantly, I've had it drop my feathers twice now (I was babysitting, looked away for 3 minutes, came back to no feathers) Also it doesn't change from the one location (Fish icon on minimap) to the other when the spots are gone 90% of the time. Even babysitting seems useless; every time I look back I'm either tele'd by a random or have no feathers. And before you ask, yes my feathers are in the first slot. Appreciate the work you've put into this but it needs many fixes to be useable.

he recently updated it. have you updated the code yet?
btw the script shouldnt even drop anything before the 7th inventory slot. so most probably you didnt set something correctly. i cant test the script cos i dont play 07, i merely looked at the script.

Jagex Mod
04-16-2013, 11:06 PM
No joke, there's a guy on RS with the same name as you mafia. I think you just sold me some flax.

kylep
04-18-2013, 03:18 PM
hi, i would really like the silk thiever since i need 53 thiefing haha,
does it drop full inventory when its full? because that would be the best.
you should release it ! or share with me haha XD

the thiever should pick one drop one as thats best xp...

mafia miles
04-18-2013, 08:59 PM
Eh. It was a personal script tbh. Not fancy enough to release.
Lol no i have no in game name related to mafia miles.

Pieman1444
06-30-2013, 04:15 PM
I've been using this script for a few hours now. It does click the fishing spot more then it has to. But, it does switch to new fishing spots and drops the fish good. It would be great if it ran from combat. But overall better then any other fly fisher on here. So goodjob :)

ned 2 sp3c
07-04-2013, 08:52 AM
this is so bad because he don't wait until full back ... he drops them when he gets 1 fish ....

Le_don
08-04-2013, 04:25 PM
I have edited this script slightly to my needs and have improved it somewhat, I think.

Drops items in inventory space 3-28, so you have space for one rod and feathers in the top left.

Also sets up the camera so that isfishing will find your pixelshift, and has a random chance of resetting the camera to that position to make sure nothing breaks.

Also draws a box where isfishing checks pixelshift so you can see if your camera is in the wrong position.


program Fisher1;
{$DEFINE SMART8}
{$I SRL-OSR/SRL.Simba}
{$I SRL-OSR/SRL/Misc/Debug.Simba}
{$I SRL-OSR/SRL/misc/SmartGraphics.Simba}

var x, y, i: integer;
const
AccountLogin = '';
AccountPass = '';
CharacterName = '';
version = '1.1'; //fish1drop1 Wont Drop Featers or Rod When Placed In
//the first 2 inventory spots.

//Declare your username and password
procedure DeclarePlayer;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name := AccountLogin;
Players[0].Pass := AccountPass;
Players[0].Nick := CharacterName; //Important for antirandoms
Players[0].Active := True;
end;
Procedure SetupCamera;
begin
KeyDown(VK_UP);
wait(randomrange(1500, 2500));
KeyUp(VK_UP);
wait(randomrange(300, 500));
MakeCompass('E');
end;
Procedure AntiBan;
begin
//writeln('antiban debug!');
Case Random(130) Of
1: HoverSkill(skill_fishing, false);
2: Wait(2500 + random(4500));
3: PickUpMouse;
4: RandomRClick;
end;
end;



Procedure DebugShiftCount;
Var
PBox: TBox;

Begin
PBox := IntToBox(245, 130, 285, 195);
Writeln(IntToStr(AveragePixelShift(PBox, 250, 500)));
End;


Function isfishing: Boolean; //Average PixelShift from Flights TuT (THANKS FLIGHT!!)
var
PBox: TBox;
begin
PBox := IntToBox(230, 165, 290, 260);
SMART_DrawBox(intToBox(230, 165, 290, 260));
Writeln('Checking if we are fishing in this box.');
Result := (AveragePixelShift(PBox, 300, 600) > 100);
end;



Procedure DropFish;
var
i: Integer;
begin
Writeln('Inventory full! Dropping Fish!');
if(InvFull) then
for i := 3 to 28 do
begin
if ExistsItem(i) then
DropItem(i);
wait(50+random(50));
end;
end;

procedure Fish;
var
x, y, i: integer;
begin
Repeat
if not(isfishing) then
begin
wait(500);
if (FindObjCustom(x, y, ['ure', 'ishin', 'ot'], [14597535, 15123609, 14794914, 14858129, 13216647, 14597268, 15123625, 14398100, 14729121], 3) ) then
begin
wait(600 + random(500));
mouse(x,y,1,1,1)
wait(5000 + random(100));
end;
end
else Writeln('We are fishing!');
Until not(isfishing) or (InvFull)
if (InvFull) then
begin
DropAllExcept([1, 2]);
end;
end;





begin
SetupSRL;
activateclient;
DeclarePlayer;
LoginPlayer;
wait(500);
SetupCamera;
repeat
Antiban;
Fish;
begin
Case Random(50) Of
1: SetupCamera;
end;
end;
until(false);
end.