PDA

View Full Version : [Catherby] Fisher [Lobsters]



joulaha
02-12-2014, 11:36 PM
Simple as it gets, catherby fisher. For lobsters.
You may have seen my RSPS scripts which are similar.

How it works ?
Start near bank
Checks if you have cage, if not then logs out does nothing and reports the lack of cage!
Walks to fishing spot
Finds fishing spot, somewhat intelligent since it does not click whirlpools :)
Starts fishing
Does antibans (Randomly right clicks, moves screen around and so on)
Checks if you are fishing
If you are not fishing then checks for cage option again, if not found then moves on to next spot
When inventory is full walks to deposit box and empties inventory (Needs better way to find the deposit box, works now fine though) (Needs to be improved, currently checks if there is lobster on last spot of inventory)
Starts again

Things that need to be worked on
Need better method for finding fishing spot,maybe?
Need better method for finding deposit box
Perhaps better proggy?
Better check for full inventory
Add check for randoms!
Add check for having level

REQUIRES
Smart 8.3 - http://villavu.com/forum/showthread.php?t=105548
Reflection - http://villavu.com/forum/showthread.php?t=107698
SRL-OSR - http://villavu.com/forum/showthread.php?t=99577
These might help with problems
http://villavu.com/forum/showthread.php?t=106693
http://villavu.com/forum/showthread.php?t=47714

Coming soon
Check if not running, starts running
Check your current hp, runs to bank if facing danger
More antibans
Random support

Currently seems to work pretty much fine, except when facing randoms.
I personally do recommend babysitting since no support for randoms, but will fish until facing randoms.

I DO take suggestions towards the script, if you have one feel free to post :)
If you are so lucky that it runs longer periods please take print screen/copy of the proggy!
Seriously would appreciate to see how its working :)

jowojowo
02-13-2014, 05:47 PM
Looks like a nice script but i'm having the following error when i try to start up:
Exception in Script: Unable to find file 'SRL-OSR/SRL/Reflection/Reflection.simba' used from 'C:\Simba\Scripts\LobsterFisher.simba'

joulaha
02-13-2014, 09:11 PM
Do you have reflection installed?
Might be that ;)

Sk1nyNerd
02-13-2014, 10:00 PM
nice release! simple and clean code. good job :)

improvements/suggestions:
use variables that are easier to understand/know whats going on. later youre going to come back to this script to improve it and you might forget what c v b m z meant.

deposit box issue could be resolved by using the same function you used to find the fishing spots rather then a bitmap :)

make sure you free your dtms all the way. add this where you declare all your setups

AddOnTerminate('FreeBitmaps');

joulaha
02-13-2014, 10:07 PM
Thanks, was aiming for cleaner code but was too lazy. Will make more clear later :)

Idea is nice to use variables, has some work but nothing that cant be done!

Well im using same system for finding the deposit as finding the boxes. Bitmaps im using for finding the actual lobster and deposit option after right clicking the fish.

joulaha
02-17-2014, 08:51 PM
Updated, new version in original post :)
First test run with new changes, so far so good. No randoms faced.

https://hostr.co/file/970/i1eLLEXyFeaa/Proggy.png

Krazy_Meerkat
02-19-2014, 11:13 AM
Cool script, I like that you used reflection :)
Standards were a bit whack though :huh:

joulaha
02-19-2014, 02:40 PM
Standards?

Little explanation would help, english is not my native language !

Krazy_Meerkat
02-20-2014, 02:05 PM
Standards?

Little explanation would help, english is not my native language !

Standards, basically it's indentation.. But it can also mean to prefer more optimised declarations over crude structure..
Here's a link to basic pascal standards, it's not quite pascalscript, but it's very similar..
http://www.gnu-pascal.de/h-gpcs-en.html

vizzyy
02-21-2014, 04:55 AM
Thank you for posting your script.

Apparently my account cannot post new threads due to a bug on the website (something to do with javascript) I took the liberty of taking your ideas and completely rewriting your script to be a little (i think) better.

Now, my guy is not yet level 40 fishing so I adapted it to fish tuna, but if you take the time to read through it i think you'll find you can easily apply my idea to any other fishing pool. Feel free to take the code and update your own however you'd like.

This script requires the same things yours did. Does:
Randoms
Fishes stuff
goes to bank when full
checks if your fishing tool is there
will withdraw new tool from first bank slot if lost

does not:
no real concrete whirlpool (taken straight from yours no additions) but mine has not lost his fishing tool once yet
does not find tool if thrown away


program Fisher;
{$DEFINE SMART8}
{$I SRL-OSR/SRL.Simba}
{$I SRL-OSR/SRL/Reflection/Reflection.simba}
{$i SRL-OSR/SRL/misc/al_functions.simba}

var
X,Y,TriedTimes,currentspot,fuckups: Integer;
pin,tool:string;
myloc:tpoint;

Procedure DeclarePlayers;
Begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name :='';
Players[0].Pass :='';
Players[0].Nick :='';
Players[0].Active:=True;
pin:='';
SetScreenName(Players[CurrentPlayer].Nick);
End;

procedure initvars;
begin
currentspot:=1;
fuckups:=0;
tool:='Harpoon';
end;

function checkTool: boolean;
begin
invmouse(1,3); //assumes tool is in first slot of inv, playa
if(isuptext(tool)) then
begin
result:=true;
end
else
result:=false;
end;

Procedure TurnOnRun;
begin
if (GameTab(tab_Options)) then
begin
if (CountColorTolerance(2369440, 649, 415, 680, 446, 20)<1) then
MouseBox(654, 420, 677, 443, mouse_left);
end;
end;

procedure withdrawTool;
begin
Withdraw(0, 0, 1);// TOOL in first slot of bank, must be scrolled up all the way bruh
end;

Procedure Antiban;
begin
case random(45) of
1: HoverSkill(randomrange(1,17), False);
2: HoverOnlineFriend;
3: compassmovement(100,150,false);
4..7: BoredHuman;
8: Turnonrun;
9: RandomFKeys(false);
10: MMouseOffClient('random');
11: PressKey(randomrange(1,4));
12..15: AL_HumanRandomMouse;
end;
end;

procedure OpenBank1;
var x, y: integer;
begin
MakeCompass('n');
writeln('openbank');
Repeat
If(not Bankscreen and FindObj(x, y, 'ank booth', 9145751, 10)) then
begin
wait(randomrange(600,1000));
Mouse(RandomRange(X - 5, x + 5), RandomRange(Y - 5, Y + 5), random(3), random(3), false);
wait(randomrange(600,1000));
ChooseOptionMulti(['Bank']);
wait(randomrange(2000,2500));
if(pinpending) then
confirmpin;
if(pinscreen) then
inpin(pin);
end
else
begin
if(((myloc.x<2806) or (myloc.x>2812)) or ((myloc.y>3441) or (myloc.y<3438))) then //not in bank (coordinates)
begin
writeln('Bank contingency.');
R_BlindWalk(Point(2811, 3440));
end;
compassmovement(100,150,false);
fuckups:=fuckups+1;
end;
until(BankScreen or (fuckups>20))
end;

function checkPool : boolean; //checks if right kinda patch, ya dig ???
begin
if(OptionsExist(['Cage Fishing spot'], false) and OptionsExist(['Harpoon Fishing spot'], true)) then
begin
result:=true;
end
else
result:=false;
end;

procedure gotobank;
begin
turnonrun;
currentspot:=1;
R_BlindWalk(Point(2810, 3440));
wait(randomrange(1000,1500));
myloc:=R_GetTileGlobal;
if(((myloc.x<2806) or (myloc.x>2812)) or ((myloc.y>3441) or (myloc.y<3438))) then //not in bank (coordinates)
begin
writeln('Bank contingency.');
R_BlindWalk(Point(2811, 3440));
end;
end;

procedure NextSpot;
begin
turnonrun;
case (currentspot) of
1:
begin
R_BlindWalk(Point(2845, 3428));//Spot2
currentspot:=2;
end;
2:
begin
R_BlindWalk(Point(2854, 3422));//Spot3
currentspot:=3;
end;
3:
begin
R_BlindWalk(Point(2860, 3426));//Spot4
currentspot:=4;
end;
4:
begin
R_BlindWalk(Point(2837, 3430));//Spot1
currentspot:=1;
end;
end;
end;

procedure gotofish;
begin
turnonrun;
currentspot:=1;
R_BlindWalk(Point(2837, 3430));//Spot1
end;

procedure FindFish;
begin
wait(800+random(200));
if (FindObjCustom(x,y,['Cage','age','Cag'],[4597535, 14597268, 15123625, 14398100, 15058085],15) and (not clicktocontinue)) then
begin
Wait(randomrange(600,800));
mouse(x,y,3,3,false);
if(checkPool) then
begin
chooseoptionmulti(['Harpoon','arpoon']);
TriedTimes:=0;
wait(randomrange(1000,1400));
end
else
begin
chooseoptionmulti(['Cancel','ancel']);
TriedTimes:=TriedTimes+1;
end;
end
else
begin
if(clicktocontinue) then
begin
if(not checktool) then
begin
writeln('checktool failed');
gotobank;
openbank1;
deposit(2,28,true);
withdrawtool;
closebank;
gotofish;
end;
end;
compassmovement(100,150,false);
TriedTimes := TriedTimes + 1;
fuckups:=fuckups+1;
end;
if(triedTimes>1)then
begin
Nextspot;
wait(randomrange(1500,2000));
end;
end;

procedure StartBotting;
begin
repeat
findnormalrandoms;
findnoninventoryrandoms;
solvebox;

if(invfull)then
begin
gotobank;
openbank1;
if(bankscreen) then
begin
fuckups:=0;
deposit(2,28,true);
end;
closebank;
gotofish;
end;
if((not invfull) and (not r_isanimating) and (not al_playerwalking)) then
begin
if(not clicktocontinue) then //incase popup chat that says inv is full
begin
findfish;
end
else
begin
if(not checktool) then
begin
writeln('Tool not found, lost or wrong uptext found');
gotobank;
openbank1;
withdrawtool;
closebank;
currentspot:=1;
gotofish;
end;
end;
end
else
begin
if(r_isanimating) then
antiban;
end;
until((not LoggedIn) or (fuckups>20));
if(fuckups>20) then
begin
writeln('ya dun fucked up');
terminatescript;
end;
end;

begin
activateclient;
SetupSrl;
SetupReflection;
DeclarePlayers;
SetScreenName(Players[CurrentPlayer].Nick);
ActivateClient;
ClearDebug();
initvars;
AddOnTerminate('srl_FreeBitmaps');
if(not loggedin) then
loginplayer;
StartBotting;
end.



what makes the mothafucka so damn fresh

jetola
02-21-2014, 12:18 PM
as soon as i click start the first thing it says is no fishing cage? but theres a lobster pot in my inventory?

joulaha
02-22-2014, 04:04 PM
Do you have it first slot, highest brightness?
And keep inventory tab open when you start script!

timmykeus
03-05-2014, 12:10 AM
[Error] C:\Simba\Includes\SRL-OSR\SRL\Reflection\AntiRandoms\R_ForesterSolve.sim ba(65:10): Unknown identifier 'R_FindFreeNpc' at line 65
Compiling failed.
i get this what does it mean?

srhrich
04-05-2014, 08:06 AM
Exception in Script: Plugin(libsmartremote32) has not been found


Where will i find the script?

wister1
04-07-2014, 02:16 PM
it gets stuck alot when going to the bank since he moves the camera alot

brentdevent
04-18-2014, 08:10 PM
Its getting stuck when it opens the deposit box!

goswag
04-23-2014, 06:30 PM
it doesent seem to work for me.i can't find where to put the name/pass in.can someone please walk me through the process?

brentdevent
04-23-2014, 08:08 PM
it doesent seem to work for me.i can't find where to put the name/pass in.can someone please walk me through the process?
It doesn't have the automatic login support ;)

1.Run the script
2.Login
3.Run it again (End it, run it again and don't close Smart)
4.???
5.Profit

also a tip check regulary your bot because this script doesn't support random events and it get sometimes stuck at the bank!

xBruceyy
04-24-2014, 05:26 AM
It's getting stuck everytime at the bank for me? :/

Nice script otherwise, Any ideas on a fix?

saucy salad
05-05-2014, 05:31 PM
Not working for me this is what it says when trying to boot up: Exception in Script: Unable to find file 'SRL-OSR/SRL/misc/al_functions.simba'

sirhyro
05-07-2014, 01:33 AM
Saucy, you need that include file.

Get it here: http://villavu.com/forum/showthread.php?t=108415

dojo
05-11-2014, 02:39 PM
fixed

Stick1234
05-15-2014, 12:24 AM
Can we get one of these script geniuses to make this thing fish sharks as well? I'm not qualified. EDIT : JK all I had to do was copy paste Vizzyy's modified version to fish Tunas, and change the 'cage' options to 'net', and it works pretty well, but I can't get it to bank them at all. It gets to the bank and opens the bank booth, and then hovers over various items in my bank and never continues past that point, if somebody has a quickfix for that problem

sewpra
06-29-2014, 11:09 AM
I really like this script but sadly i cannot leave it, i must keep my eye on it.

What i have noticed is that i loves to bank my lobsters in the bank. But just sometimes he goes to the deposit box insted, and gets stuckt, or he banks everything including my cage and then gets stuckt. Or he dosent bank at all.
But for me it always seems to end there, i tried to restart the script a few times but its really that issue only.

Otherwise 5/5 i like it, it fishes does its job. Just gets stuckt a few times, but if your around and can keep an eye on it. Sure its a great script! GJ!

ibby93
07-01-2014, 11:33 PM
Help please, I keep getting the following error messagE:

Exception in Script: Operator expected at line 394, column 26 in file "C:\Simba\Includes\SRL-OSR\SRL\Reflection\Core\Tiles.simba"

dan8808
08-15-2014, 02:15 PM
This script was working fine for me up until today when I got this message:

Attempting to pair to a smart client..
Found 1 free client(s), attempting to pair to one...
Set SMART[3884] as Simba's target
Succesfully paired to a existing client, SMART[3884]
Reflection Hooks are outdated
No need to post about it, we are currently working on it. ~ Reflection dev's
Succesfully freed SMART[3884]
Successfully executed.

I have reflection installed and also Aerolib

dan8808
08-15-2014, 02:16 PM
choose pascalscript as your interpreter ibby

joulaha
10-26-2014, 12:18 PM
Been a while, going to continue developing the script now :)

Hoodz
10-26-2014, 01:32 PM
Been a while, going to continue developing the script now :)

welcome back and good luck!

joulaha
11-01-2014, 10:45 AM
welcome back and good luck!
Thanks! :p

Banking issues seems to be fixed, going to tweak it a little before publishing :)

joulaha
11-02-2014, 07:11 PM
A little tweaks made, a lot more stable now :)
Considering a new version release for tomorrow :P

24346

joulaha
11-07-2014, 02:14 PM
Updating file on the original post in 5 minutes.
Seems to run stable 1k+ runs, both of these were interrupted by me.
So far so good. :)
24375
24376

Dan the man
01-04-2015, 03:29 AM
Working well for me. Very nice script! :)

Edit: the only problem ive seen is the banking. It sometimes goes to my bank which has a pin on it and gets stuck. Have to restart the script from that point.

Poojar102
01-04-2015, 03:53 PM
I get this error when starting the script using osbuddy client:
Exception in Script: Unable to find file './lib/core/Hooks.simba' used from 'C:\Simba\Includes\SRL-OSR\SRL\Reflection\Reflection.simba'

Harrier
01-04-2015, 03:55 PM
I get this error when starting the script using osbuddy client:
Exception in Script: Unable to find file './lib/core/Hooks.simba' used from 'C:\Simba\Includes\SRL-OSR\SRL\Reflection\Reflection.simba'
You can't use this script (Or any reflection script) with osbuddy

Poojar102
01-04-2015, 05:52 PM
I still get this error: Exception in Script: Unable to find file './lib/core/Hooks.simba' used from 'C:\Simba\Includes\SRL-OSR\SRL\Reflection\Reflection.simba' without using osbuddy as the client.

Harrier
01-04-2015, 05:59 PM
I still get this error: Exception in Script: Unable to find file './lib/core/Hooks.simba' used from 'C:\Simba\Includes\SRL-OSR\SRL\Reflection\Reflection.simba' without using osbuddy as the client.
Either your not using SMART, or haven't install the unofficial reflection include

joulaha
08-03-2015, 05:02 PM
Had problems with Reflection, updated hooks through : https://villavu.com/forum/showthread.php?t=111667&page=3

/Joulaha

jorjjorj1234
10-04-2015, 02:48 PM
I really need help guys. [Error] C:\Simba\Includes\SRL-OSR\SRL\core\text.simba(214:5): Unknown identifier 'TypeByte' at line 215
Compiling failed. i just getting these error. I did everything but no scripts is working for me. Please help me what to do..i am working on it like from 2 days. HELP
EDIT: DONE