PDA

View Full Version : [Multi-Skilled] Fishy Combiner [AL][Reflection]



Blak Fishy
10-13-2015, 09:09 PM
http://i.imgur.com/2r8RrEf.png

Current Release: 2.3

Finally updating the script. Tested on about 3500 jugs of wine on f2p, tell me if anything goes wrong or if you have any suggestions.

1. What the Script Does
- Combines two items together obviously! This means using an item on another item then making them. For example: stringing bows or making potions.
- Works with making potions, unfinished potions, stringing bows, jugs of wine, battlestaves... maybe more?

2. Features
- Supports whatever item you want it to!
- Progress graphic
- Antiban
- Failsafes
- Supports npc and booth banking
- Stops if out of material

3. Instructions
- Not necessary, but start with the items you want to use in the top right of your bank, this will make it a lot quicker.
- Start in front of the bank booth. Tested mostly at VWest and GE.
- Finish the user setup
- If you wish you make battlestaves, you must change the script to only right click the items, rather than left click. Just some simple changes in Make()
- Have brightness at max, zoom set to default, and fixed screen
- Have interpreter set to lape
- Report back with suggestions or feedback!

4. What You Need
- AeroLib: https://villavu.com/forum/showthread.php?t=108953
- Reflection (lape): https://villavu.com/forum/showthread.php?t=111662
- Latest version of SMART and Simba

5. Credits
- Anth - Used some of his old scripts as the base for mine

6. TODO
- Add breaks (only if it is highly requested, don't really care for them)
- Add support for bank chest
- Suggestions

7. Changelog
= 2.3
- Fixed levelUp stopping program
- Made Withdraw and Make procedures more random
- Now chooses f2p/p2p world based on user input
- Improved antiban procedure
- Added to Withdraw so it won't accidentally withdraw notes
- plenty of other random stuff I noticed when looking through my code again
= 2.2
- Small change to antiban procedure
- Solved some problems in make
= 2.1
- Fixed case of running out of one item
- Moved reflection objects to the funcs they are used in

27811
26842
26828
26804

AFools
10-13-2015, 10:24 PM
Good Job! I haven't really got a use for this atm; but i may try to make some bows or something.

Though this would have many uses. with a little changes it could be reflection fletching script =D

captainblast
10-14-2015, 01:30 AM
Good stuff bro! I will be sure to check it out and improve on it if I can. Glad to see this here man, people will love it.

Blak Fishy
10-20-2015, 02:26 AM
Updated to release 2.1
Fixed issue of running out of one item, moved reflection objects to prevent memory leaks, and optimized many functions.
Script runs very smoothly now: is there anything wanted next?

Blak Fishy
11-23-2015, 01:08 AM
On release 2.2. Just wanted to say I check on this every update to make sure the script still works and test for 30 minutes or so. Please report if anything is wrong, if you liked the script, or any suggested improvements.

terrorbyte
02-13-2016, 04:28 PM
Blak Fishy, I just wanted to test this script and I downloaded Reflection as per the instruction on reflection's thread. When I try to run this script, I get a new tab opened on SIMBA called SimbaEX and get this error:


Error: Unknown declaration "init" at line 623
Compiling failed.

The line 623 in this new tab SimbaEX is:


S.init();

Obscurity
02-13-2016, 05:46 PM
Blak Fishy, I just wanted to test this script and I downloaded Reflection as per the instruction on reflection's thread. When I try to run this script, I get a new tab opened on SIMBA called SimbaEX and get this error:



The line 623 in this new tab SimbaEX is:

Update ProSocks.

terrorbyte
02-13-2016, 06:44 PM
Update ProSocks.

Yes, sorry for not updating the post. I was able to update the ProSocks and able to run the script. I have not, however, tested the script itself yet since my bot doesn't have the required herblore level to test the script out.

But compiler itself is working so I am going to assume for now that the script will most likely work as well. Will post an update once I've thoroughly tested out the script.

maikelpro99
02-16-2016, 01:20 AM
Error: Unknown declaration "getInvCount" at line 361

tmpCount := getInvCount();

Blak Fishy
02-16-2016, 04:22 PM
Script is currently outdated: will be coming out soon with a completely redone script only using reflection.
The problems now are menial and should be able to be figured out if you look up updated reflection commands to replace them.

terrorbyte
02-21-2016, 12:29 AM
Script is currently outdated: will be coming out soon with a completely redone script only using reflection.
The problems now are menial and should be able to be figured out if you look up updated reflection commands to replace them.

Can't wait, Fishy :)

bv2490
02-24-2016, 03:34 PM
This looks great, cant wait to try it

sizzayin
04-25-2016, 05:52 PM
Great script. One problem I noticed with this is that it would often withraw the selected items as a note and then it would think that it had run out of the selected items and log out. This happened with both version 2.1 and 2.2. I made a very slight adjustment to the withdraw function which seems to have fixed the problem. This change I made was between lines 268-285 of version 2.2. Instead of reposting the whole script, I will just paste the withdraw function because I only added 2 lines and they were in the withdraw function.

case random(0, 1) of
0:
begin
Notes(False); //This is the only change made. I added it again for the other case (first item)
ScndB.Withdraw(-14);
case random(0, 1) of
0: FrstB.Withdraw(-14);
1: FrstB.Withdraw(-1);
end;
end;
1:
begin
Notes(False); // this is the only change that I made
FrstB.Withdraw(-14);
case random(0, 1) of
0: ScndB.Withdraw(-14);
1: ScndB.Withdraw(-1);
end;

bv2490
05-30-2016, 11:14 PM
Nice ty!

kyyskis
06-05-2016, 08:35 AM
2.2 version doesn't work for me for combining herbs with vial of water. (Says that names are bad, doesn't matter what you type in, always same error)
2.1 version works for that but gets stuck a lot :(

anth_
06-05-2016, 10:53 AM
2.2 version doesn't work for me for combining herbs with vial of water. (Says that names are bad, doesn't matter what you type in, always same error)
2.1 version works for that but gets stuck a lot :(

Have you tried putting the names in case-sensitive?

kyyskis
06-05-2016, 04:46 PM
Have you tried putting the names in case-sensitive?

yep,i tried but it didn't worked :(

P.S. just re downloaded script 2.2 version, and typed in other herbs and now worked

Blak Fishy
06-16-2016, 09:48 AM
yep,i tried but it didn't worked :(

P.S. just re downloaded script 2.2 version, and typed in other herbs and now worked

Just tested with a couple herbs and it still worked, will try to update soon with a big update to fix everything. Been away for a while but I've been trying some random stuff lately and perfecting this sounds fun.

Blak Fishy
09-07-2016, 01:33 PM
Update to 2.3 posted. Fixed some problems with recent updates like placeholders. Also fixed existing problems like choice f2p/p2p login and noted items being withdrawn. Finally, I added some behavior changes to make detection harder. Tested by making over 3500 wines and had no problems. If you have any problems or have any suggestions for further improvements feel free to post them.

jacz24
12-29-2016, 07:21 PM
Hey, great script. Only suggestion is to add support for multiple items. Say if you are doing herblore and want to go onto the next herb once another has run out. Shouldn't be too difficult. I'd be happy to do it myself and post back if you would like but I am pretty busy.

Bago47
12-29-2016, 11:04 PM
Hey, just letting you know that your script rocks! Thank you for sharing :)

Bago47
12-29-2016, 11:28 PM
PS: just letting anyone doing hosidius know - comment out lines 387 to 397 (do NOT comment out 398, it's connected to another function). It will skip "Make all" option, which doesn't pop up when making things like sulphurous fertiliser for favours - you will still have to press continue every now and then when it levels up farming, haven't wrapped my head around that one yet :)