PDA

View Full Version : [RuneCrafting] ClutchFireRunes



Clutch
02-11-2016, 02:57 AM
Clutch Fire Runes
Feedback & Criticism on script is encouraged!

Notes:

I totally spaced on crediting AFools; within the script - I'll update this with the next release - Thanks again AFools;
Script will automatically download updates - if you run it ensure you read the debug as it may fail out as there is a new update
Please babysit -there's bound to be bugs
If you have anything you would like added please post below
Review of the script integrity and suggestions/tips and/or criticism are appreciated.
Don't like something? Post about it


Requirements:
Must have a Fire tiara equipped
Highly suggested to have a Ring of dueling equipped in the ring slot

Installing:
Locate the script at the bottom of this post "ClutchFireRuneUpdater.simba"
Download and place this in your X:/Simba/Scripts directory

Instructions:
- Fill out lines 7-9
- Start at Castle Wars Bank chest
- Script currently only supports Pure essence - make sure you have plenty
- Ensure you have a large number of Ring of dueling(8) within your bank

Version:
Version1.00 - Alpha Release - Please leave all feedback

To do List:

Pouch support
Lava Rune support


You can get the script here:

AFools
02-11-2016, 03:11 AM
Good work!

*** edit

You guys and your fancy updater's! =P

****** EDIT!

MY BAD! I had confused your name many months ago with "curse". Hence why i didn't know why the guild script was neglected!

This is my bad!!

Mj
02-11-2016, 03:20 AM
Nice work, i'll try to nit pick the hell out of this later when I have some time, trying to make a reflection based GE buyer /seller

Clutch
02-11-2016, 03:32 AM
Good work!

*** edit

You guys are your fancy updater's! =P

PS - i have some time today if you want me try debug some snippets? saves you from using key(1);key(2) to move through dialogues?

Code looks tidy; I just don't have an acc to test this on atm. But i will do.

On a side note..? Do you want to re-write your guild script slightly together? So it is a lot easier to add locations? Update etc?

Thanks, I plan on leaving that as is - honestly that's how I legit with teleporting is with key 1 and 2.

What do you mean my "guild" script?


Nice work, i'll try to nit pick the hell out of this later when I have some time, trying to make a reflection based GE buyer /seller

Please do!
Edit: Grats on JR!

Laquisha
02-11-2016, 04:40 AM
trying to make a reflection based GE buyer /seller

Something like this (https://villavu.com/forum/showthread.php?t=115341) should definitely be in /lib/widgets IMO

Clutch
02-11-2016, 05:39 AM
I'm seeing online expectations of ~20K xp/hr & theoretically up to 27K xp/hr - I did some test runs though and with near perfect timing I'm having troubles hitting ~35 second mark per round trip. Anyways here's a report. This is the longest I've let it run before stopping before. Would let it run longer but am off to sleep. *Please babysit unless your not worried about getting banned. I haven't seen any issues where it's gotten stuck as most of the script is made to correct itself on it's own but you never know.
ClutchFireRunes v1.0 || 02:15:47 ||
XP Gained: 28392
XP per hour: 12544.8579880081
Rings used: 39
Rings used per hour: 17.2319160614222

Mj
02-11-2016, 05:49 AM
https://paste.villavu.com/show/6842/ has inline comments, just stuff to get you started. I can be a harsh code reviewer with many nit picks on style and maybe not so much functionality at first. Also I refracted some of AFools methods to be reflection based and I believe they work, I was just having issues with dismissing randoms in my script, but that could be unrelated.


function DismissAllRandoms: Boolean;
var
Npc, Random, MyIndex: Integer;
Npcs: TReflectNPCArray;
Randoms: TStringArray;
begin
Randoms := ['dunce', 'molly', 'niles', 'miles', 'giles', 'sandwich lady',
'drunken dwarf', 'highwayman', 'dr jekyll', 'cap' 'n hand',
'security guard', 'rick turpentine', 'mysterious old man',
'frog', 'null', 'mime', 'sergeant damien', 'freaky forester',
'strange plant', 'postie pete', 'tilt', 'flippa', 'leo',
'pillory guard', 'evil bob'];
Npcs.GetAll();
MyIndex := TReflectLocalPlayer.GetPlayerIndex;
for Npc := 0 to High(Npcs) do
begin
if (Npcs[Npc].GetInteractingIndex() = MyIndex) then
begin
for Random := 0 to High(Randoms) do
begin
if (Pos(Randoms[Random], Lowercase(Npcs[Npc].GetName())) > 0) then
begin
if R_InteractTile(Npcs[Npc].GetTile(), 'Dismiss', 0, 0, 50) then
begin
MyPlayer.FFlag(0);
Wait(RandomRange(500, 5000));
Reflect.Logger.Status('Dismissed random: ' + Npcs[Npc].GetName);
Result := True;
end;
end;
end;
end;
end;
end;

function R_InteractTile(Tile: TPoint; Action: string; X: integer = 0; Y: integer = 0; Z: integer = 0): Boolean;
var
RSTile: TPoint;
begin
if R_TileOnMS(Tile, RSTile, X, Y, Z) then
begin
Reflect.Mouse.Move(RSTile, 3, 3);
if Reflect.Text.IsUpText(Action) then
begin
Reflect.Mouse.Click(MOUSE_LEFT);
Result := Reflect.Mouse.DidClick(true, 1000);
end
else
begin
if Reflect.Text.OptionExists(Action) then
begin
Reflect.Mouse.Click(MOUSE_RIGHT);
Result := Reflect.Text.ChooseOption(Action);
end;
if not Result then
Reflect.Antiban.HumanRandomMouse;
end;
end;
end;

function R_TileOnMS(Tile: TPoint; OutputPoint: TPoint; X: integer = 0; Y: integer = 0; Z: integer = 0): Boolean;
var
TempBox: TBox;
begin
OutputPoint := Reflect.Tiles.TileToMS(Tile, X, Y, Z);
TempBox := IntToBox(MSX1, MSY1, MSX2, MSY2);
Result := PointInBox(OutputPoint, TempBox);
end;

AFools
02-11-2016, 06:26 AM
...

At the moment i am writing in strict reflection. (No Aerolib) there has been some teething problems. I would also suggest trying to migrate to one one include or the other.

But in all this is a great script from what i can see.. and i'm sure it will become a lot better in time. I will release some of my new functions shortly. I am having problems with using/making TileonMS.. if you have a strict reflection version of this i would be interested.

Clutch
02-11-2016, 03:14 PM
At the moment i am writing in strict reflection. (No Aerolib) there has been some teething problems. I would also suggest trying to migrate to one one include or the other.

But in all this is a great script from what i can see.. and i'm sure it will become a lot better in time. I will release some of my new functions shortly. I am having problems with using/making TileonMS.. if you have a strict reflection version of this i would be interested.

Yeah, I'll also be looking into those - so far they work and I'm not exactly proficient in creating custom functions but they were definitely a good base and do work!
mudda_fudda; I'll take a look at that.

Blak Fishy
02-12-2016, 06:58 PM
This will be sick nasty when it gets lava support. Even if it runs slower lavas are double the exp.

Clutch
02-12-2016, 08:23 PM
This will be sick nasty when it gets lava support. Even if it runs slower lavas are double the exp.

Yeah, just need some time to get my account up in levels so I can use magic imbue. Unless someone has an account they're willing to loan for testing or want to just test in general.

nuclearexplosion
02-17-2016, 03:50 PM
Wouldn't it be easy to add support for rune essence as well? I haven't looked at the script but I'll take a look to see if I can modify it.

Clutch
02-17-2016, 04:31 PM
Wouldn't it be easy to add support for rune essence as well? I haven't looked at the script but I'll take a look to see if I can modify it.

Of course I can alter it so you can choose between the two at the top of the script.

Whiteballs
06-08-2016, 08:43 AM
Ty for sharing the script m8.

ShadowsTM
06-08-2016, 11:39 AM
Got my main banned after 2 hours use, bot carefully with it