PDA

View Full Version : [Fighting] [AeroLib] GiantRat Slayer Lumby (No Food Needed)



Aspect
08-18-2016, 11:17 AM
GiantRat Slayer 27735

GiantRat slayer goes to the Giant rat location behind Lumbridge castle and kills the giant rats until it dies, then it equips 3 items in the inventory to go back and kill more.

27739



Simply start the bot with the 3 items youd like to use for combat either on, or in your inventory near Lumbridge castle.
MAKE SURE TO TURN YOUR BRIGHTNESS ALL THE WAY UP AS WELL
[/CENTER]
NOTE: You must have the AeroLib to run this bot!
You may get it here https://villavu.com/forum/showthread.php?t=108953

Features
On-Screen Progress Report
Anti-ban Chat and events




UPCOMMING
Level tracking


KNOWN BUGS:
N/A
*Noticed it was keeping bones over my iron scimmy on death so I've updated the bot to drop bones.


Let me know if anyone has any suggestions or if you find any bugs!
*Updated with 5-hour proggy

jstemper
08-18-2016, 01:00 PM
Nice release, p.s. parse your script ;D

Aspect
08-18-2016, 05:01 PM
Yeah, this was my second script, I'm still learning. Do you mind linking me a guide on proper spacing, or give me a few pointers on what you're talking about?

acow
08-18-2016, 06:04 PM
Yeah, this was my second script, I'm still learning. Do you mind linking me a guide on proper spacing, or give me a few pointers on what you're talking about?

https://villavu.com/forum/showthread.php?t=60288

Aspect
08-18-2016, 07:53 PM
https://villavu.com/forum/showthread.php?t=60288

Thank you :) I'll be paying more attention when scripting from now on.

Laquisha
08-19-2016, 02:39 AM
Thank you :) I'll be paying more attention when scripting from now on.

Nice script! I agree it is kinda hard to read with the messy indentation. There is a formatter extension packaged with Simba. You can enable it in the extensions menu and use it to clean up your indentation/spacing, so you can see what it is meant to look like.

The other issue with mucky indentation is confusing corresponding begin..end blocks. If you look, you will notice your FreeBMP() and loadBMP() procedures are actually nested inside your mainLoop() procedure. If you call these procedures from anywhere else in your script it will fail to compile. The reason it compiles now is because you never actually use these BMP procedures at all (so I guess you can delete them?). You never use your getTile and AtRats procedures either.

In my opinion, the biggest problem with OSR scripts on here is combining different includes together (as it gets messy). The reflection include is currently written so it can function as a standalone include.

From what I can see, the only AeroLib stuff you use is the OS_Smart.__Graphics calls, and maybe some of the antiban stuff. You can replace these with the reflection methods (e.g. Reflect.Graphics.Draw.., Reflect.Antiban..). Not really necessary, but it will leave you with a tidier script.

Aspect
08-19-2016, 04:52 AM
Nice script! I agree it is kinda hard to read with the messy indentation. There is a formatter extension packaged with Simba. You can enable it in the extensions menu and use it to clean up your indentation/spacing, so you can see what it is meant to look like.

The other issue with mucky indentation is confusing corresponding begin..end blocks. If you look, you will notice your FreeBMP() and loadBMP() procedures are actually nested inside your mainLoop() procedure. If you call these procedures from anywhere else in your script it will fail to compile. The reason it compiles now is because you never actually use these BMP procedures at all (so I guess you can delete them?). You never use your getTile and AtRats procedures either.

In my opinion, the biggest problem with OSR scripts on here is combining different includes together (as it gets messy). The reflection include is currently written so it can function as a standalone include.

From what I can see, the only AeroLib stuff you use is the OS_Smart.__Graphics calls, and maybe some of the antiban stuff. You can replace these with the reflection methods (e.g. Reflect.Graphics.Draw.., Reflect.Antiban..). Not really necessary, but it will leave you with a tidier script.

Yeah, usually I just use my other scripts as a base for my new ones so sometimes I forget to take out the unneeded code. That's something I'll look into for my text release. Thanks for the info.

Aspect
08-19-2016, 10:47 PM
Updated to check for and drop bones. It was keeping bones on death over my iron scimmy, and then burrying them lol.

Her0nz
08-21-2016, 02:44 AM
God bless, this is the script I've been looking for.

I'll be testing this later and I'll be sure to post a proggy.

Aspect
08-21-2016, 02:19 PM
God bless, this is the script I've been looking for.

I'll be testing this later and I'll be sure to post a proggy.

Yeah I saw a few people wanted it on the requests section. I used it to level a pure. It's pretty stable from what I've tested so far.

Her0nz
08-22-2016, 12:05 PM
http://puu.sh/qKaoC/4eff43eb1e.png
It didn't run that long but I don't know when it logged out. I was leveling a defense pure.

My only complaint that I observed with the script is that it takes an unnaturally long time to find the next target.

Could have been my fault, forgot to set brightness higher.

Her0nz
08-22-2016, 10:48 PM
http://puu.sh/qKKgM/713903b927.jpg

Another proggy 4 u

Aspect
08-23-2016, 12:01 AM
Did making your brightness higher help?

Her0nz
08-23-2016, 02:47 PM
Did making your brightness higher help?

It was still a bit shaky.

Aspect
08-23-2016, 06:49 PM
I'll look at it and update it when I have time.

Havij
10-02-2016, 04:01 PM
Thanks for this script, will be using this for a short while.

metalistas1993
04-25-2017, 04:32 PM
It's a bit messed up... My char stands like for 3 minutes straight until attacking, no idea why. It clicks like one tick away from the rat, and that's annoying as hell

Aspect
04-25-2017, 05:00 PM
It's a bit messed up... My char stands like for 3 minutes straight until attacking, no idea why. It clicks like one tick away from the rat, and that's annoying as hell

Yeah, it's needed a fix for a while. Considering this seems to be my most popular script, I'll push out an update tonight around midnight.

Aspect
04-26-2017, 02:33 AM
So I just ran the script and it worked fine. At the most you may have 5 solid seconds between locating rats rarely. There are a few pauses and antibans in there and I'm not going to sacrifice the human like movement for speed. I think its efficient. Make sure your brightness settigns are correct and you are in a fixed window mode.

metalistas1993
04-26-2017, 11:57 PM
i've raised the fps bar on the right to the maximum - turned out it was at default (middle). leaving the bot overnight, we'll see whether it will crash or not :) oh and good job by the way, well done :)

terd
05-02-2017, 06:06 AM
Ran for ~10 hours. Sometimes takes a while to find a new target or clicks on a rat after it is dead. Also, sometimes clicks too far south resulting in the character attempting to run west around the fence. It seems to recover whenever this happens, although it spends a bit of time walking.

SpyroPT
05-10-2017, 10:16 PM
I've been having some issues, he switches to kill another rat even though he hasn't finished combat with the current one.
Also when I die I keep getting this error:
[Reflection] [Warn] Failed to find Tile {X = 3197, Y = 3189} on MM.

jcastle92
10-08-2017, 02:44 AM
i get this error when trying to run the script

Error: Unknown declaration "GetTickCount64" at line 156

slacky
10-08-2017, 11:18 AM
i get this error when trying to run the script

Error: Unknown declaration "GetTickCount64" at line 156
Wrong version of Simba (your's is newer than what the script is meant for), and the aerolib version you have ATM to go alongside it is probably the one meant for Simba 1.2

Aspect
10-10-2017, 11:26 PM
Wrong version of Simba (your's is newer than what the script is meant for), and the aerolib version you have ATM to go alongside it is probably the one meant for Simba 1.2

Second script, probably tuns of garbage code anyways.

Happy birthday btw.