PDA

View Full Version : Login broken after last update.



Pastah
08-25-2017, 03:47 AM
The login screen changed after last update(they've added a remember username and hide username box). Now it messes up logging in. If someone could help me fix this please. I've already tried editing the loginbox and passwordbox Tbox but to no avail, while I managed to get it to enter the username at the right spot it immediately follows with the password behind the username instead of in the passwordbox.

lcbbln
08-25-2017, 11:07 AM
Seek help on the same. Login broken after last update.

Flight
08-25-2017, 03:00 PM
I just noticed AeroLib's login was also broken so I'll be working on this immediately. Aside from the username/password boxes being off, is there anything else that you've noticed was broken?

slacky
08-25-2017, 03:03 PM
Reflection sucks. I mean.. I wonder if this affected SRL as well.. #fixedInSRL (https://villavu.com/forum/usertag.php?do=list&action=hash&hash=fixedInSRL)

Pastah
08-25-2017, 03:58 PM
I just noticed AeroLib's login was also broken so I'll be working on this immediately. Aside from the username/password boxes being off, is there anything else that you've noticed was broken?

It's also like it doesn't know when to go to the password box, it just types in the username immediately followed by the password in the loginbox. Mind you I've edited the login and password Tbox so they are at the right place. Maybe I made a mistake or something more than this needs to be fixed.

Brandon
08-25-2017, 04:25 PM
Reflection sucks. I mean.. I wonder if this affected SRL as well.. #fixedInSRL (https://villavu.com/forum/usertag.php?do=list&action=hash&hash=fixedInSRL)

Says Reflection sucks; Colour got broken. https://github.com/SRL/SRL/commit/bafce6caaa8c1650b6600dd3a22a8cc3725a4ca3

The reflection include uses COLOUR for Login -_-

Flight
08-25-2017, 04:37 PM
It's also like it doesn't know when to go to the password box, it just types in the username immediately followed by the password in the loginbox. Mind you I've edited the login and password Tbox so they are at the right place. Maybe I made a mistake or something more than this needs to be fixed.

All fixed in AeroLib. I briefly tested the login and it seems to work fine under revision 1.

Pastah
08-25-2017, 05:35 PM
Thanks everyone for all the help, I still had the same problem of it entering the password right after the username.
I managed to fix it by changing line 285 in the login.simba file from

Reflect.Keyboard.Send(Password+'{enter}');

to

Reflect.Keyboard.Send('{enter}'+Password+'{enter}' );

slacky
08-26-2017, 02:40 AM
Says Reflection sucks; Colour got broken. https://github.com/SRL/SRL/commit/bafce6caaa8c1650b6600dd3a22a8cc3725a4ca3

The reflection include uses COLOUR for Login -_-
Cool, reflection sucks anyway - poor mans way to botting. Fyi.. static/hard coded boxes was off [nothing related to color]. The whole method should have rather located the actual "login" and "password"-text, which could have been used to create them areas dynamically. But ya know, had cut some corners when it's a 2 man project in order to complete it, since none of the two dev's actually gave a fuck about RS.

Brandon
08-26-2017, 06:03 AM
Cool, reflection sucks anyway - poor mans way to botting.

Cool story. The only thing poor around here is your attitude & understanding.

They did give a shit about it.. they just have other priorities in life first.

Kasi
08-26-2017, 06:42 AM
Cool, reflection sucks anyway - poor mans way to botting. Fyi.. static/hard coded boxes was off [nothing related to color]. The whole method should have rather located the actual "login" and "password"-text, which could have been used to create them areas dynamically. But ya know, had cut some corners when it's a 2 man project in order to complete it, since none of the two dev's actually gave a fuck about RS.

Not sure why they need to be created dynamically. They're hard-coded in the client based off where the login screen starts. Also you don't really need to know where the boxes are in order to log in with reflection.

Twinki
08-26-2017, 07:07 AM
Cool, reflection sucks anyway - poor mans way to botting. Fyi.. static/hard coded boxes was off [nothing related to color]. The whole method should have rather located the actual "login" and "password"-text, which could have been used to create them areas dynamically. But ya know, had cut some corners when it's a 2 man project in order to complete it, since none of the two dev's actually gave a fuck about RS.

> Says Reflection is the poor mans way of botting
> Uses static boxes for login methods in a color include

Flight
08-26-2017, 02:37 PM
Ugh let's not form this into another Reflection vs color debate. Clearly there's pros and cons in either direction, and to each his own.


Not sure why they need to be created dynamically. They're hard-coded in the client based off where the login screen starts. Also you don't really need to know where the boxes are in order to log in with reflection.

I didn't think about making the login screen information dynamically in that way, though it makes sense. AeroLib HD utilizes text on the screen for relevant coordinates, as Slacky suggested above. Kinda surprising I didn't do it that way because the majority of the include itself detects sprite and interface positions based off tiny, unique DTMs. Oh well, I doubt the difference between OCR and a static login screen DTM/Bitmap is significant.

slacky
08-26-2017, 03:23 PM
Cool story. The only thing poor around here is your attitude & understanding.

They did give a shit about it.. they just have other priorities in life first.
I am joking man, glad you liked the story tho, I made it up all by myself :p
Btw, I wrote SRL alongside Olly. We are the two devs I am talkin about. I surely didn't care much for RS anymore, cant speak for Olly tho, but knew he was bored of RS at least


Not sure why they need to be created dynamically. They're hard-coded in the client based off where the login screen starts.
Huh? The only good argument for just hardcoding the boxes like it was, is that it rarely changes. Writing a more dynamic solution is the long term lazy way to ensure or make it less likely that you don't have to update it.

Kasi
08-26-2017, 06:22 PM
I am joking man, glad you liked the story tho, I made it up all by myself :p
Btw, I wrote SRL alongside Olly. We are the two devs I am talkin about. I surely didn't care much for RS anymore, cant speak for Olly tho, but knew he was bored of RS at least


Huh? The only good argument for just hardcoding the boxes like it was, is that it rarely changes. Writing a more dynamic solution is the long term lazy way to ensure or make it less likely that you don't have to update it.

Sure it might be cooler to dynamically find them but the colours have just as much chance of changing as the static hard-coded coordinates do, just like the text or anything else. Not sure you can future-proof for that without some sense of AI. I guess we just think differently.