Evaluation/ Script Thoughts

[Macho Man67]

Some background info:
After reading most of the tutorials in both the begginers and intermediate sections, I decided to make a script that might actually work, Macho Oak Owner. I know in the past I have had a bad reputation and have been known for making scripts that dont even work, but this time I tried very hard. My goals for the SRL Community are to make a great script and to eventually become a SRL Member.

Main Point:
I came here for people to evalute my script, post suggestions and comments, and even give me advice. The reason I came here for help/evaluation is that I really want to make this a pretty good script and for people to suggest things that I could add to the script, which might give me a better chance of getting accepted to SRL Members when I apply. Also I can take a little flaming( If its really necessary...). NOTE:This script has not been tested before....

So I hope you all could help me out and evaluate my script, post comments and suggestions, and give advice.

[Kik]

Wrong Section.

Good script, anyways.

[dvdcrayola]

Wrong section... but ill take a look

for your proggie.. the XP part, you can just do logs*logxp

other then that it looks fairly good.. didnt look too closely though.

[hardman]

Hi i was looking at ur script am it look cool but i cant test it because of the rs update but i looked at so thing u got in ur script so can i use some of it and ill put in credits ur name if not just tell me to go away

[drnewheart]

Wrong Section. Good idea but releasing scripts right now is a little useless considering half of your procedures might be updated out.

[Sir R. M8gic1an]

ok, here's a suggestion that'll save you a whole load of space, n copy pasting
this is what you wrote:
7: begin
HoverSkill('Attack', False);
wait(2000+random(2000));
GameTab(4);
end;
8: begin
HoverSkill('Strength', False);
wait(1000+random(2000));
GameTab(4);
end;
9: begin
HoverSkill('Defence', False);
wait(1000+random(2000));
GameTab(4);
end;
10: begin
HoverSkill('Range', False);
wait(1000+random(2000));
GameTab(4);
end;
11: begin
HoverSkill('Prayer', False);
wait(1000+random(2000));
GameTab(4);
end;
12: begin
HoverSkill('Magic', False);
wait(1000+random(2000));
GameTab(4);
end;
13: begin
HoverSkill('Runecraft', False);
wait(1000+random(2000));
GameTab(4);
end;
14: begin
HoverSkill('Construction', False);
wait(1000+random(2000));
GameTab(4);
end;
15: begin
HoverSkill('Hitpoints', False);
wait(1000+random(2000));
GameTab(4);
end;
16: begin
HoverSkill('Agility', False);
wait(1000+random(2000));
GameTab(4);
end;
17: begin
HoverSkill('Herblore', False);
wait(1000+random(2000));
GameTab(4);
end;
18: begin
HoverSkill('Thieving', False);
wait(1000+random(2000));
GameTab(4);
end;
19: begin
HoverSkill('Crafting', False);
wait(1000+random(2000));
GameTab(4);
end;
20: begin
HoverSkill('Fletching', False);
wait(1000+random(2000));
GameTab(4);
end;
21: begin
HoverSkill('Slayer', False);
wait(1000+random(2000));
GameTab(4);
end;
22: begin
HoverSkill('Hunting', False);
wait(1000+random(2000));
GameTab(4);
end;
23: begin
HoverSkill('Mining', False);
wait(1000+random(2000));
GameTab(4);
end;
24: begin
HoverSkill('Smithing', False);
wait(1000+random(2000));
GameTab(4);
end;
25: begin
HoverSkill('Fishing', False);
wait(2000+random(1000));
GameTab(4);
end;
26: begin
HoverSkill('Cooking', False);
wait(1000+random(2000));
GameTab(4);
end;
27: begin
HoverSkill('Firemaking', False);
wait(2000+random(1000));
GameTab(4);
end;
28: begin
HoverSkill('Farming', False);
wait(1000+random(2000));
GameTab(4);
end;
29: begin
HoverSkill('random', False);
wait(2000+random(1000));
GameTab(4);
end;
30: begin
GameTab(5);
wait(1000+random(100));
GameTab(4);
end;
end;

this will do the same and look much better, sparing lots of space :)


7:HoverSkill('Attack', False);
8: HoverSkill('Strength', False);
9:HoverSkill('Defence', False);
10:HoverSkill('Range', False);
11: HoverSkill('Prayer', False);
12:HoverSkill('Magic', False);
13: HoverSkill('Runecraft', False);
14:HoverSkill('Construction', False);
15:HoverSkill('Hitpoints', False);
16: HoverSkill('Agility', False);
17: HoverSkill('Herblore', False);
18: HoverSkill('Thieving', False);
19: HoverSkill('Crafting', False);
20: HoverSkill('Fletching', False);
21:HoverSkill('Slayer', False);
22: HoverSkill('Hunting', False);
23: HoverSkill('Mining', False);
24: HoverSkill('Smithing', False);
25: HoverSkill('Fishing', False);
26: HoverSkill('Cooking', False);
27: HoverSkill('Firemaking', False);
28:HoverSkill('Farming', False);
29: HoverSkill('random', False);
30: GameTab(5);
end;
wait(1000+random(100));
GameTab(4);

[joerobo]

:o ahhh 4got to pm u sry :(, ive just got back frm holiday, if that makes a slight excuse, will do now, then ill look over yr latest script!


edit: looked over it now, i see firemaking has been left by the wayside for the timebeing :p standards are a bit astray (though thats no major problem). perhaps check that yr ent finder will only check the tree you are chopping and not any others- do you need to credit yohojo? (nt sure if it is his 1 or not just looking at it briefly). second perhaps introduce a more reliable way to check the tree has gone else you could get stuck within an infite loop within the findinthetree procedure.