View Full Version : All potion maker[c]
Brotein
02-08-2012, 10:31 PM
Bot works fine if you log it in and do pin yourself.
madmash
02-11-2012, 06:14 AM
bots working fine now!
Hey there, I've been using this for about a week now to make unfinished irit potions and now unfinished dwarf weed potions. It makes great money and is, for the most part, stable enough to run while at your computer. Thank you.
Thomashamka
02-11-2012, 09:19 AM
Cleaning lantadyme works sometimes. Yesterday cleaned 1k lantadymes with it but today it doesnt work =). Still testing whats the problem.
EDIT: It works if you put another task there. Put first: Lantadymes then 500 IRITS, and voila. Doesnt matter if you dont have irits in bank. All updates needs to be done before this worked. Couple restarts might need to be done.
Hope this helps.
99 range ftw
02-11-2012, 10:43 AM
hey , thank you for the scrip ^^.
unfortunately, i am having problems with it because as soon as i run it
and the client opens and logs in i get an error which is the following:
Error: Out Of Range at line 1459
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap
and the bot stops working. what am i doing wrong? i have tried many different settings. i am trying to make attack potions from unf guam and eye of newt. your help will be much appreciated! :D
ownmanga
02-11-2012, 03:05 PM
hey , thank you for the scrip ^^.
unfortunately, i am having problems with it because as soon as i run it
and the client opens and logs in i get an error which is the following:
Error: Out Of Range at line 1459
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap
and the bot stops working. what am i doing wrong? i have tried many different settings. i am trying to make attack potions from unf guam and eye of newt. your help will be much appreciated! :D
Same here :fiery:
iee77
02-11-2012, 05:01 PM
http://img546.imageshack.us/img546/8540/23508132.png (http://imageshack.us/photo/my-images/546/23508132.png/)
3 Hours Proggy, more to come!
liamb
02-12-2012, 09:26 PM
nvm got it working :D
nice bot :)
Sunblast
02-12-2012, 09:28 PM
First try got it working for a nice 2 hour proggy.
Thing is... now I cant get it to do anything...
It logs in and just stands at the bank doing nothing. Am I missing something? It says its starting my serum 207... but it just doesn't get on with it.
I've tried logging it in manually, letting the bot log me in, start bot on bank screen... but nothing works. :<
Pic below.
http://img713.imageshack.us/img713/1102/helpku.png
Same problem but with super antipotion
liamb
02-13-2012, 01:06 PM
Same problem but with super antipotion
Try entering pin and everything, and enable SMART with the bank screen open.
worked for me
Sunblast
02-13-2012, 04:07 PM
Damn, it worked for 30 minutes but now it does 1 inventory and then doens't click the bank and wait..
ownmanga
02-14-2012, 02:21 AM
Someone sould verified this script
I not sure if is this script or another bot call rarebot
Can someone read the script and say if it's save.
bud_wis_er_420
02-14-2012, 04:55 AM
I been thinking about remaking this. Been doing alot of reading to get better at scripting and I have a few ideas to make this script flawless. But I would have to start from scratch. I work alot so I only get like 4 hours a day of free time most days and I do have somewhat of a life outside of rs. So don't expect anything for at least a few weeks. And This time I'm not gona release it until it's 100% ready.
Someone sould verified this script
I not sure if is this script or another bot call rarebot
Can someone read the script and say if it's save.
Your the guy that pmed me saying I tried to scam you. Dude who are you. Whoever you are, trust me you don't know me.
I play rs only for the scripting and the occasional mini game. I never even attempted to make a trade with someone in game or out. You got the wrong person. But... you've tickled my curiosity. What exactly did happen. This don't explain much.
http://desmond.imageshack.us/Himg710/scaled.php?server=710&filename=97280710.png&res=medium
ownmanga
02-15-2012, 01:35 AM
When Im using your script the SMART screen freezed so I try to log in with the official runescape. It said that i sould log out first but I closed all simba shit already. Like 5-6 minutes after, when I log on my account was at the GE with everything in bank sold but still get the cash.
tight butts
02-15-2012, 06:10 AM
I'm stoked for your new release Bud, Can't wait.
bud_wis_er_420
02-15-2012, 09:24 AM
When Im using your script the SMART screen freezed so I try to log in with the official runescape. It said that i sould log out first but I closed all simba shit already. Like 5-6 minutes after, when I log on my account was at the GE with everything in bank sold but still get the cash.
Well I don't know what to tell you my scripts clean, look at it to see for your self. I have no interest in hacking others and couldn't even if I wanted to. I am not that advanced.
Now Making 4000 attack
Bank Uptext found, clicking bank
We did not find bank after clicking, checking for pin screen
We are in bank
Getting unf guam
unf guam is not found in storage
I Think we found the unf guam
Checking the uptext Guam pot, uam pot, or uam pot
Could not find uptext: Guam pot, uam pot, or uam pot
Could not find the Guam pot BMP
Retrying with block checker
Could not item with finditem 2
Retrying with FindColorSpiralTolerance
Could not find the unf guam
Successfully executed.
The following bitmaps were not freed: [3]
werder
02-15-2012, 10:34 PM
nice script but iv got some issues..
at first time tried this out it made me 2k prayer pots
then i logged out and bought more stuff to make prayer pots
> it makes 14 and stops??
werder
02-15-2012, 10:35 PM
Damn, it worked for 30 minutes but now it does 1 inventory and then doens't click the bank and wait..
same here
bigmike6675
02-16-2012, 05:12 PM
for some reason the script ran for about 20 minutes, and then just sat there after. im trying ot get it to work again now
gotwhip
02-17-2012, 09:28 AM
yea i'm having similar problems. it worked great for me a few days ago. made 10k unf pots in like 4 and a half hours. but today i tried to run it to make p pots, it made 68 then quit. tried again, made 140 and quit. tried a third time and made 70 then it quit. it goes to the bank and keeps saying it cant find the bank or supplies when it's already in the bank. the supplies haven't moved. and occasionally it just stops and doesn't attempt to do anything.
sieni
02-17-2012, 12:36 PM
there's not saradomin brew :(:(:( o there is but in "do list" there was no saradomin brew but i there was saradomin brew codes/settings ready so i just added "saradomin brew on that " to do list" works now :):) bot owned did u forgot sara brew on that list?:D
gotwhip
02-17-2012, 10:14 PM
my bad guys, that did absolutely nothing to the bot. it stopped working again right when i went afk lol. i guess it just had a lucky run. i'm still not sure why it keeps stopping. wish i did know so i could fix it....
kamil7123
02-18-2012, 05:27 PM
@gotwhip, make sure your graphic details are set as low as can be opengl software, I use that and all scripts I ever ran are perfectly fine.
Bud this is one of the best scripts I have seen and the code is great. ( I can understand that you are busy coding this as I used to code mopar servers myself, and that's a total different code and can get annoying.) I'm asking you, if you can of course, would you be able to add a option to make the mouse mouse movement faster? Somewhat like MK's herb cleaner, I believe that would increase the potions per hour at a very big amount. Anyways keep going, at the pace you're at right now, your job is almost at the perfection level and I know that's where you're headed.
I think with the new xp thing that pops up when you level up messes the script up when it trys to look in bank and I did disable "xp pop up" btw.
missile
02-19-2012, 09:08 PM
Most efficient and flawless script I've used yet.
im new idk where download is :(
madmatt9797
02-20-2012, 03:17 AM
It works good for sometime , but then it stops and this error happens.
We have made/cleaned a total of 882 super energys
Bank Uptext found, clicking bank
We did not find bank after clicking, checking for pin screen
We did not find bank after clicking or the pin screen
Bank not found, trying find_chest
Looking for bank with DTM
Warning! You passed a wrong xs to a finder function: -1. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ys to a finder function: -1. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ye to a finder function: 519. The client has a height of 503, thus the ye is out of bounds. Setting the value to 502 (h-1) for now.
Warning! You passed a wrong xs to a finder function: -21. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ys to a finder function: -21. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ye to a finder function: 539. The client has a height of 503, thus the ye is out of bounds. Setting the value to 502 (h-1) for now.
The following DTMs were not freed: [SRL - Lamp bitmap, 1, 2]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128]
tutkubakay
02-22-2012, 01:18 AM
I am using this script like a week and i dont get any errors. Works Brilliant!!
Ps: It cleans 5K herbs in a hour. You gain 25K herblore exp with some profit.
kimalia
02-22-2012, 11:17 PM
I am using this script like a week and i dont get any errors. Works Brilliant!!
Ps: It cleans 5K herbs in a hour. You gain 25K herblore exp with some profit.
it does like 1,2k potions/h costs me 13gp/exp
soo thats 120k exp/h :D
Scoped Guns
02-23-2012, 07:38 PM
i cant get it to find the bank it says bank uptext not found a million times
Bank Uptext not found
Warning! You passed a wrong xs to a finder function: -101. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ys to a finder function: -101. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ye to a finder function: 619. The client has a height of 503, thus the ye is out of bounds. Setting the value to 502 (h-1) for now.
Jeevesman
02-25-2012, 06:05 PM
Ok so i know you've given up on this bot but i had it working last night, now i'm having trouble again, it seems to be the antiban, it's just rotating my camera, any help would be much appreciated.
Many thanks
I can't seem to trust the log in thing, is it safe to enter acc details/bank pin in the form?
janbricky
02-27-2012, 12:19 PM
script crashes on login - just spins the camera around with the text
Warning! You passed a wrong xs to a finder function: -61. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ys to a finder function: -61. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ye to a finder function: 579. The client has a height of 503, thus the ye is out of bounds. Setting the value to 502 (h-1) for now.
bud_wis_er_420
02-29-2012, 10:08 PM
I'm working on a new one atm but first I'm making an include file I'm gona call something like FindBankItems. My plan is to use this include with all my future scripts on bank withdrawing. So like using an srl function, anyone can use this include in there script to find and withdraw items. I know there are srl functions that already exist that HELP in finding items, But what I want is to be able to enter
if(FindBankItem('Iron ore'))then // 'Iron ore' <-- exactly how it's typed in rs
DoThis;
The above would use many types of methods in finding the item. All I would have to do after this and start collecting a database on most commonly used items.
I have alot of work to do and little free time to do it so don't expect anything anytime soon. But once I complete the FindBankItems thingy I will be a simple matter of adding it to my incomplete script I been working on just below.
For a temp script That I use on a daily bases I posted on the first page.
Just showing you that I am working on it.
program SRLBasicTemplet;
{$DEFINE SMART}
{$i srl/srl.Simba}
{$i FindBankItem.Simba}
//{$i Basic.Simba}
//{$i SRL/SRL/misc/paintsmart.Simba}
//{$i ObjectDTM\ObjDTMInclude.simba}
// ItemArray stores everything about every item.
type
ItemArray = record
ItemName: string;
ItemType: integer;
LocationX: integer;
LocationY: integer;
end;
var
x, y, count: Integer;
FirstTime: Boolean;
Item: array of ItemArray;
const
Login_44 = 1; // 0 =451 off; 1 = on;
procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name := ''; //Youe Rs username
Players[0].Pass := ''; //Your RS password
Players[0].Nick := ''; //3-4 letters from name
Players[0].Active:= True;
Players[0].Pin := '';
end;
//***********************************
// Logs in player, need to redo
//***********************************
procedure CheckLogin;
var
Login_Screen,Invalid_Screen, Update_Screen:Integer;
begin
Login_Screen := DTMFromString('78DA6354656460D8C1800214656418B8803 45' +
'086E13F1030660059EDA86A5E3FD8035703028C6E40D60502 6A64' +
'81AC2B04D4D80359428C286A5616B0A0AA5943849A6620AB0 7BF5' +
'D00B3E316FA');
//Looks for Login and Lobby Screens
if(FindDTM(Login_Screen, x, y, 243, 107, 517, 418))or
(LobbyScreen)then
begin
Sleep(1000+Random(1000));
if(LoginPlayerToLob)then
begin
if(Login_44 = 1)then
begin
if(OpenWorldScreen)then
begin
Sleep(1000+Random(1000));
Mouse(123,125, 3, 3, true);//click world order arrow
Sleep(500+Random(1000));
Mouse(686,157, 4, 0, true);//click scroll bar top
Sleep(1000+Random(1000));
Mouse(687, 257, 3, 0, true);//click scroll bar to see world 44
Sleep(1000+Random(1000));
Mouse(144, 281, 100, 8, true);//click world 44
Sleep(2000+Random(1000));
Mouse(308, 452, 160, 19, true);//click login
Sleep(2000+Random(1000));
Writeln('Logged into world 44');
end else
begin
Writeln('Could not log into world 44');
if(LoginPLayer)then
begin
Writeln('Logged in');
end else
begin
CheckLogin
end;
end;
end else
begin
if(LoginPLayer)then
begin
Writeln('Logged in');
end else
begin
CheckLogin
end;
end;
end else
begin
CheckLogin;
end;
end;
FreeDTM(Login_Screen);
end;
//***********************************
// Antiban, need to redo
//***********************************
procedure AntiBan(SlotNum: Integer);
var
j, WTime, SleepT, CTime, StartColor :Integer;
Slot: TBox;
time :longword;
begin
j := Random(201)
time := GetSystemTime;
WTime := 15000 + Random(1000);
SleepT := time + WTime;
Slot := invbox(SlotNum);
StartColor := GetColor(Slot.x1 + 19, Slot.y1 + 15);
repeat
case j of
0: begin
//Check_for_text;
HoverSkill ('Herblore', False);
Sleep(1000+Random(3000));
GameTab(tab_Inv);
end;
1..5:
begin
//Check_for_text;
PickUpMouse;
end;
6..10:
begin
//Check_for_text;
RandomRClick;
end;
11:
begin
//Check_for_text;
//GameTab(tab_Inv);
end;
12:
begin
//Check_for_text;
ExamineInv;
end;
13..200:
begin
end;
end;
Sleep(500+Random(500))
CTime := GetSystemTime;
until(WaitColorGone(StartColor, Slot.x1 + 19, Slot.y1 + 15, 5, 30000))or
(SleepT < CTime)
end;
//***********************
//Script setup ** Not Finished
//***********************
procedure SetupWhatToMake;
begin
SetArrayLength(Item, 2);
Item[0].ItemName := 'water';
Item[0].ItemType := 2;
Item[1].ItemName := 'harralander';
Item[1].ItemType := 1;
end;
var
ItemData: array of ItemDataArray;
//**************************
//
//Need a way to check current item amount in bank to
//crosscheck with how many to be made. Don't want to
//go over the amount and lose item positions
//
//*************************
//Uses SetupWhatToMake array list to find all the items in bank the
//script is gona need to complete all tasks and store it's bank location.
procedure WithdrawSetup;
var
I, Ind: Integer;
FoundXY, BankXY, RowSlot: TPoint;
begin
SetupWhatToMake;
for I := 0 to High(Item) do
begin // Loops till all items script is gonna need is found
if(FindTheItem(x, y, Item[I].ItemName, Item[I].ItemType))then
begin
FoundXY := Point(x, y); //Stores found item x, y to a Tpoint
RowSlot := MSTPointToBankPoint(FoundXY); //Converts mouse point to a bank point(row, column)
Ind := BankPointToBankIndex(RowSlot); //Converts point to index
BankXY := BankIndexToMSPoint(Ind); // Converts index to mouse point
Item[I].LocationX := BankXY.x + 14;// Stores middle point of bank slot for item
Item[I].LocationY := BankXY.y + 15;
writeln(Item[I].ItemName + ' found and stored at row ' + IntToStr(RowSlot.y + 1) + ', Slot ' + IntToStr(RowSlot.x + 1));
end else
begin
Writeln('Shutting down script');
TerminateScript;
end;
end;
end;
//Simple right click and move mouse 74(Random) pixels down to withdraw-?
procedure GetTheItem(ax, ay: integer);
begin
Mouse(ax - 4, ay - 4, 8, 8, false);
Sleep(500 + Random(500));
GetMousePos(x, y);
Mouse(x - 5, y + 74, 10, 4, true);
end;
// Withdraws First items
function WithdrawFirst: Boolean;
begin
GetTheItem(Item[0].LocationX, Item[0].LocationY);
if(WaitInvCount(14, 4000, ExactCT))then //****Change to item.amount
begin
Result := True;
end else WithdrawFirst;
end;
// Withdraws Second items
function WithdrawSecond: Boolean;
var
StartCount, FinishCount: Integer;
begin
GetTheItem(Item[1].LocationX, Item[1].LocationY);
if(WaitInvCount(28, 4000, ExactCT))then
begin
Result := True;
end else WithdrawSecond;
end;
// Withdraws items
procedure WithdrawStuff;
begin
DepositAll;
if(FirstTime = True)then
begin
WithdrawSetup;
FirstTime := False;
end;
if(WithdrawFirst)then
begin
if(WithdrawSecond)then
begin
CloseBank;
end else
begin
WithdrawStuff;
end;
end else
begin
WithdrawStuff;
end;
end;
//Waits for 4 sec for the bank screen and also handles pin screen
function WaitForBank: Boolean;
begin
if(WaitFunc(@BankScreen, 500 + Random(100), 4000))or
(WaitFunc(@PinScreen, 500 + Random(100), 4000))then
begin
if(PinScreen)then
begin
Writeln('We are at pinscreen');
if(CheckPin)then
begin
WaitFunc(@BankScreen, 500 + Random(100), 4000);
if(BankScreen)then
begin
Result := True;
Sleep(500 + Random(500));
Exit;
end else
begin
Writeln('Did not find bank after enetering pin');
end;
end;
end;
if(BankScreen)then
begin
Result := True
Sleep(500 + Random(500));
end;
end else
begin
Writeln('Did not find bank after waiting');
end;
end;
// Finds bank using OpenBankChest
function FindTheBank3: Boolean;
begin
if(OpenBankChest(SRL_BANK_SW))then Result := True;
end;
// Finds bank using OpenBankChestEdge
function FindTheBank2: Boolean;
begin
if(OpenBankChestEdge(SRL_BANK_SW))then Result := True;
end;
// Finds bank using only uptext(Quick)
function FindTheBank1: Boolean;
begin
count := 0;
x := 256;
y := 196;
repeat
MMouse(x, y, 15, 7);
WaitUpTextMulti(['Use', 'ank', 'hest', 'che', 'nk ch'], 1000 + Random(100));
Inc(count);
until(IsUpTextMultiCustom(['Use', 'ank', 'hest', 'che', 'nk ch']))or
(count > 20)
if(IsUpTextMultiCustom(['Use', 'ank', 'hest', 'che', 'nk ch']))then
begin
GetMousePos(x,y)
Mouse(x,y,0,0,true);
if(WaitForBank)then Result := True;
end;
end;
// Uses the above 3 funtions to try and open the bank.
function OpenTheBank: Boolean;
begin
if(BankScreen)then
begin
Result := True;
Exit;
end;
CheckAngle(180);
if(FindTheBank1)then
begin
Result := True;
end else
begin
if(FindTheBank2)then
begin
Result := True;
end else
begin
if(FindTheBank3)then
begin
Result := True;
end else
begin
Writeln('Could not open the bank')
end;
end;
end;
end;
//Waits 4 sec for the make screen
Function WaitForMakeScreen: Boolean;
begin
if(WaitColor(388, 357, 2070783 , 5, 4000))then
begin
Writeln('Make screen found');
Result := True;
end else
begin
Writeln('Make screen not found');
end;
end;
//Makes the items
procedure Make;
var h :Integer;
begin
if not(InvFull)then Exit;
While not(ItemActivated(13)) do
begin
Mouse(575, 329, 10, 10, True);
Sleep(500 + Random(100));
end;
Mouse(570, 372, 10, 10, true);
if(WaitForMakeScreen)then
begin
Mouse(227, 406, 30, 20, true);
count := 1;
AntiBan(14); //Tie in 14 to amount in ItemArray
end else
begin
Make;
end;
end;
//Main Loop
procedure MainLoop;
begin
if(OpenTheBank)then
begin
WithdrawStuff;
Make;
end;
end;
Begin
ClearDebug();
Smart_Server := 44;
SetupSRL();
count := 0;
FirstTime := True;
repeat
MainLoop;
until(false)
End.
tight butts
03-01-2012, 06:17 AM
[Error] (32:1): Semicolon (';') expected at line 31
Compiling failed.
It keeps saying that at the Playsound_When_Done = false;// //
But the ';' is there... and if i delete that line, It'll say that ';' is expected at the line with
Procedure DeclarePlayers;
Weird.. I'm using the Temp. script that you posted on the first page.
bud_wis_er_420
03-02-2012, 04:53 AM
[Error] (32:1): Semicolon (';') expected at line 31
Compiling failed.
It keeps saying that at the Playsound_When_Done = false;// //
But the ';' is there... and if i delete that line, It'll say that ';' is expected at the line with
Procedure DeclarePlayers;
Weird.. I'm using the Temp. script that you posted on the first page.
sry bout that i did a few last min changes to make it ready for public use. You needed to add the semicolon to the line above the one you were refering to.
WarningSound = 'C:\botclient\config\sounds\alarm.wav'; <-----
Adamcoled
03-04-2012, 02:07 PM
Why does it bank every 5 unf made? How do I change that?
iRack93
03-04-2012, 05:55 PM
[Hint] (142:3): Variable 'INVALID_SCREEN' never used at line 141
[Hint] (142:3): Variable 'UPDATE_SCREEN' never used at line 141
[Error] (1:1): Unexpected end of file at line 0
Compiling failed.
This is the error I keep getting :|
jans123
03-05-2012, 07:25 AM
it worked fine for about 2minutes until the camera just keeps spinning around (antiban issues) and an issue about finding the item; im trying to finish off guam potions into attack potions and has issues finding the potions and eye of newt
looks like a great script , but needs to be corrected :)
bud_wis_er_420
03-07-2012, 09:07 AM
Just an update I'm getting real close. I got most of the main script finished and also the bank item finding include is looking really good. If all goes as planed this include will find Items 100% of the time. I already perfected my uptext finding. Check it out.
works 100% of the time!!
function ConvertTextToStrArray(ItemName: string): TStringArray;
var
I: Integer;
Txtleng: LongInt;
Text_array: TStringArray;
begin
Txtleng := Length(ItemName);
SetArrayLength(Text_array, Txtleng + 1);
for I := 0 to Txtleng do
Text_array[I] := Copy(ItemName, I, 1);
Result := Text_array;
end;
function CheckUpext(text: string): Boolean;
var
I, found: integer;
leng: Extended;
CompareText: string;
TxtArray, CompareTxtArray: TStringArray;
begin
CompareText := GetTextAt(82, 10, 0, 5, 10, 3182559, 47, 75, UpChars);
Text := Replace(Text, '''', '.');
SetArrayLength(CompareTxtArray, High(TxtArray))
TxtArray := ConvertTextToStrArray(Text);
CompareTxtArray := ConvertTextToStrArray(CompareText);
Writeln('Text got from rs: ' + CompareText);
Writeln('Text we are looking for: ' + Text);
found := 0;
for I := 1 to High(TxtArray) do
begin
Writeln('Char "' + TxtArray[i] +
'"compaired with char "' + CompareTxtArray[i] +'"');
if(TxtArray[i] = CompareTxtArray[i])then
begin
Inc(found);
end;
end;
leng := High(TxtArray);
if(found > leng - (0.20 * leng))then
begin
Result := True;
end else
begin
Writeln('The uptext "' + Text + '", was not found');
Writeln('Text got from rs: ' + CompareText);
Writeln('Found ' + IntToStr(found) + ' chars out of ' + FloatToStr(leng));
end;
end;
function WaitForUpText(Text: string; Time: Integer): Boolean;
var
ax,ay: integer;
begin
if(WaitFindColor(ax, ay, 3182559, 82, 10, 100, 16, 47, Time))then
begin
if(CheckUpext(Text))then
begin
Result := True;
Exit;
end;
end;
end;
After a few more things the main thing on my list will just be to build the item database. so be on the look out!! Real Soon!!
Script is working right now, just all it makes is unf harralander pots. And I want to do some testing.
Looks nice keep up the good work :)
draken95
03-09-2012, 07:12 PM
Witch bank does it support?
Ezio Auditore da Firenze
03-10-2012, 08:42 AM
Hmm, script was working fine for a long time, but now i get this error.
Error: Exception: Access violation at line 101
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap]
elmotheskaat
03-10-2012, 05:32 PM
Hmm, script was working fine for a long time, but now i get this error.
Error: Exception: Access violation at line 101
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap]
http://villavu.com/forum/showthread.php?p=848708
Ezio Auditore da Firenze
03-10-2012, 06:45 PM
http://villavu.com/forum/showthread.php?p=848708
Thanks mate :)
IBZerked
03-15-2012, 05:16 PM
how to make overloads?
bud_wis_er_420
03-16-2012, 05:56 AM
Ok, it's beta testing time!! Check out the first page for update information.
Semtex
03-16-2012, 02:10 PM
i'm like super sad i didn't know you only gain xp from putting the ingredient in unf pot, :d cause this script is pro, would have made ALOT more xp if i knew that before
newy1
03-16-2012, 03:15 PM
Most difficult script to set up I've ever seen.
What is the difference between ManualMode and Easy Setup?
Do you need to fill all fields for "Easy Setup, Manual SET UP SCRIPT 1, Manual SET UP SCRIPT 2"?
What does slot 7-4 mean?
" //Fill in what to make. You can enter how ever many you want. //Just be sure to change the numbers"
Should I put a number before "//"? I tried to put 1000 and got an error.
Semtex
03-16-2012, 03:18 PM
Most difficult script to set up I've ever seen.
What is the difference between ManualMode and Easy Setup?
Do you need to fill all fields for "Easy Setup, Manual SET UP SCRIPT 1, Manual SET UP SCRIPT 2"?
What does slot 7-4 mean?
" //Fill in what to make. You can enter how ever many you want. //Just be sure to change the numbers"
Should I put a number before "//"? I tried to put 1000 and got an error.
use the beta script, not the one's attached, they are not working 100%
newy1
03-16-2012, 03:24 PM
use the beta script, not the one's attached, they are not working 100%
Oh ok thanks.
Semtex
03-16-2012, 05:21 PM
Gained 520k xp so far with the beta script, it's working great :)
Sulferx
03-16-2012, 07:44 PM
Using this for BXP and it's working flawlessly. thanks!
bud_wis_er_420
03-17-2012, 02:09 AM
I'm glad it's working great for yall too and not just me, I will finish the main script this weekend and update here. Then I will start on the item database. I have been procrastinating on that because I have to reload the rs page like 10 times or more for each item to get the correct color tolerances. This Bank Item Finding Include I built will one day have most common items from every skill set. You could use my include to very simply withdraw ores, bars, charms, logs, food, hides, fish, and the list goes on and on and on.
if you look at this piece of code in the beta script I posted on the front page, you will see me calling the very easy to use function that will find any bank item.
{ if(FindBankItemMulti(x, y, Item[I].ItemName))then
begin
FoundXY := Point(x, y); //Stores found item x, y to a Tpoint
RowSlot := MSTPointToBankPoint(FoundXY); //Converts mouse point to a bank point(row, column)
Ind := BankPointToBankIndex(RowSlot); //Converts point to index
BankXY := BankIndexToMSPoint(Ind); // Converts index to mouse point
Item[I].LocationX := BankXY.x + 14;// Stores middle point of bank slot for item
Item[I].LocationY := BankXY.y + 15;
writeln(Item[I].ItemName + ' found and stored at row ' + IntToStr(RowSlot.y + 1) + ', Slot ' + IntToStr(RowSlot.x + 1));
end else
begin
Writeln('Shutting down script');
TerminateScript;
end; }
I just have it commented out because I don't have the item database going yet. But the include is finished. Take a look if you like,below, but this might change a bit depending on any problems that may arise from building the item database.
{
FindBankItems
The FindBankItems include contains functions to find many bank Items.
* by Bud_wis_er_420
Function List:
~ * function AutoTheColorEx(StringType: string; ax, ay, bx, by: Integer): Integer;
~ * function AutoTheColor(var x, y:integer; ItemName: string): Boolean;
~ * function ConvertTextToStrArray(ItemName: string): TStringArray;
~ * function CheckItemUpext(text: string): Boolean;
~ * function WaitForUpText(Text: string; Time: Integer): Boolean;
~ * function FindBankItemDtmEx(var x, y:integer; ItemName: string; ax, ay, bx, by: integer): Boolean;
~ * function FindBankItemDtm(var x, y:integer; ItemName: string): Boolean;
~ * function FindBankItemDtmSlot(var x, y: integer; ItemName: string): Boolean;
~ * function FindBankItemAutoColorSlot(var x, y: integer; ItemName: string): Boolean;
~ * function FindBankItemMulti(var x, y:integer; ItemName: string): Boolean;
Item List:
~~Herbs~~
Clean guam, Grimy guam, Clean marrentill, Grimy marrentill, Clean tarromin,
Grimy tarromin, Clean harralander, Grimy harralander, Clean ranarr, Grimy ranarr,
Clean toadflax, Grimy toadflax, Clean spirit weed, Grimy spirit weed, Clean irit,
Grimy irit, Clean wergali, Grimy wergali, Clean avantoe, Grimy avantoe,
Clean kwuarm, Grimy kwuarm, Clean snapdragon, Grimy snapdragon, Clean cadantine,
Grimy cadantine, Clean lantadyme, Grimy lantadyme, Clean dwarf weed,
Grimy dwarf weed, Clean torstol, Grimy torstol, Clean fellstalk, Grimy fellstalk
~~Potions: Finished and Unfinished~~
~~Ores and Bars~~
~~Logs~~
~~Bows: Finished and Unfinished~~
~~Leather~~
~~Fish: Cooked and Uncooked~~
~~Equipment~~
~~Weapons and Armour~~
~~Other~~
}
{$i ItemData.Simba}
(*
AutoTheColorEx
~~~~~~~~~~
.. code-block:: pascal
function AutoTheColorEx(StringType: string; ax, ay, bx, by: Integer): Integer;
* Uses Edited ACA funtion to autocolor many different
colors within ItemData Include
* Returns Auto Color within a specified box
.. note::
Author: Nielsie95 and Sumilion edited by Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function AutoTheColorEx(StringType: string; ax, ay, bx, by: Integer): Integer;
var
arP: TPointArray;
arC: TIntegerArray;
tmpCTS, i, arL, Acolor, Atol: Integer;
Hue, Sat: Extended;
begin
GetAutoColorData(StringType, Acolor, Atol, Hue, Sat);
tmpCTS := GetColorToleranceSpeed;
ColorToleranceSpeed(2);
SetColorSpeed2Modifiers(Hue, Sat);
FindColorsSpiralTolerance(ax, ay, arP, Acolor, ax, ay, bx, by, Atol);
if (Length(arP) = 0) then
begin
Writeln('Failed to find the color, no result.');
ColorToleranceSpeed(tmpCTS);
SetColorSpeed2Modifiers(0.2, 0.2);
Exit;
end;
arC := GetColors(arP);
ClearSameIntegers(arC);
arL := High(arC);
for i := 0 to arL do
begin
Result := arC[i];
//Writeln('AutoColor = ' + IntToStr(arC[i]));
Break;
end;
ColorToleranceSpeed(tmpCTS);
SetColorSpeed2Modifiers(0.2, 0.2);
if (i = arL + 1) then
Writeln('AutoColor failed in finding the color.');
end;
(*
AutoTheColor
~~~~~~~~~~
.. code-block:: pascal
function AutoTheColor(StringType: string): Integer;
* Uses AutoTheColorEx
* Returns Auto Color within whole screen
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function AutoTheColor(StringType: string): Integer;
begin
Result := AutoTheColorEx(StringType, MSX1, MSY1, MSX2, MSY2);
end;
(*
ConvertTextToStrArray
~~~~~~~~~~
.. code-block:: pascal
function ConvertTextToStrArray(ItemName: string): TStringArray;
Returns a string array of individual characters of a String.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function ConvertTextToStrArray(ItemName: string): TStringArray;
var
I: Integer;
Txtleng: LongInt;
Text_array: TStringArray;
begin
Txtleng := Length(ItemName);
SetArrayLength(Text_array, Txtleng + 1);
for I := 0 to Txtleng do
Text_array[I] := Copy(ItemName, I, 1);
Result := Text_array;
end;
(*
CheckItemUpext
~~~~~~~~~~
.. code-block:: pascal
function CheckItemUpext(text: string): Boolean;
Gets RS item text and compares each character with var text.
Returns true if results are at least an 80% match.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function CheckItemUpext(text: string): Boolean;
var
I, found: integer;
leng: Extended;
CompareText: string;
TxtArray, CompareTxtArray: TStringArray;
begin
Result := False;
CompareText := GetTextAt(82, 10, 0, 5, 10, 3182559, 47, 75, UpChars);
Text := Replace(Text, '''', '.');
SetArrayLength(CompareTxtArray, High(TxtArray))
TxtArray := ConvertTextToStrArray(Text);
CompareTxtArray := ConvertTextToStrArray(CompareText);
//Writeln('Text got from rs: ' + CompareText);
//Writeln('Text we are looking for: ' + Text);
found := 0;
for I := 1 to High(TxtArray) do
begin
//Writeln('Char "' + TxtArray[i] +
// '"compaired with char "' + CompareTxtArray[i] +'"');
if(TxtArray[i] = CompareTxtArray[i])then
begin
Inc(found);
end;
end;
leng := High(TxtArray);
if(found > leng - (0.20 * leng))then
begin
Result := True;
end else
begin
Writeln('The uptext "' + Text + '", was not found');
Writeln('Text got from rs: ' + CompareText);
Writeln('Found ' + IntToStr(found) + ' chars out of ' + FloatToStr(leng));
end;
end;
(*
WaitForUpText
~~~~~~~~~~
.. code-block:: pascal
function WaitForUpText(Text: string; Time: Integer): Boolean;
Waits for orange text to appear. Then uses CheckItemUpext to compare text
Returns true if found, else it tries once more incase of lag.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function WaitForUpText(Text: string; Time: Integer): Boolean;
var
ax,ay: integer;
begin
Result := False;
if(WaitFindColor(ax, ay, 3182559, 82, 10, 100, 16, 47, Time))then
begin
if(CheckItemUpext(Text))then
begin
Result := True;
Exit;
end else
begin
//Checking again in 2 to 3 sec, temp lag protection
Sleep(2000 + random(1000));
if(CheckItemUpext(Text))then
begin
Result := True;
Exit;
end;
end;
end;
end;
(*
FindBankItemDtmEx
~~~~~~~~~~
.. code-block:: pascal
function FindBankItemDtmEx(var x, y:integer; ItemName: string; ax, ay, bx, by: integer): Boolean;
Finds premade DTM within a specified box. Returns true if found.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function FindBankItemDtmEx(var x, y:integer; ItemName: string; ax, ay, bx, by: integer): Boolean;
var
DTM: Integer;
begin
Result := False;
DTM := GetItemDTM(ItemName);
if(FindDTM(DTM, x, y, ax, ay, bx, by))then
begin
MMouse(x - 2, y - 2, 4, 4);
sleep(200+random(100));
if(WaitForUpText(ItemName, 4000))then Result := True;
end else Writeln('Did not find the ' + ItemName + ' with FindBankItemDTM');
FreeDTM(DTM);
end;
(*
FindBankItemDtm
~~~~~~~~~~
.. code-block:: pascal
function FindBankItemDtm(var x, y:integer; ItemName: string): Boolean;
Finds premade DTM within the bank screen(Not Tab Area). Returns true if found.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function FindBankItemDtm(var x, y:integer; ItemName: string): Boolean;
begin
Result := FindBankItemDtmEx(x, y, ItemName, 25, 83, 480, 491);
end;
(*
FindBankItemDtmSlot
~~~~~~~~~~
.. code-block:: pascal
function FindBankItemDtmSlot(var x, y: integer; ItemName: string): Boolean;
Finds premade DTM within the bank screen(Not Tab Area),
checking one bank slot at a time. Returns true if found.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function FindBankItemDtmSlot(var x, y: integer; ItemName: string): Boolean;
var
rightcount, downcount, Slotx, Sloty: integer;
begin
Result := False;
Slotx := 31;
Sloty := 85;
rightcount := 0;
downcount := 0;
repeat
repeat
//SMART_DrawBoxEx(True, IntToBox(Slotx, Sloty, Slotx + 44, Sloty + 44), clRed);
if(FindBankItemDtmEx(x, y, ItemName, Slotx, Sloty, Slotx + 44, Sloty + 44))then
begin
Result := True;
Exit;
end;
Slotx := Slotx + 44;
Inc(rightcount);
Sleep(5 + random(2));
until(rightcount >= 10)
rightcount := 0;
Sloty := Sloty + 44;
Slotx := 31;
Inc(downcount);
Sleep(10);
until(downcount >= 4)
Writeln(ItemName + ' was not found with FindBankItemDtmSlot');
//SMART_ClearCanvas;
end;
(*
FindBankItemAutoColorSlot
~~~~~~~~~~
.. code-block:: pascal
function FindBankItemAutoColorSlot(var x, y: integer; ItemName: string): Boolean;
Finds Auto Color of an Item within the bank screen(Not Tab Area),
checking one bank slot at a time. Returns true if found.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function FindBankItemAutoColorSlot(var x, y: integer; ItemName: string): Boolean;
var
rightcount, downcount, Slotx, Sloty, AColor: integer;
begin
Result := False;
Slotx := 31;
Sloty := 85;
rightcount := 0;
downcount := 0;
repeat
repeat
//SMART_DrawBoxEx(True, IntToBox(Slotx, Sloty, Slotx + 44, Sloty + 44), clRed);
AColor := AutoTheColorEX(ItemName, Slotx, Sloty, Slotx + 44, Sloty + 44)
if(AColor > 0)then
begin
if(FindColorTolerance(x, y, AColor, Slotx, Sloty, Slotx + 44, Sloty + 44, 5))then
begin
MMouse(Slotx + 16, Sloty + 16, 12, 12);
Sleep(200+random(100));
if(WaitForUpText(ItemName, 4000))then
begin
Result := True;
Exit;
end;
end;
end;
Slotx := Slotx + 44;
Inc(rightcount);
Sleep(10);
until(rightcount >= 10)
rightcount := 0;
Sloty := Sloty + 44;
Slotx := 31;
Inc(downcount);
Sleep(10);
until(downcount >= 4)
Writeln(ItemName + ' was not found with FindBankItemAutoColorSlot');
//SMART_ClearCanvas;
end;
(*
FindBankItemMulti
~~~~~~~~~~
.. code-block:: pascal
function FindBankItemMulti(var x, y:integer; ItemName: string): Boolean;
Uses 3 different functions as a fail safe to find a bank item.
Returns true if Found.
.. note::
Author: Bud_wis_er_420
Last Modified: Mar. 7th, 2012 by Bud_wis_er_420
Example:
.. code-block:: pascal
*)
function FindBankItemMulti(var x, y:integer; ItemName: string): Boolean;
begin
if(FindBankItemDTM(x, y, ItemName))then
begin
Result := True;
end else
begin
if(FindBankItemDtmSlot(x, y, ItemName))then
begin
Result := True;
end else
begin
if(FindBankItemAutoColorSlot(x, y, ItemName))then
begin
Result := True;
end else
begin
Writeln(ItemName + ' was not found using all 3 methods');
end;
end;
end;
end;
Bungalow
03-17-2012, 04:13 AM
How do i add this so i can run it or whatever?
SACbotter
03-17-2012, 04:23 AM
hmm, this script is incompatible with the scroll of cleansing. What that does it that it saves herbs, so often after an inventory is finished, there will be secondaries left behind (herbs if making unfs, the 2ndary if making pots). I hvaen't looked through your code, but it looks like it waits for the bottm half of the inventory to be empty before banking. could you please add the scroll of cleansing fix?
bud_wis_er_420
03-18-2012, 02:32 AM
hmm, this script is incompatible with the scroll of cleansing. What that does it that it saves herbs, so often after an inventory is finished, there will be secondaries left behind (herbs if making unfs, the 2ndary if making pots). I hvaen't looked through your code, but it looks like it waits for the bottm half of the inventory to be empty before banking. could you please add the scroll of cleansing fix?
It's not that it is incompatible with the scroll of cleansing, I forgot to redo the antiban. Anyways it should be fixed now, recopy and paste the script on the first page.
Btw I took out the crashsmart because there is a better way now using SMARTManager (http://villavu.com/forum/showthread.php?t=76404)
Adamcoled
03-24-2012, 10:26 PM
Just a request.. If you could make it so that it will stop if it withdraws one of the supplies < 14 instead of having to specify how many to make before you start the bot. Mainly because I run multiple accounts at once and would prefer not having to find and set that number everytime I set a bot up, especially if the bot isn't flawless. However, if you make that simple change I'd be glad to test run the script for you on my accounts and post the bugs here.
dragon926
03-31-2012, 02:58 PM
Hey it works but it is rather slow, after making potions it takes a while to find the bank.
Apart from that... this is a great script
Actually i found out the problem. Since i have scroll of cleansing, there will be left over materials. Whenever there is left over materials the bot would attempt to mix the secondary ingredient with the already combined potion (unf) until it eventually clicks the bank.
Copied the latest code but im still experiencing this problem^
Surfster
04-05-2012, 09:50 PM
hey when i am using the script in world 44 login, the script sometimes walks out of soul wars and doesnt walk back to the sw
jonjon4012
04-09-2012, 05:13 PM
I'm still relatively new to this site, I cant seem how to figure out how to copy paste into simba, a noob error i know. Can someone help me with this? I would like to get this script running seeing as how i have the scroll of cleansing, and according to the above posts it does do unfinished potions. Any help would be nice. Like i said im still new and trying to figure this out.
Neznam
04-09-2012, 11:09 PM
I'm still relatively new to this site, I cant seem how to figure out how to copy paste into simba, a noob error i know. Can someone help me with this? I would like to get this script running seeing as how i have the scroll of cleansing, and according to the above posts it does do unfinished potions. Any help would be nice. Like i said im still new and trying to figure this out.
If when you try to COPY and PASTE the code and it pastes the code all in ONE line...
All you do is QUOTE the first post... scroll to the beginning part of the script, COPY, open simba paste. This time when you paste it will paste normally and not all in one line.
Good luck
EDIT:
I get
[Hint] C:\Simba\Includes\SRL/SRL/core/mapwalk.simba(1353:3): Variable 'BOX' never used at line 1352
[Hint] (249:2): Variable 'IND' never used at line 248
[Hint] (250:2): Variable 'FOUNDXY' never used at line 249
[Hint] (250:2): Variable 'BANKXY' never used at line 249
[Hint] (250:2): Variable 'ROWSLOT' never used at line 249
[Error] (1:1): period ('.') expected at line 0
Compiling failed.
omar84
04-15-2012, 02:12 AM
what bank will this script work best at?
Rocker 1414
04-15-2012, 05:35 PM
If when you try to COPY and PASTE the code and it pastes the code all in ONE line...
All you do is QUOTE the first post... scroll to the beginning part of the script, COPY, open simba paste. This time when you paste it will paste normally and not all in one line.
Good luck
EDIT:
I get
[Hint] C:\Simba\Includes\SRL/SRL/core/mapwalk.simba(1353:3): Variable 'BOX' never used at line 1352
[Hint] (249:2): Variable 'IND' never used at line 248
[Hint] (250:2): Variable 'FOUNDXY' never used at line 249
[Hint] (250:2): Variable 'BANKXY' never used at line 249
[Hint] (250:2): Variable 'ROWSLOT' never used at line 249
[Error] (1:1): period ('.') expected at line 0
Compiling failed.
Make sure you get the last line "End."
Son of Zeus
04-15-2012, 06:42 PM
Got 99 herblore with this script a couple of weeks ago, many thanks for this :)
Surfster
04-15-2012, 11:52 PM
Great script, ive leveled more than 30 times with this script, but I would like to suggest a part in your script that deals with the extra spins that you get when the script is running
Very nice script, works perfect and atleast now i have a use for all my clean herbs :p
Br3edage
04-19-2012, 01:19 PM
havent found anything that is profitable from making (unf) potions..... clean herbs are worth more then (unf) pots lol.
Crack_Cocaine
04-19-2012, 06:57 PM
havent found anything that is profitable from making (unf) potions..... clean herbs are worth more then (unf) pots lol.
Are you using a Scroll of Clensing from dungeoneering? That's the only way literally to make any profit from unf potions.
As for the script;
Is this seriously BETA? If it's better, then this guy deserves a huge pat on the back. One of the best herb scripts I've used since the bot nuke. Scratch that. THE best herb bot I've used.
Neznam
04-19-2012, 07:19 PM
Clean herbs are not worth more than (unf) potions. At least not all.
Take a look at the second list which shows Clean Herbs to Unfinished Potions...
http://runescape.wikia.com/wiki/Calculators/Unfinished_potions
Some have a potential profit anywhere from around 100-500gp per potion.
Tiggy
04-26-2012, 04:32 PM
Great script, made 10K prayer pots yesterday night. But stuck on a spinning ticket today, can you fix that?
Neznam
04-28-2012, 06:27 PM
Out of all the Herbalore scripts in this section, this herb script is the best one ive used. Ive tried them all, and this one has been flawless so far.
Great script, made 10K prayer pots yesterday night. But stuck on a spinning ticket today, can you fix that?
^ clicking on the ticket is the only problem
but can be fixed it by adding
"FindNormalRandoms;" to the main loop, and thoughout a few other spots in the script too
kefkuh
04-29-2012, 12:39 AM
everything seems to be working great, thank you sir
iFluffy
04-29-2012, 05:18 PM
when scroll of cleansing saves herbs it takes about 10x longer to bank then when it doesn't. any solution for that?
Surfster
05-04-2012, 01:25 AM
best herb script so far, flawless
when scroll of cleansing saves herbs it takes about 10x longer to bank then when it doesn't. any solution for that?
i was having this problem too when making unf pots. i fixed it by moving my vials into the 1st slot and my herbs in the 2nd (previously had been herbs 1st, vials 2nd) and it now works flawless. hope it helps
chuckyb0y
05-07-2012, 11:03 AM
i was having this problem too when making unf pots. i fixed it by moving my vials into the 1st slot and my herbs in the 2nd (previously had been herbs 1st, vials 2nd) and it now works flawless. hope it helps
this fixed it for me :)
tame27
05-08-2012, 07:11 AM
why does my piece of crap simba just spin in circles..
Era Xz
05-08-2012, 07:28 AM
think it has to do with update of simba or RS. Does same for me
iiNveRsioN
05-08-2012, 08:02 AM
Yup spins for me as well.. seems to effect other SW chest scripts as well.
vkillerv
05-08-2012, 08:45 AM
Yup spins for me as well.. seems to effect other SW chest scripts as well.
think it has to do with update of simba or RS. Does same for me
why does my piece of crap simba just spin in circles..
refer to this post: http://villavu.com/forum/showpost.php?p=1011304&postcount=10
rebeltjeh
05-08-2012, 05:06 PM
Or just press SRL => Update .. :)
ZachZl
05-08-2012, 06:15 PM
Sorry if this is a dumb question, but will this script make Extremes? Specifically attack/strength?
b3astown
05-08-2012, 06:46 PM
how do u copy it into simba, it doesn't copy it in the correct format, so when i try to compile it, it never works
Neznam
05-08-2012, 07:01 PM
Sorry if this is a dumb question, but will this script make Extremes? Specifically attack/strength?
I believe it can. As long as you put one item in the first bank slot, and the other in the second.
how do u copy it into simba, it doesn't copy it in the correct format, so when i try to compile it, it never works
The way I do it is, I press [QUOTE] at the bottom of the post, and it will show up in the box as a quote... then you copy the code part of it and when you paste it in simba, it will write it normaly, instead of all in 1 line...
If you need clearing up on what I mean, just PM me.
Death Iz Pro
05-08-2012, 08:44 PM
Was working before spin problem. Changed, and now working again - now back to getting extremes/ovls. Thanks! Best herblore script IMO, all others either shut off after 1-2k pots or don't work at all.
Rang30wns
05-10-2012, 04:01 AM
[Hint] C:\Simba\Includes\SRL/SRL/core/animation.simba(257:3): Variable 'X' never used at line 256
[Hint] C:\Simba\Includes\SRL/SRL/core/animation.simba(257:3): Variable 'Y' never used at line 256
[Hint] (235:2): Variable 'IND' never used at line 234
[Hint] (236:2): Variable 'FOUNDXY' never used at line 235
[Hint] (236:2): Variable 'BANKXY' never used at line 235
[Hint] (236:2): Variable 'ROWSLOT' never used at line 235
[Error] (1:1): period ('.') expected at line 0
Compiling failed.
How do i fix?
Rang30wns
05-10-2012, 04:13 AM
Holy cow, i feel so dumb. forgot a period at the end... -.- sorry for stupid question guys
eboy89
05-10-2012, 08:51 PM
Well I thought this script was flawless until I attempted extreme strength pots and it derped hard. It withdraws 27 pots and 1 herb, then starts drinking your pots.....So just reporting do not try extreme strengths.
newlolplayer
05-11-2012, 05:43 AM
Great script! thx a lot.
When I was using it, I received a spin ticket, and the script got stuck at trying to store all inventory items (repeated it 50+ times before i noticed)
is there a way I can fix this?
Does this make super attacks ?
newlolplayer
05-11-2012, 06:40 PM
Does this make super attacks ?
Yes it does, place the ingredient and the unf pot in the first 2 places of your bank tab and start :)
pkwa9lawy
05-11-2012, 09:15 PM
guys hows the script antibans? should i use it for 65-99 ?
melee
05-12-2012, 02:07 AM
Hmm looks great but I'm trying spec restores and it doesnt recognize them in my first 2 slots. It then changed to color checking and goes through every item in bank.
melee
05-12-2012, 02:25 AM
I changed to copy and paste the main script and it just eats the papaya
pkwa9lawy
05-12-2012, 02:37 AM
I changed to copy and paste the main script and it just eats the papaya
which script yoy copy pasteD? try the one in tags
Dried
05-13-2012, 12:53 AM
why am i only getting 1.5k potions done in 1 hr, i saw proggie with 2.3k done per hr
ballmccartney
05-13-2012, 01:06 AM
I'm not sure if this is a client issue or is something that can be fixed with the script, but as a few people have stated already, you often receive a spin ticket and it messes up the bot. It will just sit there attempting to deposit all items over and over again.
FloppyWien3r
05-14-2012, 12:11 AM
Say could you add the adding/removal of a spin ticket from inventory.
kneekopiko
05-15-2012, 02:42 AM
Really splendid and well-commented script. Did a great job of making 1k extremes of every type, and then with not too much fiddling around I got it to make overloads as well.
Thanks and nice job!
jagger3320
05-15-2012, 10:56 PM
:stirthepot:
Aberrant
05-16-2012, 01:40 PM
Good script worked flawlessly for a few hours until I got a Spin Ticket, how can I fix this?
Surfster
05-17-2012, 12:22 AM
Good script worked flawlessly for a few hours until I got a Spin Ticket, how can I fix this?
I also ran into this problem, I also ran into the problem of having the bot walk in front of the bank.
Overall, Perfect script, thank you for getting me from 55 herblore, to 90 herblore!!
this bot is amazing :)
except that it stops and logs out whenever it gets a spin ticket, is there a fix to this?
Inheaven
05-19-2012, 12:41 PM
Error? Please help:
Compiling failed.
Exception in Script: Unable to find file 'SRL/SRL.scar' used from ''
Exception in Script: Unable to find file 'SRL/SRL.scar' used from ''
[Hint] C:\Simba\Includes\SRL/SRL/core/animation.simba(257:3): Variable 'X' never used at line 256
[Hint] C:\Simba\Includes\SRL/SRL/core/animation.simba(257:3): Variable 'Y' never used at line 256
[Error] C:\Simba\Includes\SRL/SRL/core/antirandoms\certers.simba(122:165): Closing square bracket (']') expected at line 121
Compiling failed.
OwainJones
05-23-2012, 01:59 AM
Just get it to click slot 14 and slot 18. Regardless that having a spin token in the inventory will slow it down, it's still faster than most of the bloated scripts around here. Yes this is highly detectable.
awesomem8
05-23-2012, 07:57 PM
Thanks man just got 99 herblore with this script. modified it to make extreme range as well. Now Im using it to fletch. testing out smart manager to see if it will go more than 6 hours now.
I am amazed at the fluidity with which this script runs.
Thanks again.
jake53142
05-25-2012, 02:55 AM
it takes around 15 second to bank. any way to fix this?
Syntax
05-25-2012, 10:01 AM
Error? Please help:
'SRL/SRL.scar'
There's your problem, change it to 'SRL/SRL.simba' in the includes.
Yellow Partyhat
05-29-2012, 12:19 AM
Manual set up is abit confusing, but the bot is alright rep :)
speedypetey
06-03-2012, 11:23 AM
Great script just about the only quality working potion making script...even with the spin ticket problem.
going to 99!
thanks again!
Great script! Really want to use it but I have 2 issues;
1. After a few minutes it stopped banking the unfinished pots, looks like it couldn't find the bank chest at SW anymore. Although it found it after 30 sec.
2. Same thing happened again although this time several minutes passed and it hasn't found the bank yet.
Any ideas how to fix this?
Fascinate
06-04-2012, 05:26 PM
Great script! Really want to use it but I have 2 issues;
1. After a few minutes it stopped banking the unfinished pots, looks like it couldn't find the bank chest at SW anymore. Although it found it after 30 sec.
2. Same thing happened again although this time several minutes passed and it hasn't found the bank yet.
Any ideas how to fix this?
You could update the colors yourself to find it more reliably.
I wish I knew how to,
It seems to work very good except for certain times when it just stands there and does nothing. I've tried browsing through the script to see if I can change anything but I don't want to mess up anything.
Anyone got any ideas of what to change? Or why it does this?
speedypetey
06-06-2012, 06:13 PM
Thanks a lot for this script man
got me 99! :)
crazya
06-27-2012, 07:04 AM
I am really looking forward to trying your script but sadly I am getting this error:
Error: Out Of Range at line 1459
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap]
I know I have to do something with line 1459, which I have no idea what to do. please help me?
crazya
06-27-2012, 02:42 PM
not working for me =(
Liquid Atoms
07-03-2012, 12:10 AM
When selecting special recoveries, all goes well until it opens bank. It cannot detect the super energies which are in their (3) form. I also have a (4) pot and it doesn't detect it either. Maybe I am doing something wrong, because this script seems so well done.
kambyz
07-03-2012, 06:38 PM
Beast script, guess best around here, just only one bug, that many ppl got here: that shitty spin ticket suck balls! Sorry for rage, but it does.
Can u fix it please? I guess that Jeffrey's Herblore script have corrected that bug
Juggalo812
07-07-2012, 05:12 PM
Beast script, guess best around here, just only one bug, that many ppl got here: that shitty spin ticket suck balls! Sorry for rage, but it does.
Can u fix it please? I guess that Jeffrey's Herblore script have corrected that bug
Just add "FindNormalRandoms;" without the "" into the script. Problem solved.
bud_wis_er_420
03-05-2013, 12:37 AM
All Potion Maker is back. Got it working again. Updated to ver 2.0
Trying to get thread moved back to public scripts.
Hobbit
03-05-2013, 04:13 PM
Working for EOC I'm assuming?
Moved
bud_wis_er_420
03-05-2013, 05:12 PM
yes and thx
GoHard
04-08-2013, 01:14 AM
i don't understand hopw to set it up for ovls, it just withdraws vials of waters and sits there.
evokepkbow
04-10-2013, 05:37 PM
It makes 5 pots and banks again.. What's going on? Or what I'm I doing wrong?
bud_wis_er_420
04-13-2013, 06:07 PM
It makes 5 pots and banks again.. What's going on? Or what I'm I doing wrong?
Right click on the xp button next to your minimap and select toggle production or something like that. The production window need to be on.
prabhsun
04-15-2013, 01:55 AM
Bro, i noticed you did not have saradomin brews, could you add those please? thank you :D
bud_wis_er_420
04-26-2013, 03:30 AM
It's in there already keep looking.
hackingislol133
04-27-2013, 11:44 PM
manual setup 1 is flawed for multiple tasks. having herbs in a slot earlier than vial of water changes the position of the vials when type of unf is finished.
why not have vials of water in slot 1 and herbs in slot 2? this would completely avoid the problem of item positioning in the bank and allow for continuous purging of herbs that are finished.
edit: is there a plan to add GE banks?
bud_wis_er_420
04-28-2013, 08:19 AM
manual setup 1 is flawed for multiple tasks. having herbs in a slot earlier than vial of water changes the position of the vials when type of unf is finished.
why not have vials of water in slot 1 and herbs in slot 2? this would completely avoid the problem of item positioning in the bank and allow for continuous purging of herbs that are finished.
edit: is there a plan to add GE banks?
right below the option to turn on manual setup
{ManualMode: Setup //
NOTE: *Only use one task at a time! //
*Set up x withdraw in game to correct amount.
Only use one task at a time!
if you want to set up multiple tasks to run more than 6 hrs, which should be the only reason to use manual setup, then you have to use the long set up. [Manual SET UP SCRIPT 2] I will look into switching the vial and herb position though.
Also Manual 1 is just a stationary withdraw method if the find item in bank breaks. You can manually tell the script where the items are. You still have to tell it what you are making in manual 2. But using manual 1 you can only do one task at a time.
I will try adding a help section on front page to explain the setup better. I know it can be confusing. And you know when I made it this way it was meant to be less confusing. But as the script grew it got more confusing then I intended. I will also see if I can clean it up and make it more noob friendly.
...and more banking locations.
bud_wis_er_420
05-01-2013, 08:19 PM
I'm gonna try to get around to adding more bank locations today, folks.
I'm going for Edgeville, GE most SW bank, Verrock West bank, and Falador west bank. Let me know if you want anymore locations.
bud_wis_er_420
05-11-2013, 07:48 PM
I'm totally revamping this script. That's what is taking me so long to release more bank locations. This way script will be much easier to manage. I've build an include that will, in the future, be used with all my scripts. It comes with easy to use functions. Like one of my favs:
Is the bank withdraw function. You would call it and give it color info and it will remember where that bank object is, making it easier to find next time. Lots more is included. Stay tuned cause I'm almost finished. I already finished with my smelter script, But I don't what to release yet cause I got alot of cleaning up to do.
prabhsun
05-12-2013, 03:26 AM
I'm totally revamping this script. That's what is taking me so long to release more bank locations. This way script will be much easier to manage. I've build an include that will, in the future, be used with all my scripts. It comes with easy to use functions. Like one of my favs:
Is the bank withdraw function. You would call it and give it color info and it will remember where that bank object is, making it easier to find next time. Lots more is included. Stay tuned cause I'm almost finished. I already finished with my smelter script, But I don't what to release yet cause I got alot of cleaning up to do.
WOOOOOTTTT \m/
bud_wis_er_420
05-13-2013, 06:32 AM
Just to give yall an idea of all the items I'm having to work with... Getting close though.
http://img823.imageshack.us/img823/1900/itemslist.png
Almost there doing final testing.
bud_wis_er_420
05-14-2013, 04:00 AM
OK, I think I got most of it working. I'm sure I missed something. THis script is so massive it makes my head spin. Hard to keep track of everything. I still have lots to do, but I need a break and testing done. So I'm releasing 2.1 for yall to test for me.
If an item is found though the single slot checker please tell me what item it is.
Also add Flask making and 4 dose making. Will update the first page later.
OMG! So much to do.
I'm working on totally rewriting this script for easier navigation and less space. For example I got most of my item color info on 200 lines vs. the 5000 lines currently used. Numbers are estimates.
hackingislol133
05-19-2013, 06:23 AM
put together an includes library to simplify source. lol
looking forward to the rewritten code. fight on!
bud_wis_er_420
05-19-2013, 09:18 AM
put together an includes library to simplify source. lol
looking forward to the rewritten code. fight on!
Not sure if I'm understanding you right, but if I am, your mocking me for making an include with functions that mimic what some srl functions do. Well I just recently found out about a good human srl mouse function. Can't remember the name, but I know I could find it again. Anyways, that is on my agenda list. About the rest, trust me my functions were only made because the srl ones either failed, didn't exist to my knowledge, or didn't function the way I needed them to.
Take for example. The MDeposit function...
function MDeposit(InvStart, InvEnd: integer): Boolean;
Just like SRL procedure Deposit(SlotFrom, SlotTo: Integer; vType: Variant);
Well it's not. Deposit will not deposit single items in inv if deposit is set to deposit all. So you have to put in a fail safe to catch the items it misses. That's what MDeposit started off as, just a fail safe. Now, my method works better without the original Deposit. So I committed it out. Try it for you self, it's fast and reliable. Not only does it deposit to any bank but it deposits to a Bob too.
Another example...
Procedure FindSpinTicketACA;
Yes SRL has one but if you try one of my scripts and turn on debug watch the srl one fail time and time and again. Then my fail safe one pick up the slack.
And another...
function WaitOptionExist(S: TStringArray; Time: Integer; Action: Boolean): Boolean;
is just like SRL WaitOption. Once again if you try mine you will notice how much faster mine is. I created this replacement at the request of a user of my Smelting script. Ask me to speed up withdrawing part of the banking. Found out it was the WaitOption that took so long to complete.
I don't have access to change srl my self and I want my scripts to work, which I think I have proven. Yes I could go in and fix or edit the source to suit my needs. But then, so would every user of one of my scripts would have to as well.
After hours of testing this and that with this and that, this is what I have come up with, that works best for me. If you don't like it, then sry, don't use it or my script. No skin off my back.
prabhsun
05-19-2013, 09:35 PM
Not sure if I'm understanding you right, but if I am, your mocking me for making an include with functions that mimic what some srl functions do. Well I just recently found out about a good human srl mouse function. Can't remember the name, but I know I could find it again. Anyways, that is on my agenda list. About the rest, trust me my functions were only made because the srl ones either failed, didn't exist to my knowledge, or didn't function the way I needed them to.
Take for example. The MDeposit function...
function MDeposit(InvStart, InvEnd: integer): Boolean;
Just like SRL procedure Deposit(SlotFrom, SlotTo: Integer; vType: Variant);
Well it's not. Deposit will not deposit single items in inv if deposit is set to deposit all. So you have to put in a fail safe to catch the items it misses. That's what MDeposit started off as, just a fail safe. Now, my method works better without the original Deposit. So I committed it out. Try it for you self, it's fast and reliable. Not only does it deposit to any bank but it deposits to a Bob too.
Another example...
Procedure FindSpinTicketACA;
Yes SRL has one but if you try one of my scripts and turn on debug watch the srl one fail time and time and again. Then my fail safe one pick up the slack.
And another...
function WaitOptionExist(S: TStringArray; Time: Integer; Action: Boolean): Boolean;
is just like SRL WaitOption. Once again if you try mine you will notice how much faster mine is. I created this replacement at the request of a user of my Smelting script. Ask me to speed up withdrawing part of the banking. Found out it was the WaitOption that took so long to complete.
I don't have access to change srl my self and I want my scripts to work, which I think I have proven. Yes I could go in and fix or edit the source to suit my needs. But then, so would every user of one of my scripts would have to as well.
After hours of testing this and that with this and that, this is what I have come up with, that works best for me. If you don't like it, then sry, don't use it or my script. No skin off my back.
You tell em mate!. Anyways, how's it coming along, i had tried to convert overload 3's into flasks but it shows as a greyed out area, have u managed to work on that or is that still a work in progress.
bud_wis_er_420
05-20-2013, 04:05 AM
You tell em mate!. Anyways, how's it coming along, i had tried to convert overload 3's into flasks but it shows as a greyed out area, have u managed to work on that or is that still a work in progress.
Flasks and 4 dose both should be working. What do you mean by greyed out area? Oh wait, you mean the easy setup, right? Yea, it is a task in it's own and automatically selects it's own task within the code. In other words it's supposed to be greyed out. Just like when you click on herbs it greys out the potion tasks. The easy setup might be a little buggy though. That is one of the main reasons I'm rebuilding the script. This script is like one of those houses that ppl kept adding additions onto. After awhile the thing becomes a maze. I really don't want to mess with the GUI right now only to have to change it again for the new script. For now use the other setup if the GUI don't work. I tested that one and it worked for me when I updated last. Just in case I posted the setting you would use below. Let me know if you have any problems.
My reconstruction of this script is gonna take awhile, so if anything is broken I will update the current script. So yes please further explain your problem and give me a full bug report. I will fix it real soon. I'm off tomorrow and I plan on scripting most of the day. Be looking for the first release to my CW script, tomorrow. First ver will only support AFKing, but I have plans on adding much, much more.
{*} EasySetupGUI = 'Off'; // On/Off Easy Setup, you must fill in {*}
{*} ManuaBanklMode = 'Off'; //Look at setup inst. below {*}Unless you want to use manual bank mode
{*} AddTaskCount := 1; //how many different tasks you are setting up {*}
{*} Make[0] := SetVars('Overloads', 1000, 6); {*}
BTW, is the manual set up easier to understand now?
prabhsun
05-20-2013, 02:24 PM
Flasks and 4 dose both should be working. What do you mean by greyed out area? Oh wait, you mean the easy setup, right? Yea, it is a task in it's own and automatically selects it's own task within the code. In other words it's supposed to be greyed out. Just like when you click on herbs it greys out the potion tasks. The easy setup might be a little buggy though. That is one of the main reasons I'm rebuilding the script. This script is like one of those houses that ppl kept adding additions onto. After awhile the thing becomes a maze. I really don't want to mess with the GUI right now only to have to change it again for the new script. For now use the other setup if the GUI don't work. I tested that one and it worked for me when I updated last. Just in case I posted the setting you would use below. Let me know if you have any problems.
My reconstruction of this script is gonna take awhile, so if anything is broken I will update the current script. So yes please further explain your problem and give me a full bug report. I will fix it real soon. I'm off tomorrow and I plan on scripting most of the day. Be looking for the first release to my CW script, tomorrow. First ver will only support AFKing, but I have plans on adding much, much more.
{*} EasySetupGUI = 'Off'; // On/Off Easy Setup, you must fill in {*}
{*} ManuaBanklMode = 'Off'; //Look at setup inst. below {*}Unless you want to use manual bank mode
{*} AddTaskCount := 1; //how many different tasks you are setting up {*}
{*} Make[0] := SetVars('Overloads', 1000, 6); {*}
BTW, is the manual set up easier to understand now?
Well what i had tried to do was, i clicked on overloads, and the radio buttons were unusable in order to select a task and stuff, let me show you image.2131221313
Ah that setup seems better than the easier one. Oh great, a CW script would be truly amazing! Let me know when you release!
bud_wis_er_420
05-21-2013, 12:11 PM
Well what i had tried to do was, i clicked on overloads, and the radio buttons were unusable in order to select a task and stuff, let me show you image.2131221313
Ah that setup seems better than the easier one. Oh great, a CW script would be truly amazing! Let me know when you release!
The radio buttons are suppose to be unusable when selecting Overloads. Try it. It should work.
Almost done with the CW script all that is left to do is a small amount of debugging and adding all the support fail safes. You know, things like, the login check, player switching, progress report, etc.
iamorange12
05-22-2013, 10:21 PM
The radio buttons are suppose to be unusable when selecting Overloads. Try it. It should work.
Almost done with the CW script all that is left to do is a small amount of debugging and adding all the support fail safes. You know, things like, the login check, player switching, progress report, etc.
bud_wis_er_420
On version 1.2 of your include you forgot the change the version constant to 1.2 :spongebob:
bud_wis_er_420
05-23-2013, 01:05 AM
bud_wis_er_420
On version 1.2 of your include you forgot the change the version constant to 1.2 :spongebob:
I'm on ver 1.3 now. It should auto update if you have ver 1.2. If not get latest ver from my Castle war script page.
iamorange12
05-23-2013, 03:56 AM
I'm on ver 1.3 now. It should auto update if you have ver 1.2. If not get latest ver from my Castle war script page.
You must've updated it recently. Because it showed 1.2 on your version check page when I posted that.
hackingislol133
06-01-2013, 12:17 AM
Not sure if I'm understanding you right, but if I am, your mocking me for making an include with functions that mimic what some srl functions do.
don't read too deep into it, i understand that semantically my post was worded strangely.
I did the same thing you did when I put together a army rune runner half a year back. i ran into a problem with the cooking guild door and caused a down time.
jch1993
06-26-2013, 05:28 AM
what pots will this make into flasks?
Powered by vBulletin® Version 4.2.1 Copyright © 2024 vBulletin Solutions, Inc. All rights reserved.