Log in

View Full Version : Jeffrey's Herblore script



Pages : 1 [2]

vladko78
08-14-2012, 11:07 AM
script is amazing working fast and flawless but i dont understand why it cant stop working if you are out of herbs, it keeps clicking on any two items for 1-2 hours

Spenser171
08-14-2012, 10:38 PM
When I attempt to run this, it brings the rs client up, but then immediately says the following:

SRL Compiled in 0 msec
Loading SMART: http://world8.runescape.com/f631831233234651749
Error: Out Of Range at line 23
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap]

What am I doing wrong?

Wardancer
08-19-2012, 04:15 AM
It shouldn't.... I just read through smart 8.0 and it says there will be no need for rewriting scripts so.... its not the script its the user i think in this case ;) Just revert your simba back to use v7.2 until there is a clean update ready for everyone :p

Edit:
//****************************
Thank You for using Jeffrey's Herblore script!
You have made: 3836 potions!
This has been running for 1 Hours, 22 Minutes and 15 Seconds
//****************************

^v1.6 working out a "noob" friendly version.... but I have taken some more of my time to work on this script ;) ya thats 2.8k unf pots an hour :p


Enjoy
~Getdropped :cool:

About SMART 8.0, the script is working perfectly fine with it.

Thank you very much for this great script, Jeffrey.

I have a suggestion though. It would be nice to add a fail safe. Having the possibility to make the script stop by itself when you run out of ingredients. It doesn't look very human like to be trying to mix bronze hatchets with iron darts for hours. If we can turn it on and off, I'm sure everyone would be pleased. It's a fairly simple thing to add to the script too (about 4 lines).

EDIT: Nevermind my suggestion. I just realized the script terminates if it can't find the Make All box. Very nice solution... much better than if the inventory isn't full as it let you do multiple orders if you want. Great job.

Getdropped
08-21-2012, 08:05 PM
About SMART 8.0, the script is working perfectly fine with it.

Thank you very much for this great script, Jeffrey.

I have a suggestion though. It would be nice to add a fail safe. Having the possibility to make the script stop by itself when you run out of ingredients. It doesn't look very human like to be trying to mix bronze hatchets with iron darts for hours. If we can turn it on and off, I'm sure everyone would be pleased. It's a fairly simple thing to add to the script too (about 4 lines).

EDIT: Nevermind my suggestion. I just realized the script terminates if it can't find the Make All box. Very nice solution... much better than if the inventory isn't full as it let you do multiple orders if you want. Great job.

That was my noob friendly update ;) but honestly you should ever "run out" because you should put in the amount of loads you want it to complete..... but I did add it as a fail safe :p glade to hear you like it.

~getdropped

Valeyard
09-01-2012, 12:36 AM
Changed lines 105 and 108 respectively to,

InvMouse(RandomRange(0, 14), 3);
InvMouse(RandomRange(15, 27), 3);

I am not actually sure if this is more human like, it might be better to reduce the range to just the items on the middle 3 rows.

Thanks for making a great script .

EDIT: Also I was trying to make the WaitTimer to be randomised but I am not sure how to do it. I added it to the global viariable list and tried to have it get set at teh start of the Mix procedure everytime but it didn't work. I was using RandomRange(150,180) and it kept throwing up errrors in the randomtool.simba file, any ideas?

EDIT2: It also seems to sometimes try and..right click the bank? Then it ends up trading someone and it gets pretty suspicious.

EDIT3: Trying to use this at Yanille bank and it freaked out and starting running behind the bank.

EDIT4: I am using just the standard 1.6, it just failed at depositing there and tried to mix herbs and finished potions, not sure why

EDIT5: When it tries to bank, it sometimes mouses over each of the 3 bankers here in turn, over and over again (while the "Banker" uptext is there) before deciding to pick a banker

Getdropped
09-01-2012, 07:23 AM
Changed lines 105 and 108 respectively to,

InvMouse(RandomRange(0, 14), 3);
InvMouse(RandomRange(15, 27), 3);

I am not actually sure if this is more human like, it might be better to reduce the range to just the items on the middle 3 rows.

Thanks for making a great script .

EDIT: Also I was trying to make the WaitTimer to be randomised but I am not sure how to do it. I added it to the global viariable list and tried to have it get set at teh start of the Mix procedure everytime but it didn't work. I was using RandomRange(150,180) and it kept throwing up errrors in the randomtool.simba file, any ideas?

EDIT2: It also seems to sometimes try and..right click the bank? Then it ends up trading someone and it gets pretty suspicious.

EDIT3: Trying to use this at Yanille bank and it freaked out and starting running behind the bank.

EDIT4: I am using just the standard 1.6, it just failed at depositing there and tried to mix herbs and finished potions, not sure why

EDIT5: When it tries to bank, it sometimes mouses over each of the 3 bankers here in turn, over and over again (while the "Banker" uptext is there) before deciding to pick a banker

right clicking someone has never happened to me..... im not really sure why it is happening to you.... the suggested areas are sw bank and varrock west bank. and as for it trying to mix finished pots with herbs read the setup and make sure you first to spots in you bank slot are the herbs and unf pot or are herbs and vials of water..... and as for the random slot items... i always pick the two together when i was doing it legit =/ you could do that if you want up to you. The mostlikely reason it wont find the banker is because the background behind the uptext makes it hard to read that is why you should try using sw bank or varrock west. Please feel free to post any other problems and concerns you have thank you ;)
~Getdropped :cool:

Valeyard
09-01-2012, 08:06 AM
Hey,

First of all I just want you to know those weren't meant to be complaints- I was just documenting my experiences for later use.

I was/still am very tired while posting all that. I believe most of the problems came from the RS zoom setting being SLIGHTLY off. Haven't been back to SW yet but it has been running mostly fine at another bank for a while now.

Will report back, hopefully with a proggy, in the next couple of days.

Thanks again :)

Getdropped
09-01-2012, 08:02 PM
Hey,

First of all I just want you to know those weren't meant to be complaints- I was just documenting my experiences for later use.

I was/still am very tired while posting all that. I believe most of the problems came from the RS zoom setting being SLIGHTLY off. Haven't been back to SW yet but it has been running mostly fine at another bank for a while now.

Will report back, hopefully with a proggy, in the next couple of days.

Thanks again :)

Great to hear hopefully it is working well for you now. Sorry to be so aggressive with the comment I just tried tomake the last version as noob friendly as possible and i was stunned by the issues :p ah well hope please feel free to post any other issues though it will help me to make it even more noob friendly in the future ;)

Valeyard
09-01-2012, 11:17 PM
Quick question,

Would it be possible to change the WaitTimer constant to a variable that is assigned every time the Mix procedure is ran?

So instead of being, for example, 130 every time it could be like RandomRange(130, 150) and do you think this would actually make this any less detectable?

Getdropped
09-02-2012, 03:49 PM
Quick question,

Would it be possible to change the WaitTimer constant to a variable that is assigned every time the Mix procedure is ran?

So instead of being, for example, 130 every time it could be like RandomRange(130, 150) and do you think this would actually make this any less detectable?

yes change line 140:
until(x > WaitTimer);
to:

until(x > RandomRange(130, 150));

chongc
09-05-2012, 11:13 AM
just wondering if this would be possible to do for making overloads, saw it on a video a while back...


put torstols in familiar, withdraw 5 of each extreme+3 torstols, mix, click take BoB,
make 5 ovls/invent.

Profit!

Getdropped
09-06-2012, 04:25 AM
just wondering if this would be possible to do for making overloads, saw it on a video a while back...


put torstols in familiar, withdraw 5 of each extreme+3 torstols, mix, click take BoB,
make 5 ovls/invent.

Profit!

not with this script but it would be pretty easy for you to add if you wanted

l6bustank
09-06-2012, 09:45 AM
pasted from debug:
Warning! You passed a wrong ye to a finder function: 130. The client has a height of 129, thus the ye is out of bounds. Setting the value to 128 (h-1) for now.

What does that mean?

E: oo.., new version out. Its just the added failsafe and a fixed timer that changed? or did I miss sth?

Getdropped
09-07-2012, 04:04 AM
pasted from debug:
Warning! You passed a wrong ye to a finder function: 130. The client has a height of 129, thus the ye is out of bounds. Setting the value to 128 (h-1) for now.

What does that mean?

E: oo.., new version out. Its just the added failsafe and a fixed timer that changed? or did I miss sth?

The new version has been out for a while..... you probably changed the old script that is why you got the errors you did..... is it working for you? the new version has all the anti-noob stuff in it but it was out when you had all your.... complaints/problems :p

Tilen755
09-08-2012, 08:44 PM
could you make it failsafed? i mean sometimes it doesnt winthdraw vials or herbs and then it stops and loggs out

print
09-09-2012, 02:23 AM
does this script make serums 207??

l6bustank
09-09-2012, 06:38 AM
The new version has been out for a while..... you probably changed the old script that is why you got the errors you did..... is it working for you? the new version has all the anti-noob stuff in it but it was out when you had all your.... complaints/problems :p
I changed 2 things:
1. Trimmed the wait timers in bank function and mix procedure
2. Deleted the report procedure, since it was useless to me and saved me 1% of CPU.

How this caused the problem? No idea atm. But then again, im not much of a scripter too :D .

satkan
09-11-2012, 08:19 PM
So,... does this also support Barbarian mixes?

wolfex16
09-12-2012, 12:38 AM
i get this SRL Compiled in 16 msec
** Fatal Error: Pairing Clients; Terminating Script **
Successfully executed.

satkan
09-12-2012, 08:36 AM
i get this SRL Compiled in 16 msec
** Fatal Error: Pairing Clients; Terminating Script **
Successfully executed.

Just redo the compiling.

It sometimes does that, and if you keep trying it will work.

If it doesn't work after 2-3 tries, restart Simba.

If then it doesn't work, just remove the smart and Simba processes altogether in the task manager.
(I normally also delete the temp smart file.)

After that it should again, work!

l6bustank
09-17-2012, 05:30 PM
Found a slight and rare flaw:
when making potions, my user RARELY (but still) receives a SOF ticket to the 15th inv slot (row 4, column 3). Instead of claiming, the script continues and tries to use slot 14 with 15 and fails infinitely.

John
09-18-2012, 07:30 AM
Tyvm, I did edit it for my liking ;) but Ty :)
http://puu.sh/16g2f

Getdropped
09-19-2012, 01:01 AM
Tyvm, I did edit it for my liking ;) but Ty :)
http://puu.sh/16g2f

gratz haven't had much time to update this because of school im happy to see people still doing well with it ;) gratz on 96 herby :p

lolskilla
09-21-2012, 01:35 PM
great script but i cant seem to make it work for more than 10 minutes; it always ends saying it couldnt find the make function

Getdropped
09-22-2012, 06:43 AM
great script but i cant seem to make it work for more than 10 minutes; it always ends saying it couldnt find the make function

Change line 116:
if (FailSafe > 50) then

to:
if (FailSafe > 100) then

Please tell me if you still have the problem thanks ;)

lolskilla
09-23-2012, 06:52 PM
still fails within 5 minutes :( i upped the time to bank and the value above that you stated

EDIT: restarted simba, cleared up some cpu, and it seems to be working much better thanks!

Getdropped
10-02-2012, 02:03 AM
still fails within 5 minutes :( i upped the time to bank and the value above that you stated

EDIT: restarted simba, cleared up some cpu, and it seems to be working much better thanks!

It's all just timing for errors people are getting, I guess that's good XD I haven't used this in a while hope you are all still getting good pots/hr :)

John404
10-07-2012, 02:36 AM
//****************************
Thank You for using Jeffrey's Herblore script!
You have made: 4046 potions!
This has been running for 2 Hours, 18 Minutes and 2 Seconds
You have managed to gain 725940 exp!
You are gaining -203040 exp per hour!
//****************************
the xp/hr bugged but im doing sara brews so around 300-400k xp/hr thanks for the script

edit:

//****************************
Thank You for using Jeffrey's Herblore script!
You have made: 6342 potions!
This has been running for 3 Hours, 36 Minutes and 19 Seconds
You have managed to gain 1138140 exp!
You are gaining -15229 exp per hour!
//****************************

westkevin12
11-15-2012, 12:49 AM
[Error] C:\Simba\Includes\SRL/SRL/core/globals.simba(606:5): Unknown identifier 'ImageSetClientArea' at line 605
Compiling failed.

How do i fix this?

Mr[S]
11-16-2012, 06:38 PM
Does this have six hour fix in it? I'm on phone atm so didn't check when setting script up

vladko78
11-20-2012, 12:07 PM
needs to be updated after eoc update

euphemism
12-08-2012, 03:25 AM
Moved to outdated.