Issue: grandExchange

  1. issueid=458 10-04-2015 10:30 AM
    SRL Member
    grandExchange

    I believe some of the Grand Exchange functions are not positioned right. I think the following things have a minor offset:
    • "Confirm Offer" box;
    • "The buy button grid;
    • The sell button grid;


    The Quantity buttons and the price buttons are working correctly.
Issue Details
Issue Number 458
Project SRL Bugs and Suggestions
Status Unconfirmed
Users able to reproduce bug 0
Users unable to reproduce bug 1
Assigned Users (none)
Tags (none)




  1. 11-13-2015 02:30 PM
    SRL Member
    Had some time to find out what the bug was. The offset in the confirm box in the 'buyItem' and 'sellItem' functions are wrong. It now is:
    Simba Code:
    confirm: TBox := [self.x1 + 212, self.y1 + 504, self.x1 + 350, self.y1 + 525];
    and it should be:
    Simba Code:
    confirm: TBox := [self.x1 + 225, self.y1 + 518, self.x1 + 373, self.y1 + 543];

    I believe I've found another bug. In the buyitem and sellitem functions the check for the next slot is:
    Simba Code:
    for i := 1 to 6 do
        if self.__isSlotEmpty(i) and self.__isSlotActive(i) then
        begin
          nextSlot := i;
          break();
        end;

    It shouldn't be 6, because there now are 8 tabs.

    EDIT:

    I believe I've found another bug. When selling an item for mid price or selling all, those buttons are pressed (which shouldn't be, because it's set default). The bug occurs in the '__enterPrice' and '__enterQuantity' functions. My solution was to exit:
    Simba Code:
    if (i <> 3) and (i <> 1) then
        mouseBox(priceBox[i], MOUSE_LEFT)
      else if i = 1 then
        exit()
      else
  2. 11-18-2015 01:30 PM
    SRL Member
    A few other bugs. The offset in "TRSGrandExchange.__getSlotBoxes()" is wrong.

    Now it's [104, 213] but it should be [121, 226].

    The function "getPercentDone" has the wrong colors:

    Now it's "BG_COLORS = [2565929, 2237482];" but it should be "BG_COLORS = [2565929, 2039584, 2237482, 1776673];"
  3. 04-01-2016 01:25 PM
    SRL Member
    Isnt this an include?
+ Reply