Grats on release :) Gonna skim through your code.
Edit: first few things I notice:
Put DeclarePlayers procedure in the beginning of the script, way more userfriendly. ( people might miss it )
U forgot to call Players[0].Nick =''; for the antirandoms;
U called DeclarePlayers
AFTER Setupsrl; , with the new method it should be
BEFORE
Easier to free multiple DTMS is by using Freedtms (just personal preference to reduce scriptlines)
At line 93-95
Simba Code:
if (IsUpTextMultiCustom(['bank booth'])) then // try using 3-4 letters not full words eg: ['ban', 'nk b', 'boo']
clickMouse2(MOUSE_left); // don't know why u doubleclick
clickMouse2(MOUSE_left); // this click is seperate from your if statement (see below)
Usage of if..then statements for more than 1 follow-up
Simba Code:
if BankScreen then // this if then statement will only affect Deposit(2,28,true);
Deposit(2,28,true);
wait(300) //Wait(300) and Closebank; are not part of the if statement.
CloseBank; //so if the bankscreen is false, the script will still play these 2 lines
{**using if..then for MULTI follow-ups needs a begin..end; **}
if BankScreen then
begin //notice the begin and end?
Deposit(2,28,true);
wait(300) // now Wait(300) and Closebank; are within the if statement!
CloseBank;
end;
It's great that your loops are
not infinite (cause u use Inc(attempt)) , that's a pluspoint!
U can also use: MarkTime(Time); repeat until(TimeFromMark(Time) > 10000); // This will timeout after 10 seconds and leave the loop.
Just a matter of preference.
Can't find anything worth mentioning, the rest seems ok!
U could work on your standards though :) if you're lazy then Enable the formatter.sex extension and then just format script.
Next stop is usage of TPA's and ATPA's, try and look thru other people's code to learn. It helps
A LOT. U will pick a lot of things (usage of the include, or the way they approach to script)