[SMART] Bob_Dole's AutoSeller (trades)

This is my first script; short, simple, but does the trick. This script sells items to other players. To prevent scams, it waits for the other player to accept before checking the amount of the item in trade vs. the amount of cash the other player is offering.

Directions
1. Fill out the variables. Nickname, item, price, and amount to stop at.
2. Position your character at the designated area.
3. Place the items in inventory spot #1 .
4. Start the script and wait for players to trade you.

Features

1. Waits for the other player to accept before double checking the amount of item and cash in trade.
2. Times out after 30 seconds if the buyer fails to add cash or accept the trade.
3. Adds failed trades and traders to a list to prevent multiple failed trades.
4. Adds successful trades and traders to a list to prevent sending trades after a successful sale.
5. Paint!

CAUTION Watch over this script as it is possible (but difficult) for players to lure you into a dangerous zone via a series of sent trades.

Please post any questions, comments, concerns regarding this script. This is my first script but it has been tested thoroughly and has many fail-safes added to hopefully prevent any issues.



If you really like the script, a donation of any amount is always appreciated. I have a scripting background starting from age 11 and have already coded several runescape scripts. With your donation you can submit a script suggestion in the notes. I will be on a lot during the summer and should have time to create many more scripts to come. Thanks!

https://www.paypalobjects.com/en_US/...onateCC_LG.gif

Bob_Dole's Autotrader v1.0

Tested it out, everything seems to work well. But it won't put my item into the trade , atleast not within a decent time. I'm not sure if it ever does but everyone has declined the trade while the bot has this being replayed.
Trade open, waiting for cash...
Trade open, waiting for cash...
Adding items to trade...
When I disable smart and do it myself the amount of item to trade is open but no number is there.

Seems like a great script! Nice release :)

Does it writeLn the amount that it was supposed to trade correctly? Is your brightness on high, etc? I don't see why it wouldn't work for you.

Perhaps the traders have not offered the proper amount for the price of the item?

Quote:

---

Originally Posted by Sjoe

Seems like a great script! Nice release :)

---

Thanks, many more scripts to come.

it gives me some error about 07bigchars missing..

i should have everything installed correct :( i wanna use this looks like a nice script

can u help me out :)?

Quote:

---

Originally Posted by sammys

it gives me some error about 07bigchars missing..

i should have everything installed correct :( i wanna use this looks like a nice script

can u help me out :)?

---

Looks like you didnt install the 07 fonts correctly. Simply delete line 101 of the script or install 07 fonts from this link:

http://villavu.com/forum/showthread....52#post1192252

now i get this after the first time it types what im selling, it executes

ccessfully executed.
The following DTMs were not freed: [2, 3, 4, 5]


edit: after installing fonts i now get this

[Hint] C:\Documents and Settings\sleiman\Skrivebord\scripts\AutoSeller v1.02.simba(41:3): Variable 'I' never used at line 40
[Hint] C:\Documents and Settings\sleiman\Skrivebord\scripts\AutoSeller v1.02.simba(22:1): Variable 'MESSAGE' never used at line 21
[Hint] C:\Documents and Settings\sleiman\Skrivebord\scripts\AutoSeller v1.02.simba(421:1): Variable 'X' never used at line 420
[Hint] C:\Documents and Settings\sleiman\Skrivebord\scripts\AutoSeller v1.02.simba(421:1): Variable 'Y' never used at line 420
[Hint] C:\Documents and Settings\sleiman\Skrivebord\scripts\AutoSeller v1.02.simba(421:1): Variable 'COINDTM' never used at line 420
Compiled successfully in 1266 ms.
SRL Compiled in 0 msec
Paired with SMART[5192]
Successfully executed.
The following DTMs were not freed: [2, 3, 4, 5]


edit: now just gives me the dtms were not fred :(



edit: got it to work by putting amount to stop at to 0 weird :0

anyways works nicely and its fast :)


another thing i wanted to sell bronze arrows for 20gp each and a guy offered me 200k and it traded him only 1k bronze arrows

Probably because the amount to stop at was higher than the amount you had. Would cause it to stop after the first round.

The amount issue I have had with the 10000's being read as 1000's and I added my own quick fix, but if it is doing the same thing with hundred thousands there really isn't much I can do since the images are the same. Looks like it is a bug for SRL-OSR that needs to be fixed.

Edit Now that I think about it, a possible fix would be examining any amount over 99,999 and getting the amount that way but I am going to wait and see if the issue is common before going through with that.

it is doing it with lobtsers too i try to sell lobsters 200 each and he offered 800k and my sxcript only offered him lik 400 lobbys

Quote:

---

Originally Posted by sammys

it is doing it with lobtsers too i try to sell lobsters 200 each and he offered 800k and my sxcript only offered him lik 400 lobbys

---

sounds like u typed 2000ea tbh

nope i didnt. does it work for you ?

I use this to sell over 10m in items per day I never have those amount issues. Was selling chocolate bars earlier, guy put up 500k it put up 2k bars just like it should

weird maybe i should try to reinstall the script, yeah i think its weird too cuz when i tried it first time and it worked it actually did it right, but suddenly it didnt calc hmm.

can anyone help me to setup simba, and setup this script ?

Ill pay you in rs07, thanks for the help

Skype:ModJobs

could u help me? Thanks

Slightly disappointing to put so much work into making this script to make it perfect & then be unable to fill a whole page of replies.

Over 70 downloads and about three people repled to it, it wouldn't hurt to contribute to the community a bit with opinions, suggestions, or even just comments.

My next public release will likely be a woodcutter. Not one that you babysit but one that you can have a decent chance of running ovenight. It has got over 1.8k lines of code or 48Kb. A big step down from the abyss crafter I had in mind but I guess I will save it for membs or at least junior membs

Bob how is it going with our wc'er:P?

seems like a nice script, going to test it out with selling pray pots and sharks will leave on overnight and let you know how it goes in the morning.

SCRipt doesnt work for me, something to do with the text file.

Works :)

Quote:

---

Originally Posted by bigblacknerd

SCRipt doesnt work for me, something to do with the text file.

---

if you need help I need you to copy/paste the actual error.

The magic tree chopper is finished and being tested at the moment. The area that I am botting them at is one of the, if not the, only magic tree area besides lleyta that is not infested with bots. I am getting good cash/hr with it and I am not sure if I want the area crowed with bots that are using my script.

bob dole, can you please make an auto buyer please? I don't wanna have to buy items myself :S

Haven't used this script but I was just thinking how useful this script would be! Great job dude. (Nice touch with the blacklist of bad traders)(does it give 2nd chances to failed trades?)

Quote:

---

Originally Posted by cause

Haven't used this script but I was just thinking how useful this script would be! Great job dude. (Nice touch with the blacklist of bad traders)(does it give 2nd chances to failed trades?)

---

Yes, the script actually gives three chances before it begins to filter out and ignore that particular user. If the script detects that a successful trade has been made with a player, that player is then added to the blacklist with all three strikes. This was to prevent 'accepting' the trade with that same player after a successful trade. This would only have been an issue in low-populated areas, as in say w301 the purple trade request texts disappear quickly.

is a good script but i have a small problem with it

Haven't used yet but seen multiple people using scripts like this merchanting and it's really fucking pissing me off. So thanks for creating this now I can use it and sell my items for the price I want while I sleep :) Thanks abunch could you please make a buying script to? When I try your script out and it makes me some money I'll definitely donate to you :D

Apologies if this counts as grave digging, but been using the script for a few hours now and cant find any fault. Great script and love the paint :)

Quick question though, i noticed you commented out the FindNormalRandoms, so i put it back in and now it runs away whenever a HP bar appears on screen (other players)? Is there any way around this?

Quote:

---

Originally Posted by GREEN GIANT

Apologies if this counts as grave digging, but been using the script for a few hours now and cant find any fault. Great script and love the paint :)

Quick question though, i noticed you commented out the FindNormalRandoms, so i put it back in and now it runs away whenever a HP bar appears on screen (other players)? Is there any way around this?

---

I am sure I could make a custom function to check HP level before running away but I would recommended to use the findtalkingrandoms function for now.

Quote:

---

Originally Posted by bob_dole

I am sure I could make a custom function to check HP level before running away but I would recommended to use the findtalkingrandoms function for now.

---

Hey, there seems to be a problem with random detection recently, when running this script (and others) there has been problems with NickName detection. Only difference is, when using this script there are so many random events i cannot run it more than 5 mins without something going wrong. Now im not sure if the problems i am having are my own fault or some error with Nick finding but its happening to me on multiple scripts recently.

Ignore this post, i sorted my problem :)

This comes up when i try to run it, help please.
'COINDTM' never used at line 420
Compiled successfully in 1139 ms.
SRL Compiled in 0 msec
Paired with SMART[3516]
You need the item you want to sell in inventory slot #1 .
Successfully executed.
The following DTMs were not freed: [2, 3, 4, 5]

I am getting the following error when running this script:

Quote:

---

The following DTMs were not freed: [2, 3, 4, 5]

---

So I read up on freeing DTMs and added this procedure:

Quote:

---

Procedure FreetheDTMs;
Begin
FreeDTM(CoinDTMs[0]);
FreeDTM(CoinDTMs[1]);
FreeDTM(CoinDTMs[2]);
FreeDTM(CoinDTMs[3]);
end;

---

Here is the mainloop:

Quote:

---

begin

Smart_World := 1;
SetupSRL;
DeclarePlayers;
CheckStuff;
TradeOn;

repeat

if not (LoggedIn) then
begin
LoginPlayer;
CheckStuff;
TradeOn;
end;

Report;

Left := GetAmountBox(InvBox(1));

sendkeys(MSG, 15, 15);
TypeByte(VK_RETURN);
Trade;
wait2(1500 + (chat_speed * 500));

//FindNormalRandoms;

until (GetAmountBox(InvBox(1)) < minimum);

AddonTerminate('FreetheDTMS');

end.

---

I'm trying to figure out what is causing this error, any help is appreciated!

P.S. I'm using the original script that's on the first page created my the coder and following his directions

As stated it only works with certain ammounts of cash, I've added a fix so 38k and 76k offers work for 1k - 2k arrows but if someone puts up 50k or 80k it messes up and trades like 30k arrows. Same with 100k+ offers, I can manage to fix certain offers but some offers resulting in 5371,5354 steel arrows messes up also. Can't really use it right now...

Quote:

---

Originally Posted by Nilsie

As stated it only works with certain ammounts of cash, I've added a fix so 38k and 76k offers work for 1k - 2k arrows but if someone puts up 50k or 80k it messes up and trades like 30k arrows. Same with 100k+ offers, I can manage to fix certain offers but some offers resulting in 5371,5354 steel arrows messes up also. Can't really use it right now...

---

It was also stated that the user who had this issue likely put in the wrong price. I've tested this with amounts from 10k to 1m just now and they all work fine.

The only known issue with larger amounts is if someone say offers 100,999 it will return 100k. Same with 10.9m it will return 10m. That's the only known issue and in reality when you are selling lower priced items it is in your favor. Not many people offer amounts that would cause this to be an issue but it does happen.

Edit:

If you managed to create a fix for your issue why not share it here? What better way to diagnose a problem than to look over the fix? Even if it is just a line or two, posting it here would be the best way for me to diagnose and subsequently code an official fix. On top of that, it will also help any others who may possibly have the same issue. I'd imagine any users with the same issue wouldn't be able to click the reply button fast enough which leads me to believe it could very well just be you or only affect those running on a very specific, rare run-time environment.

For now I can only suggest you double-check your 07 fonts files, SRL includes, SMART, and even Simba itself to ensure they are all current. Probably not the problem but it doesn't hurt to make sure. Who knows, we might get lucky though. ;)

A response would be much appreciated, even if it happens to be a short/lazy one.

Everything seems to be working fine, the person puts up the amount for the item, then it goes to enter the amount of items, but then it just sits, doesn't put the item in trade.

edit: looks like its just typing 0 as the "X" amount and entering then it just sits.

- I seem to be getting this sorts of an error on bootup, it loads up smart, i log in, then it sets chat on "trade" and then crashes with error:

Quote:

---

The following DTMs were not freed: [2, 3, 4, 5]
[Hint] C:\Simba\Scripts\AutoSeller v1.0.simba(41:3): Variable 'I' never used at line 40
[Hint] C:\Simba\Scripts\AutoSeller v1.0.simba(22:1): Variable 'MESSAGE' never used at line 21
[Hint] C:\Simba\Scripts\AutoSeller v1.0.simba(421:1): Variable 'X' never used at line 420
[Hint] C:\Simba\Scripts\AutoSeller v1.0.simba(421:1): Variable 'Y' never used at line 420
[Hint] C:\Simba\Scripts\AutoSeller v1.0.simba(421:1): Variable 'COINDTM' never used at line 420
Compiled successfully in 593 ms.
SRL Compiled in 0 msec
Paired with SMART[12852]
Error: Exception: Font [BigChars07] not found. at line 662
The following DTMs were not freed: [SRL - Lamp bitmap, SRL - Book of Knowledge, 2, 3, 4, 5]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Minimap Mask bitmap, 3]

---

Any ideas?

I tried:
downloading new osrs-srl and replacing it with mine,
downloading smart 8.3 and replacing it with my 8.2

neither of them worked, so i reinstalled everything with slushpuppys installer found here
http://villavu.com/forum/showthread.php?t=100478
and it returns to the same error.

- for some reason i couldnt get newest os-srl and smart 8.3 working together, i think it is because smart 8.3 takes one extra parameter now.

// Edit: Got it working after reinstalling 07Fonts :)

Quote:

---

Originally Posted by prostaker

- I seem to be getting this sorts of an error on bootup, it loads up smart, i log in, then it sets chat on "trade" and then crashes with error:



Any ideas?

I tried:
downloading new osrs-srl and replacing it with mine,
downloading smart 8.3 and replacing it with my 8.2

neither of them worked, so i reinstalled everything with slushpuppys installer found here
http://villavu.com/forum/showthread.php?t=100478
and it returns to the same error.

- for some reason i couldnt get newest os-srl and smart 8.3 working together, i think it is because smart 8.3 takes one extra parameter now.

// Edit: Got it working after reinstalling 07Fonts :)

---

Where can i download the 07fonts? cheers

You can find the 07fonts here - http://villavu.com/forum/showthread....52#post1192252
He mentioned this somewhere on the first page of this thread.

Planning on trying this out soon. Did you guys merch with it yet? How much did you make? :p

This script works - used it to sell 100k~ shark earlier.. I however did notice some issues with it.. It'll occasionally not wait until the offer "x" entry comes up, thus entering the number into chat and will time out of the trade. I ALSO got scammed for 1k shark by someone, I watched it happen - person put up 700k for 1k shark, no idea how he timed it but he had accepted, removed it and accepted again too quick for the script to pick up.. script accepted trade too quick for me to stop. No big deal though. Otherwise, awesome script. Ty. Also, I've donated to you. THANKS MAN.