[Fighting] [SRL-6] bonsaiFighter

i thought i would take a crack at implementing those features into bl.combat, and i seem to have cleaned it up a bit, however i am getting a compiling error at line 542 in bl.combat

Quote:

Error: Invalid evaluation at line 542
function TcombatMgr.attack var npc: Tnpc; waitTilDead: boolean;

i think i'm just missing some parentheses or something like that, because i haven't changed any code on this line (unless accidentally)

Quote:

Originally Posted by klamor

i thought i would take a crack at implementing those features into bl.combat, and i seem to have cleaned it up a bit, however i am getting a compiling error at line 542 in bl.combat

i think i'm just missing some parentheses or something like that, because i haven't changed any code on this line (unless accidentally)

Yes, that's most likely what happened I suppose. But once again, please note that the suggestions I have posted are only meant for bonsai.

Here should be a working code:
To use this, just replace the original procedure in the blCombat.simba file and change your action bar keys to whatever you want to use (ingame or in the code, so they both match).
This code allows both the use of regenerate and sgs spec. You have to edit one of them out by using //, it currently uses SGS, and regenerate is ruled out. (The same can be achieved by putting the code between the { and } brackets.

Simba Code:

procedure __defaultHealthCheck();
var
  berserkTimer: TTimeMarker;
  assaultTimer: TTimeMarker;
begin
  if (actionbar.getHPPercent() < 40) then
  begin
    sendKeys('m', 250, 40);
    wait(gaussRangeInt(300, 1000));
    exit;
  end;
  if (actionbar.getHPPercent() < 20) then
  begin
    writeln('***** Terminating script due to low health');
    terminateScript();
  end;
  if (combatMgr.healthTimer.getTime() < 3600) then
    exit;
  while (actionbar.getHPPercent() > 70) do
  begin
    if (actionbar.getAdrenalinePercent() = 100) and (berserkTimer.getTime() > 60000) then
    begin
      sendKeys('b', 200, 40);
      berserkTimer.start();
      wait(gaussRangeInt(100, 200));
      combatMgr.healthTimer.start();
      exit;
    end;
    if (actionbar.getAdrenalinePercent() > 50) and (assaultTimer.getTime() > 30000) then
    begin
      sendKeys('a', 200, 40);
      assaultTimer.start();
      wait(gaussRangeInt(100, 200));
      combatMgr.healthTimer.start();
      exit;
    end;
  end;
  while (actionbar.getHPPercent() < 70) do
  begin
    if (actionbar.getAdrenalinePercent() > 50) then
    begin
      sendKeys('s', 140, 40);
      wait(gaussRangeInt(400, 1000));
      combatMgr.healthTimer.start();
      exit;
    end;
//    if (actionbar.getAdrenalinePercent() > 30) then
//    begin
//      sendKeys('r', 200, 50);
//      repeat
//        wait(600);
//      until actionbar.getAdrenalinePercent() < 15;
//      wait(gaussRangeInt(100, 1300));
//      combatMgr.healthTimer.start();
//      exit;
//    end;
  end;
end;

Quote:

Originally Posted by lovebotter

Yes, that's most likely what happened I suppose. But once again, please note that the suggestions I have posted are only meant for bonsai.

Here should be a working code:
To use this, just replace the original procedure in the blCombat.simba file and change your action bar keys to whatever you want to use (ingame or in the code, so they both match).
This code allows both the use of regenerate and sgs spec. You have to edit one of them out by using //, it currently uses SGS, and regenerate is ruled out. (The same can be achieved by putting the code between the { and } brackets.

thanks a bunch, working beautifully now. :D

////////////////////////////////////////////////////////////////////////////////////////////////////
//////////////////////////////////////// Bonsai ////////////////////////////////////////
//////////////////////////////////////// Fighter ////////////////////////////////////////
//////////////////////////////////////// _______ ////////////////////////////////////////
////////// //////////
////////// Script runtime: //////////
////////// 7 hr 6 min 23 sec(Total) 7 hr 6 min 23 sec(Active) 0 sec(Break) //////////
////////// //////////
//////////////////////////////////////// Kills ////////////////////////////////////////
////////// Total Per Hour /Hour Active //////////
////////// waterfiend 3,210 451.71 451.71 //////////
////////// XP 2,854,332 401,656.44 401,656.44 //////////
////////// Const XP 951,444 133,885.48 133,885.48 //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////
Still going

Code:

//////////////////////////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////// Bonsai //////////////////////////////////////// //////////////////////////////////////// Fighter //////////////////////////////////////// //////////////////////////////////////// _______ //////////////////////////////////////// ////////// ////////// ////////// Script runtime: ////////// ////////// 11 hr 26 min 42 sec(Total) 11 hr 12 min 13 sec(Active) 14 min 29 sec(Break)////////// ////////// ////////// //////////////////////////////////////// Kills //////////////////////////////////////// ////////// Total Per Hour /Hour Active ////////// ////////// Goblin 5,790 505.89 516.8 ////////// ////////// XP 163,278 14,266.08 14,573.63 ////////// ////////// Const XP 54,426 4,755.36 4,857.88 ////////// ////////// ////////// ////////////////////////////////////////////////////////////////////////////////////////////////////

Excuse me if this sounds noobish.

/*-------------------------From Bonsai first post----------------------------
program corpseTorso;
{$DEFINE SMART}
{$include_once srl-6/srl.simba}
{$include_once bonsai/blCombat.simba}

var
ccTorso: Tnpc;
i: integer;

begin
SetupSRL();
ccTorso.init('crawling-corpse-torso', true);

for i := 0 to 5 do
begin
combatMgr.attack(ccTorso, true {wait until dead},
nil {use default foodhandler}, MOUSE_RIGHT);
sleep(5000);
end;

-------------------------From Bonsai first post----------------------------*/

Some one correct me if im wrong. This script includes Bonsai Fighter and calls the attack function from Bonsai Fighter. So, I'm guessing that to implement a basic looter, Id have to write a script to search the screen for a specific color, right click it and if "xxstringxx" shows, pick it up.

Quick question:: What is the SRL function to search the screen for a color ?
end.

http://gyazo.com/2178784ecc869e42dc78237c419c5ca1

That is where you can pick a colour. or you can use the programa ACA to detect colours :)

Quote:

Originally Posted by destinyxx

Quick question:: What is the SRL function to search the screen for a color ?
end.

Variations of findcolor. Type findcol into the search box under your function list.

Search the srl-6 library for lots of examples.

bonsai, are you or anyone else having a problem loading your script properly? It will open up a client, and then it will log me in, but then it won't start the script just stands there doing nothing. any reason to that? I'm fully updated and have used this bot all the time.

EDIT: nvm, it fixed itself some how lol

////////////////////////////////////////////////////////////////////////////////////////////////////
//////////////////////////////////////// Bonsai ////////////////////////////////////////
//////////////////////////////////////// Fighter ////////////////////////////////////////
//////////////////////////////////////// _______ ////////////////////////////////////////
////////// //////////
////////// Script runtime: //////////
////////// 5 hr 6 sec(Total) 4 hr 35 min 51 sec(Active) 24 min 14 sec(Break) //////////
////////// //////////
//////////////////////////////////////// Kills ////////////////////////////////////////
////////// Total Per Hour /Hour Active //////////
////////// Corpse Spider 3,149 629.56 684.9 //////////
////////// XP 78,410.1 15,676.15 17,053.99 //////////
////////// Const XP 26,136.7 5,225.38 5,684.66 //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////
used it to level up magic over night, it works fantastic, thank you :)

Just looking at this script is extremely satisfying, good work! 5/5

How might I make this work for kalgerions? :p

How are people lasting so long at Waterfiends? The 2 times I've tried I've died and lasted about an hour before running out of food.

Anyone make this able to pick up charms yet?

Quote:

Originally Posted by PootisMann

Anyone make this able to pick up charms yet?

Get a charming imp, it's only 100k dung tokens. :D

i am having trouble running this! http://gyazo.com/56ec308150a75e2b3423bfb6935e23b8

Works like a charm.

////////////////////////////////////////////////////////////////////////////////////////////////////
//////////////////////////////////////// Bonsai ////////////////////////////////////////
//////////////////////////////////////// Fighter ////////////////////////////////////////
//////////////////////////////////////// _______ ////////////////////////////////////////
////////// //////////
////////// Script runtime: //////////
////////// 9 hr 53 min 49 sec(Total) 7 hr 49 min 4 sec(Active) 2 hr 4 min 45 sec(Break)///////
////////// //////////
//////////////////////////////////////// Kills ////////////////////////////////////////
////////// Total Per Hour /Hour Active //////////
////////// corpse-spider 5,280 533.49 675.37 //////////
////////// XP 5,280 533.49 675.37 //////////
////////// Const XP 1,760 177.83 225.12 //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

Quote:

Originally Posted by madmaxman3

i am having trouble running this! http://gyazo.com/56ec308150a75e2b3423bfb6935e23b8

Sorry, maxmadman, I missed this. I assume you sorted it out?

You have some old SRL code there, choose SRL->update on your simba.

The script works great for me but I have a question about the red dot(mouse). It keeps looking for colors every 3rd monster and will go crazy all over the screen. Is that something to worry about it terms of being detected for botting? Also any way to add potion drinking? I could add it in myself but there is no script unless I have to dig it up from somewhere.

I used this script in its earliest form, great to see how far it has advanced! I'm curious, could I give you my colour files for your google drive?

Quote:

Originally Posted by photomac54

The script works great for me but I have a question about the red dot(mouse). It keeps looking for colors every 3rd monster and will go crazy all over the screen. Is that something to worry about it terms of being detected for botting? Also any way to add potion drinking? I could add it in myself but there is no script unless I have to dig it up from somewhere.

I'm having the same result here - the mouse jumps all over. Seems kind of bannable, unless I've greatly mistaken how the new bot catching system works.

As for adding potions, the script itself is stored in an include folder, typically at "C:\Simba\Includes\bonsai".

Quote:

Originally Posted by adc

I'm having the same result here - the mouse jumps all over. Seems kind of bannable, unless I've greatly mistaken how the new bot catching system works.

As for adding potions, the script itself is stored in an include folder, typically at "C:\Simba\Includes\bonsai".

Thanks for the file location.

Quote:

Originally Posted by BottingFTW

I used this script in its earliest form, great to see how far it has advanced! I'm curious, could I give you my colour files for your google drive?

It would be great to keep them updated, thanks! I sent you a link.

Quote:

Originally Posted by photomac54

The script works great for me but I have a question about the red dot(mouse). It keeps looking for colors every 3rd monster and will go crazy all over the screen. Is that something to worry about it terms of being detected for botting? Also any way to add potion drinking? I could add it in myself but there is no script unless I have to dig it up from somewhere.

Quote:

Originally Posted by adc

I'm having the same result here - the mouse jumps all over. Seems kind of bannable, unless I've greatly mistaken how the new bot catching system works.

As for adding potions, the script itself is stored in an include folder, typically at "C:\Simba\Includes\bonsai".

For altering the script you probably want to understand and modify blCombat.simba in that folder. The past few pages of this thread have a lot of posted mods.

If you got banned for the mouse we would all be banned.

That's how it colors. It stops doing it once you have a decent supply of information.

That's one reason it's good to have that color file stash so you can have information ahead of time.

I know this is a bit of a far shot and not fair, but im in a very tight situation and dont have time to implement a looter:P

Could anyone please share a simple looter implemented with bonsai's awesome script? You could just private message me:P

Thanks a lot

For some reason it stops after logging in

Check your graphics settings and make sure they match what's required.

Hey working quite well! Here the colors for chickens: here/cXNdT4JR

Just dropping this off here, it's my health check procedure I use in my own combat script.
Do note that you cannot just copy paste this into this script! It'll have to be changed somewhat.

Simba Code:

procedure checkHealth();
begin
  case actionbar.getHPPercent() of
    0..20: terminateScript();
    21..40: sendKeys('m', 200, 40);
    41..70:
      if (actionbar.getAdrenalinePercent() > 50) then
        sendKeys('s', 200, 40);
    71..100:
      begin
        if (berserkTimer.getTime() > 60000) and (actionbar.getAdrenalinePercent() = 100) then
        begin
          sendKeys('b', 200, 40);
          berserkTimer.start();
          exit;
        end;
        if (assaultTimer.getTime() > 30000) and (actionbar.getAdrenalinePercent() > 50) then
        begin
          sendKeys('a', 200, 40);
          assaultTimer.start();
        end;
      end;
  end;
end;

@bonsai
Hope this might be usefull to you.

I'm not pm'ing this to bonsai as others might have some uses for it aswell.

Quote:

Originally Posted by lovebotter

@bonsai
Hope this might be usefull to you.

I'm not pm'ing this to bonsai as others might have some uses for it aswell.

Thanks, these are helpful to everyone. I'm still so busy IRL I haven't even thought about updating things. I check the site from my phone and that's about it.

If you guys come with a modded blCombat that supports some of these extra features I would certainly try to get it merged/posted.

@BottingFTW uploaded some new color files to the shared drive, an updated waterfiend plus gargoyle and jadinko

''OVERLOAD. More than 30000 matches.''

Hmm... Now that's funny.

Can anyone help me setup looting for noted items? Mostly from abyssal demons and dark beasts. Any help would be awesome!!!

Quote:

Originally Posted by lovebotter

Yes, that's most likely what happened I suppose. But once again, please note that the suggestions I have posted are only meant for bonsai.

Here should be a working code:
To use this, just replace the original procedure in the blCombat.simba file and change your action bar keys to whatever you want to use (ingame or in the code, so they both match).
This code allows both the use of regenerate and sgs spec. You have to edit one of them out by using //, it currently uses SGS, and regenerate is ruled out. (The same can be achieved by putting the code between the { and } brackets.

Simba Code:

procedure __defaultHealthCheck();
var
  berserkTimer: TTimeMarker;
  assaultTimer: TTimeMarker;
begin
  if (actionbar.getHPPercent() < 40) then
  begin
    sendKeys('m', 250, 40);
    wait(gaussRangeInt(300, 1000));
    exit;
  end;
  if (actionbar.getHPPercent() < 20) then
  begin
    writeln('***** Terminating script due to low health');
    terminateScript();
  end;
  if (combatMgr.healthTimer.getTime() < 3600) then
    exit;
  while (actionbar.getHPPercent() > 70) do
  begin
    if (actionbar.getAdrenalinePercent() = 100) and (berserkTimer.getTime() > 60000) then
    begin
      sendKeys('b', 200, 40);
      berserkTimer.start();
      wait(gaussRangeInt(100, 200));
      combatMgr.healthTimer.start();
      exit;
    end;
    if (actionbar.getAdrenalinePercent() > 50) and (assaultTimer.getTime() > 30000) then
    begin
      sendKeys('a', 200, 40);
      assaultTimer.start();
      wait(gaussRangeInt(100, 200));
      combatMgr.healthTimer.start();
      exit;
    end;
  end;
  while (actionbar.getHPPercent() < 70) do
  begin
    if (actionbar.getAdrenalinePercent() > 50) then
    begin
      sendKeys('s', 140, 40);
      wait(gaussRangeInt(400, 1000));
      combatMgr.healthTimer.start();
      exit;
    end;
//    if (actionbar.getAdrenalinePercent() > 30) then
//    begin
//      sendKeys('r', 200, 50);
//      repeat
//        wait(600);
//      until actionbar.getAdrenalinePercent() < 15;
//      wait(gaussRangeInt(100, 1300));
//      combatMgr.healthTimer.start();
//      exit;
//    end;
  end;
end;

I tried this but the script got stuck at 'Booting up'. Mind you there were no compiling errors either.

Quote:

Originally Posted by lovebotter

Just dropping this off here, it's my health check procedure I use in my own combat script.
Do note that you cannot just copy paste this into this script! It'll have to be changed somewhat.

Simba Code:

procedure checkHealth();
begin
  case actionbar.getHPPercent() of
    0..20: terminateScript();
    21..40: sendKeys('m', 200, 40);
    41..70:
      if (actionbar.getAdrenalinePercent() > 50) then
        sendKeys('s', 200, 40);
    71..100:
      begin
        if (berserkTimer.getTime() > 60000) and (actionbar.getAdrenalinePercent() = 100) then
        begin
          sendKeys('b', 200, 40);
          berserkTimer.start();
          exit;
        end;
        if (assaultTimer.getTime() > 30000) and (actionbar.getAdrenalinePercent() > 50) then
        begin
          sendKeys('a', 200, 40);
          assaultTimer.start();
        end;
      end;
  end;
end;

@bonsai
Hope this might be usefull to you.

I'm not pm'ing this to bonsai as others might have some uses for it aswell.

Also this
''Error: Unknown declaration "berserkTimer" at line 486
Compiling failed.''

I'm relatively new to this so I'm getting confused :p

BUG report: The bot hops on to an another monster while there's already a monster that it is supposed to kill.
Another Bug: The bot never uses Rejuvenation even if it's off-Cooldown. However, it will perform Berserk or any other ultimates.
A small bug: The bot doesn't utilize manual abilities very well and it tends to wait a few seconds to do abilities in between.

Does anyone know a good melee training spot for 50-75 combat stats?

Quote:

Originally Posted by lovebotter

Does anyone know a good melee training spot for 50-75 combat stats?

Hill giants, Moss giants are nice. I did Moss giants until 75 attack, then started using sgs at fire giants!! Great xp/hr.

Quote:

Originally Posted by Theron

Hill giants, Moss giants are nice. I did Moss giants until 75 attack, then started using sgs at fire giants!! Great xp/hr.

Please do tell me, how did you get Fire Giants to work? For me, it scans over 100,000 colours (!) and only 3 of them were 'deemed' viable for usage.

Also, can you get Deadly Red Spider to work? Can you please post colors?

Quote:

Originally Posted by sombix71

Please do tell me, how did you get Fire Giants to work? For me, it scans over 100,000 colours (!) and only 3 of them were 'deemed' viable for usage.

Also, can you get Deadly Red Spider to work? Can you please post colors?

i used the colors that are on the OP. You need to save them in the colors file. C drive > simba > include > Bonsai > colors.

after you save the files, restart your script and they should be under your NPC options. I used Fire Giants in the chaos tunnels, I zoomed in my screen so it only saw the one room with the fire giants, versus having your screen zoomed all the way out.

Quote:

Originally Posted by Theron

i used the colors that are on the OP. You need to save them in the colors file. C drive > simba > include > Bonsai > colors.

after you save the files, restart your script and they should be under your NPC options. I used Fire Giants in the chaos tunnels, I zoomed in my screen so it only saw the one room with the fire giants, versus having your screen zoomed all the way out.

Many cheers friend!

Quote:

Originally Posted by sombix71

Many cheers friend!

Hope i helped!! Goodluck!