Garrett's Fire Crafter

Ya, I'll have to update the fail-safes.

didnt work for me it just clicked on runescape and clicked on inventory and just sat there, didnt even get ess.

Strange.. I don't think anyone has had that problem.

its really wierd, it just stands there and i really need to get my crafting to lvl 35

Worked a little better this time, still not sure why it messed up.


//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.1
| AntiBan: On
|
| ******* RuneCrafting Level = 56
| Banked: 4.
| Essence Crafted: 112.
| Fire Runes Crafted: 224.
| Worked for 26 Minutes and 53 Seconds
//////////////////////////////////////////////////

Remaining Essence to Craft: 4888
Cactus Color = 2646325
Cactus Color = 2646325
Road Color: 5668993

-------------------------------------
ran it again this time it was good. had the same problem as previous i believe. not sure why.
//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.1
| AntiBan: On
|
| ******* RuneCrafting Level = 56
| Banked: 13.
| Essence Crafted: 364.
| Fire Runes Crafted: 728.
| Worked for 1 Hours, 26 Minutes and 22 Seconds
//////////////////////////////////////////////////

Remaining Essence to Craft: 4636
Cactus Color = 2646325
Cactus Color = 2646325
Road Color: 5863813

both times i logged in and it was here:
http://i222.photobucket.com/albums/d...ious/stuck.jpg
maybe that will help. overall good job.
-------------------------------------
ran it again got 140 essence crafted and was around same spot as picture above when logged in.
-------------------------------------
ran it again again, and crafted 168 rune essence, logged back in and was in same spot again.

ok got it to work just changed a color thing

proggy

| ***** RuneCrafting Level = 37
| Banked: 3.
| Essence Crafted: 84.
| Fire Runes Crafted: 168.
| Worked for 18 Minutes and 26 Seconds

Alright, thanks mickaliscious.. that should help me alot with fixing it.

Strange though, I have never have had any problems. But, I'll work on getting it fixed up right now.. I might have the radial walk set wrong.

EDIT:

Found problem, your character obviously goes to the wrong rock...
So for a quick fix for yourself you can edit this(NOT TESTED) although, you can be my tester =D
Line: 1035
change
If(RadialWalk( GetRoadCo , 0, 60, 75, 5, 5))Then
TO
If(RadialWalk( GetRoadCo , -40, 60, 75, 5, 5))Then

Please let me know if that helps.. and post any other problems, thanks.

EDIT2:

woops, forgot to add players[].active
I'll fix that too... and I'm almost done updating this. (I might work a bit on the forms too though)

alright, i'll test now and see if it works any better.
___________________________________________
ran it, this time i think i actually figured out the problem, and why it sometimes occured on the first trip to the ruins, and other times on the 6th. randomly, right before clicking on the road color right before the ruins, when it should click on the rock, there is another rock in the northeast corner of the minimap. i think you figured this out, but it still sometimes clicks on that rock. the problem isn't clicking on that rock, since you can still see the road/roadcolor on the minimap, but the problem is that there is a place where you can click, the flag will go up, you will run there but cannot fully reach the flag so the flag remains up, and the script does not move on. (the flag was on the rock, and the player was right next to the rock) I'm not sure why this happens, and it seems like it would be hard to correct in the script.
-also still fails to find a symbol (kebab, scimitar) if there is a person/npc standing on the symbol, which usually causes it to log out if the person/npc doesn't move from the symbol quick enough. if this script were for one player instead of two you could fix that by checking to see if logged out and then resuming the task it logged out on (only for a certain number of tries so it would log out if it couldn't find the symbol after so long). if that were possible both the flag not dissapearing and people on the symbol would be corrected and this script could run nearly infinitely on one character, or until you used all of your essence.

Ok, well, I have a better(safer way) fixed for it, the command that I had you put in may bring you way off the path. I'll upload in about 10 minutes.

yay ill test also when you upload the new version Garrett92 :)

thanks!

Alright, test that out, let me know of any problems that need to be fixed... or if that rock problem still hasn't been fixed.

Quote:

---

also still fails to find a symbol (kebab, scimitar) if there is a person/npc standing on the symbol, which usually causes it to log out if the person/npc doesn't move from the symbol quick enough. if this script were for one player instead of two you could fix that by checking to see if logged out and then resuming the task it logged out on (only for a certain number of tries so it would log out if it couldn't find the symbol after so long). if that were possible both the flag not dissapearing and people on the symbol would be corrected and this script could run nearly infinitely on one character, or until you used all of your essence.

---

Just fixed so that it has a max of 20 tries(but it terminates script atm)... and I don't know if its possible to fix the problem with the npc standing on it. but ya, that is a good idea.. I'll see what I can do.

I was thinking, mabey after it doesnt find symbol, logs out, do a wait for about 60 sec, logs in, and restart, do that about a max of 3 times.

yeah, had to stop the script one time because that command brought it off the path.

heres an example of where it gets stuck because the flag doesn't go away.
http://i222.photobucket.com/albums/d...ous/stuck2.jpg
my character sat there until it logged out, and i think this is the problem i've been having.

EDIT:Just saw you updated script so i'll test that out and see if same thing occurs.

Ah, alright.. let me see what I can do.

Edit:
Ah.. ok, lol.. I thought you just tested it.
and I got my forms working again woohoo!!

I wont upload my version with the forms until you give back your report. =)
(Just incase there are anymore bugs I need to fix)

Edit: Ok, thanks.

alright well i'll run it but it usually goes for at least 20 minutes so i'll post up when it messes up or if it runs well for a good amount of time
EDIT:
Ran it 3 times, all three times it terminated at the kebab symbol because the npc was standing on the symbol. I think looking for the color 20 times is actually fairly quick. You should make it look for the color 60 times in case he moves. The best thing to do is to log the character back in after those 60 times in hopes of the symbol or the npc moving, but until then its really all about timing I guess.
EDIT2:
Also, I just watched the script click on the altar to craft the fire runes and then click where it walked next, but the flag dissapeared right away because the character was still doing the runecrafting emote. You might want to change the speed of that to allow more time for the actual crafting. This is actually the first time I've seen it happen though so its pretty rare.

Ok, thanks... I'll try to fix that.

Quote:

---

EDIT2:
Also, I just watched the script click on the altar to craft the fire runes and then click where it walked next, but the flag dissapeared right away because the character was still doing the runecrafting emote. You might want to change the speed of that to allow more time for the actual crafting. This is actually the first time I've seen it happen though so its pretty rare.

---

Should be fixed... added a wait of 4 sec before leaving.
Fixed, changed wait to 2 sec, that should be good.

Quote:

---

EDIT:
Ran it 3 times, all three times it terminated at the kebab symbol because the npc was standing on the symbol. I think looking for the color 20 times is actually fairly quick. You should make it look for the color 60 times in case he moves. The best thing to do is to log the character back in after those 60 times in hopes of the symbol or the npc moving, but until then its really all about timing I guess.

---

does it logout first? (before it terminates)
If so, I think I have a fix.
nvm.. yes it does.

Fixed - Logs out for 60 sec, logs in.. tries again
Does that 3 times... On last try, if it doesnt find, switches to a new player (if there is one).

Mabey I can end up adding some kind of world switcher?
_______________________________

EDIT:
Well, im going to bed... I have some stuff fixed, and there are still a few things. I'll get it finished up tommorow, thansk for all your help.
_______________________________

EDIT:
Just another quick run, just to test my next version.

SCAR Code:

//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.3
| AntiBan: On
|
| xxxxxxxxx RuneCrafting Level = 31
| Banked: 1.
| Essence Crafted: 28.
| Fire Runes Crafted: 28.
| Worked for 4 Minutes and 35 Seconds
//////////////////////////////////////////////////

I think I also Improved the script speed by a minute or 2.

Released V3.3 - I'll do another test, but this time for about an hour... be back later to post.

SCAR Code:

//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.3
| AntiBan: On
|
| xxxxxxxx RuneCrafting Level = 31
| Banked: 6.
| Essence Crafted: 168.
| Fire Runes Crafted: 168.
| Worked for 29 Minutes and 16 Seconds
//////////////////////////////////////////////////

Looks like there may be a problem with my road autocolor, let me know If anyone else has a similar problem. I may need to change the tolerance a bit.

testings 3.3 ill post proggy later

Congrats on becoming an SRL Member. I knew it was only a matter of time.

heres a proggie.
//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.3
| AntiBan: On
|
| ******** RuneCrafting Level = 57
| Banked: 7.
| Essence Crafted: 196.
| Fire Runes Crafted: 392.
| Worked for 47 Minutes and 43 Seconds
//////////////////////////////////////////////////

Remaining Essence to Craft: 304
Rock Color Not Found! Trying Again.
Rock Color Not Found! Trying Again.
Rock Color Not Found! Trying Again.
Rock AutoColor: 2840705
Cactus Color = 4556633
Script Got Lost On: WalkTo
1/3 Tries
Did Not Find Color/Object. Could be due to NPC.
Relogging in 60 sec!
*********
Cactus Color = 4556633
Road Color: 5865860
Cactus Color = 4556633
1/3 Tries.
Cactus Color = 4556633
Could not find Cactus Color!
2/3 Tries.
Could not find Cactus Color!
3/3 Tries. Searching last time, then Switching Mouse Location.
Could not find Cactus Color!
Successfully executed

it somehow got inside ruins and was still looking for a cactus color. not sure what happened.

and once it got stuck again but this time right here:
http://i222.photobucket.com/albums/d...ous/stuck3.jpg

not sure why, but other than that, the log out log back in thing worked excellent. i'll keep running it and try to figure out what happened.

Edit: Figured out why it got stuck in corner. It couldn't find the main mysterious ruins thing, so it clicked east and got stuck in a spot where it won't reach the flag. If you could make it to where it clicks the other pillars if they are visible instead of going east it would solve that problem. If they aren't visible the script could still go east though.

I have had it get stuck there, but it usually gets out of it... but at least I'm getting it to slowly work better =D and I'll work on fixing that in a bit. I may be able to just have it walk higher, so it doesn't miss the ruins... its usually very close though.

I also like your idea also... i think I may try your way.

i cant get 3.3 to work. when i hit start script in that box that comes up it says

Cannot find Scar CDE

Strange.. I'll add a way so you can choose either forms or just normal lines.

[Runtime Error] : Out Of Range in line 1650 in script C:\GarrettsFireCrafterv3.3.scar

:( think its been mentioned allready tho

wont let me set up the player(s)

There... I updated it, and also added a constant to turn the forms on/off
Fixed it so if your character is under the altar, walks up some before going to the right of the altar.. which gets you stuck sometimes.
try setting it to UseForms = False
If that doesn't work, then I'm not sure.

EDIT:
I was thinking... some people may have problems with the screenshots, so I'll add a constant to have the option to turn them off... It will be in my next release.

heres a proggie from 3.3:
//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.3
| AntiBan: On
|
| ******* RuneCrafting Level = 57
| Banked: 18.
| Essence Crafted: 500.
| Fire Runes Crafted: 1000.
| Worked for 1 Hours, 38 Minutes and 28 Seconds
//////////////////////////////////////////////////

should probably terminate the script if theres no nextplayer and the all the essence has been crafted.

Ya.. I'll do that, but I'm not sure how to terminate if there is no nextplayer... I'll see if I can search it up.

But, good to know that its working better =D

:(

wont work for me i watched it withdrew it and it didnt work ill send u a pm of where it ended up

Sorry inkd, this isn't meant to be running in the members world... just a non-members world, so try that and let me know how it works.

I'll add that to the main post.

Edit:
Getting the multiplayer side of my script setup a little better... It will have pin numbers for each account, and also a separate amount of essence to craft for each account.

I reccommend turning the Forms off right now... If you don't, nothing will work (Those forms havent really been released by SRL yet, which is why I needed to add "{.include SRL/SRL/core/Users.scar}" to get them to work. They wont let me add custom variables for users yet.. and you can only use them for single player. TURN THEM OFF, I dont want to hear any complaints about them. They will be turned to False in my next release.

Edit:
I have multiplayer working perfectly now.. counts essence correctly and everything, also fixed the bug where it still searches for cactus color while inside the ruins.
Then there were also 2 other bugs with my radial walk on the tree's/cactus's and that was fixed.. just changed the distance and radius on the radialwalk. I'll be uploading this new version after I get done testing it, trying to get as many bugs as I can :)
Also, you might have a problem with the player going to high above the ruins.. also fixed in this version, or at least I hope its fixed :(

Edit:
New Version 3.5 uploaded... let me know of any bugs/errors

//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.5
| AntiBan: True
|
| RuneCrafting Level = 29
| Banked: 5.
| Essence Crafted: 140.
| Fire Runes Crafted: 140.
| Worked for 23 Minutes and 55 Seconds
//////////////////////////////////////////////////


lol every time i run it it always do only 140 runes and then bot losts its way

lol.. thats strange :confused:

i think the new update randomly changes the location of the bank screen relative to the runescape screen. sometimes it withdraws essence and other times it doesn't withdraw anything. if this is true you're going to have to use a colorfinder or something to withdraw the essence which will be a huge pain in the butt.

Actually, I'm already working on that.. Mainly just so you dont need to put the essence in the first slot though. But, if thats the case hopefully I can get it fixed soon!

//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.5
| AntiBan: True
|
| ******* RuneCrafting Level = 58
| Banked: 10.
| Essence Crafted: 280.
| Fire Runes Crafted: 560.
| Worked for 51 Minutes and 5 Seconds
//////////////////////////////////////////////////

Remaining Essence to Craft: 720
Rock AutoColor: 79959
Cactus Color = 1795887
Cactus Color = 1795887
Road Color: 5471096
Cactus Color = 1795887
Searching For Ruins: Please Give Up To 30 Seconds.
NextPlayer

Logged back in and it was here:
http://i222.photobucket.com/albums/d...s/stuck2-1.jpg
Think its having the same problem as last time with the flag not going away. This just happens, and it seems the only way to fix it is to have the character log back in and resume the action. Hmmm.

Alright.. I just learned how to use DTM's a few days ago.. so I really should be able to make it 100% findable if I can use some DTM with the cactus.

DTM's would be cool then.

Its a new record:
//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.5
| AntiBan: True
|
| ******* RuneCrafting Level = 58
| Banked: 23.
| Essence Crafted: 644.
| Fire Runes Crafted: 1288.
| Worked for 2 Hours, 5 Minutes and 33 Seconds
//////////////////////////////////////////////////

Remaining Essence to Craft: 356
Rock AutoColor: 79959
Cactus Color = 1795887
Cactus Color = 1795887
Road Color: 5667969
Cactus Color = 1795887
Searching For Ruins: Please Give Up To 30 Seconds.
NextPlayer

Logged back in and it was here:
http://i222.photobucket.com/albums/d...us/stuck-1.jpg
Unless my internet connection went out and then came back on within the 20 minutes of me checkin on it, i'm not sure why it couldn't find the ruins.

ya, thats very strange.. and nice proggy :D
but my proggy from v2.8 is still better :p
(unless your going for the most fire runes crafted)

//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 2.8
| AntiBan: Off
|
| xxxxx RuneCrafting Level = 31
| Banked: 36.
| Essence Crafted: 1000.
| Fire Runes Crafted: 1000.
| Worked for 3 Hours, 43 Minutes and 12 Seconds
//////////////////////////////////////////////////

hmm im having the same problem it does 1 run then gets at the alter and logs out coz it doesnt get close enough to the alter..... but every now and then it does 100 runes.. then stops....

Best progress report ever? I think so.

//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.5
| AntiBan: True
|
| ******* RuneCrafting Level = 58
| Banked: 36.
| Essence Crafted: 1000.
| Fire Runes Crafted: 2000.
| Worked for 2 Hours, 56 Minutes and 28 Seconds
//////////////////////////////////////////////////

:spot: (<- First smiley I have ever used on any forums)
Good job. I had a run get stuck in the kebab shop though because the door was closed... thats something to look into.

I'm gonna set it to do the 2k essence I have left in the bank and let it run over night and see how it does.

alright.. nice proggy, I'll post that on the main post tomorrow... but I'm in a hurry right now and g2g.

and yes.. that was something else I was thinking about, a kebab shop door checker. just kinda waiting for someone to have a problem with it first though :p

i keep getting the searching for ruins problem...

Ya... currently I'm having a hard time with that, still trying to figure out a way to make it fail-proof :D

Another good progress report:
//////////////////////////////////////////////////
| Garretts FireRune Crafter
| Version: 3.5
| AntiBan: True
|
| ******* RuneCrafting Level = 59
| Banked: 42.
| Essence Crafted: 1152.
| Fire Runes Crafted: 2304.
| Worked for 3 Hours, 43 Minutes and 28 Seconds
//////////////////////////////////////////////////

NextPlayer

I ran out of essence otherwise it would've kept going.
The times kind've long though not sure what happened.