Printable View
Okay, I have finally gotten around to finishing (kinda) my Prayer Upper. It picks up bones and buries them. Remember that this is the pre-release and it will undoubtedly be chock full of bugs. I posted it in the scripting help section so I would get constructive comments and nothing like "OMGZORGZ THIS 5KR1PZ N0T W0RK1N 4 MEH!!! U SUX!!! H3LP MEH!!!" lol.
I dont play rs any more, so i can really test it. I looked over the codee, and it all looks pretty good to my eyes. I coundt find anything really sticking out, its simple, but it looks good, well done.
thats what I was aiming for. Just something simple that I could try all of the member's requirements in (multi-player, anti-random, etc...) to see if I knew them. If it works, I'm gonna get back to my banana's quest runner.
first few things i see:
1) you never want to have typesend messages in your antiban. this is because if after you grab 1 bone and you type a message...then you grab the next one and lets say types the EXACT same message you are gonna look pretty bot-like and more likely to get reported/banned...
2) if you want the player to be declared false after it is logged out just use "nextplayer(False);" if your player is logged out it will consider him inactive and just switch to the next active player...but if your guy logs out because of something unimportant then nextplayer(True); will be a better choice in order to relogg him in and see if theres a real problem (maybe after certain number of log ins without a bone pickup declare him inactive..) Also maybe at the start of the script have a if(not(LoggedIn))then LogInPlayer;
3) maybe you could also add DTM dropping because its more accurate
4) To beef up your antirandoms you should add WT-Fakawi's FindFastRandoms;
SCAR Code:Function FindFastRandoms: Boolean; // By WT-Fakawi.
Var
i: Integer;
Begin
For I := 1 To 11 Do
Begin
Case I Of
1: If FindDead Then
Result := True;
2: If FindMod Then
Result := True;
3: If FindMime Then
Result := True;
4: If FindMaze Then
Result := True;
5: If FindQuiz Then
Result := True;
6: If FindDemon Then
Result := True;
7: Begin
If NoGameTab Then
Begin
Result := True;
Players[CurrentPlayer].loc := 'No GameTab';
Logout;
Exit;
End;
End;
8 : If RC Then
Result := True;
9 : If FindFight Then
Begin
Result := True;
RunTo('S', True);
End;
10: If FindTalk Then
Result := True;
11: If FindTrade Then
Result := True;
End;
Wait(1);
End;
End;
Other than that it looks like a pretty good script and i only suggest to continue to test it and kink out all the bugs that you can and find out how to tweak it just right ;) Nice script and good luck :D
Yeh I agree on the anti bann thing make about 100 - 50 diffrent sentces all lower case and make a integer genrate a random value 10 - 20 eg then use that as a case then make another integer so everytime that case is ran it will it will add 1 to it so you get a random text every 10 times and then just reset it again!
Do you guys realize that you're wrong? The chance of it saying the same thing in a row for my antiban is... *calculates* 1 in 44. Not likely.
And for Gerauchert,
1) Just proved you wrong.
2) I want them to continue for ever unless they run into errors (making them false) and mywill keep them the way they are so if they run into 0 errors, they can continue when their turn comes again. look in the intermediate or advanced tut section and you'll see where I got the idea from.SCAR Code:NextPlayer(Players[CurrentPlayer].Active);
3)No need for DTM dropping. There is no other item that has bury as a popup. This actualy makes it better, it will bury not only bones, bot big bones and dragon bones etc... It uses an SRL function to check every item in your inventory, right clicks, and then selects either bury(if its there) or cancel(if it can't find bury).
4)Maybe, but I don't think you'll run into much other than shades, zombies, and mysterious men while prayer lvling.
Can you say Pwnt?
@cathering_
Lets see you make it. Look at the antiban for big, awesome scripts (Wizup's Essence Miner for example), they have 4-6 like random text in their antiban.
Thanks for the advice, but please look over it better next time so I don't have to explain stuff XD
Again, thank you for your contribution!
You really should watch your attitude.Quote:
Originally Posted by rotflmfwao
these poeple are trying to help you be better. Not chalenge your scripting abilities. You need to be able to accept constructive critizism.
Now, 1 in 44 is too big of a chance in my eyes, specialy if you want it to run over night. The way cathering mentioned is undenably better.
If you hit an error, instead of logging out, you should do NextPlayer(false), no argument their either. It will still go forever if there are no errors.
You're right, sorry to you 2 for the 'lil outburst there. You were offering constructive criticism, nothing more nothing less.
And all you'd need to do to make it a 1:99 chance of repeating is make it a 9 line TypeSend instead of 4.
even then, if that random case is called more than 99 times (whitch it wuld be in a over night script) you are more then bound to haven problems.Quote:
Originally Posted by rotflmfwao
And if not in one night, in the next. Basicly, if you EVER plan to run that case statement more than 99 times, ure still screwed.
his way is beter....
He was talking about the antiban repeating itself 2x in a row, so the chances reset every time. Btw, no1 is gonna care if you say one think and then 99 mins or so later you say it again XD
sigh...Quote:
Originally Posted by rotflmfwao
Ok, i know probability can be triky, so just take it slow, and walk with me here.
1.We know that the odds of it saying ANYTHING is 100%... ok, good.
2.Now, the odds of it Repeating the SAME thing, are one in 99. good.
So that means... the 99th time you repeat this function, it will (probably) repeat itself.
The chances do NOT reset every time, because step two can also be step one.
Folow?
Edit: for clarifaction, these are the odds of you saying something, and then reapeat it the VERY NEXT time you call the anti ban
i dont think (in my opinion, obbviously) that you should use a single case so many times.
Yes, but repeating itself every 99th time is a completely different problem, and his way will stop that, but with the problem of repeating itself 2x in a row is 1:99 and resets every time. That is NOT connected to the repeating itself every 99th time.Quote:
Originally Posted by lordgreggreg
EDIT: and you're telling me to watch my altitude?
this shows that the odds or it repeating every 99 times are 100%. That is what the odds are.Quote:
Originally Posted by rotflmfwao
It will reapeat itself the very next time once out of every 99 times.
This is because.. well, lets do this
shot number 1. you say one thing.
time number 2. you have a 1/99 to say the same thing
time number 3. you have a 1/99 to say time number 2.
ohhh! I think i know where you are getting confused.
Supose you have a quarter, options are heads and tails.
You flip in the air, 1/2 chance to be heads. And it is heads!
Now, you flip it in the air again, and it is heads again!
now, what are the odds for the next flip? are they 1/2, or are they less than that.
You see, the flip itself will ofcourse still be a 1/2 chance to be heads. But because the last 2 were also heads, we know by experince that the odds for a tails to happen are getting higher and higher.
This is the same thing with your talking, sure, each time is has a 1/99 chance... but as time goes on.. and it doesnt repreat itself.. its is more bound to repeat itself the next time.
triky, i know, thats just how probablitlty works.
Thats exactly what i'm saying. I took advanced probability last year, 2 semesters in a row...
it doesnt matter what classes you took, thats an invalid argument for so many ways im not even going to bother mentioning it.
did you read anything past "ohhh! I think i know where you are getting confused."
if you dont belive me, go grab a quarter and try it out.
Thats the exact same thing I was saying! I read your whole post! Please, I'd rather not argue, we were both correct, I was saying the same thing as:It was a miscommunication.Quote:
It will reapeat itself the very next time once out of every 99 times.
This is because.. well, lets do this
shot number 1. you say one thing.
time number 2. you have a 1/99 to say the same thing
time number 3. you have a 1/99 to say time number 2.
Btw, the quarter thing is the intro to the probability class XD you could be a teacher!
Lets see...
1 in 99 chance of repetition in the first 99 times.
2 in 99 chance of repetition in the first 198 times.
So, theoretically, you will most likely repeat the sentence every 100 times.
This is inevitable. But, will someone be keeping a record of your sentences?
Well, here's what could happen. These are 300 numbers, from 1 to 99:
92, 19, 31, 84, 71, 71, 32, 12, 60, 30, 30, 68, 82, 90, 6, 35, 39, 4, 90, 35, 18, 47, 59, 37, 83, 29, 48, 19, 62, 58, 55, 56, 63, 83, 21, 33, 85, 84, 19, 83, 10, 56, 3, 17, 70, 43, 76, 79, 64, 91, 3, 63, 35, 42, 52, 59, 36, 72, 55, 20, 71, 58, 28, 69, 60, 31, 69, 83, 80, 31, 50, 36, 71, 91, 47, 63, 24, 4, 96, 8, 74, 45, 53, 38, 75, 80, 1, 64, 28, 52, 38, 81, 79, 30, 33, 20, 32, 84, 27, 81, 16, 7, 32, 96, 18, 86, 51, 27, 73, 13, 3, 88, 54, 77, 50, 90, 26, 84, 57, 2, 45, 85, 16, 83, 19, 17, 25, 74, 51, 99, 9, 91, 56, 13, 14, 86, 99, 72, 14, 94, 1, 67, 21, 37, 16, 37, 65, 70, 74, 84, 13, 15, 50, 68, 21, 74, 70, 20, 51, 47, 18, 64, 95, 99, 64, 58, 79, 24, 41, 64, 50, 28, 39, 24, 65, 13, 97, 4, 37, 49, 13, 21, 97, 46, 81, 85, 98, 72, 70, 98, 43, 94, 59, 99, 31, 12, 8, 61, 54, 23, 43, 62, 88, 54, 74, 95, 39, 23, 65, 87, 65, 17, 31, 38, 82, 29, 54, 99, 11, 68, 4, 70, 26, 20, 29, 60, 21, 52, 53, 47, 4, 89, 87, 45, 71, 75, 44, 52, 36, 16, 9, 37, 14, 83, 24, 91, 75, 96, 60, 59, 31, 22, 9, 10, 11, 71, 6, 33, 39, 69, 69, 49, 30, 29, 27, 78, 54, 60, 34, 24, 38, 90, 48, 29, 13, 83, 85, 42, 24, 73, 69, 93, 48, 64, 73, 50, 99, 44, 96, 38, 20, 30, 28, 8, 76, 40, 93, 8, 9, 50,
In those numbers, 3 numbers were repeated twice in a row:
71 (at the very beginning - 92, 19, 31, 84, 71, 71, 32, 12)
30 (right after the 71s - 71, 71, 32, 12, 60, 30, 30, 68, 82)
60 (pretty far in there - 6, 33, 39, 69, 69, 49, 30)
and just in case you wanted it,
SCAR Code:program New;
var i,r,l:integer;
s:string;
begin
for i := 1 to 300 do
begin
r := random(99)+1;
if r=l then
writeln('Repeated a number ('+inttostr(r)+').');
l := r;
s := s + IntToStr(r)+', ';
if length(s)>500 then
begin
writeln(s);
s := '';
end;
end;
writeln(s)
end.
Ahh, THANK YOU widget. This is a perfect demonstration.Quote:
Originally Posted by Widget
roft... do you see now?
sorry lordgreggreg but you are absolutely wrong (you too rotflmfwao), the number of times that you flip the coin has not bearing at all whatsoever on the probability that the coin will land on a heads or tales. it will always be 50/50 (theoretically). for example if you flip a coin 100 times and it is tales every time then the next time that you flip it the probability of it being tales is still 50%, it does not change at all. There is the same probability that you flip a coin 100 times and it is tales every time as there is for it to be 50 times heads and 50 times tales. the probability is 1 / 100 (100 combinations of heads/tales: 0/100..1/99..2/98...98/2..99/1..100/0). every combination of tales and heads has this same probability of happening. i am surprised that no one has mentioned this yet.
No there is twice the chance for it. Not to mention that fliping 100 coins will (gausian curve style) give more results like 45/55 47/53 44/56 MUCH MUCH more often than 1/99 3/97 etcQuote:
Originally Posted by sherlockmeister
Also, it is only a 50/50 chance ONLY if you are looking a ONE flip.
We are looking at 99 or more flips, and the answers is that it will most likly repeat itself once every 99 times or so.
Ah, I see. Another thing to consider is multiplayer. You're not gonna stay on the same player for more that 50 AntiBan's or so... Which really cuts down the odds of repeating yourself. I guess the simplest solution is just to not have any text in your antiban.
@Sherlockmeister (or something to that affect)
If you're looking for the odds from the 45th flip to the 46th flip, the chance they will be the same is 50/50.
If you're looking for the odds that all 99 flips will be heads, the probability of that is 2^99 or 2 to the power of 99.
well, the thing is, switch pplayers really doenst save you from these odds either.Quote:
Originally Posted by rotflmfwao
sure, ifthey happen to repeat on the 50th and 51st, (and u swtiched at 50) it wouldnt matter.
but other then that, the odds stay just as bad for multiplayers.
so yeah, imho no text is the best way. fawki was thinking of a system where you could talk to other srl users who would talk back/... that would own
or if you are going to talk, have it randomize through groups of 9 or something.
Yeah, but is someone really gonna care if Bob somes in and says 'Hiya all!' then leaves, and then James comes in and says 'Hiya all!' ?
But yeah, Fawki's system would pwn all ass.
I'm just gonna keep text out of my antiban 'till then.