Zephyr's Karamja Fisher w/ Reflection

Printable View

Show 40 post(s) from this thread on one page

Sorry for being nooby but I can't find that line in amount.scar
SCAR Code:
function CountItemsBmp(area: string; bmp, tol: Integer): Integer;
var
  coords: TPointArray;
begin
  coords := ItemCoordsBmp(area, bmp, tol);
  Result := GetArrayLength(coords);
end;
lines 390-396 in amount.scar I have rev 20

08-05-2008, 03:56 AM
kingarabian

[------------------------------------------------------------------------------------]
[ August 4th, 2008, 05:25:45 PM ]
[------------------------------------------------------------------------------------]
[ >>> Zephyr`s Karamja Fisher Ver 1.0 <<< ]
[------------------------------------------------------------------------------------]
[ Total Time Running: 34 Minutes and 8 Seconds ]
[ Total Loads Done: 2 ]
[ Total Fish Caught: 52 ]
[ o Lobsters: 52 ]
[ Fishing Rate: 91 Fish/Hr ]
[ Total Fishing Exp Gained: 4680 ]
[ Experience Gain Rate: 8227 Exp/Hr

=/ hope i get a better run tonight.
08-05-2008, 05:16 AM
Dangerous Garden Tools

could you make it without smart? Ive done things to lower lag, but its just not enough lol
08-05-2008, 05:17 AM
Method

Quote:

Originally Posted by Dangerous Garden Tools

could you make it without smart? Ive done things to lower lag, but its just not enough lol

Reflection with SCAR only works with SMART currently. Without SMART the script couldn't function.
08-05-2008, 08:14 AM
ZephyrsFury
Quote:
Originally Posted by jose89

Sorry for being nooby but I can't find that line in amount.scar

SCAR Code:

function CountItemsBmp(area: string; bmp, tol: Integer): Integer;
var
coords: TPointArray;
begin
coords := ItemCoordsBmp(area, bmp, tol);
Result := GetArrayLength(coords);
end;

lines 390-396 in amount.scar I have rev 20
CountItemsBMP was removed in Rev 18 or something so you definately don't have rev 20 :p

SCAR Code:

[------------------------------------------------------------------------------------]
[                     >>>  Zephyr`s Karamja Fisher Ver 1.0  <<<                      ]
[------------------------------------------------------------------------------------]
[  Total Time Running: 1 Hours, 31 Minutes and 31 Seconds                            ]
[  Total Loads Done: 11                                                              ]
[  Total Fish Caught: 286                                                            ]
[   o Lobsters: 286                                                                  ]
[  Fishing Rate: 188 Fish/Hr                                                         ]
[  Total Fishing Exp Gained: 25740                                                   ]
[  Experience Gain Rate: 16876 Exp/Hr                                                ]
[  Fishing Levels Gained: 0                                                          ]
[------------------------------------------------------------------------------------]
[   | Nick | Act | Loc                              |  Lvl | Loads | Fish | Time     ]
[ o         |  F  | Lost - No Customs officer  |  70  |   11  | 286  | 89 min   ]
[------------------------------------------------------------------------------------]

awesome script mate i luv reflection it got lost at customs officer
coming from a full inv going to port sarim

Quote:

Location: Fish
Inventory Full, going back to Bank
Location: Fish To Karamja
Walking to Path Index: 5 (2924, 3172).
Walking to Path Index: 4 (2914, 3164).
Walking to Path Index: 3 (2917, 3151).
Walking to Path Index: 2 (2929, 3152).
Walking to Path Index: 1 (2942, 3145).
Walking to Path Index: 0 (2956, 3146).
Location: Karamja To Sarim
Location: Lost - No Customs officer

was facing the walking plank hope i helped this was just my main ill get my army onto it later

08-05-2008, 03:35 PM
kingarabian

Hooks are now fucked since rs updated?
08-05-2008, 05:27 PM
Method

Quote:

Originally Posted by kingarabian

Hooks are now fucked since rs updated?

If there was an update, then I assume they wouldn't work.
08-05-2008, 09:40 PM
Dangerous Garden Tools

Quote:

Originally Posted by Method

Reflection with SCAR only works with SMART currently. Without SMART the script couldn't function.

well is there any other way i can lower lag? i gets to the fishing spot and lags out. Ive read tuts to lower it, but it just hasnt helped enough.
08-05-2008, 10:24 PM
Method

Quote:

Originally Posted by Dangerous Garden Tools

well is there any other way i can lower lag? i gets to the fishing spot and lags out. Ive read tuts to lower it, but it just hasnt helped enough.

Try lowering the FPS bar in SMART (the one on the right side) and that may help to fix your lag. Otherwise, you'll probably just have to avoid using SMART altogether until your computer can handle it.
08-06-2008, 05:54 AM
Dangerous Garden Tools

logs in and just sits there >.>
08-06-2008, 06:03 AM
NiCbaZ

yeah hooks our outdated.
08-06-2008, 06:04 AM
Method

RuneScape updated (twice) today, so the hooks are outdated. You need to wait until they're updated to use any reflection script.
08-06-2008, 11:29 AM
unl

lmfao look at my fishing lvl :"D

SRL Compiled in 5797 msec
Welcome to Runescape.
*********
Creating the NickTPA.
Fishing Level is 65535
08-06-2008, 02:31 PM
the scar noob

Quote:

Originally Posted by unl

lmfao look at my fishing lvl :"D

SRL Compiled in 5797 msec
Welcome to Runescape.
*********
Creating the NickTPA.
Fishing Level is 65535

haha, lol! 65535 is the highest integer value at pascal/delphi:)

Don't use the script, hooks are outdated....!!

-Tsn.
08-07-2008, 08:30 AM
ZephyrsFury

Quote:

Originally Posted by the scar noob

haha, lol! 65535 is the highest integer value at pascal/delphi:)

Don't use the script, hooks are outdated....!!

-Tsn.

You sure its not just my script being so good that it gets you 65535 fishing without fishing anything? :p
08-07-2008, 04:10 PM
tarajunky

The hooks are up to date now in the Reflection svn.

The script works great. Too good, in my opinion. Watching it walk is almost painful, since it's so precise. It always seems to click the next spot just before your character would stop running, which is the most efficient way to do it, but seems bot-like to me. It also never clicks on the wrong kind of fishing spot. It always clicks the Cage/Harpoon one the first time, which no real player could do.

The only 'problem' was that it mistakenly thought it had stopped fishing a few times when the delay between lobs was long, which isn't a big deal.

Also, an autoresponder would be the icing on the cake. Good job!
08-07-2008, 06:23 PM
kingarabian

[------------------------------------------------------------------------------------]
[ August 7th, 2008, 06:51:04 AM ]
[------------------------------------------------------------------------------------]
[ >>> Zephyr`s Karamja Fisher Ver 1.0 <<< ]
[------------------------------------------------------------------------------------]
[ Total Time Running: 1 Hours, 30 Minutes and 35 Seconds ]
[ Total Loads Done: 9 ]
[ Total Fish Caught: 234 ]
[ o Lobsters: 234 ]
[ Fishing Rate: 155 Fish/Hr ]
[ Total Fishing Exp Gained: 21060 ]
[ Experience Gain Rate: 13950 Exp/Hr ]
[ Fishing Levels Gained: 1 ]
[------------------------------------------------------------------------------------]
[ | Nick | Act | Loc | Lvl | Loads | Fish | Time ]
[ o | azad| T | Bank | 58 | 9 | 234 | 90 min ]
[------------------------------------------------------------------------------------]
08-07-2008, 06:23 PM
NightBlade

Code:

File access error SRL Compiled in 2391 msec Welcome to Runescape. Creating the NickTPA. Fishing Level is 59 ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** Withdrawing Coins... Withdrew 832 coins. ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** Location: Lost - No Fishing Gear NextPlayer Creating the NickTPA. Fishing Level is 64 ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** Withdrawing Coins... Withdrew 979 coins. ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** Location: Lost - No Fishing Gear [------------------------------------------------------------------------------------] [ August 7th, 2008, 02:19:13 PM ] [------------------------------------------------------------------------------------] [ >>> Zephyr`s Karamja Fisher Ver 1.0 <<< ] [------------------------------------------------------------------------------------] [ Total Time Running: 1 Minutes and 14 Seconds ] [ Total Loads Done: 0 ] [ Total Fish Caught: 0 ] [ Fishing Rate: 0 Fish/Hr ] [ Total Fishing Exp Gained: 0 ] [ Experience Gain Rate: 0 Exp/Hr ] [ Fishing Levels Gained: 0 ] [------------------------------------------------------------------------------------] [ | Nick | Act | Loc | Lvl | Loads | Fish | Time ] [ o | elbo | F | Lost - No Fishing Gear | 59 | 0 | 0 | 0 min ] [ o | ezu | F | Lost - No Fishing Gear | 64 | 0 | 0 | 0 min ] [------------------------------------------------------------------------------------] Thanks for using Zephyr's Karamja Fisher Successfully executed

Coins and lobster pot are in inventory
08-07-2008, 07:00 PM
tarajunky

Quote:

Originally Posted by NightBlade

Code:

** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'** ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'**

Coins and lobster pot are in inventory

Looks like you're getting the "bmp," error. You need to read back through the thread to see how to fix it.
08-07-2008, 07:03 PM
NightBlade

ahhh shit my bad.. :(
08-08-2008, 05:39 AM
sjlou

almost every time my chars is Lost - No Customs officer
is cause it couldnt talk to the officer

1 he finds him
2 clicks on him
3 coulndt reach him
4 Location: Lost - No Customs officer

maybe add a failsafe there ?
08-08-2008, 05:39 AM
Luski14

Quote:

Line 437: [Error] (16975:9): Unknown identifier 'WalkToTileTol' in script C:\Program Files\SCAR 3.15\Scripts\Karamja Fisher + Banker.scar

Error I get.
Scar 3.15b, SRL Rev #20, and most updated Reflection

:( Was looking forward to this.
08-08-2008, 06:08 AM
kingarabian

Quote:

Originally Posted by dushii

almost every time my chars is Lost - No Customs officer
is cause it couldnt talk to the officer

1 he finds him
2 clicks on him
3 coulndt reach him
4 Location: Lost - No Customs officer

maybe add a failsafe there ?

Yea for both officers, there needs to be a failsafe =/. Go for it Zeph.
08-08-2008, 07:03 AM
sweetleaf

Quote:

Originally Posted by kingarabian

Yea for both officers, there needs to be a failsafe =/. Go for it Zeph.

this is also my complaint lol :) but ya i left it on for about 2 hours earlier today, looks like it ran really good, this is a really awsome script lol! i leave for about 3 weeks and come back to some awsome advances in SCAR. reflection is awsome lol!
08-08-2008, 07:21 AM
Rsnerdx

I dont know wtf is up with this script seems to be good but for me

i run in draynor bank with a cage and all it does is this.

Welcome to Runescape.
(MY USERNAME)
Creating the NickTPA.
Fishing Level is 65535

help!!
08-08-2008, 07:39 AM
Narcle

Now we need a Catherby fisher for us member folks.[Reflection style] Faster fishing spot. :D

I'd make one, but I have enough projects atm.
08-08-2008, 08:20 AM
kingarabian

Quote:

Originally Posted by Rsnerdx

I dont know wtf is up with this script seems to be good but for me

i run in draynor bank with a cage and all it does is this.

Welcome to Runescape.
(MY USERNAME)
Creating the NickTPA.
Fishing Level is 65535

help!!

Update your reflection folder.
08-08-2008, 09:10 AM
ZephyrsFury

Quote:

Originally Posted by tarajunky

The hooks are up to date now in the Reflection svn.

The script works great. Too good, in my opinion. Watching it walk is almost painful, since it's so precise. It always seems to click the next spot just before your character would stop running, which is the most efficient way to do it, but seems bot-like to me. It also never clicks on the wrong kind of fishing spot. It always clicks the Cage/Harpoon one the first time, which no real player could do.

The only 'problem' was that it mistakenly thought it had stopped fishing a few times when the delay between lobs was long, which isn't a big deal.

Also, an autoresponder would be the icing on the cake. Good job!

Thanks tara.
Yea the walking is great, works well with R_FFlag which makes sure the char doesn't stop for a second or so.
The script always clicks on the Cage/Harpoon fishing spots cos the ID's for each type of fishing spot are different. I might change this when I have time. Also the script uses reflection to find the characters animation so unless the animation changes (he stops fishing) the script will continue to wait. Not sure why it thinks it stopped fishing when it hasn't unless the animations change randomly or something.
And with the autoresponder I don't think I'll be adding it in because as I said before this script isn't really supposed to be flawless with a lot of features. Its merely just a script for people to look at and learn from it. However now that reflection can detect other players it might be worthwhile making an autoresponder that uses reflection. :)

Quote:

Originally Posted by dushii

almost every time my chars is Lost - No Customs officer
is cause it couldnt talk to the officer

1 he finds him
2 clicks on him
3 coulndt reach him
4 Location: Lost - No Customs officer

maybe add a failsafe there ?

Yea I probably should add a failsafe. I'll see what I can do.

Quote:

Originally Posted by Luski14

Error I get.
Scar 3.15b, SRL Rev #20, and most updated Reflection

:( Was looking forward to this.

Reflection SVN was changed and that function was removed. I've uploaded a new version with the fix.

Thanks everyone for comments, suggestions, etc. :)
08-08-2008, 09:51 AM
the scar noob

Quote:

Originally Posted by ZephyrsFury

Thanks tara.
Yea the walking is great, works well with R_FFlag which makes sure the char doesn't stop for a second or so.
The script always clicks on the Cage/Harpoon fishing spots cos the ID's for each type of fishing spot are different. I might change this when I have time. Also the script uses reflection to find the characters animation so unless the animation changes (he stops fishing) the script will continue to wait. Not sure why it thinks it stopped fishing when it hasn't unless the animations change randomly or something.
And with the autoresponder I don't think I'll be adding it in because as I said before this script isn't really supposed to be flawless with a lot of features. Its merely just a script for people to look at and learn from it. However now that reflection can detect other players it might be worthwhile making an autoresponder that uses reflection. :)

Yea I probably should add a failsafe. I'll see what I can do.

Reflection SVN was changed and that function was removed. I've uploaded a new version with the fix.

Thanks everyone for comments, suggestions, etc. :)

You never said something about my comments:( I thought we were friends *sniff*:p

-Tsn.
08-08-2008, 10:39 AM
ZephyrsFury
Sorry who are you again??? :p
Quote:
Originally Posted by the scar noob

I love that you made your own type (TFishEquip), people should do that more, imo, it's easier to use by yourself if you understand it.
I love the way you load the paths
Fantastic Progress Report, fascinating!

SCAR Code:

function GetClosestTileInPath(Path: TPointArray): Integer;

Great idea! Now I see why you "converted" those tiles into tpoints:)
In that function:

SCAR Code:

Last := 1 shl 20;

I know that that's bitshifting and that's actually "1048576", but I don't understand why you use it. Especially in combination with this:

SCAR Code:

Dist := Distance(x, y, Path[II].x, Path[II].y);
if (Dist > Last) then [B]Continue[/B];

Is it ment to detect invalid tiles or so?

SCAR Code:

WalkMyPath

Just totally awesome!:)

SCAR Code:

function GetPlayerLoc: string;

nice idea of using the tiles to determine current player's loc!:)

SCAR Code:

function OpenTheBank: Boolean;

You even open the bank with reflection:p

SCAR Code:

function GetFishingGear: Boolean;

Good back-up you've got over there (the bank searching);)

SCAR Code:

function FindWhirlPool(ax, ay: Integer): Boolean;

SCAR Code:

Result := (WhirlPool[II].NPCType = 405);

Is that the ID of a whirlpool or so?

SCAR Code:

function Fishing: Boolean;

Haha, animation, fabulous!:p;)

SCAR Code:

function ClickFishingSpot(var ax, ay: Integer): Boolean;

Brilliant coding! Also the

SCAR Code:

if (FindWhirlPool(ax, ay)) then Continue;

part in the loop to check if the found spot became a whirlpool. If it is it'll check for the next spot, very nice:D

SCAR Code:

function CrossGangPlank: Boolean;

Again nice usage of reflection:)
<3 random path walking:)
<3 usage of player location

..and Zephyr did it again!! imo, this is the best karamja fisher/banker that's ever been made! (I hope it beats Nielsie's private one:p)

Thanks to your script, I realized how efficient reflection is, and I'll probably make a reflection script aswell:);)

Congratulations with this fantastic script!

Yource,

-Tsn.
You own... although a lot of the stuff you mentioned isn't that special. In fact I think the script is rather basic. Nielsie's should be a lot better than this :)

Thanks TSN. :D
08-08-2008, 10:45 AM
BobboHobbo

Yeah nielse should release his and have a battle of the Devolpers/Admin :)
08-08-2008, 03:08 PM
Luski14

Quote:

Originally Posted by ZephyrsFury

Reflection SVN was changed and that function was removed. I've uploaded a new version with the fix.

Thanks everyone for comments, suggestions, etc. :)

Thank you very much :)
BUT

Quote:

SRL Compiled in 2746 msec
MY USERNAME
Logged In Player is not in Players array.
MY USERNAME
Logged In Player is not in Players array.

Just does that over and over again. I set up lines 54-71 correctly. Only using one player though, is there an issue with that?

Quote:

Originally Posted by Luski14

Thank you very much :)
BUT

Just does that over and over again. I set up lines 54-71 correctly. Only using one player though, is there an issue with that?

SCAR Code:

T := GetSystemTime;
    while (not(FindColor(Tx, Ty, 0, 8, 458, 45, 470))) and (GetSystemTime - T < 5000) do
      Wait(100);
    if (FindColor(Tx, Ty, 0, 8, 458, 45, 470)) then
      if (not(FindTextTpa(0, 0, 7, 457, 137, 475, Players[CurrentPlayer].Nick, SmallChars, Nothing))) then      //Double check if logged in player is what we think it is
      begin
        WriteLn('Logged In Player is not in Players array.');
        LogOut;
        Wait(1000 + Random(1000));
        LoginPlayer;
        Exit;

delete those in your login.scar
the search button is your best friend

08-08-2008, 05:54 PM
Luski14

Quote:

Originally Posted by dushii

delete those in your login.scar
the search button is your best friend

My apologies. Figured that it was part of the script issue, not Scar since I can use other scripts, so I searched just this forum to receive no results.

Quote:

It is not my goal to have this script work flawlessly overnight or anything. I haven't spent much time on it and it has had limited testing.

I think it can...Once I got past all the errors it does run flawlessly. If all Reflection scripts work as well as this, we are in heaven. Least, for cheating we are. Now I will try and run it overnight and post proggies of as much as it does. If it is working when I wake up I'll stop it. If it works, I bow down.

Also: Does it prioritize? If I bring a harpoon, does it drop the tuna if it catches any to get a full load of just swordfish? If anyone has tested let me know, thanks! :)
08-08-2008, 08:04 PM
noob-2

Everytime it logs in i have a cage and coins and it always says ** Warning in ItemCoordinates: Invalid ItemType: 'bmp,'**
Location: Lost - No Fishing Gear
08-09-2008, 12:57 AM
tarajunky

Look at the first post for the way to fix that 'bmp,' problem

Quote:

[------------------------------------------------------------------------------------]
[ August 8th, 2008, 11:35:26 AM ]
[------------------------------------------------------------------------------------]
[ >>> Zephyr`s Karamja Fisher Ver 1.0 <<< ]
[------------------------------------------------------------------------------------]
[ Total Time Running: 2 Hours, 46 Minutes and 31 Seconds ]
[ Total Loads Done: 22 ]
[ Total Fish Caught: 438 ]
[ o Lobsters: 438 ]
[ Fishing Rate: 158 Fish/Hr ]
[ Total Fishing Exp Gained: 39420 ]
[ Experience Gain Rate: 14204 Exp/Hr ]
[ Fishing Levels Gained: 1 ]
[------------------------------------------------------------------------------------]
[ | Nick | Act | Loc | Lvl | Loads | Fish | Time ]
[ o | **** | F | Lost - Gang Plank Failed | 56 | 22 | 438 | 164 min ]
[------------------------------------------------------------------------------------]
08-09-2008, 01:20 AM
kingarabian

[------------------------------------------------------------------------------------]
[ August 8th, 2008, 03:17:39 PM ]
[------------------------------------------------------------------------------------]
[ >>> Zephyr`s Karamja Fisher Ver 1.0 <<< ]
[------------------------------------------------------------------------------------]
[ Total Time Running: 4 Hours, 5 Minutes and 9 Seconds ]
[ Total Loads Done: 22 ]
[ Total Fish Caught: 572 ]
[ o Lobsters: 572 ]
[ Fishing Rate: 140 Fish/Hr ]
[ Total Fishing Exp Gained: 51480 ]
[ Experience Gain Rate: 12600 Exp/Hr ]
[ Fishing Levels Gained: 1 ]
[------------------------------------------------------------------------------------]
[ | Nick | Act | Loc | Lvl | Loads | Fish | Time ]
[ o | azad| F | Lost - No Customs officer | 60 | 22 | 572 222min ]
[------------------------------------------------------------------------------------]

Best proggie so far I got =). Look at were it got lost ;).
08-09-2008, 01:45 AM
sjlou

one of my chars jus got stuck in a loop (tried to fish with no lob cage) for 1 hour+ :(
08-09-2008, 04:10 AM
tarajunky

One suggestion I have.

I logged into a character that was in a molly random, and after solving it the character was missing the lobster pot. When I tried to run the script, it detected it was still at the dock, saw that there was no pot, and logged out. Why not have it walk back to the bank and check there before automatically assuming there's some sort of error and logging out?

Show 40 post(s) from this thread on one page