[SRL] AK Smelter

Quote:

Originally Posted by popsmight

I got simba working but am having are error right after it withdraws all of the ore. This comes up.
The following DTMs were not freed: [SRL - Lamp bitmap]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, 2]
File[C:\Users\Owner\Documents\Simba\Includes\SRL\Logs\S RL Log 29-06-10 0.txt] has not been freed in the script, freeing it now.

Then it stops. Any ideas?

those aren't the errors that just happens after the script is prematurely ended sometimes. I need the Error to help you.

Sorry didn't see this part :P.

Item := TPAItem(172, 30, 28, 1317678);
Item := TPAItem(172, 30, 28, 1515038);
Error: divide by Zero at line 257

Here we go

Make sure you move the plugins first from the "place inside plugins folder" folder.

then do the same for the Simba folder inside that one. if it says to overwrite then do so because it's the simba compatable plugins.

here is a pic of what you need

http://i46.tinypic.com/2lve91i.jpg

Now I am getting this error :P...

[Error] C:\Users\Owner\Documents\Simba\Includes\SRL/SRL/Core/Text.scar(564:38): Unknown identifier 'UpChars' at line 563
Compiling failed.

Great work on your script here narcle, i only got one problem with it.

im smelting mithril, your script log ins, set up game, open bank withdraw 5 mith and 23 coal
it runs for smelting the ores and smelt 5 perfect bars.
- but when im going back to the bank, it opens bank - deposit 5 mithril bars - and then it withdraws 5 mithril ores, then depositing it again and doing it over and over again.
but when you deposit the last 3 coal ores and enable smart again it can take 5 more mithril bars. - maybe you wanna look at this?

PeaZzT

Quote:

Originally Posted by popsmight

Now I am getting this error :P...

[Error] C:\Users\Owner\Documents\Simba\Includes\SRL/SRL/Core/Text.scar(564:38): Unknown identifier 'UpChars' at line 563
Compiling failed.

What SRL revision are you using? make sure your using the open-dev version aswell. i forgot something earlier to you need to run a blank script in simba too. once its setup such as this

PHP Code:

Program new; begin end.

Quote:

Originally Posted by PeaZzT

Great work on your script here narcle, i only got one problem with it.

im smelting mithril, your script log ins, set up game, open bank withdraw 5 mith and 23 coal
it runs for smelting the ores and smelt 5 perfect bars.
- but when im going back to the bank, it opens bank - deposit 5 mithril bars - and then it withdraws 5 mithril ores, then depositing it again and doing it over and over again.
but when you deposit the last 3 coal ores and enable smart again it can take 5 more mithril bars. - maybe you wanna look at this?

PeaZzT

I've been going through the code for banking and I can't find the problem yet. But this did point me to a possible infinite loop if this occurs so I've added a failsafe ready for next update. I'll upload soon as I figured out the problem you stated.

btw what version are you using?

Edit:
Nvm I found it go to this line: Line ~814
SCAR Code:
if InRange(InvCount, WithDrawMain, WithDrawMain+1) then//+1 for Moulds
Change it to:
SCAR Code:
if (InvCount >= WithDrawMain) then
Tell me if it works.

It's working for me :). Here is a proggy report. It stopped because I had a jail random :(.

[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[ by Narcle ]
[=================================]
[ Run Time : 1 Hr 51 Min 37 Sec ]
[ Total Bars : 774 ]
[ Total XP : 13588 ]
[ Crafted : 0 ]
[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[=================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ]
[================================================== ====================]
[ | False | 02:11:28 | 87 | 774 | 13588 | 6223 | 0 ]
[================================================== ====================]

Quote:
Originally Posted by Narcle
I've been going through the code for banking and I can't find the problem yet. But this did point me to a possible infinite loop if this occurs so I've added a failsafe ready for next update. I'll upload soon as I figured out the problem you stated.

btw what version are you using?

Edit:
Nvm I found it go to this line: Line ~814
SCAR Code:
if InRange(InvCount, WithDrawMain, WithDrawMain+1) then//+1 for Moulds
Change it to:
SCAR Code:
if (InvCount >= WithDrawMain) then
Tell me if it works.
im using the last simba version - scar is not working for me :s - so im using simba - but i'll try this in a few hours, i'll let u know - thanks for the quick response (:

Quote:

Originally Posted by PeaZzT

im using the last simba version - scar is not working for me :s - so im using simba - but i'll try this in a few hours, i'll let u know - thanks for the quick response (:

it worked gr8 narcle, but now theres a new problem. it take about 2-3 runs and then i cant run ingame anymore. - it proberbly goes from bank to "cactus" sits there to rest so it can run again, but it dosen't continue running to the furnance it just continue sitting og the ground - it dosen't detect that i has 100% run and returning to the furnance.

hope u can fix this problem to narcle (:

Edit: it does continue just very slowly - maybe a fix where it detecs 100% run faster?
EDIT2: it does not continue, it sits until it logs out, then log back in and then it continues.
PeaZzT (:

Quote:

Originally Posted by popsmight

It's working for me :). Here is a proggy report. It stopped because I had a jail random :(.

[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[ by Narcle ]
[=================================]
[ Run Time : 1 Hr 51 Min 37 Sec ]
[ Total Bars : 774 ]
[ Total XP : 13588 ]
[ Crafted : 0 ]
[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[=================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ]
[================================================== ====================]
[ | False | 02:11:28 | 87 | 774 | 13588 | 6223 | 0 ]
[================================================== ====================]

That's good to hear glad I was able to help. nice proggy.

I'm still having one more small problem :P. Whenever I tell it to make cannonballs it tries to withdraw 9 of the steel bars (first slot in bank) and all of whatever is in my second slot. I have the cball mold in the 1 slot of my inventory. What am I doing wrong?

Quote:

Originally Posted by popsmight

I'm still having one more small problem :P. Whenever I tell it to make cannonballs it tries to withdraw 9 of the steel bars (first slot in bank) and all of whatever is in my second slot. I have the cball mold in the 1 slot of my inventory. What am I doing wrong?

'cballs' makes them from iron and coal.
'steel' makes steel bars from iron and coal.
'steeltoball' makes cballs from steel bars.

Quote:

Originally Posted by PeaZzT

it worked gr8 narcle, but now theres a new problem. it take about 2-3 runs and then i cant run ingame anymore. - it proberbly goes from bank to "cactus" sits there to rest so it can run again, but it dosen't continue running to the furnance it just continue sitting og the ground - it dosen't detect that i has 100% run and returning to the furnance.

hope u can fix this problem to narcle (:

Edit: it does continue just very slowly - maybe a fix where it detecs 100% run faster?
EDIT2: it does not continue, it sits until it logs out, then log back in and then it continues.
PeaZzT (:

The problem was in SRL not my script. I went and did extensive testing on the problem and fixed it. Update to latest SRL rev, should be 560 or higher rev.

Quote:

Originally Posted by Narcle

The problem was in SRL not my script. I went and did extensive testing on the problem and fixed it. Update to latest SRL rev, should be 560 or higher rev.

i installed simba yesterday and updated to the latest srl rev :s - i used srl.sex to update SRL - have i done anything wrong?

peazzt

Quote:

Originally Posted by PeaZzT

i installed simba yesterday and updated to the latest srl rev :s - i used srl.sex to update SRL - have i done anything wrong?

peazzt

I think he means that there was a bug in SRL when you tested it and that SRL has been updated since then. You haven't done anything wrong :)

Quote:

Originally Posted by -daazndagger-

I think he means that there was a bug in SRL when you tested it and that SRL has been updated since then. You haven't done anything wrong :)

so there have been an update from yesterday to today? :S im confused :S
i'll try to update srl again then :s

i updated SRL - it found an update :s

now it takes 1 run to smelt and back to bank and makes this error:

Error: divide by Zero at line 257
The following DTMs were not freed: [SRL - Lamp bitmap]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, 2]
File[C:\Simba\Includes\SRL\Logs\SRL Log 01-07-10 1.txt] has not been freed in the script, freeing it now.

EDIT: got it working again but i still have the problem that it sits to rest and dosent continue before it has logged out and in again :s

Another proggy :).

[================================]
[ Narcle'S AK Smelter 1.2.2 ]
[ by Narcle ]
[================================]
[ Run Time : 2 Hr 52 Min 0 Sec ]
[ Total Bars : 0 ]
[ Total XP : 28215 ]
[ Crafted : 4429 ]
[================================]
[ Narcle'S AK Smelter 1.2.2 ]
[================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ]
[================================================== ====================]
[ | False | 03:07:52 | 41 | 0 | 28215 | 9052 | 4429 ]
[================================================== ====================]

dont know what happend, but everything works now :s

thx for the help guys, i'll post a proggy when i have a good one :D

- PeaZzT!

[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[ by Narcle ]
[=================================]
[ Run Time : 2 Hr 20 Min 42 Sec ]
[ Total Bars : 595 ]
[ Total XP : 17850 ]
[ Crafted : 0 ]
[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[=================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ]
[================================================== ====================]
[ | False | 03:26:50 | 121 | 595 | 17850 | 5199 | 0 ]
[================================================== ====================]

Got a Super Proggy for you. Hope you like it :spot:

PHP Code:

[================================] [ NarcleS AK Smelter 1.2.2 ] [ by Narcle ] [================================] [ Run Time : 8 Hr 8 Min 25 Sec ] [ Total Bars : 1667 ] [ Total XP : 71886 ] [ Crafted : 6672 ] [================================] [ NarcleS AK Smelter 1.2.2 ] [================================] [======================================================================] [ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ] [======================================================================] [ | True | 08:06:31 | 193 | 1667 | 71886 | 8874 | 6672 ] [======================================================================]

Could you maybe add in random proggy to this also. I like to know how many randoms I get and how often.

Just to let you know, multiplayer gives me a divide by zero error in the Exp/hr calculation because the player will not have any time worked. Its line 257.

proggy for 1000 mithril bars - had to stop it cause i needed restart - h8 windows updates :D - love your script narcle <3

[================================]
[ Narcle'S AK Smelter 1.2.2 ]
[ by Narcle ]
[================================]
[ Run Time : 3 Hr 1 Min 45 Sec ]
[ Total Bars : 820 ]
[ Total XP : 24600 ]
[ Crafted : 0 ]
[================================]
[ Narcle'S AK Smelter 1.2.2 ]
[================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ]
[================================================== ====================]
[ | True | 03:01:27 | 165 | 820 | 24600 | 8154 | 0 ]
[================================================== ====================]

Quote:

Originally Posted by mormonman

Just to let you know, multiplayer gives me a divide by zero error in the Exp/hr calculation because the player will not have any time worked. Its line 257.

I thought about that, but that doesn't make any sense because it only does one person.
SCAR Code:
With Players[CurrentPlayer] do   
  begin
    Integers[12] := integers[12] + MyVars[0];//XP
    IncEx(TotalXP, MyVars[0]);
    Integers[13] := round( (Integers[12]*60)/(PlayerWorked(CurrentPlayer)/60000));//XP Per hour
  end;
Only one person... not all of them.

Quote:
Originally Posted by Narcle
I thought about that, but that doesn't make any sense because it only does one person.
SCAR Code:
With Players[CurrentPlayer] do   
  begin
    Integers[12] := integers[12] + MyVars[0];//XP
    IncEx(TotalXP, MyVars[0]);
    Integers[13] := round( (Integers[12]*60)/(PlayerWorked(CurrentPlayer)/60000));//XP Per hour
  end;
Only one person... not all of them.
i also have it sometimes - but i just play script again and then it works :s

Quote:
Originally Posted by Narcle
I thought about that, but that doesn't make any sense because it only does one person.
SCAR Code:
With Players[CurrentPlayer] do   
  begin
    Integers[12] := integers[12] + MyVars[0];//XP
    IncEx(TotalXP, MyVars[0]);
    Integers[13] := round( (Integers[12]*60)/(PlayerWorked(CurrentPlayer)/60000));//XP Per hour
  end;
Only one person... not all of them.
Well somehow I get that about 13-20 minutes in everytime I run the script.

[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[ by Narcle ]
[=================================]
[ Run Time : 4 Hr 40 Min 45 Sec ]
[ Total Bars : 1899 ]
[ Total XP : 33338 ]
[ Crafted : 0 ]
[=================================]
[ Narcle'S AK Smelter 1.2.2 ]
[=================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ]
[================================================== ====================]
[ | False | 06:22:54 | 212 | 1899 | 33338 | 5236 | 0 ]
[================================================== ====================]

Quote:

Originally Posted by mormonman

Well somehow I get that about 13-20 minutes in everytime I run the script.

Hmm, well just add a Try/Except there

Code:

try Integers[13] := round( (Integers[12]*60)/(PlayerWorked(CurrentPlayer)/60000)); Except Integers[13] := 404;//so you know its a error end;

Nice PeaZzT :thumbsup:

I just commented it out.

Code:

[=================================] [ Narcle'S AK Smelter 1.2.2 ] [ by Narcle ] [=================================] [ Run Time : 12 Hr 27 Min 2 Sec ] [ Total Bars : 3906 ] [ Total XP : 24273 ] [ Crafted : 0 ] [=================================] [ Narcle'S AK Smelter 1.2.2 ] [=================================] [======================================================================] [ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ] [======================================================================] [ | False | 03:51:15 | 141 | 1974 | 12267 | 0 | 0 ] [ | True | 08:30:40 | 139 | 1932 | 12006 | 0 | 0 ] [======================================================================]

Edit: new proggy stopped manually

Code:

[==================================] [ Narcle'S AK Smelter 1.2.2 ] [ by Narcle ] [==================================] [ Run Time : 15 Hr 35 Min 52 Sec ] [ Total Bars : 7038 ] [ Total XP : 123556 ] [ Crafted : 0 ] [==================================] [ Narcle'S AK Smelter 1.2.2 ] [==================================] [======================================================================] [ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ] [======================================================================] [ | True | 07:51:27 | 402 | 3609 | 63358 | 0 | 0 ] [ | True | 07:38:08 | 382 | 3429 | 60198 | 0 | 0 ] [======================================================================]

I just run it as the first script I'd ran in 6 months. How dissapointed was I that it failed so quick :(

Code:

[============================] [ Narcle'S AK Smelter 1.2.2 ] [ by Narcle ] [============================] [ Run Time : 12 Min 40 Sec ] [ Total Bars : 0 ] [ Total XP : 3000 ] [ Crafted : 0 ] [============================] [ Narcle'S AK Smelter 1.2.2 ] [============================] [=====================================================================] [ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ] [=====================================================================] [ | True | 00:12:19 | 9 | 0 | 3000 | 15000 | 150 ] [=====================================================================]

It failed when it was at bank. It didn't give any debug box indications, but the simba console was chock full with "Warning in native method: JNI call made with exception pending" statements.

post some of the errors, they might be simple things to fix, but we can't really help you if you don't tell us what it says. As far as failing so quick I run this every morning for a few hours. Had it go for 11 hours last week on the same revision your using.

I just posted everything I had, sorry chap if it wasn't enough to help :)

Quote:

Originally Posted by Cigue

I just posted everything I had, sorry chap if it wasn't enough to help :)

Its something in SRL, I've had it happen in almost every script I've ran randomly. I believe its in LoginPlayer but still haven't found/confirmed it.

Well I've got it to work anyway. Thanks Narcle, your script truly is great ^^

Code:

[=================================] [ Narcle'S AK Smelter 1.2.2 ] [=================================] [======================================================================] [ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ] [======================================================================] [ | True | 01:18:39 | 54 | 0 | 20140 | 15492 | 1007 ] [======================================================================]

EDIT : Failed again. I found my char in the kebab place, with log as following :

Code:

Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Couldn't find the bank. Exiting Banking failed, is now inactive. NextPlayer

Quote:

Originally Posted by Cigue

Well I've got it to work anyway. Thanks Narcle, your script truly is great ^^

Code:

[=================================] [ Narcle'S AK Smelter 1.2.2 ] [=================================] [======================================================================] [ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ] [======================================================================] [ | True | 01:18:39 | 54 | 0 | 20140 | 15492 | 1007 ] [======================================================================]

EDIT : Failed again. I found my char in the kebab place, with log as following :

Code:

Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Couldn't find the bank. Exiting Banking failed, is now inactive. NextPlayer

looks like a random fail - i have runned this script alot and i havent got that error :s

Glad to see you added crafting to this script! (even though I'm still only going to use it for cannon balls.. :p) Please tell me making cannon balls still works! ;)

Just realized JaGeX is doing free membs for a week! Need to make some money on my F2P PKers lol...

Will have many proggies for you soon..

You should change line 215 to

if ((GetTimeRunning/1000) < 120) then

Quote:

Originally Posted by Cigue

You should change line 215 to

if ((GetTimeRunning/1000) < 120) then

Won't be needed in next update. Been using it myself and tweaking the script.

Quote:

Originally Posted by Narcle

Won't be needed in next update. Been using it myself and tweaking the script.

Yay updates! :p

PHP Code:

[======================================================================] [ Nick | Active | Worked | Banked | Bars | XP | XP/Hour | Crafted ] [======================================================================] [ | True | 01:01:03 | 39 | 0 | 25400 | 24983 | 1016 ] [======================================================================]

Still flawless! :)