Line 608:
if FindTextTpaEx(2070783, 0, MCX1, MCY1, MCX2, MCY2, T.x, T.y, 'annonb',statchars, Nothing) then
On that line change 'annonb' to something in Cannonball, maybe 'onba' or 'nno' something with less text.
Printable View
Alright, changed it to just 'nno' but when it starts making them, it doesn't wait for it to be done. It start walking back to the bank immediately.
I looked through the code a little and it looked good as long as it hits that 'Continue;' it shouldn't increment C, but for some reason it probably does.
ooooh. it uses BaseItem < 1 and the base item are ore? So that would make it increment...
edit:
So
Needs like a 'or iCount(steel bars) > 0' ? But I looked at the iCount function and couldn't figure out the whole TTPItem and all that.Code:if CannonBall then
if ( iCount(BaseItem) > 0 ) then
Continue;
Thanks narcle for such a quick ifx :) Works perfectly. Will post proggie at end of day.
Progress Report:[=====================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [=====================================================================] [ Tast | False | 02:18:56 | 59 | 531 | 0 | 9322 | 4026 ] [=====================================================================]
Thanks for the update. One thing I've noticed is that it sometimes fails after banking the items- it doesn't take out the new coal/iron and just closes bank, log outs and switches to the next player.
The other thing is that it get's my nick wrong (if that matters for something) since the auto detect because my log-in name is different from my in-game name.
Narcle hit me up when you want a members account.. :)
Update 1.2.7
Cannonballs fixed and tested (thanks to Naike for letting me borrow account)
I'll test crafting this weekend.
Every half an our or so, I get the message "ran out of secondary, player set to inactive", when this is not true.. (i had 6000 coal ores). All it needs is a restart and it runs. Any help?
Btw I am smelting steel bars, with iron in first and coal in second.
I had this happen a couple times too. Seems like there is something up with the text reading once in a while.
This however gives me an idea how to hopefully avoid this: If it successfully reads it the first time I'll start recording it and after it banks calculate if its really gone or not from the previous record. This system should completely fix it and make it more reliable.
Good thinking :) looking forward to next update!
Just a quick proggie, I have got similar results about five times because it no longer detects secondary:
Progress Report:Ran out of secondary, ****** is now inactive. NextPlayer SwitchToPlayer(PlayerNo: 0, Active: False); 1 2 4 Player is not Active... All players not active! [===========================] [ Narcle'S AK Smelter 1.2.7 ] [ by Narcle ] [===========================] [ Run Time : 7 Min 18 Sec ] [ Total Bars : 54 ] [ Crafted : 0 ] [ Total XP : 948 ] [===========================] [ Narcle'S AK Smelter 1.2.7 ] [===========================] [====================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [====================================================================] [ **** | False | 00:14:32 | 6 | 54 | 0 | 948 | 3913 ] [====================================================================]
And again :)
Progress Report:Ran out of secondary, ******* is now inactive. NextPlayer SwitchToPlayer(PlayerNo: 0, Active: False); 1 2 4 Player is not Active... All players not active! [============================] [ Narcle'S AK Smelter 1.2.7 ] [ by Narcle ] [============================] [ Run Time : 14 Min 10 Sec ] [ Total Bars : 90 ] [ Crafted : 0 ] [ Total XP : 1580 ] [============================] [ Narcle'S AK Smelter 1.2.7 ] [============================] [=====================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [=====================================================================] [ **** | False | 00:27:54 | 10 | 90 | 0 | 1580 | 3398 ] [=====================================================================] NextPlayer
Progress Report:Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now. Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now. Banking failed,
Ive got this error twice now once after about an hour and once after about 4
Updated ver. 1.3.0
- Now has a Form [can be disabled]
- Setup has changed per player via setup array
- Added bank counting failsafe (records current amount and determines if you still have ore/bars in bank etc.)
I hope to add:
- DDTMs for all the items in the future so there is less work involved for setup.
- Make the form better gradually.
Progress Report:[=================================] [ Narcle'S AK Smelter 1.3.0 ] [ by Narcle ] [=================================] [ Run Time : 3 Hr 39 Min 42 Sec ] [ Total Bars : 0 ] [ Crafted : 3011 ] [ Total XP : 90330 ] [=================================] [ Narcle'S AK Smelter 1.3.0 ] [=================================] [======================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [======================================================================] [ Smid | True | 03:33:18 | 113 | 0 | 3011 | 90330 | 25408 ] [======================================================================]
Ran perfectly until I stopped it manualy :)
good script helped get rid of some MSI Mining ores.
Progress Report by bobzilla69:[============================] [ Narcle'S AK Smelter 1.3.0 ] [ by Narcle ] [============================] [ Run Time : 27 Min 44 Sec ] [ Total Bars : 266 ] [ Crafted : 0 ] [ Total XP : 1653 ] [============================] [ Narcle'S AK Smelter 1.3.0 ] [============================] [=====================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [=====================================================================] [ Ques | True | 00:26:37 | 19 | 266 | 0 | 1653 | 3727 ] [=====================================================================]
only problem it left 14 copper ores in bank and said it was out or secondary ore
Its a failsafe, I use the amount required +1 left to withdraw, because I don't currently use static DTMs or Bitmaps so if it withdraws those last 14 another item will take its place then there might be a chance that the item that fills the spot can be withdrawn when its not ores or bars.
ahhh, i see well, its a great script i loved it, will be using again once i get more ores.
edit:
Progress Report by bobzilla69:[===========================] [ Narcle'S AK Smelter 1.3.0 ] [ by Narcle ] [===========================] [ Run Time : 38 Min 0 Sec ] [ Total Bars : 246 ] [ Crafted : 0 ] [ Total XP : 4318 ] [===========================] [ Narcle'S AK Smelter 1.3.0 ] [===========================] [=====================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [=====================================================================] [ Ques | True | 00:36:24 | 28 | 246 | 0 | 4318 | 7115 ] [=====================================================================]
Progress Report:[==================================] [ Narcle'S AK Smelter 1.3.0 ] [ by Narcle ] [==================================] [ Run Time : 22 Hr 53 Min 27 Sec ] [ Total Bars : 5257 ] [ Crafted : 21033 ] [ Total XP : 226666 ]
Before that I had made a 8 hour run but had to stop for something and forgot the proggy, made a little under 32k cballs :D
[================================================== ==============]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[================================================== ==============]
[ ???? | True | 06:04:15 | 167 | 1494 | 5977 | 64414 | 10610 ]
[================================================== ==============]
Works fantastic, many thanks again.
EDIT:
[=================================]
[ Narcle'S AK Smelter 1.3.0 ]
[=================================]
[================================================== ===========]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[================================================== ===========]
[????? | True | 13:14:48 | 375 | 3357 | 13430 | 144736 | 10926 ]
[================================================== ===========]
Both times stopped manually btw.
The bot is still running :)
[=================================]
[ Narcle'S AK Smelter 1.3.0 ]
[=================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[================================================== ====================]
[ Supr | True | 05:56:50 | 293 | 2628 | 0 | 46136 | 7758 ]
[================================================== ====================]
Glad its working well! Thanks for proggies :)
went from 60 to 70 in less then 2days
and with my other account from 40 to 82 but that took a bit more time xp
the program only fails when a small lag happens when walking from furnace to cactus and then for some reason click on hides shop
Maybe u could add a fails safe when he cant find the spot he needs to searches for bank , furnace or cactus? so it run back to re-find his poss ?
huh, has problems trying to withdraw some coal when making steel bars, the cursor just sits on it after right clicking it.
Stuck at bank, doesn't do anything. Then again, I'm a noob.
SMART Initialized.
Loaded: Server 1, Members: True, Signed: True, Super Detail: False.
Player 0: Settings array set wrong, setting to defaults.
Player 0 create string not setup correctly, please fix.
Thanks for using my AK Smelter!
Please post proggies on forums!
-Narcle
Successfully executed.
Post your player array but edit out the name and pass.
~BraK
[================================]
[ Narcle'S AK Smelter 1.3.0 ]
[ by Narcle ]
[================================]
[ Run Time : 3 Hr 3 Min 54 Sec ]
[ Total Bars : 1298 ]
[ Crafted : 0 ]
[ Total XP : 22786 ]
[================================]
[ Narcle'S AK Smelter 1.3.0 ]
[================================]
[================================================== ====================]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[================================================== ====================]
[ Sir | True | 03:03:01 | 146 | 1298 | 0 | 22786 | 7470 ]
[================================================== ====================]
Doing cannon balls from bars. :)PHP Code:
[=================================]
[ Narcle'S AK Smelter 1.3.0 ]
[ by Narcle ]
[=================================]
[ Run Time : 2 Hr 15 Min 21 Sec ]
[ Total Bars : 0 ]
[ Crafted : 4133 ]
[ Total XP : 26329 ]
[=================================]
[ Narcle'S AK Smelter 1.3.0 ]
[=================================]
[======================================================================]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[======================================================================]
[ Merc | True | 02:15:01 | 40 | 0 | 4133 | 26329 | 11700 ]
[======================================================================]
almost running for 4 hours! will update with a proggy when the script finishes (if it does) which I hope it doesn't haha. I am also doing cannon balls from bars :)
completely amazing :) loved it! and I have 11k steel bars to make into cannonballs :)PHP Code:[==================================]
[ Narcle'S AK Smelter 1.3.0 ]
[ by Narcle ]
[==================================]
[ Run Time : 15 Hr 30 Min 37 Sec ]
[ Total Bars : 0 ]
[ Crafted : 25800 ]
[ Total XP : 164356 ]
[==================================]
[ Narcle'S AK Smelter 1.3.0 ]
[==================================]
[=======================================================================]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[=======================================================================]
[ Tell | True | 15:29:05 | 240 | 0 | 25800 | 164356 | 10614 ]
[=======================================================================]
EDIT: sorry I forgot to edit my last post :/
How'd you get it to run for 15 hours? Pretty much anything I use in Simba usually breaks due to a random after about 2.5 hours or so.
Also, my proggie so far:
Progress Report:[=================================] [ Narcle'S AK Smelter 1.3.0 ] [ by Narcle ] [=================================] [ Run Time : 1 Hr 21 Min 46 Sec ] [ Total Bars : 615 ] [ Crafted : 0 ] [ Total XP : 10797 ] [=================================] [ Narcle'S AK Smelter 1.3.0 ] [=================================] [======================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [======================================================================] [ **** | True | 01:21:32 | 71 | 615 | 0 | 10797 | 7944 ] [======================================================================]
Still running, just copied that from the output box. I'd also like to note that once in a while it will return to the bank before completing all of the smithing, ex it will smith 2 or 3 bars then return to the bank. Has only happened once or twice so far.
Smithing only 2/3 bars? Times I've seen this happen is when the screen flickers and it doesn't read the inventory correctly. It shouldn't happen after the first run but I've found no definite fix for this yet. There could be another reason but when it happens so rarely its hard to pinpoint.
I updated first post, I went through every page and added a change log (from my posts). I also found a proggie I missed by nose_smasher, check it out on first page it has a crazy run time.
Thanks for the proggies all, glad your enjoying the new version.
Is the form setup okay any suggestions on it?
Oh I'm hoping to add SRL stats soon once its up and running better. :)
oh I can't wait for stats :) I might have to buy another 20-30k steel bars then :) haha
I think the form setup is pretty good and simple :) just every time I start it again there is a tab open for a blank character which I have to delete :/ and it wont let me save after I delete that, other than the setup is super :) <3
Failed freaky forester random :( but the script is flawless :)PHP Code:[==================================]
[ Narcle'S AK Smelter 1.3.0 ]
[ by Narcle ]
[==================================]
[ Run Time : 12 Hr 57 Min 22 Sec ]
[ Total Bars : 0 ]
[ Crafted : 20844 ]
[ Total XP : 132785 ]
[==================================]
[ Narcle'S AK Smelter 1.3.0 ]
[==================================]
[=======================================================================]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[=======================================================================]
[ Tell | True | 12:55:13 | 193 | 0 | 20844 | 132785 | 10277 ]
[=======================================================================]
Possible Random: Freaky Forester. Identifying by textbox.
EDIT:
PHP Code:[=================================]
[ Narcle'S AK Smelter 1.3.0 ]
[ by Narcle ]
[=================================]
[ Run Time : 6 Hr 35 Min 47 Sec ]
[ Total Bars : 0 ]
[ Crafted : 10996 ]
[ Total XP : 70049 ]
[=================================]
[ Narcle'S AK Smelter 1.3.0 ]
[=================================]
[======================================================================]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[======================================================================]
[ Tell | True | 06:34:14 | 102 | 0 | 10996 | 70049 | 10661 ]
[======================================================================]
Still works flawless I see :D I just need to control myself this time so i dont get banned lol... I used this script 24/7 LAST YEAR tryin to get 99 smithing lol and got the BanHammer :( (100% my fault, not the script - in case any nubs were wondering...) *Got to 96 before they got me ;)SCAR Code:[=================================]
[ NarcleS AK Smelter 1.3.0 ]
[ by Narcle ]
[=================================]
[ Run Time : 5 Hr 30 Min 40 Sec ]
[ Total Bars : 1332 ]
[ Crafted : 5328 ]
[ Total XP : 57424 ]
[=================================]
[ NarcleS AK Smelter 1.3.0 ]
[=================================]
[======================================================================]
[ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ]
[======================================================================]
[ **** | True | 05:29:58 | 149 | 1332 | 5328 | 57424 | 10442 ]
[======================================================================]
Great job though! :)
wow, thanks for the warning :o no more 15 hour reports for me then :) hehehe <3Quote:
Still works flawless I see :D I just need to control myself this time so i dont get banned lol... I used this script 24/7 last year tryin to get 99 smithing lol and got the BanHammer :( (100% my fault, not the script - in case any nubs were wondering...) *Got to 96 before they got me ;)
Great job though! :)
check the first post - it was prolly the 58 hour one that did it... im sure 15 hours is ok... and I ran this script 24/7 that prolly did it too... (meaning as soon as I found out the script stopped I restarted it)
@Narcle - will the script smelt gold ore into bars and then immediately craft? First page sounds like it EITHER smelts ores or crafts bars...
I suggest adding the new SRL stats :) unless you already have, which means I will start using this script again to get from 75 smithing to 80 :)
AFTER I am done with fishing and possibly cooking haha
Progress Report:[============================] [ Narcle'S AK Smelter 1.3.0 ] [ by Narcle ] [============================] [ Run Time : 38 Min 47 Sec ] [ Total Bars : 279 ] [ Crafted : 0 ] [ Total XP : 4898 ] [============================] [ Narcle'S AK Smelter 1.3.0 ] [============================] [=====================================================================] [ Nick | Active | Worked | Banked | Bars | Crafted | XP | XP/Hour ] [=====================================================================] [ **** | True | 00:38:25 | 32 | 279 | 0 | 4898 | 7648 ] [=====================================================================] SwitchToPlayer(PlayerNo: 0, Active: False); Player is not Active... All players not active!
It stopped right outside the bank? But it seems great, just got unlucky i bet =)