SuperBatManS SuperAlcher

Heres my first program. It is an alcher. Has quite a bit of features for a first program (i think). AntiRandoms, antiban, randomtalk(talks magic only),AutoBuy(will buy more alch sets if you wish(read in the consts, you can set the item, and the price of both the alch item and nats.)
I got about 900alchs/hour minimum and 1050 alchs max. it counts how many youve alched, how much xp youve gotten, how many alchs bought, and has magic xp goals. Will prob add a timer soon, antilost (incase antirandoms fail), maybe smart(if i can find out wtf SMART is), and mybe autoflechter

Critisizm is HIGHLY welcomed. I see that as a way to make me better.

(sorry for bad writing and grammar, i broke my right index finger and it shard to type.)

It looks really nice for a first script. I don't have an account to test this on or I would. I can try to offer you some help from just looking it over though...

Your buyyews procedure should be BuyYews (just for cosmetics), same with buynats.

Your BuyYews procedure does not have failsafes for the first bit of that. I would recommend that you add some. You have some later on in the procedure.

Quote:

---

Line 50: [Error] (16256:1): Semicolon (';') expected in script

---

Can be fixed by adding a semicolon on the line above after your string.

Quote:

---

Line 182: [Error] (16388:29): Type mismatch in script

---

AlchItem is a string and as thus does not need IntToStr

After those changes it compiles nicely.

Quote:

---

Critisizm is HIGHLY welcomed. I see that as a way to make me better.

---

Awesome attitude. You will make it far here.

SCAR Code:

until(x=999999999999)

No, bad. Make sure you add some fail safes onto that. Basically that is an endless loop. Try setting a constant asking them how many times they want to alch if they don't want to buy. Maybe cut down on some of the constants. Capitalize your variables.

SCAR Code:

MagicLvl=72;         //Input magy lvl;

Should be able to be replaced with GetLevel('Magic'...); (don't know the exact way, should be an easy search)

Do all of the GE colors/coords change so much that you have to input them every time? If not try to cut down on those. The chatbox coords shouldn't change much either and so you shouldn't need them as constants.

Again, it looks pretty good. Just some small changes.

To much of it is preset coordinate clicking. Add some failsafes. Make it use colors to find it.

But for a first script, it looks really good! Better then a lot of scripts I've seen as firsts. Read up on some tuts. If you still need some help, feel free to post in the help section or private message me.

~Sandstorm

Nice info Aser.
I agree with Sandstorm, change it up a little... add a few DTM's/DDTM's or something...

:D nice for a first,

use ChooseOption instead of clicking a coord,

use GameTab instead of looking for the colors,

and some other things that were already said..

but again, a lot better than my first script :p

keep it up ^^

lolz, thanks all. yah know what, i kinda noticed a few semicolons missing, but for sum reason, it still comiled for me. I think one of the main things i needa do is look into srl more, cause there is obviously more avalable isin SLR. I dunno if anyone noticed, but i didnt use until false at the end of my main loop, because for some reason, it would only do 4 alchs then stop.

cord clicking fails.

/Captain Obvious.

~Sandstorm

Quote:

---

Originally Posted by Sandstorm

To much of it is preset coordinate clicking. Add some failsafes. Make it use colors to find it.


~Sandstorm

---

/captain obvious

Quote:

---

Originally Posted by jakeyboy29

/captain obvious

---

I stated that because no-one else had? There were like four people who did before you.

Not gonna argue with you though.

~Sandstorm

Chord clicking? It is working fine for me... Is that the tabs? Im going to look into SRL for some tabs, and other stuff....

I just Tryed To add some SRL, i changed out all the BTMTabs with GameTab(7); which i thought was supposed to go to the magic tab, but for me it does nothing.
The BTMTab that i wrote myself works for me, but u guys r saying it isnt working.

Oh, I have a question. I never drag the cross hair to the rs game tab because "canvis doesnt alow drawing of box" on FindColorTolerance functions.
I attacted the new code that uses GameTab, if anyone would try it out, id b thankful.

If you included srl (you use Mouse, so I guess you did :P) you can go through the gametabs like this:

GameTab(Tab Number);

Where the tabs are set up like this:

1 2 3 4 5 6 7 8
9 10 11 12 13

Something like that.

~Sandstorm

coords not chords :P

coords as in co-ordinates.. it works fine, it just is VERY bannable..

SandStorm, read my edit please. 99, a bit more specific please, i will try to make it as ban free as posibble.

I'm not sure. Are you using the regular client? If so, try it in Firefox or Swiftkit.

~Sandstorm

im using firefox.
Im Redownloading Scar, cause my script stopped working altogether

your FindMoveNotes won't work for everyone, you have a certain color for it, and a const color too, but it won't change it in the proc..

and the gametab error is because you call it in the wrong place..

Instead of (FindColorTolerance(blahblah)) just do GameTab(7);

should work :)

I did that look up a few posts of mine. I found Out why it wasnt working for me, it was because i wasnt setting the RS game tab to client. I never set the rs tab to client because when i do, findcolortolerance() wont work, i get returned :
[Runtime Error] : Exception: Canvas does not allow drawing in line 238 in script C:\Documents and Settings\Admin\Desktop\Alcher.scar

Lolz, well i couldnt find anything on the Runtime error, but i did find something quite interesting. I found that in global.scar it has all the endpoint for the mainscreen, chat screen, inv screen and minimap. Im suprised nobody told me that because that was like half of my Consts. oh well..... lolz

Oo, and i got gametab() up now so thats a bit better. I changed many of the coords to findcolortolerances, so that should be better too.. Im gonna go change out my custom consts for the global.scar coords, ill post my new code in a bit.


OMG OMG OMG, i just found heaven.......
In Scar, go to the help tab and then the SRL manual tab. It is a full on library.... omg... heaven.... omg.... lolz, that is what took away all my consts(well.... some of them.) Now there should Be no problem with you guys running this im not even using coords to cast the spelll or choose inv item. It takes alot of the work out of it(which was kinda fun, and takes a little self pride out of it) but ow well....

if you want work, make it flawless :D

fail safes, extreme anti ban, be able to tele to somewhere and alch there to mix it up.. :)

make it able to start anywhere :D

you can do a lot more advance stuff to it

If you add this:

SCAR Code:

{.include srl/srl/skill/Magic.scar}

you can use this:

SCAR Code:

Cast('high level alchemy');

to cast your spells.

yeah, i probably will in the future. Im expecting a temp ban to come any day now, lolz. I still have to find out my runtime errror though. =(

senarth, already done =0. Thanks though =)

you still need help with that runtime? >.>

do you have gmail?

nvm.. I added you..

add me? :D

if you want to add smart to your script

Find this line:



{.Include SRL\SRL.SCAR}

Change it to:


{.Include SRL\SRL\Misc\SMART.SCAR}
{.Include SRL\SRL.SCAR}

Hit CTRL+F.

Type in SetUpSRL;

Find this line:


SetUpSRL;

Change it to:

SMARTSetUp(SmartPrefix, True, True, False);
SetTargetDC(SMARTGetDC);
SetUpSRL;


and if it dont work


change:

Smartsetup(SmartPrefix, true, true, false);
Settargetdc(smartgetdc);


for :

SMARTSetupEx(2, True, True, False);
Wait(5000);
SetTargetDC(SmartGetDC);
repeat
wait(100);
until(SmartGetColor(253, 233)<>1118604);

I have No idea what smart does, can you explain a bit? Anyway, im having other problems with my script. When i try to ad SRL/SRL/SKill/Magic.scar as an include it returns 'identifier expected'. Heres my new version, it should work, there may be some silly errors in it, but seeing as i cant compile it i cnat find errors or test it.

Ive Re-Downloaded SRL/SCAR 5 times and it still wont work.