Thanks for feedback all! Script Updated! Should work now with latest SCAR 3.22 pre-release and latest Dev SRL (262 atm)
Big credits to Marpis for his Fighting Functions, should fix the spam clicking on roaches...
Printable View
Thanks for feedback all! Script Updated! Should work now with latest SCAR 3.22 pre-release and latest Dev SRL (262 atm)
Big credits to Marpis for his Fighting Functions, should fix the spam clicking on roaches...
Looks good. I will give it a try :D
Looks good. But I can't run the script for more than 1 hour :( always terminates because of one thing or another. finding the crevice is really not that good. As it keeps moving the pointer from my char to the tree repeatedly till finally clicking the hole. But its a really good script :D Got me some nice cash....ran it only a few hours and got 500+ laws, 100 nats, 500 mitril ores, 100 addy ores, 10 rune scimmys and 5 rune square shield not to mention the amount of exp i got :D You rock! Here is the longest proggy I could get:
PHP Code:Nose Smasher's Roach Smasher
/~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~\
| |
| Total Roaches Killed --> 105 |
| |
| Total EXP Gained ---> 32448 |
| |
| Time Running ---> 1 Hours, 35 Minutes and 34 Seconds |
| |
| Player Active Banked Killed XP-Gained PickUps XP/Hour |
| # 0 True 2 105 32448 77 20493 |
| |
| |
\--------------------------------------------------------------------------/
Nose Smasher's Roach Smasher
/~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~\
| |
| Total Roaches Killed --> 310 |
| |
| Total EXP Gained ---> 56608 |
| |
| Time Running ---> 3 Hours, 6 Minutes and 25 Seconds |
| |
| Player Active Banked Killed XP-Gained PickUps XP/Hour |
| # 0 True 4 310 56608 123 18261 |
| |
| |
\--------------------------------------------------------------------------/
smart frozen :O
Here is a long (for me anyway) proggy :D
PHP Code:Nose Smasher's Roach Smasher
/~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~\
| |
| Total Roaches Killed --> 290 |
| |
| Total EXP Gained ---> -1544849 |
| |
| Time Running ---> 4 Hours, 19 Minutes and 49 Seconds |
| |
| Player Active Banked Killed XP-Gained PickUps XP/Hour |
| # 0 True 5 290 -1544849 212 -357880 |
| |
| |
\--------------------------------------------------------------------------/
nice proggies guys :)
I'm running on a membs account atm... pick-ups go crazy because of charms and mushrooms lol... So as of right now, I would use caution when using this script with a membs account (or jus add colors for charms and other membs only drops yourself...)
Another thing I noticed was food gets missed on slow comps or if its laggy... otherwise it works, but I might add a few failsafes for food later...
Lastly, I was thinking of adding a failsafe to see if roach is in fight, if so then to not att it unless there are no more roaches on the screen because when there is another person down there with you and they att first, you hp bar doesn't show up and it spam clicks roaches...
Just some ideas... lemme know if there's anything else that could use improvement or anything like that...
When I was using it last time(before you came back) the biggest problem I was experiencing was the spam clicking the attacked roaches(by others) - what you said-, so I would give that the biggest priority.
yea that was the main thing I was concerned about... I'll see what I can do
i am still having the same error, i have the latest pre-release scar and the latest dev-svn, i have no clue as to why..... i have tried watching it and it can happen after 2-3 or after the first kill, but after it kills a roach it pickups the drop and it crashes when it tries to attack again, i cant see why u will try to debug a few procedures but atm im stuck as to what causes thisQuote:
have the latest version of this script, scar 3.21 and scar alpha and the latest dev SRL but when i run this script it all goes fine runs to the cockroachs kills one then goes to pick up and scar closes/crashes, i have no idea why anyone else got this? or a fix?
is anyone else getting this?
EDIT: maybe a bug in FindColorsSpiralTolerance? i cant see what else could cause it tho =[
Nose Smasher's Roach Smasher
/~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~\
| |
| Total Roaches Killed --> 366 |
| |
| Total EXP Gained ---> 39672 |
| |
| Time Running ---> 3 Hours, 42 Minutes and 44 Seconds |
| |
| Player Active Banked Killed XP-Gained PickUps XP/Hour |
| # 0 True 4 366 39672 55 10722 |
| |
| |
\--------------------------------------------------------------------------/
also i got something you need to do....
before breaks do item checks you might have that but it isn't picking items up before breaks... i came in my room and notices it was on break so i waited for it to come back to see what he had and right after i logged in some guy was thanking me for a rune scimmy i didn't pick up so i watched it and it sometimes picks before breaks but sometimes it doesn't... or just misses
gothguydante - how did he get the skimmy? I though Jagex made it so anything dropped thats worth more than 1k it does not show up for anyone but the one who got the drop... anywayz, I do have a failsafe, but sometimes the pickup itself doesn't work 100% of the time...
Mind adding my name in very small font for credits, was my idea after all XD!
thats what i thought but i have gotten items over 1k that they didn't pick up if i helped kill it... oh and i love this script just wish it would allow stuff to stay in innovatory i don't have any room for death runes so it will keep clicking to bank them so i have to pause it and drop or run to the ge to sell them... but if i had room for them this wouldn't be a problem just wish it would hold onto them till it was done then i could take alot to the ge instead of like 30 every run... and you are a great script writer.....
Lol ty... and I will Ultra lol...
nose_smasher, have you heard of my problem?
Hey There,
looks like some nice work, I haven't tried it yet, but a couple of suggestions... try changing the distance the that is acceptable to find hit point bars, to closer around your character (you have <50, experiment with a smaller number?) this may help alleviate "spam clicks"..... Also, there was an "issue" in leaving your SRL ID and P/W in a script...EVERYONE here should register for their own, and you should make it it that your script stops and directs them where to register if they don't have their own...I know we are having issues with script stats and it is hosted from a different site atm, but when these are resolved,don't be surprised if your Stats are reset...it's one thing to sign up for an SRL ID account as a test account, but to put your own in there in hopes other people will add to your own stats is unacceptable...please search for posts concerning this, as I'm sure you don't want to jeopardize your status at these forums.
Best of Luck,
~RAM
Sorry RAM, I forgot all about the stats lol... Yea I think someone told me bout how we can't set ours in there... I'll take it out ;)
Where do i get scar 3.22 beta, i cant find it on http://freddy1990.com/scar.php
never mind got it
aww its broken won't find bank any fixes coming soon?
Once again, I'm impressed.
your impressed with a script that hasn't been updated for three months? I'm confused.Quote:
Originally Posted by The Man
Anyone find any other problems besides it not finding the bank?
And what are you impressed with The Man? :p
It finds the Bank booth but it doesn't click any of the options, just keeps right clicking every bank booth.
Its outdated...Look at the first postQuote:
Originally Posted by bi a op
Updated on October 2009...
I know... on almost every post you make me look like a dumbass noob, but I do update SRL bfore sreaming for help, I do read the first post before screaming for help...Quote:
Originally Posted by FEAR
Read last post by nose_smasher, according to that post, the only thing that didn't work was opening bank, and I thought it wouldn't be too hard to fix.
Thanks to NCDS I got it working.
Stopped manuallyCode:Nose Smasher's Roach Smasher
/~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~\
| |
| Total Roaches Killed --> 293 |
| |
| Total EXP Gained ---> 85748 |
| |
| Time Running ---> 4 Hours, 4 Minutes and 46 Seconds |
| |
| Player Active Banked Killed XP-Gained PickUps XP/Hour |
| # 0 True 5 293 85748 212 21617 |
| |
| |
\--------------------------------------------------------------------------/
Did you change anything to get it working? Or does this still work?
Possible update coming soon...
Haha, you know what?Quote:
Originally Posted by nose_smasher
I have no idea :p
Sorry >.<
Yes.Quote:
Originally Posted by nose_smasher
SCAR Code:function OpenEbBankFast: Boolean; //Edited version of OpenBankFast
var
x, y, i, l, c, z, fail: Integer;
Info: TIntegerArray;
Booths, t: TPointArray;
begin
Wait(400);
Info := [(MSCX + 25), MSCY, 3230295, 9, 2];
MakeCompass('n');
SetAngle(true);
z := GetColorToleranceSpeed;
ColorToleranceSpeed(Info[4]);
FindColorsSpiralTolerance(Info[0], Info[1], Booths, Info[2], MSCX-25, MSY1, MSX2, MSY2, Info[3]);
ColorToleranceSpeed(z);
SetArrayLength(t, 0);
t := Booths;
SetArrayLength(Booths, 0);
Booths := ReArrangeAndShortenArray(t, 14);
l := GetArrayLength(Booths) -1;
for i := 0 to l do
begin
if (not LoggedIn) or BankScreen or PinScreen then
Break;
MMouse(Booths[i].X, Booths[i].Y, 3, 3);
Wait(75 + Random(75));
if IsUpTextMultiCustom(['ooth', 'ank', 'anker']) Then
begin
GetMousePos(x, y);
Mouse(x, y, 0, 0, False);
Wait(70 + Random(75));
if WaitOptionMulti(['uickly', 'ui', 'ck', 'ly', 'ic', 'kl'], 3000) then // the 3000 means wait 3 seconds maximum
begin
MarkTime(c);
repeat
Wait(100);
until (BankScreen) or (PinScreen) or (TimeFromMark(c) > 3000);
fail:= getcolor(260, 180);
if (fail = 0) then MouseBox(126, 138, 388, 152, 1);
if (Length(Players) > 0) then
if (Players[CurrentPlayer].Pin <> '') then
InPin(Players[CurrentPlayer].Pin);
end;
end;
end;
Result := (BankScreen) or (PinScreen);
end;
http://villavu.com/forum/showpost.php?p=688216&postcount=4
Line 204: [Error] (22292:37): Invalid number of parameters in script
help would be appreciated
Sorry script is outdated, might be a quick easy fix, might be something a lil more serious, but I'm actually just running out the door, so I'll edit in the fix if no one else has by the time I get home...Quote:
Originally Posted by zenith22
If you don't know what that error means here's an example:
SCAR Code:{WRONG/Error causing way:}
WriteLn('Hello', WTF, 37); // <---- Too Many Parameters....
{Correct way of using WriteLn}
WriteLn('Hello');
Hmm, banking works now with the fix I posted, but can't find roach. I'm not able to fix this, I'll wait for the next version, take your time :D
Another thing, item finding is a bit slow, and when it rotates the screen over and over again, it might look at little bottish, but thats just me :P
Yea I never like how much it moved the screen but I've never been banned from this script (and I've abused it a LOT) but I'd like to fix that as well.. :p
@ Zenith22: So I found out that Freddy (Creator of SCAR) changed the function "rs_GetUpTextAt" but it's all good, jus wait til update comes...
EDIT: Got it working again... Too tired to make any l33t changes, but everything should work perfect again...
Re Download...
Wee, thanks. You're a beast. This is currently my favourite script, *hint hint* Because there is no flawless Herb cleaner + unf potions maker! (yet...) *hint hint*Quote:
Originally Posted by nose_smasher
If you lend me a membs acc with herbs and vials I could give it a shot...Quote:
Originally Posted by bi a op
Meanwhile, forgot about the bug where players get lost north of edgy bank.. I'll try and come up with a quick fix, but no worries it's not serious..
will run for a bit now. give u a proggie in few hrs doin on my zerker pure:P
Updated 1 March? So you don't have the lobby thing and HP update (If needed)?
Added charms pickup? Pl0x :D:D
Quote:
Originally Posted by bi a op
Those updates were taken care of in SRL... If the script doesn't work someone let me know because I don't use this script actively...
Charms:
Quote:
Originally Posted by Nose_Smasher
Ok, thanks :) I'll give it a go. But it is a little slow on picking up noted items, is it because of the color, should I try to add my own color?Quote:
Originally Posted by nose_smasher
yea most likely because all the colors i got were from like last year or something lol...
Try adding your own colors for now... I'm currently working on a dark wizard killer and I'm playing around with the PickUp function, if I can come up with a better way of picking up items I'll add it to this script.. :p