ChooseOptionMulti + WizzyPlugin

In the last few months I have been getting lots of run times errors from WizzyPlugin in ChooseoptionMulti ( In different spots ).
So today I switched to 3.2d, and I got this Run time error [Runtime Error] : Exception: Access violation at address 04C0DACD in module 'WizzyPlugin.dll'. Write of address 41412F9A in line 587 in script C:\Program Files\SCAR 3.20\includes\SRL/SRL/Core/Text.scar on this line TPA := ReturnPointsNotInTPA(TPA, B);
Thats one of many.
I told Wizzup on teh IRC, and he told me to post here.

Works fine for me.. :o using 3.20d + dev rev..

I get the same error! But I get it for almost everything in WizzyPlugin... FindColorsTolerance returns me with an error too.

I've got it once now.

http://www.villavu.com/forum/showpos...postcount=2001
http://www.villavu.com/forum/showpos...postcount=1938
- http://www.villavu.com/forum/showpos...postcount=1949 (same person)
- http://www.villavu.com/forum/showpos...postcount=1950 (same person)
http://www.villavu.com/forum/showpos...postcount=1944

I got it again last night. Same error. (After 4 hours with my Guild Miner)
/me checks out those links

Edit: Zytex, I'm not getting out of Memory Errors. 4/5 of those are out of memory. (I got Out Of Memory when I was using ForeFeathers as well)

Tbh, I think this is a scar problem, not an SRL one.

By looking at the code, I think you might get an error in ReturnPointsNotInTPA if there are duplicate points in your TPA or when points fall out of the box.

So maybe a ClearDoubleTPA before calling it?

Quote:

---

Originally Posted by nielsie95

By looking at the code, I think you might get an error in ReturnPointsNotInTPA if there are duplicate points in your TPA or when points fall out of the box.

---

I wrote the function mainly for Quiz Master, I don't think I added any error checking. Most likely ChooseOptionMulti isn't using is correctly, or forgot some failsafe / check.

i have never got any errors from wizzyplugin :)

~shut

So, Freddy, take a look at this?

Quote:

---

Originally Posted by noidea

So, Freddy, take a look at this?

---

As Wizzup said, it might be in the plugin. I guess I will take a look at it later.

Try adding a ClearDoubleTPA before it..

Yes i'v had same Error ( We discussed about this in IRC ) :) But itäs cool i know that you guys will handle it (;

~Home

Quote:

---

Originally Posted by nielsie95

Try adding a ClearDoubleTPA before it..

---

I'd rather use a different solution, that would slow it down would it not?

Slow > Run Time Error
...

Quote:

---

Originally Posted by noidea

Slow > Run Time Error
...

---

Seems like there should be a faster solution though.. Doesn't it?

Quote:

---

Originally Posted by Nava2

I'd rather use a different solution, that would slow it down would it not?

---

Lol. Probably not. But you can use it to see if it's really the problem.

Quote:

---

Originally Posted by Nava2

I'd rather use a different solution, that would slow it down would it not?

---

It shouldn't slow it down too much really, unless you use *huge* TPA's.
I could rewrite it this evening...

EDIT: It would be nice if you can check if this is indeed the problem.

EDIT2: I took a look at the function, and this should fix it:

pascal Code:

8,9d7
<   SetLength(Result, ((Box.X2 - Box.X1 + 1) * (Box.Y2 - Box.Y1 + 1)) - Length(TotalTPA));
< 
11d8
< 
14a12
>   SetLength(Result, Length(TotalTPA);  
24a23
>   SetLength(Result, I);

Note that will still error if you pass an invalid (too small) TBox.

Full code...

pascal Code:

Function ReturnPointsNotInTPA(Const TotalTPA: TPointArray; Box: TBox): TPointArray;

Var
   X, Y, I: Integer;
   B: Array Of Array Of Boolean;

Begin
  SetLength(B, Box.X2 - Box.X1 + 1, Box.Y2 - Box.Y1 + 1);
  For I := 0 To High(TotalTPA) Do
    B[TotalTPA[I].X - Box.X1][TotalTPA[I].Y - Box.Y1] := True;

  SetLength(Result, Length(TotalTPA);  
  I := 0;
  For X := 0 To Box.X2 - Box.X1 Do
    For Y := 0 To Box.Y2 - Box.Y1 Do
      If Not B[X][Y] Then
      Begin
          Result[I].X := X + Box.X1;
          Result[I].Y := Y + Box.Y1;
        I := I + 1;
      End;
  SetLength(B, 0);
  SetLength(Result, I);
End;

So.. can you like give us the 'updated' dll or something? I don't know anything about that :S

Any gain on this?
I saw Shut's thread.

I think Nava is adding it.

Shuts problem may or may not be related, although the problem does appear to exist in the same module.

From what i can gather this issue was/is an intermittent problem.

The current issue that shuttle highlighted and I for one experience was introduced in Open Dev 44 and is repeatable every time when any parameter of any ChooseOption routine is run.

Okay, so I have been playing with the ReturnPointsNotInTPA and I cannot seem to fix it.

Anyone else have any solutions? Here is what is in there:

pascal Code:

Function ReturnPointsNotInTPA(Const TotalTPA: TPointArray; const Box: TBox): TPointArray;
var
  x, y, w, h, i, l: integer;
  B: Array of Array of Boolean;
begin;
  w := Box.x2 - Box.x1;
  h := Box.y2 - Box.y1;
  if (w = 0) and (h = 0) then
    Exit;
  SetLength(b, w + 1, h + 1);
  l := High(TotalTPA);
  x := 0;
  for i := 0 to l do
    if ((TotalTPA[i].x >= Box.x1) and (TotalTPA[i].x <= Box.x2) and
        (TotalTPA[i].y >= Box.y1) and (TotalTPA[i].y <= Box.y2)) then
    begin;
      Inc(x);
      B[TotalTPA[i].x-Box.x1][TotalTPA[i].y-Box.y1] := True;
    end;
  if x = 0 then
    Exit;
  SetLength(result,(w + 1) * (h + 1) - x);
  i := 0;
  for x := 0 to w do
    for y := 0 to h do
      if not B[x][y] then
      begin;
        Result[i].x := x + Box.x1;
        Result[i].y := y + Box.y1;
        Inc(i);
      end;
  SetLength(b,0);
end;

What is the purpose of the function exactly...? I don't get why your making it so complicated if its just to return all the TPAs that are do not match point from the TBox..? Unless i'm not understanding what your trying to do exactly...



~NS