{$Define SMART} and {$Define REFLECTION}

I think these should be put into SRL.scar:

SCAR Code:

{$IfDef SMART}
{.include srl/srl/misc/smart.scar}
{$EndIf}

{$IfDef REFLECTION}
{.include SRL/SRL/reflection/reflection.scar}
{$EndIf}

var
  World: integer;
  Signed, Members, HighDetail: boolean;

I think this should be put into SetupSRL;

SCAR Code:

{$IfDef SMART}
  SmartSetupEx(World, Members, Signed, HighDetail);
  SetTargetDC(SmartGetDC);
  repeat
   wait(100);
  until(SmartGetColor(253, 233)<>1118604); 
{$EndIf}

Then just {.include srl/srl.scar} would be enough.
You could make script use SMART just by writing {$Define SMART} and reflection by writing {$Define REFLECTION}

edit: btw, [ scar] tags don't recognize preprocessor commands, fix that immediately! ;)

Good idea for the S.M.A.R.T part, don't think reflection will be added tho.

Quote:

---

Originally Posted by N1ke!

Good idea for the S.M.A.R.T part, don't think reflection will be added tho.

---

+1
I don;t agree with adding reflection though.

why not reflection?

Quote:

---

Originally Posted by marpis

why not reflection?

---

Not every one appreciates Reflection. While ALMOST every one uses SMART.

Quote:

---

Originally Posted by noidea

Not every one appreciates Reflection. While ALMOST every one uses SMART.

---

not every one appreciates olives and still they are sold in all stores? your argument has no logic.

S.M.A.R.T is default with SRL so it would be a good idea, but some people aren't away of reflection straight away, and there may be a mass of posts asking why they get errors with SRL, so perhaps not the best idea.

you could just do this...

setupsrl(true,false);

true for smart false for reflection, unless your script uses it them make both booleans true

Quote:

---

Originally Posted by Richard

S.M.A.R.T is default with SRL so it would be a good idea, but some people aren't away of reflection straight away, and there may be a mass of posts asking why they get errors with SRL, so perhaps not the best idea.

---

Thats what I meant. I guess I worded it wrong -.-

Quote:

---

Originally Posted by rogue poser

you could just do this...

setupsrl(true,false);

true for smart false for reflection, unless your script uses it them make both booleans true

---

Not possible, since SMART and Reflection are includes.

@noidea's topic: I think thats a pretty good idea... It can be like this:

Scripters Side:

SCAR Code:

{$DEFINE SMART}
{$DEFINE REFLECTION}
{.include SRL/SRL.scar}

SRL.scar:

SCAR Code:

{$IFDEF SMART}
  {.include SRL/SRL/misc/Smart.scar}
{$ENDIF}

{... all of SRL's include files...}

// At the very end:
{$IFDEF REFLECTION}
  {.include SRL/SRL/reflection/reflection.scar}
{$ENDIF}

So I don't see why not?



~NS

If you want to do {$DEFINE Reflection} Then I could probably add it into the reflection files. It will NOT go into SRL though.

I think the SMART one could though.

Wait lol I just realized... There is not point really of using {$DEFINE Reflection} since it is simply just a one liner to include the reflection file itself? - Besides it looking better. SMART should be enough IMO.



~NS

Quote:

---

Originally Posted by Nadeem

Not possible, since SMART and Reflection are includes.

---

how is it not possible, when you setup srl it loads a bunch of includes, you could use another file as a buffer to only load the includes specified... humor me for a second

lets pretend i made a new file setSRL.scar

i make this

Code:

---

procedure setSRLup(isSmart,isReflection:boolean)
begin

if(isSmart)
  setupSmart

if(isReflection)
  setupReflection

setupSrl

 
end;

---

and there were 2 more files, one setupReflection one setupSmart

it would be a bit more convenient, but then again, why waste cpu cycles

edit: then again that wouldnt really help as it would be the same as declaring smart or reflection and just not calling it

Quote:

---

Originally Posted by rogue poser

how is it not possible, when you setup srl it loads a bunch of includes, you could use another file as a buffer to only load the includes specified... humor me for a second

lets pretend i made a new file setSRL.scar

i make this

Code:

---

procedure setSRLup(isSmart,isReflection:boolean)
begin

if(isSmart)
  setupSmart

if(isReflection)
  setupReflection

setupSrl

 
end;

---

and there were 2 more files, one setupReflection one setupSmart

it would be a bit more convenient, but then again, why waste cpu cycles

edit: then again that wouldnt really help as it would be the same as declaring smart or reflection and just not calling it

---

It wouldn't work because SMART.scar overrides some of SCAR's mouse and keyboard functions when it compiles. It doesn't matter if SetupReflection or SetupSmart is called it will still be overridden.

Quote:

---

Originally Posted by ZephyrsFury

It wouldn't work because SMART.scar overrides some of SCAR's mouse and keyboard functions when it compiles. It doesn't matter if SetupReflection or SetupSmart is called it will still be overridden.

---

Exactly, because either way, the SMART and Reflection file's would have to be included for that loading function to work. {$DEFINE} = much better.



~NS

I have added {$DEFINE SMART} at the top of Smart.scar, so it is now easier to use in your scripts.

Just include smart, if people do not wish to use it they can just comment it out, and then in your scripts do something of the like:

SCAR Code:

{$IFDEF SMART}
Procedure SetupSmart;
begin

  SmartSetupEx(100, False, True, False);
  Wait(5000);
  SetTargetDC(SmartGetDC);
  repeat
    wait(100);
  until(RSReady);

end;
{$ENDIF}

~RM