I don't understand how this could have come up. Does the script login fine?Quote:
Originally Posted by SOmesand
Printable View
I don't understand how this could have come up. Does the script login fine?Quote:
Originally Posted by SOmesand
I'm not exactly sure how to setup the declare players correctly. I looked at the tutorial on here, and the format in the script is different. It won't login. I start it logged in.Quote:
Originally Posted by Coh3n
How would I setup this correctly?
Players.Setup(['Player''s Nickname/Login Name/Display Name'], 'PlayerFileName');
CurrentPlayer := 0;
I get the filename part, but the filling in of the names and everything boggles my mind...
Players.Setup(['myemail@gmail.com'], 'PlayerFile');Quote:
Originally Posted by SOmesand
Where "myemail@gmail.com" is the username you use to login. It has to match the login name you entered into Rafiki (SRL > Player Manager).
Seems to be working, but why does it click on the same tree every 1/2 seconds, even if it is chopping it?
I was finally able to get it to work!!!!! The script works great. keep up the good work!
Because it uses pixel shifting to determine if the player is still chopping or not. Your character could be wearing clothing that moves a lot, or a tree could be completely blocking your player. It is recommended that you mess with the ANIMATION_SHIFT constant to find a value that works well for your player.Quote:
Originally Posted by Godless
Script works. After a few loads, it goes to the trees and then it can't find them even though it is right next to them. Not sure if it's my client, or the script.
That likely has something to do with the colors in the script. I'll have to update them when I get time.Quote:
Originally Posted by SOmesand
Oh alright. I really enjoy this script even if it is a bit buggy. I've already increased my woodcutting level 20 levels and haven't been banned yet!
My apologies, I'll give it a fiddle and see how we go.Quote:
Originally Posted by Coh3n
Coh3n, I changed the color myself and it works like a charm now. 10 hours and no bugs!
Not a problem. I think it will be a little buggy no matter what you set it to since there's a chance the tree will completely cover the player. It will still work, though, it just might click the tree a few times.Quote:
Originally Posted by Godless
Glad to hear it! It might be the easiest solution for users to set their own colors as it's hard to find the right combination that works for everyone.Quote:
Originally Posted by SOmesand
I changed the colour and it finds the trees better now. However no matter what I change the animation shift too it just keeps spam clicking and/or running south and spamming the debug box about a fishing spot.
EDIT: Changing camera angle once and moving north fixes the fishing spot issue. Can't seem to get it to stop clicking constantly and switching between trees. It is working and getting full loads and banking, just a little slowly and a bit bot like.
Coh3n, I think you might find this interesting. The following snippet is made by @bonsai, all credit goes to him. It searches for individual colours and if you play with the split and filterBetween lines, you could adjust it to your script. Just run the script when you're near the trees. Unfortunately, I don't have the knowledge to implement it in your script and I also don't have that much time so I'm afraid someone else has to do it.
So in case someone is interested...
How it looks like:
http://i.imgur.com/khlkbPq.jpg?1
Simba Code:program willow
{$DEFINE SMART}
{$include_once srl-6/srl.simba}
const
colList = [2504767,2902350,
2574671,2769735,2901835,2703172,
2570554,2967374,2505279,3033166,
3231315,2502959,3032907,2439229,
2637124,2702917,2504765,2571071,
2437944,2372407,2504250,2438973,
2637121,2570557,2571075,2637634,
2571841,2703428,2571329,2504764,
2702915,2570556,2768707,2637377,
2572353,2572355,2373174,2636863,
2570297,2636091,2504507,2572098,
2570303,2571584,2504760,2571324,
2504504,2505017];
var
cdata: T2DColorData;
i: integer;
tpa: TPointArray;
atpa: T2DPointArray;
begin
smartEnableDrawing := true;
setupSRL();
setLength(cdata, length(colList));
for i := 0 to high(cdata) do
with cdata[i] do
begin
color := colList[i];
tolerance := 0;
settings := colorSetting(0);
end;
while (true) do
begin
cdata.gatherIn(tpa, mainscreen.getBounds());
atpa := tpa.split(20);
atpa.filterBetween(0, 40);
atpa.filterBetween(400, maxint);
smartImage.debugATPA(atpa);
for i := 0 to high(atpa) do
writeln('len atpa[', i, '] is ', length(atpa[i]));
sleep(1000);
smartImage.clear();
end;
end.
Is there a way I can change the script so that instead of stopping, it waits for more trees? I found that when it stops, it thinks its lost because it can't find trees but this occurs when I'm cutting them and others are too.
There isn't a lot I can do about the spam clicking right now, but I'll try to think of something. It should never click south while it's cutting. Could you post the debug of when this happens?Quote:
Originally Posted by Godless
That is interesting. If I have time today or tomorrow I'll look into it. Definitely looks better than what I'm using.Quote:
Originally Posted by Spaceblow
What? It's supposed to wait if it can't find any trees. I guess I'll look into that as well.Quote:
Originally Posted by SOmesand
Just so everyone is aware, this script was written in 2008, back before RS3 and the new style of trees. The object finding method I use now is the same as I used back then but with different colors. I guess it's about time for a decent update, since a lot of people seem to be using this script.
I'll do my best to come up with something this week.
Alright. It stops the script after not being able to find any trees, but what I did was add multiple colors to the color list and mess with that for awhile. Learning more and more as I read the tutorials and stuff around here.
Can you post the debug of when this happens?Quote:
Originally Posted by SOmesand
I get this:
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
[00:00:39]: -- TRSMinimap._getSymbolColor()
[00:00:39]: ---- Loaded symbol: Fishing Spot
[00:00:39]: ---- Found symbol bitmap 42
[00:00:39]: -- TRSMinimap._getSymbolColor(): -1
then it says script executed. Prints a progress report, and then stops. Stated reason for stopping: Lost.
Although I'm right next to the trees.
Using ACA, I believe I found a color that works really well with the trees.
I've been using this (Starting at line 235)
Color := 2966076;
Hue := 1.03;
Sat := 1.00;
Exp := 67.5;
Tol := 8;
Okay. I'm going to completely remove the symbol finding since it's broken at the moment.Quote:
Originally Posted by SOmesand
Thanks, I'll add that to the next version until I have time to check out another object method.Quote:
Originally Posted by SOmesand
I've uploaded a new version. List of changes can be found here. Setup instructions have changed -- make sure your player starts in the bank and make sure your camera is zoomed all the way out. I also recommend not wearing any clothing while chopping.
The new colors may still not work sometimes, but the screen will now rotate if trees aren't found, which in most cases fixes the issue. Here's a progress report (I just wanted it do a few loads):
Progress Report:/====================================================| | Coh3n's Draynor Chop N' Bank! | | - Revision 82 - | |====================================================| | 13 Minutes and 1 Seconds | |----------------------------------------------------| | Player: 0 | | Location: Willows | | Active: True | | Tree Type: Willow | | Loads Done: 4 | | Logs Cut: 108 | | Logs P/H: 497 | | Experience: 7,290 | | Exp P/H: 33,571 | | Breaks: 0 | |____________________________________________________| |____________________________________________________/
Enjoy,
Coh3n
I did try to but when I went to copy and paste it disappeared for some strange reason. If it comes up again I'll screenshot it. Taking a bit of a break from Woodcutting though.Quote:
Originally Posted by Coh3n
Wow, for a script that old it's stood the test of time fairly well!
I'll run it over night and get back to you.Quote:
Originally Posted by Coh3n
I think, that the colors change on different worlds.... I have been on three different worlds and I have had to use different colors 3 times. Interesting. I have ~7000 logs in my bank at the moment. Rev. 82 really made the difference. I would advise any new users to use ACA if the script doesn't find any trees. It is most likely a color issue.
Glad it's working (other than the colors, obviously). :)Quote:
Originally Posted by SOmesand
After adding my own colours it seems a lot more stable. After the update I haven't ran in to the fishing spot error. The only problem I can see now is the clicking one. Thanks for your continued updates and support. I am sure I am not the only person who is thankful. :)
I agree with Godless. After adding user defined colors, it is stable. Coh3n, you should include a link to ACA and a small guide to setting it up with the trees so that way anyone who uses the script knows how to use it properly. I have 12000 logs in my bank now and my alt account hasn't gotten banned. I'm now WC 73, and I'm gonna attempt to pull a 99 in RS3!
Also, is there a way to set this script up to cut oak logs near dray nor?
No, there is not. It used to have that functionality, but it was removed when the new tree graphics were released.Quote:
Originally Posted by SOmesand
I plan to train my wc a bit, i'll try to update the colors. How many world samples should i take? and what part of the tree should i take colors from. Green only or all over?Quote:
Originally Posted by SOmesand
AFAIK the leaves of the tree aren't actually clickable, so the trunk is what you're after. The more colors you can get the better, 30, 40+ etc and from multiple worlds. It's a good idea to save your .aca file so you can add to it later if need be.Quote:
Originally Posted by tulpiuka
Hm, alright. I'm glad that we can cut willows though. I do notice that sometimes it finds the same color over and over and when it can't click it, it keeps trying anyways.... You should set it to automatically rotate the camera every x amount of seconds or something...Quote:
Originally Posted by Coh3n
Alright, I'll add that to my list.Quote:
Originally Posted by SOmesand
Sounds good.Quote:
Originally Posted by Coh3n
I've been really power using the script lately.... I have around 20000 willows in my bank now and it's so great because I'm gonna use them in a firemaking script to burn them, and then bank the ashes.
Ashes currently sell for 451 Gp. Assume we sell 20000 ashes.....
To be perfectly honest I got lucky with this script. I didn't have to use ACA. I just selected a darker brown from the top of the Willow, left the hue and other settings as they were and it ran. For 6hrs. You might not be as lucky, so don't blame me if it doesn't work. :PQuote:
Originally Posted by tulpiuka
9m. You could have made 90m in that time and then burned 15m worth of Yews with DXP coming up. But oh well...Quote:
Originally Posted by SOmesand
Should I be in legacy mode while running this script?
No.Quote:
Originally Posted by ochovg
I followed the setup guide and when I run the script:
/================================================== ==|
| Coh3n's Draynor Chop N' Bank! |
| - Revision 82 - |
|================================================= ===|
| 5 Seconds |
|----------------------------------------------------|
|_________________________________________________ ___|
|_________________________________________________ ___/
/================================================== =====================================|
| Coh3n's Draynor Chop N' Bank! |
| - Revision 82 - |
|================================================= ======================================|
| Ran for: 5 Seconds |
|?????? ???????? ???????????? ??????? ???????? ?????????? ???????? ???????????? ????????|
| Nick | Active | Location | Loads | Tree | Logs Cut | Levels | Experience | Breaks |
|?????? ???????? ???????????? ??????? ???????? ?????????? ???????? ???????????? ????????|
|????????????????????????????????????????????????? ??????????????????????????????????????|
| Totals: | 0 | | 0 | N/A | 0 | 0 |
|_________________________________________________ ______________________________________|
|_________________________________________________ ______________________________________/
[0:00:05]: -- Succesfully freed SMART[14740]
[0:00:05]: Successfully executed.