TIme to get back to my "job" as a woodcutter.
Expect a proggie soon.
Printable View
TIme to get back to my "job" as a woodcutter.
Expect a proggie soon.
Okay awesome, I really hope it works well for you. Bare in mind that the walking isn't perfect. To be honest, it is really hard, what with the crazy minimap updates.Quote:
Originally Posted by xSaintias
i know what you mean... i may not be a srl member but i do actually script little scripts like talking and burying bones....Quote:
Originally Posted by Coh3n
(just never bother to submit for membership :D)
and this updates got me like omg...
every time i make it find a road color it finds the wrong one...
it really pisses me off...
EDIT: watch out because even if the script doesnt make it to wiilows and you are still in the bank, it wil still say arrived at willows and go to trying to locate and chop. You might want to check on that.
UPDATE: they upodated runescape...
not sure what they updated...
script doesn't seem to be affected though.
Lol you said a lot of things there that are jumbled, and I didn't get much out of it. Is it working fine? Or is the walking seriously messed up?Quote:
Originally Posted by xSaintias
He's saying that sometimes it doesn't make it to the trees, but it thinks that it has and carries on trying to find and chop the trees. Also, that Runescape updated, and he doesn't know whether or not it will affect the script.Quote:
Originally Posted by Coh3n
Richard
Lol, alright R1ch, thanks. :)Quote:
Originally Posted by R1ch
way to make sense of my mumbo jumbo lol.Quote:
Originally Posted by R1ch
sry bought that coh3n.
anyways, its working fine... untill it got that random where you have to choose the odd appendix out. not sure whats its called but yeah..
other than that its doing great.
Okay that's good to hear, and the Randoms is in SRL, not the script, just so you know. :p I'm glad you're using it.Quote:
Originally Posted by xSaintias
Coh3n
I'm using it too right now, I have a couple suggestions.
It rotates the camera when it's cutting, and it will think that the willow disappeared.
It doesn't wait to stop moving before it tries clicking a willow, and it will sometimes missclick when it left clicks.
1. I'm guessing that's it stores the point it clicked the tree in "TP". In then checked a 20 x 20 box (I think) for the tree color. Because of this, if the camera angle moves, the coordinates may move to somewhere that doesn't have a tree. You can simply erase the camera movement in my Antiban if you wish to get rid of this.Quote:
Originally Posted by 3Garrett3
2. The tree cut down detection isn't perfect, and to be honest, I don't think can be. It's going to fail once in a while. When you say "Left Clicks", do you mean it's left clicking the Willows to chop them? Because that's not suppose to happen I don't think. That could be one of the "RandomRClick" Antiban procedures. In which case it could randomly right click a Willow and move away.
I hope that clears a bit up. If these become a bigger problem than it's worth, I can try to make them better, I'm just not exactly sure how at this point in time.
Thanks,
Coh3n
1- I think I will.Quote:
Originally Posted by Coh3n
2- No, I meant that it left clicks (single click to chop) on the *tree* but since it is moving, it misses the tree. If it is supposed to right click, followed by a chooseoption, you have accidentally made it left click on every tree. I propose a simple Flag; before looking for the tree to make sure that you aren't moving. :)
The first one isnt really a problem, it just looks botty to rotate the cam and then find a new tree every time :\
The second one is more of a problem. I've noticed it clicks the tree, starts walking, loses the TPoint stored (understandable) but then tries clicking while it is moving, and misses the tree, then walks next to the tree and stands there, waiting for your failsafe to click a new one (I'm assuming you have a timeout somewhere)
But both have a simple fix. Thanks for the prompt response. I hope you continue to improve the script :)
Lol, when you said left click, I was thinking right click. :duh: You are right about the rotating camera, I think I'm going to take that out, thanks. :)Quote:
Originally Posted by 3Garrett3
As for the second one, yes, I've noticed that when I test, and it really bugs me, I just never thought of a way to fix it. A simple "Flag" check is perfect (I think). I have to go to hockey right now, but I should be able to upload another version later tonight.
Thanks very much for your awesome feedback. :D
Coh3n
You play hockey too? I think we should get married.Quote:
Originally Posted by Coh3n
I hope that the flag check will help. If not, it can't be too complicated.
I'm okay with running the version right now, I will leave it on. I will hand out a proggy when it finishes too :).
Okay awesome! And yeah I do. Google Cohen Adair, I feel special having my name on there. :pQuote:
Originally Posted by 3Garrett3
http://www.successforlife.ca/node/29/
Is that you? Damn you're hot :p
Yes it is, and thank-you. :pQuote:
Originally Posted by 3Garrett3
Wow I didn't know they put that on the website. :o I thought that was just in the Course Calendar for my school.
EDIT: I'm working on an update right now.
EDIT2: Script updated!
Check out the first post for a list of the updates.
[================================================== ===============]
[ Coh3n's Draynor Chop N' Bank ]
[============================= V.1.3 =============================]
[ ]
[ Ran For: 42 Minutes and 4 Seconds ]
[ Loads Done: 8 ]
[ Logs Chopped: 224 ]
[ Levels Gained: 4 ]
[ Exp Gained: 15120 ]
[ Breaks: 0 ]
[ AntiBan: 33 ]
[ ]
[================================================== ===============]
[ Thank-you for using Coh3n's Draynor Chop N' Bank! ]
[================================================== ===============]
[ Be sure to post your progress reports at VillaVu/SRL-Forums! ]
[================================================== ===============]
Successfully executed
as said previously, it occasionally screws up (for me it just stops doing anything, usually with a nearly full or full inventory at trees) but its pretty good (im thinking 3 hour proggies very possible with current build)
whats the word on updating to rev 38? does this script still work with it?
let me know if you need help testing.
peace
the script is awsome sometime it mess up on the way back to the bank and also sometime it just stand by the tree do some random stuff for 3 to 4min with out cutting the tree
It should work with Rev 38, but I recommend sticking with the Open-Dev. The more people test, the better, so yes, I always need help with testing. :pQuote:
Originally Posted by King ?
How does it mess up going to the bank? Does the walking mess up? If so, where does it walk?Quote:
Originally Posted by bomh
What kind of "stuff" does it do for 3-4 minutes?
oh sometime it can't find the bank booth because it when too far to the east side of the bank when it go to the bank
Okay, try changing line 443 to this:Quote:
Originally Posted by bomh
Let me know how that works out, I don't have time to test it right now.SCAR Code:Mouse(x + 25 + Random(5), y + 45 + Random(5), 4, 4, True);
hey cohen, so i tried it out, but it stopped after one load and didn't deposit it. the proggy said it was successful but i couldn't find where i would change the desired load amount. i only found the amount of time wanted, and i had that at the equivilent of 60 minutes. am i doing something wrong?
thanks!
k i will give it a test and get back to you
Umm, the required time that you're talking about is how long your character will be logged in before it takes a 15 minute (ish) break. You fill out how many logs you want to cut, not how many loads you with to do. This is done in the DeclarePlayers:Quote:
Originally Posted by yubinator
I hope that helps. :)SCAR Code:with Players[0] do
begin
Name := 'Username';
Pass := 'Password';
Nick := 'ser';
Active := True;
Pin := '';
Integers[0] := 1000;//This line right here, just change '1000' to however many logs you wish to cut.
Booleans[0] := True;
Booleans[1] := True;
BoxRewards := ['amp', 'mote', 'ostume', 'oins', 'unes', 're', 'ems'];
end;
@bomh, looking forward to it. :)
Coh3n
something is terribly wrong. it must be my scar and srl or something. i start the script. smart pops up then nothing. doesnt log me in or anything. i disable log in and then enable it just clicks random tiles. any ideas? =/
tried the adjustment for line 443 and got a 2.5 hour proggy, lost it because im an idiot tho. sorry. but I will tell you that it solved a random then logged out.
ahha thanks cohen! i'll post a proggy in about 12 hours.
[================================================== ===============]
[ Coh3n's Draynor Chop N' Bank ]
[============================= V.1.3 =============================]
[ ]
[ Ran For: 2 Hours, 25 Minutes and 17 Seconds ]
[ Loads Done: 27 ]
[ Logs Chopped: 756 ]
[ Levels Gained: 2 ]
[ Exp Gained: 51030 ]
[ Breaks: 1 ]
[ AntiBan: 63 ]
[ ]
[================================================== ===============]
[ Thank-you for using Coh3n's Draynor Chop N' Bank! ]
[================================================== ===============]
[ Be sure to post your progress reports at VillaVu/SRL-Forums! ]
[================================================== ===============]
Successfully executed
Try updating you SCAR and SRL. Check out the guide in my signature for more information.Quote:
Originally Posted by d0pe b0i
Don't worry about it, and that's good to know that it solved a random. :)Quote:
Originally Posted by King ?
@yubinator - Looking forward to it. ;)
@King ? - Nice proggy, do you know why it stopped?
[================================================== ===============]
[ Coh3n's Draynor Chop N' Bank ]
[============================= V.1.2 =============================]
[ ]
[ Ran For: 11 Hours, 27 Minutes and 4 Seconds ]
[ Loads Done: 66 ]
[ Logs Chopped: 1798 ]
[ Levels Gained: 0 ]
[ Exp Gained: 121365 ]
[ Breaks: 0 ]
[ ]
[================================================== ===============]
[ Thank-you for using Coh3n's Draynor Chop N' Bank! ]
[================================================== ===============]
[ Be sure to post your progress reports at VillaVu/SRL-Forums! ]
[================================================== ===============
So it seems to work, but the one thing im concerned about is the time to log ratio...? 11 hours for 1700 logs? I did put it on True for take random breaks, but that doesn't seem right lol. I have 93 woodcutting and am using a rune hatchet. I now put it on false and am gonna let it run. I was away all day so I have no idea what happened :(
Ahh, I thought I fixed that issue! Apparently not. If your character logs out for whatever reason, the script wont terminate, it just keeps running, thus adding to the time, and you'll end up with a proggy that's messed up. As soon as I get time, I'll try to fix that issue. It's been a real problem for a while now, and it just doesn't want to get fixed.Quote:
Originally Posted by yubinator
However, 1700 logs in one run isn't too bad, eh? :p
Coh3n
Oh yea, 1700 is excellent, and I figured out that when I logged in and I was in a random too haha.Great Script!!
Mine ran pretty well, except for some minor things such as:
- Lagging everytime it looks for a tree/tries to cut it down
- Sometimes misclicking when trying to walk to bank, and ending up outside of it, which makes the whole wcing process longer (it runs back to trees and then back to the bank)
- And the music tab thing (but thats SRL's fault)
:p
[================================================== ===============]
[ Coh3n's Draynor Chop N' Bank ]
[============================= V.1.2 =============================]
[ ]
[ Ran For: 2 Hours, 58 Minutes and 27 Seconds ]
[ Loads Done: 55 ]
[ Logs Chopped: 1540 ]
[ Levels Gained: 0 ]
[ Exp Gained: 103950 ]
[ Breaks: 0 ]
[ ]
[================================================== ===============]
[ Thank-you for using Coh3n's Draynor Chop N' Bank! ]
[================================================== ===============]
[ Be sure to post your progress reports at VillaVu/SRL-Forums! ]
[================================================== ===============]
my best proggy yet! and one issue:
*it has about a 1:7 chance in 'not finding the bank' and has to relocate
but no complaints other than that, and it does relocate and finds the bank anyways so not that big a deal i suppose. I love this script, thanks Cohen!
oh and why does it keep going to the music tab? i know it happens with most scripts, but is that gonna be fixable?
Haha thanks! :DQuote:
Originally Posted by yubinator
The lagging must be your computer because it works perfectly for me. I think I said this before, but I'm not sure - The walking is buggy, and it really tough to make it click the bank exactly because of the minimap update. As long as the relocating is working well, I don't know what else I can do to make it better, unless someone comes up with an unreal autocoloring function.Quote:
Originally Posted by grekory5
That's awesome! :D And see the above explanation about the walking. The music tab is used to check for randoms. Every time the music tab is clicked, it thinks you're in a random. Clicking the tab is used to check for false positives so SCAR doesn't try to solve a random that you aren't in. I'm pretty sure people are working hard to get that bug fixed, but I'm not exactly sure.Quote:
Originally Posted by yubinator
Your banking messes up some times.SCAR Code:[=================================================================]
[ Coh3n's Draynor Chop N' Bank ]
[============================= V.1.3 =============================]
[ ]
[ Ran For: 3 Hours, 13 Minutes and 50 Seconds ]
[ Loads Done: 38 ]
[ Logs Chopped: 1064 ]
[ Levels Gained: 16 ]
[ Exp Gained: 71820 ]
[ Breaks: 0 ]
[ AntiBan: 101 ]
[ ]
[=================================================================]
[ Thank-you for using Coh3n's Draynor Chop N' Bank! ]
[=================================================================]
[ Be sure to post your progress reports at VillaVu/SRL-Forums! ]
[=================================================================]
I've placed this
right after your signature procedure, why?SCAR Code:procedure Cut_ChopTrees; forward;
function Lv_LevelUp: Boolean;
begin
if not LoggedIn then Exit;
Result := FindNPCChatText('ongrat', Nothing) or FindNPCChatText('dvanced', Nothing) or
FindNPCChatText('ulatio', Nothing) or FindNPCChatText('oodcuti', Nothing);
if Result then
begin
Writeln('Congratulations, you have gained a Woodcutting level!');
Wait(80 + Random(100));
Players[CurrentPlayer].Integers[11] := Players[CurrentPlayer].Integers[11] + 1;
Cut_ChopTrees;
end;
end;
procedure S_FindRandoms;
begin
LampSkill := 'woodcutting';
If (not(Lv_LevelUp)) and (Not(Getcolor(499, 455)= 4807525)) then FindNormalRandoms;
end;
TBH: People don't really click the "clicktocontinue", they click the skill guide in stats at most. This also gets rid of the constant checking the music tab for anti random.
The get color check for the quick chat bubble beside your rsn. I've done a test before, and all randoms will pop up an npc chat screen.
[================================================== ===============]
[ Coh3n's Draynor Chop N' Bank ]
[============================= V.1.2 =============================]
[ ]
[ Ran For: 1 Hours, 41 Minutes and 45 Seconds ]
[ Loads Done: 26 ]
[ Logs Chopped: 728 ]
[ Levels Gained: 0 ]
[ Exp Gained: 49140 ]
[ Breaks: 0 ]
[ ]
[================================================== ===============]
[ Thank-you for using Coh3n's Draynor Chop N' Bank! ]
[================================================== ===============]
[ Be sure to post your progress reports at VillaVu/SRL-Forums! ]
[================================================== ===============]
Successfully executed
so that's my last run, about 5 minutes ago it ended due to the fact the smart screen went black? Is that my computer? or is that smart?
Your comps memory.
Search around the tutorial forum and you'll find a thread about this.
Well, now that I know posting it in PHP tags works, I'll add that to the first post. To whoever reads this, please post proggies in PHP tags. Thanks. :)PHP Code:[=================================================================]
[ Coh3n's Draynor Chop N' Bank ]
[============================= V.1.3 =============================]
[ ]
[ Ran For: 3 Hours, 13 Minutes and 50 Seconds ]
[ Loads Done: 38 ]
[ Logs Chopped: 1064 ]
[ Levels Gained: 16 ]
[ Exp Gained: 71820 ]
[ Breaks: 0 ]
[ AntiBan: 101 ]
[ ]
[=================================================================]
[ Thank-you for using Coh3n's Draynor Chop N' Bank! ]
[=================================================================]
[ Be sure to post your progress reports at VillaVu/SRL-Forums! ]
[=================================================================]
Main, could you be more specific about how the banking messes up please?
Also, that GetColor thing is geneous! I have had quite a few people comment about the Music tab bug both in this thread, and in my PowerChopper. You should go to the PublicSVN forum and that solution on this thread -> http://www.villavu.com/forum/showthr...534#post630534 as I am sure a lot of people will be greatful. :)
The Cut_ChopTrees you added is good, but I think I'll just say something like this in my Cut_WhileChopping procedure:
SCAR Code:if Lv_LevelUp then Break;
To Main and everyone else - I'm not at home right now, but as soon as I get time I'll do a quick update of what Main fixed, so be ready.
Thanks for the great feedback,
Coh3n