Herblore.scar

Well before I add more.

SCAR Code:

//-----------------------------------------------------------------//
//--               Scar Standard Resource Library                --//
//--                     Herblore routines                       --//
//-----------------------------------------------------------------//
// * procedure SetupHerblore;               // * SRL
// * procedure VialCheck;                   // * The Man
{*******************************************************************************
procedure SetupHerblore;
By: SRL
Description: Declares Global Bitmaps.
*******************************************************************************}
procedure SetupHerblore;
begin
end;
{*******************************************************************************
procedure VialCheck;
By: The Man
Description: Returns true if there is a vial in the inventory
*******************************************************************************}
procedure VialCheck;
var
VialDTM : Integer;
begin
VialDTM := DTMFromString('78DA6314646060506040038C4824906607125' +
       '204D4F002091E22D4B0135003720F33013562408293801A512021' +
       '40408D349090C6AF0600B0BB0126');
       
if CountItems(Vialdtm, dtm, []) then
Result := True
end;

Just want to check if this is right.

T~M

CountItems isn't a boolean, you also never free the DTM, and there is no such boolean as "Result", you called it as a procedure:

SCAR Code:

Function VialCheck: Boolean;
var
VialDTM, x, y : Integer;
begin
VialDTM := DTMFromString('78DA6314646060506040038C4824906607125' +
       '204D4F002091E22D4B0135003720F33013562408293801A512021' +
       '40408D349090C6AF0600B0BB0126');
       
Result := FindDTM(VialDTM, x, y, MIX1, MIY1, MIX2, MIY2);
FreeDTM(VialDTM);
end;

Oh ok, I asked Nava what to use to search the inv and he said use that.
Oh well.
Thank you :)

T~M

Quote:

---

Originally Posted by The Man

Oh ok, I asked Nava what to use to search the inv and he said use that.
Oh well.
Thank you :)

T~M

---

If you want to use CountItems, you'd do it something more like this:

SCAR Code:

Result :=(CountItems(VialDTM, 'DTM', [0]) > 0)

Oh ok.
Thank you,

T~M

Quote:

---

Originally Posted by Richard

CountItems isn't a boolean, you also never free the DTM, and there is no such boolean as "Result", you called it as a procedure:

---

Relax dude, he's trying to contribute, developers can make their changes later, he still isn't such a good scripter, but he's doing fine. :D

otherwise, Good job TheMan.

haha thank you Tickyy.
But I like the hard criticism.
It makes me a better scripter :)

T~M

Quote:

---

Originally Posted by Tickyy

Relax dude, he's trying to contribute, developers can make their changes later, he still isn't such a good scripter, but he's doing fine. :D

otherwise, Good job TheMan.

---

I was just making sure it worked, not once did I complain about his function.

hmm, i was just thinking about making something like this :P

i guess i'll make a herb finder or something :)

i think it looks decent(the fix'd versions), good job =D

Quote:

---

Originally Posted by Tickyy

Relax dude, he's trying to contribute, developers can make their changes later, he still isn't such a good scripter, but he's doing fine. :D.

---

There was nothing wrong with Richard's post. :)