String Functions

I am making a script in which you must type in a type of spell.

My current code (it sucks, I know) is this"

SCAR Code:

if (not pos('strike', spell) = 0) then RuneType := 'mind';
  if (not pos('bolt', spell) = 0) then RuneType := 'chaos';
  if (not pos('blast', spell) = 0) then RuneType := 'death';
  if (not pos('wave', spell) = 0) then RuneType := 'blood';

Is there any way to check (in SCAR) if a substring exists in another string?

Also, is there any reason SCAR always gets an Access Violation whenever I use Bitmaps?

How would a script that just moves the mouse to a bitmap look?

SCAR Code:

program New;
var i, xx, yy: Integer;
begin
  FindBitmap(i, xx, yy);
end.

WHY???

I get this error upon compilation:

Code:

---

[Runtime Error] : Exception: Access violation at address 006585D8 in module 'scar.exe'. Read of address 00000000 in line 5 in script

---

Any help?

Please?

Quote:

---

Originally Posted by xXxBlender3DxXx

SCAR Code:

program New;
var i, xx, yy: Integer;
begin
  FindBitmap(i, xx, yy);
end.

WHY???

I get this error upon compilation:

Code:

---

[Runtime Error] : Exception: Access violation at address 006585D8 in module 'scar.exe'. Read of address 00000000 in line 5 in script

---

Any help?

Please?

---

You need to declare the bitmap, silly.

Well, I do.

It works, but when I use RuneAmount('inv', 'mind'), it gives me the same error, only on FindBitmapTransparent().

Okay, so here is the main problem(s):

I always get an access violation on line 66 in the include Amount.scar, at FindBitmapTransparentTolerance().
And how do I check to see if spell contains each of the strings (the procedures are commented out).

SCAR Code:

program DemonMager;
{.Include SRL\SRL\misc\Smart.scar}
{.Include SRL\SRL.scar}
{.Include SRL\SRL\reflection\Reflection.scar}
{.Include SRL\SRL\skill\Magic.scar}

{****************************************************************************************************
                                 Start setting up the script
 ****************************************************************************************************}
const spell = 'wind strike';                // Type in the name of your attack spell. 'Wind Strike' is an example.
      defensive = false;         // True if you want to gain Magic and Defense XP at the same time. False otherwise.
      username  = '';            // The player's username.
      password  = '';            // The player's password.
      nickname  = '';            // The first 3-4 letters of the player's username.
{****************************************************************************************************
                                 Stop setting up the script
 ****************************************************************************************************}

var xx, yy, Mark, DeadDemons, StartRunes, StartXP: Integer;
    RuneType: String;

procedure DeclarePlayer;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name   := username;
  Players[0].Pass   := password;
  Players[0].Nick   := nickname;
  Players[0].Active := true;
end;

procedure AntiBan;
begin
  case RandomRange(1, 50) of
    1: BoredHuman;
    3: RandomMovement;
    4: GameTab(RandomRange(1, 15));
    5: Sleep(RandomRange(4000, 10000));
    6: HoverSkill('magic', false);
  end;
end;

procedure SetupSMART;
begin
  Smart_Members := true;
  Smart_Server := RandomWorld(Smart_Members, False);
  Smart_Signed := False;
  Smart_SuperDetail := False;
end;

procedure SetupPlayer;
begin
{  if (not pos('strike', spell) = 0) then} RuneType := 'mind';
{  if (not pos('bolt', spell) = 0) then RuneType := 'chaos';
  if (not pos('blast', spell) = 0) then RuneType := 'death';
  if (not pos('wave', spell) = 0) then RuneType := 'blood';}

  FixSpells;
  SetUpAutoCast(spell, defensive);
  StartRunes := RuneAmount('inv', RuneType);
  writeln('You have ' + IntToStr(StartRunes) + ' ' + RuneType + ' runes.');
  StartXP := GetXP('magic');
  writeln('You have ' + IntToStr(StartXP) + ' Magic XP.');
  
  MakeCompass('n');
  SendArrowWait(0, RandomRange(1000, 1500));
end;

function IsCasting: boolean;
var A1, A2: Integer;
begin
  A1 := RuneAmount('inv', RuneType);
  sleep(RandomRange(1000, 1200));
  A2 := RuneAmount('inv', RuneType);
  
  if not(A1 = A2) then
  begin
    Result := true;
  end else
  begin
    Result := false;
  end;
end;

procedure PrintProggy;
begin
  writeln('[--------------------------------->');
  Sleep(300);
  writeln('[  Spells Cast:     ' + IntToStr(StartRunes - RuneAmount('inv', RuneType)));
  Sleep(300);
  writeln('[  Demons killed:   ' + IntToStr(DeadDemons));
  Sleep(300);
  writeln('[  Total XP Gained: ' + IntToStr(GetXP('magic') - StartXP));
  Sleep(300);
  writeln('[--------------------------------->');
end;

procedure PrintSiggy;
begin
  ClearDebug;
  writeln('[--------------------------------->');
  Sleep(300);
  writeln('[  Demon Mager v. 1.0.0.0');
  Sleep(300);
  writeln('[--------------------------------->');
end;

begin
  ClearDebug;
  
  SetupSRL;
  SetupReflection;
  SetupSMART;
  
  PrintSiggy;

  DeclarePlayer;
  LoginPlayer;
  
  SetupPlayer;
  
  repeat
    if not(LoggedIn) then LoginPlayer;
    
    FindNormalRandoms;
    
    if (FindObjCustom(xx, yy, ['2'], [2964863, 2110593, 1846639], 5)) then
    begin
      DeadDemons := DeadDemons + 1;

      GetMousePos(xx, yy);
      Mouse(xx, yy, 0, 0, False);

      Wait(50 + Random(500));
      ChooseOption('tack');
      
      FFlag(10);
      
      if (FindBlackChatMessage('ough run')) then
      begin
        writeln('You are out of runes!');
        PrintProggy;
        Logout;
        TerminateScript;
      end;
      
      MarkTime(Mark);
      repeat
        if (not(LoggedIn) or (FindNormalRandoms)) then Break;
        Sleep(1000 + Random(500));
      until (TimeFromMark(Mark) > 10000);
    end;

    while (IsCasting) do
    begin
      AntiBan;
      FindNormalRandoms;
    end;
  until false;
end.

Is it that bad?

You need to have a bitmap...

No need to keep posting, just give people time to reply ;)

SCAR Code:

function SetupPlayer(Rune: String);
begin
  case Lowercase(Rune) of
    'mind' : Result := pos('strike', spell) = 0;
    'chaos' : Result := pos('bolt', spell) = 0;
    'death' : Result := pos('blast', spell) = 0;
    'blood' : Result := pos('wave', spell) = 0;
  end; 
  RuneType := Rune;
  FixSpells;  
  SetUpAutoCast(spell, defensive);
  StartRunes := RuneAmount('inv', RuneType);
  writeln('You have ' + IntToStr(StartRunes) + ' ' + RuneType + ' runes.');
  StartXP := GetXP('magic');
  writeln('You have ' + IntToStr(StartXP) + ' Magic XP.');
  MakeCompass('n');
  SendArrowWait(0, RandomRange(1000, 1500));
end;

Instead of repetative code, try using cases :)

Do you understand what I did here?

Quote:

---

Originally Posted by NCDS

No need to keep posting, just give people time to reply ;)

SCAR Code:

procedure SetupPlayer(Rune: String);
begin
  case Lowercase(Rune) of
    'mind' : Result := pos('strike', spell) = 0;
    'chaos' : Result := pos('bolt', spell) = 0;
    'death' : Result := pos('blast', spell) = 0;
    'blood' : Result := pos('wave', spell) = 0;
  end; 
  RuneType := Rune;
  FixSpells;  
  SetUpAutoCast(spell, defensive);
  StartRunes := RuneAmount('inv', RuneType);
  writeln('You have ' + IntToStr(StartRunes) + ' ' + RuneType + ' runes.');
  StartXP := GetXP('magic');
  writeln('You have ' + IntToStr(StartXP) + ' Magic XP.');
  MakeCompass('n');
  SendArrowWait(0, RandomRange(1000, 1500));
end;

Instead of repetative code, try using cases :)

Do you understand what I did here?

---

Yes, you tried to use Result in a procedure. :confused:

NCDS Your funny :p He will still have to use the if else case no matter what to find the positions anyway in order to send it through the procedure.

Try this:

SCAR Code:

if (pos('strike', spell) > 0) then
  RuneType := 'mind'
else if (pos('bolt', spell) > 0) then
  RuneType := 'chaos'
else if (pos('blast', spell) > 0) then
  RuneType := 'death'
else if (pos('wave', spell) > 0) then
  RuneType := 'blood';

~NS

>.< hate when hat stuff happens.

Changed to function.

That works, no?

or you can make an array (TStringArray) and loop through the code so for i := 0 to high(array) do if Pos(array[i], spell) > 0 then Index := i; Case Index of yadayada. ( I like doing that more than large if..then..else statements. Either or work, tbh my way is probably slower.

Quote:

---

Originally Posted by NCDS

No need to keep posting, just give people time to reply ;)

SCAR Code:

function SetupPlayer(Rune: String);
begin
  case Lowercase(Rune) of
    'mind' : Result := pos('strike', spell) = 0;
    'chaos' : Result := pos('bolt', spell) = 0;
    'death' : Result := pos('blast', spell) = 0;
    'blood' : Result := pos('wave', spell) = 0;
  end; 
  RuneType := Rune;
  FixSpells;  
  SetUpAutoCast(spell, defensive);
  StartRunes := RuneAmount('inv', RuneType);
  writeln('You have ' + IntToStr(StartRunes) + ' ' + RuneType + ' runes.');
  StartXP := GetXP('magic');
  writeln('You have ' + IntToStr(StartXP) + ' Magic XP.');
  MakeCompass('n');
  SendArrowWait(0, RandomRange(1000, 1500));
end;

Instead of repetative code, try using cases :)

Do you understand what I did here?

---

Quote:

---

Originally Posted by NCDS

>.< hate when hat stuff happens.

Changed to function.

---

NCDS, I doubt you took a look over it again, you still need to add in : Boolean; and read my last post it shows how your function has no mean, lol do you know what is he trying to do? :p



~NS

Disregard that post then I guess lol. I'm a bit rushed right now as I'm trying to pick up and put Nathan to bed. I will look back at this later.

Lulz. I'm making some code for that setting runetype or w/e. Hold on.

SCAR Code:

function GetRuneType(SpellName : string) : string;
var
  TSA : TStringArray;
  i : integer;
begin
  TSA := ['strike', 'bolt', 'blast', 'wave', 'mind', 'chaos', 'death', 'blood'];
  for i := 0 to 3 do
    if pos(TSA[i], SpellName) > 0 then
    begin
      result := TSA[i + 4];
      exit;
    end;
end;

or:

SCAR Code:

function GetRuneType(SpellName : string) : string;
var
  TSA : TStringArray;
  i : integer;
begin
  TSA := ['strike', 'bolt', 'blast', 'wave', 'mind', 'chaos', 'death', 'blood'];
  InStrArrEx(Copy(SpellName, pos(' ', SpellName) + 1, length(SpellName)), TSA, i);
  Result := TSA[i + 4];
end;

Your choice :).

Thanks NCDS and Da 0wner.

I basically have that worked out, but my script just dies at one point.

It can count the runes once, but the second time it just gives me a runtime error in Amount.scar.
Should I be freeing the called SRL bitmaps (through CountRunes())?

Bitmaps should be freed in that procedure already.

Quote:

---

Originally Posted by xXxBlender3DxXx

Thanks NCDS and Da 0wner.

I basically have that worked out, but my script just dies at one point.

It can count the runes once, but the second time it just gives me a runtime error in Amount.scar.
Should I be freeing the called SRL bitmaps (through CountRunes())?

---

Waah..? No thanks to me? :(

You should try using the try finally except concept. Something like:

SCAR Code:

try
  // Do stuff to load bitmap and count
finally
  // Free bitmap here
except end;

~NS

Well I actually posted (a) working function(s) :p.

Anyways, he isn't loading them with his own function I don't think. I believe it is in Magic.scar.

Quote:

---

Originally Posted by Da 0wner

Well I actually posted (a) working function(s) :p.

Anyways, he isn't loading them with his own function I don't think. I believe it is in Magic.scar.

---

I meant the bitmap issue :)



~NS

So did I.

I'm loading (well, using) via RuneAmount().

It works the first time, but on the second calling of the function, I get a runtime exception.

I only (sort of) fix it it I shove a srl_FreeBitmaps before and after each calling of the function.


Do I smell a bug?

Oh, and thanks Nadeem, sorta forgot about you!

SCAR Code:

function RuneAmount(Area, RuneType: string): Integer;
var
  RuneBmp, II: Integer;
  RuneNames: TStringArray;
begin
  RuneNames := ['air', 'mind', 'water', 'fire', 'earth', 'law', 'nature', 'chaos', 'death', 'body', 'cosmic', 'soul', 'blood'];
  if (InStrArrEx(Lowercase(RuneType), RuneNames, II)) then
  begin
    RuneBmp := srl_GetBitmap(18 + II);
    Result := ItemAmount(Area, 'bmp', RuneBmp, [20]);
    FreeBitmap(RuneBmp);
  end else
    srl_Warn('RuneAmount', 'Invalid RuneType: ''' + RuneType + '''', warn_AllVersions);
end;

It frees it.

Hmm, then why does the function only work when I shove a srl_FreeBitmaps before and after it?

Not entirely sure. Maybe you could post a fix to that function with SRL_freebitmaps :).

It works on it's own, but when more than one instance of the function occurs, the script dies and scar has a seizure.

Sorta broken version:

SCAR Code:

{*******************************************************************************
function RuneAmount(area, runetype: String): Integer;
By: masquerader and modified by Ron and ZephyrsFury
Description: Returns the amount of a certain rune in the specified area.
*******************************************************************************}

function RuneAmount(Area, RuneType: string): Integer;
var
  RuneBmp, II: Integer;
  RuneNames: TStringArray;
begin
  RuneNames := ['air', 'mind', 'water', 'fire', 'earth', 'law', 'nature', 'chaos', 'death', 'body', 'cosmic', 'soul', 'blood'];
  if (InStrArrEx(Lowercase(RuneType), RuneNames, II)) then
  begin
    RuneBmp := srl_GetBitmap(18 + II);
    Result := ItemAmount(Area, 'bmp', RuneBmp, [20]);
    FreeBitmap(RuneBmp);
  end else
    srl_Warn('RuneAmount', 'Invalid RuneType: ''' + RuneType + '''', warn_AllVersions);
end;

My sorta fix:

SCAR Code:

{*******************************************************************************
function RuneAmount(area, runetype: String): Integer;
By: masquerader and modified by Ron and ZephyrsFury
Description: Returns the amount of a certain rune in the specified area.
*******************************************************************************}

function RuneAmount(Area, RuneType: string): Integer;
var
  RuneBmp, II: Integer;
  RuneNames: TStringArray;
begin
  srl_FreeBitmaps;

  RuneNames := ['air', 'mind', 'water', 'fire', 'earth', 'law', 'nature', 'chaos', 'death', 'body', 'cosmic', 'soul', 'blood'];
  if (InStrArrEx(Lowercase(RuneType), RuneNames, II)) then
  begin
    RuneBmp := srl_GetBitmap(18 + II);
    Result := ItemAmount(Area, 'bmp', RuneBmp, [20]);
    FreeBitmap(RuneBmp);

  srl_FreeBitmaps;
  end else
    srl_FreeBitmaps;

    srl_Warn('RuneAmount', 'Invalid RuneType: ''' + RuneType + '''', warn_AllVersions);

    srl_FreeBitmaps;
end;

It's he only thing that works.
0.o

xXxBlender3DxXx, remember to use the Edit button next time you have something to add to a post. Don't post more than one post consecutively.. it gets annoying.

Thanks.

is there a place to find out all the functions?