* function OpenBankNPC: Boolean;

Hello i didn't saw any NPC bank openers so i created one, tested in several worlds and Towns. Please test and tell me what you think.

Thanks.

Code:

---

{*******************************************************************************
function OpenBankNPC: Boolean;
By: Home
Description: Opens the bank by using Banker.
*******************************************************************************}
function OpenBankNPC: Boolean;
var
  bx, by, Speed, ColFace, ColGrey, ColBlue: Integer;
begin
  Speed := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  ColFace := 7774419; // Face Color
  ColGrey := 6381925; // Grey Color [ Clothes ]
  ColBlue := 2429979; // Blue Color [ Clothes ]
  if (FindObjThroughMM(bx, by, 'npc', [ColFace, ColBlue, ColGrey], [5, 5, 5], ['anke', 'to B', 'Banker', 'nker'], 2, 2)) then begin
    Mouse(bx, by, 0, 0, False);
    WaitOption('ank B', 300);
    FFlag(0);
    Wait(2000 + Random(500));
    if (Length(Players) > 0) then
      if (Players[CurrentPlayer].Pin <> '') then
        InPin(Players[CurrentPlayer].Pin);
    Result := (BankScreen) or (PinScreen);
  end;
  ColorToleranceSpeed(Speed);
end;

---

~Home

This could fix the problem with draynor banking.
Mind if i use in my script?

Quote:

---

Originally Posted by Neehosoft

This could fix the problem with draynor banking.
Mind if i use in my script?

---

Hes wanting to add this to the include; it would be public and everyone would be able to use this.

So what do you think? Remember to keep the description of the funtion with the function.

Quote:

---

Originally Posted by TRiLeZ

Hes wanting to add this to the include; it would be public and everyone would be able to use this.

So what do you think? Remember to keep the description of the funtion with the function.

---

:( You made me cry

Quote:

---

Originally Posted by Neehosoft

:( You made me cry

---

:( I didnt mean to make you cry.
How did I even make you cry?

Quote:

---

Originally Posted by TRiLeZ

:( I didnt mean to make you cry.
How did I even make you cry?

---

You make me feel stupid

lol I was going to post that he wants it in the include also, then I felt like I shouldn't say anything, and just let Home answer, because I don't know if he wants people using it without it being in the include, but my guess would be he wouldn't care if you credit him. I would still wait for him to answer though.

Ahh, nice Home! Maybe we could have this and make a MixOpenBank procedure which either uses OpenBankNPC or the original OpenBank.

GJ.

You can use it in scripts and so on :) And btw Bobbohobbo, i got this idea because i saw your thread and i tested your script and banking was slow :)

And thanks for comments people.

~Home

Works great in Edgeville :) Using this in my MiniYews script

Quote:

---

Originally Posted by marpis

Works great in Edgeville :) Using this in my MiniYews script

---

Good to hear that someone find a use for this :) Well i use this in most banks :) Works very well and pretty fast.

~Home

your a tricky one, for a second there, I thought this:

if (FindObjThroughMM(bx, by, 'npc', [ColFace, ColBlue, ColGrey], [5, 5, 5], ['anke', 'to B', 'Banker', 'nker'], 2, 2)) then begin

didn't have a begin in it, most people put begin on the next line :p

I thought there was a bug because you right click then go on without a begin, but there is one. Maybe put it on the next line to look like most other procedures/functions and to not be so confusing lol. I like your idea though, I think this should get committed.

Quote:

---

Originally Posted by Baked0420

your a tricky one, for a second there, I thought this:

if (FindObjThroughMM(bx, by, 'npc', [ColFace, ColBlue, ColGrey], [5, 5, 5], ['anke', 'to B', 'Banker', 'nker'], 2, 2)) then begin

didn't have a begin in it, most people put begin on the next line :p

I thought there was a bug because you right click then go on without a begin, but there is one. Maybe put it on the next line to look like most other procedures/functions and to not be so confusing lol. I like your idea though, I think this should get committed.

---

He, he sorry :) My "Standards" kinda are not so official, but isn't the most importan thig that Function / Procedure works :)

~Home

Quote:

---

Originally Posted by Home

He, he sorry :) My "Standards" kinda are not so official, but isn't the most importan thig that Function / Procedure works :)

~Home

---

i liek using teh if then begin too :)

and nice function

Quote:

---

Originally Posted by Home

Good to hear that someone find a use for this :) Well i use this in most banks :) Works very well and pretty fast.

~Home

---

I use it for my Firemaker in varrock, and for my willow cutter, and i will use for my flax picker and spinner

Thanks, rep++ dude.
Works like a charm in Draynor. :)
I'll add it to my script!
~Eerik~

SCAR Code:

{*******************************************************************************
function OpenBankNPC: Boolean;
By: Home
Description: Opens the bank by using Banker.
*******************************************************************************}

Function OpenBankNPC: Boolean;
 Var
  bx, by, Speed, ColFace, ColGrey, ColBlue: Integer;
Begin
  Speed := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  ColFace := 7774419; // Face Color
  ColGrey := 6381925; // Grey Color [ Clothes ]
  ColBlue := 2429979; // Blue Color [ Clothes ]
  If (FindObjThroughMM(bx, by, 'npc', [ColFace, ColBlue, ColGrey],
    [5, 5, 5], ['anke', 'to B', 'Banker', 'nker'], 2, 2)) Then 
  Begin
    Mouse(bx, by, 0, 0, False);
    WaitOption('ank B', 300);
    FFlag(0);
    Wait(2000 + Random(500));
    If (Length(Players) > 0) Then If (Players[CurrentPlayer].Pin <> '') Then
       InPin(Players[CurrentPlayer].Pin);
    Result := (BankScreen) Or (PinScreen);
  End;
  ColorToleranceSpeed(Speed);
End;

Used my standards wand on that ;).

Looks great! Rep+

Quote:

---

Originally Posted by rogeruk

SCAR Code:

{*******************************************************************************
function OpenBankNPC: Boolean;
By: Home
Description: Opens the bank by using Banker.
*******************************************************************************}

Function OpenBankNPC: Boolean;
 Var
  bx, by, Speed, ColFace, ColGrey, ColBlue: Integer;
Begin
  Speed := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  ColFace := 7774419; // Face Color
  ColGrey := 6381925; // Grey Color [ Clothes ]
  ColBlue := 2429979; // Blue Color [ Clothes ]
  If (FindObjThroughMM(bx, by, 'npc', [ColFace, ColBlue, ColGrey],
    [5, 5, 5], ['anke', 'to B', 'Banker', 'nker'], 2, 2)) Then 
  Begin
    Mouse(bx, by, 0, 0, False);
    WaitOption('ank B', 300);
    FFlag(0);
    Wait(2000 + Random(500));
    If (Length(Players) > 0) Then If (Players[CurrentPlayer].Pin <> '') Then
       InPin(Players[CurrentPlayer].Pin);
    Result := (BankScreen) Or (PinScreen);
  End;
  ColorToleranceSpeed(Speed);
End;

Used my standards wand on that ;).

Looks great! Rep+

---

He, he :) My standards are not kinda official :D
But thanks :)

~Home

Problem with it working at Al Kharid. Any chance of you looking at it?

Tried changing colors but no good just moves mouse around the floor.

Yeah, I couldnt get it to go perfectly to at Draynor, tried changing colours still goes around the floor before it goes to the banker.

Try adding before OpenBankNPC to Angle down.

~Home

P.S For me it works :S

You mean

SCAR Code:

SetAngle(True);

?

Quote:

---

Originally Posted by rogeruk

You mean

SCAR Code:

SetAngle(True);

?

---

No ;) Set angle false.

If not openbankNPC then begin
Set angle(False)
OpenBankNPC;
SetAngle(True)
end
else
.... You know :)


~Home

Yea didnt know which way you meant :P.

Quote:

---

Originally Posted by BobboHobbo

Yeah, I couldnt get it to go perfectly to at Draynor, tried changing colours still goes around the floor before it goes to the banker.

---

Works perfectly for me in draynor?

Eerik.

Watched my script for a bit and sometimes char was still moving while trying to look for bank so it didnt work.

Quote:

---

Originally Posted by BobboHobbo

Yeah, I couldnt get it to go perfectly to at Draynor, tried changing colours still goes around the floor before it goes to the banker.

---

Is that in your Draynor Chopper? I get the same problem when using your script.

Added :) GJ

~RM

Cool function. I think it's been so long since they used the committed tag they forgot an M :o.

~Sandstorm

Quote:

---

Originally Posted by Rasta Magician

Added :) GJ

~RM

---

But it doesn't work fully in Draynor...Did you change it to work then?

Edited it so that it waits until Bank/Pin screen appears. Also now it doesn't wait 2sec in vain if the banker wasn't found (misclick)

Uses WaitFunc so this would require BankScreenOrPinScreen: Boolean; to be commited as well.

Works perfectly in Catherby btw ;) Awesome job Home!

SCAR Code:

function BankScreenOrPinScreen: Boolean;
begin
  Result := BankScreen or PinScreen;
end;
{*******************************************************************************
function OpenBankNPC: Boolean;
By: Home, edited by marpis
Description: Opens the bank by using Banker.
*******************************************************************************}
function OpenBankNPC2: Boolean;
var
  bx, by, Speed, ColFace, ColGrey, ColBlue: Integer;
begin
  Speed := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  ColFace := 7774419; // Face Color
  ColGrey := 6381925; // Grey Color [ Clothes ]
  ColBlue := 2429979; // Blue Color [ Clothes ]
  if (FindObjThroughMM(bx, by, 'npc', [ColFace, ColBlue, ColGrey], [5, 5, 5], ['anke', 'to B', 'Banker', 'nker'], 2, 2)) then
  begin
    Mouse(bx, by, 0, 0, False);
    if WaitOption('ank B', 350 + Random(50)) then
    begin
      FFlag(0);
      Result := WaitFunc(@BankScreenOrPinScreen, 100, 10000 + Random(2000));
      if Result then
        if (Length(Players) > 0) then
          if (Players[CurrentPlayer].Pin <> '') then
            InPin(Players[CurrentPlayer].Pin);
    end;
  end;
  ColorToleranceSpeed(Speed);
end;