For me it still doesn't find the furnace every 5 or so runs.... have done all that suggested but no luck.
Printable View
For me it still doesn't find the furnace every 5 or so runs.... have done all that suggested but no luck.
My character just stands there after he lvled up. He writes he lvled up, but he doesn't move at all after that, I'll try to figure this out on my own. I'll edit this post if I got it :P
[edit]I didn't really know if i got it, as i haven't had a lvl up yet, but I got another problem (was mentioned earlier)
That line is:Quote:
Runtime Error] : Out Of Range in line 527 in script C:\*\Scar 3.23\Scripts\Sabzi's Kharid Smelter v1.3.scar
527: if Players[i].Strings[1] = 'r' then
Uppppppppppppppppdate!
See change log.
Also I would be quiet happy if an advanced scripter would review the code.(not the breaking/switching part, it's messy but okay)
For example I have found out now that I did not freed a dtm up(there from v1). More eyes sees more and I don't want stupid mistakes like that.
Thanks for using, helping, posting proggies/bugs in advance!
OhDAMN: I forgot to do anything with the maxtime while you are smithing. What do you think the maximum can be? Like 2 minutes for 28 ores smelted? Currently it's 5 minutes.
I think it takes 1:31 from the time the first bar goes in to the time the 28th comes out so you could use 1:45 for the max time. are you going to use 1 max time for all bar types? you could set a max time per bar and have the script take that times 4, 9, 14, 28 or whatever to find the max time for the current load.
Payton
Well, that would not effect the script too much so it's not a big problem anyway. I just forgot it. Will fix that with your idea((thx)you are already in the credits, amirite?) later when I got bigger things to do. (I am planning to make a form:stirthepot:)
Sadly I will got an operation soon(not a serious one, just a little) so I won't go to school in this week.
you need to lower the wait time from when it walks to the bank(and flag stays on mm) and when it clicks on banker. it is 5-10 seconds to long right now.
and you are right i am in the credits. thanks
Payton
ok. have you been testing this with 1 player? for me after the first break it will just do 1 load then break again.
Payton
Hmmm... I had that problem before than sorted things but it seems I mucked up something not too long ago. I will surely investigate that too. But only expect things tomorrow as it's 23:12 here and I can't script now.
EDIT: I really appreciate that you are helping to make this a better script. Thx :)(must spread some rep to give you again ...)
i just watched it do bronze bars for quite a while, and it seems to detect the level up's ok. but there are alot of random slow mouse movements accost the screen. to me this seems bot like because i usually check my exp, move mouse for next click, or do nothing at all with it. other than that and the breaks it seems to be a great script!
Payton
You can always edit the anti-ban if you don't like it. I do that too with other scripts. That's the great with scar(overall open source) scripts, that you can personalize them.
EDIT: Ahh, do you remember when I said I have mucked versions up? And I have half of the things fixed in the version I uploaded and worked on and half of the fixes in an older version ...
Well, the switching/breaking bug was fixed in the version I lost or whatever but I can't find it.(luckily the switching/breaking is the same as in SAC and that's the fixed one)
Now I will do something about waiting at the bank for the flag, then upload v1.6
Double posting, but new version uploaded. And I am looking forward to fix new bugs :stirthepot:. Although, I hope there isn't any :).
p.s.: Sorry for double post :(
and for too much smiley ...
[=============================]
[ kum ]
[ Active : True ]
[ Location : bank ]
[ Loads : 116 ]
[ XP gained : 18270 ]
[ XP/hr : 7850 ]
[ Lvlups : 0 ]
[ Xp to goal : 12850391 ]
[ Hours to goal : 1636 ]
[ Bars made : 1044 ]
[ Bars/hr : 449 ]
[ Breaks done : 2 ]
[ Smelting : steel ]
[ Worked : 02h 19m 38s ]
[=============================]
Great! My char ran out of ores.
Sure feel free :)
Code:[=============================]
[ *** ]
[ Active : True ]
[ Location : bank ]
[ Loads : 251 ]
[ XP gained : 39532 ]
[ XP/hr : 7047 ]
[ Lvlups : 0 ]
[ Xp to goal : 12486478 ]
[ Hours to goal : 1771 ]
[ Bars made : 2259 ]
[ Bars/hr : 403 ]
[ Breaks done : 0 ]
[ Smelting : steel ]
[ Worked : 05h 36m 35s ]
[=============================]
Until
[05:55:13 PM] Something wrong with inventory. Location: Bank.
Best one I've had so far! :)
Great script. Breaking doesn't work properly I think, it keeps doing breaks after it hit the break time.
Nah, I had enough ores to go on, but I'm sorry, I didn't watch it, was playing on my main. Was the first time when something like this happened though :)
When I start the script it just keeps moving around the bank people, instead of opening the bank booth.
Maybe it's me though I haven't used SCAR in quite awhile... "/
Getting SCAR 3.23 fixed it, thanks.PHP Code:[ Active : True ]
[ Location : bank ]
[ Loads : 6 ]
[ XP gained : 945 ]
[ XP/hr : 9400 ]
[ Lvlups : 0 ]
[ Xp to goal : 172409 ]
[ Hours to goal : 18 ]
[ Bars made : 54 ]
[ Bars/hr : 537 ]
[ Breaks done : 0 ]
[ Smelting : steel ]
[ Worked : 06m 01s ]
EDIT: It keeps saying "[01:43:53 PM] Failed while banking. Location: Bank?" When it's not lost at all. o_0
Missed the bank randomly; meh.Code:[==========================]
[ Zezima ]
[ Active : True ]
[ Location : bank ]
[ Loads : 31 ]
[ XP gained : 4882 ]
[ XP/hr : 8224 ]
[ Lvlups : 1 ]
[ Xp to goal : 12997207 ]
[ Hours to goal : 1580 ]
[ Bars made : 279 ]
[ Bars/hr : 470 ]
[ Breaks done : 0 ]
[ Smelting : steel ]
[ Worked : 35m 36s ]
[==========================]
It works well; is quite fast (:
Hell yea! See guys?! Even Zezima is using my script!!! :D
But tbh I totally forgot that I wanted to fix the breaking :S. And I can't do it now.
how is the breaking / multilayer working on this? everything else seems to be working nicely.
Payton
Breaking not working. I have made a fix a long ago but never posted it. I wanted to make some more tweak and then forget to even upload that ...
I haven't tested it so far so I don't want to release it now and I still want to add more stuff. But I don't got the time for it. :(
Seems to work pretty well for me except that every time it stops is either because, it can't find/open the bank or sometimes char goes behind the furnace and can't find the furnace for some reason.
Hey Sabzi!
Have you ever thought about implementing cannonball smithing?
I'd be willing to test it myself, or loan an account for testing!
I found that with the breaking, which i got pretty sick of ;P (especially with smelting addy bars i'd only get 60/run) that i just declare more players (i.e. the same player multiple times) and it would go pretty good for me. I get about 300 bars/run now.
Okay, I will see what can I do at the weekend but no cannonballs. First I want to fix the current bugs. No rushing :p. But maybe. (very kindly about lending but I got p2p atm)
/adding cannon balls to to do list ...
just smelted me 125 mith bars, so 25 loads. Forgot to copy the proggy, but no problems from what I noticed.
Funny and makes me happy it still works. However there are some unfixed flaw so be cautious.
Sadly I don't got enough time to maintain this script. Stupid learning.
Runs 2 and 3 were stopped due to running out of ores Run 1 I paused the script and it broke when I resumed it :p.PHP Code:[==========================]
[ xxx ]
[ Active : True ]
[ Location : bank ]
[ Loads : 6 ]
[ XP gained : 900 ]
[ XP/hr : 8406 ]
[ Lvlups : 0 ]
[ Xp to goal : 12585003 ]
[ Hours to goal : 1497 ]
[ Bars made : 30 ]
[ Bars/hr : 280 ]
[ Breaks done : 0 ]
[ Smelting : mithril ]
[ Worked : 06m 25s ]
[==========================]
[03:26:49 PM] Timed out while smelting. Location: Furnace.
Script runtime: 15 Minutes and 18 Seconds
[==========================]
[ xxx ]
[ Active : True ]
[ Location : bank ]
[ Loads : 14 ]
[ XP gained : 2100 ]
[ XP/hr : 8353 ]
[ Lvlups : 0 ]
[ Xp to goal : 12585003 ]
[ Hours to goal : 1506 ]
[ Bars made : 70 ]
[ Bars/hr : 278 ]
[ Breaks done : 0 ]
[ Smelting : mithril ]
[ Worked : 15m 05s ]
[==========================]
[04:56:46 PM] Something wrong with inventory. Location: Bank.
Successfully executed
Script runtime: 56 Minutes and 37 Seconds
[==========================]
[ xxx ]
[ Active : True ]
[ Location : bank ]
[ Loads : 53 ]
[ XP gained : 7950 ]
[ XP/hr : 8463 ]
[ Lvlups : 0 ]
[ Xp to goal : 12585003 ]
[ Hours to goal : 1487 ]
[ Bars made : 265 ]
[ Bars/hr : 282 ]
[ Breaks done : 0 ]
[ Smelting : mithril ]
[ Worked : 56m 21s ]
[==========================]
Only problem is that it won't do the last load of ores, because it withdraws slot 1 of the bank (mith), but then the coal shifts over and it withdraws whatever fills in coal's place.
Thanks for the proggies.
When you pause a script the system time is still growing so as we use that to determinate the time spent it was detected that you was timed out while smelting. It will happen with any script that uses time checking.
Yeah, I didn't coded the script to do the last load. I thought that that 20 second is not much. So, it's pretty much expected :p.