3Garrett3's Karamja Fishing Script

Printable View

Show 40 post(s) from this thread on one page

06-12-2010, 04:58 PM
3Garrett3

3Garrett3's Karamja Fishing Script
3Garrett3's KARAMJA Fishing Script
A Karamja Fisher and Noter/Seller by 3Garrett3

Kinda
Awesome
Ridiculously
Amazing
Makes
Jizz
Appear

Fishing Script.

Credits:
- Awkwardsaw - Helped in the brainstorm of names.
- Camaro - Helped me with the development of my ideas for how to do things.
- Tad - Looked over some of the code and told me it didn't suck :)
Description of the script:

This script is kinda awesome, ridiculously amazing, and will make jizz appear in your pants. If not, you're doing it wrong.

It will net or bait and sell to the general store. It will harpoon and cage, going to Stiles and noting the fish. It does not drop tuna. It is faster to note it.

Set this biznatch up:
1. Update your srl and reflection, so you wont complain to me
2. Setup the player near the Karamja dock, preferably on the dock.
3. You must have talked to Stiles if you plan on fishing lobster or tuna/swords, otherwise the chat is different and the script wont recognize it.
4. Only have fishing gear and money (noted fish are allowed too) in your inventory.
5. Setup the constants in the script (The ones before declareplayers)
6. Setup the declareplayers in the script
7. DO NOT TOUCH ANYTHING BELOW WHERE IT SAYS DO NOT TOUCH. You run the risk of messing the script up.
8. Press play and hope for the best
Note: If you don't mind the script cramming your debug box full, please leave debug enabled and report to me where it messed up :)

Features!

Multiplayer
Fishes in Karamja
Can net, bait, harpoon, and cage.
Antirandoms (Reflection or Colour based, user defines which)
AntiBan (User customizable for how often)
Reflection Walking, Object Finding with TPA fish spot and Stiles finding :)
Debug is saved to script location for easy recollection.
Saves a picture of RS when it fails, which lets me know what is wrong with it. Post this when it fails please :)

Currently known bugs:
-None reported.

Version Log
Pub - BETA, if something goes wrong, report and I will fix it :)
V 0.1 - Added netting. It will now do level 1-99, you just have to adjust for what gear you have. More failsafes for fishing failure.
V 0.2 - There are now so many failsafes for everything. A new option is added. "Highest" will allow the script to decide which technique to use, depending on your level and which gear you have. Not very tested though.
V 0.25 - Anyone testing netting would find that the counting didn't work. Fixed it.
V 0.5 - Wasn't finished with all of the addons I expected, but it compiles after the reflection update.
V 1.0 - It works again, and the reflection bug will no longer affect it.
V 1.5 - Added TPA Stiles finding because reflection was having problems. Debug saving and almost TPA walking included.
V 1.51 - Fixed two little things that affected the progress report, messed them up with the save debug add-on.

Things I plan on adding
Colour walking and backups for all reflection techniques.

Important Note
- Sell fishes for mid-max, even if it takes a while, you need a break from autoing anyway!

Disclaimer
I r not responsible for lost accounts due to bans or t3h own by jagex.

Proggies go here :)

Longest Proggy - 3Garrett3

PHP Code:

3Garrett3s Fisherer 0.5 Progress Report ********************************************* Ran for: 10 Hours, 59 Minutes and 12 Seconds Fished : 1125 Total Fish Fished : 269 Tuna Fished : 206 Swords Fished : 650 Lobsters ********************************************* 0: | 475 Fish | 22 Loads | 2 Levels | 42020 Experience| 1: | 650 Fish | 29 Loads | 5 Levels | 56970 Experience|

Single Player - MasterBB

PHP Code:

********************************************* Ran for: 4 Hours, 25 Minutes and 22 Seconds Fished : 744 Total Fish Fished : 405 Tuna Fished : 339 Swords ********************************************* 0: | True | 744 Fish | 31 Loads | 1 Levels | 64840 Experience|
06-12-2010, 06:45 PM
i luffs yeww

:) I like that you have a good amount of fail safes and you still use reflection. To me it shows that reflection scripts can still be advanced. ^^
06-12-2010, 08:57 PM
Danizho

another script karamja script...

but... i need "tuna drop" feature =)
06-12-2010, 09:11 PM
Awkwardsaw

Quote:

Originally Posted by Danizho

another script karamja script...

but... i need "tuna drop" feature =)

why do you needit? :p

its faster to note it
06-12-2010, 09:16 PM
Runescapian321

Quote:

Originally Posted by Awkwardsaw

why do you needit? :p

its faster to note it

Is it? If you're fishing for swordfish, my guess is that dropping the tuna ends up with a better rate of exp and gp overall. EDIT: Unless something has changed since I've last done this and tuna is actually worth it nowadays.

Nice job on the script, Garrett.
06-12-2010, 09:23 PM
Danizho

Quote:

Originally Posted by Awkwardsaw

why do you needit? :p

its faster to note it

yep... ... anyway, this is a good script... i have a lot of trouble with failsafes
06-12-2010, 09:35 PM
Awkwardsaw

Quote:

Originally Posted by Tad

Is it? If you're fishing for swordfish, my guess is that dropping the tuna ends up with a better rate of exp and gp overall. EDIT: Unless something has changed since I've last done this and tuna is actually worth it nowadays.

Nice job on the script, Garrett.

i'm not saying its worth keeping, but its faster to note the tuna instead of dropping, which results in over all faster exp
06-12-2010, 10:18 PM
Runescapian321
Quote:

Originally Posted by Awkwardsaw

i'm not saying its worth keeping, but its faster to note the tuna instead of dropping, which results in over all faster exp

Let's say that, when fishing swordfish, you get 3 tunas for every 1 swordfish. Therefore in the end, you get 1 load of swordfish for every 3 loads of tuna = 4 trips. Those three walks of tuna you made were worth about 11-12k. I'm going to guess that dropping a load of tuna takes about the same amount of time as taking a one way trip to Stiles. Hence, if you drop the tuna, what you're doing is...
- Save time equivalent to the amount of time it takes to walk to Stiles and back * 1.5
- You lose 11-12k in exchange for that time
I don't know how much time that is, but in the end it seems like you're choosing gp over exp or vice versa, making it reasonable to drop tuna if you want more exp.
06-12-2010, 11:43 PM
3Garrett3

The drop of tuna takes the same amount of time that it takes to walk half a trip to Stiles. Not really worth it if you ask me. I can add the feature in though, and make it an option. Later on, remind me or something :)
06-12-2010, 11:51 PM
kingarabian

This is one of the best SRL script i've seen in along time.

Good job.
06-13-2010, 12:00 AM
xSaintias

errors :|
Exception in Script: Unable to find file 'reflection/reflection.simba' used from ''
ive looked and reflection is there...
then i tried changing it to:
{.include srl/srl/reflection/reflection.simba} (instead of {.include reflection.simba})
then it gives:
[Error] C:\Users\xSaintias\Desktop\Simba\Includes\SRL/SRL/Core/Mapwalk.scar(626:13): Unknown identifier 'AutoColorEx' at line 625

Mapwalk.scar:

acInfo := AutoColorEx(autoColorConst);
with acInfo do
06-13-2010, 12:17 AM
i luffs yeww

^ Make sure you're placing your reflection folder in the right spot (Includes/Reflection/).
06-13-2010, 03:05 AM
xSaintias

thanks, but still getting
[Error] C:\Users\xSaintias\Desktop\Simba\Includes\SRL/SRL/Core/Mapwalk.scar(626:13): Unknown identifier 'AutoColorEx' at line 625
06-13-2010, 03:28 AM
bbri06

Did you move your reflection and SRL plugins?
06-13-2010, 03:32 AM
Awkwardsaw

in srl/srl.scar, make sure the srl/srl/core/autocolor.scar is before srl/srl/core/mapwalk.scar
06-13-2010, 04:00 AM
xSaintias

Quote:

Originally Posted by Awkwardsaw

in srl/srl.scar, make sure the srl/srl/core/autocolor.scar is before srl/srl/core/mapwalk.scar

I checked and autocolor is before mapwalk...
not sure whats causing the problem.
06-13-2010, 03:18 PM
3Garrett3

Quote:

Originally Posted by kingarabian

This is one of the best SRL script i've seen in along time.

Good job.

Lets not get carried away here.

Quote:

Originally Posted by xSaintias

I checked and autocolor is before mapwalk...
not sure whats causing the problem.

It's happened to me before. Delete your SRL folder and redownload it or update it, if you use tortoise. One of the versions of SRL didn't compile, and you have to update to fix it, or something like that.
06-13-2010, 03:40 PM
masterBB

Quote:

Originally Posted by Tad

Let's say that, when fishing swordfish, you get 3 tunas for every 1 swordfish.

Its very close to 50/50 not 1/3. Noting tuna is a faster than dropping IMO.

I want to post a progy but this scripts doesn't stop... Wel once it did, I found myself back in lumbridge... with 2 swordfish and a power amy...
06-13-2010, 03:41 PM
3Garrett3

Quote:

Originally Posted by masterBB

Its very close to 50/50 not 1/3. Noting tuna is a faster than dropping IMO.

I want to post a progy but this scripts doesn't stop... Wel once it did, I found myself back in lumbridge... with 2 swordfish and a power amy...

I didn't even know there were still fighting randoms in RS? I can add a "FindFight" to randoms. I just thought that there were only the "FindNormalRandoms" ones. I haven't played RS for over a year though..

E: It doesn't stop? Well, I like the sounds of that :)
06-13-2010, 03:46 PM
masterBB

There is a scorpion.. I only got 5 def, I am a ranger. So your walking bugged a little bit, leaving me behind with the scorpion...
06-13-2010, 04:25 PM
3Garrett3

Quote:

Originally Posted by masterBB

There is a scorpion.. I only got 5 def, I am a ranger. So your walking bugged a little bit, leaving me behind with the scorpion...

Ohhh. Right. My bad on that one. I should have mentioned that there are scorpions, and to use at your own risk on that one..

I'm in the process of making a large-ish update. It will let your player theoretically go forever. It decides which technique (net, bait, harpoon, cage) to use depending on what is in your inventory and what level you are. So theoretically if you start with a net, rod, bait, harpoon, cage in your inventory, it will go through all of them, and get you 99 fishing.

I need to know which order it should go in.

Right now it would just harpoon until 40, then cage until 99. I need to know which levels it should switch back and forth for. Should it harpoon until 40, then cage until 50, then harpoon again? Or would you like to use bait until 40, then cage until 50, then harpoon, or not harpoon at all?

Whatever people want is how I will change it before I release it.
06-13-2010, 04:29 PM
Camaro'

Quote:

Originally Posted by 3Garrett3

Ohhh. Right. My bad on that one. I should have mentioned that there are scorpions, and to use at your own risk on that one..

I'm in the process of making a large-ish update. It will let your player theoretically go forever. It decides which technique (net, bait, harpoon, cage) to use depending on what is in your inventory and what level you are. So theoretically if you start with a net, rod, bait, harpoon, cage in your inventory, it will go through all of them, and get you 99 fishing.

I need to know which order it should go in.

Right now it would just harpoon until 40, then cage until 99. I need to know which levels it should switch back and forth for. Should it harpoon until 40, then cage until 50, then harpoon again? Or would you like to use bait until 40, then cage until 50, then harpoon, or not harpoon at all?

Whatever people want is how I will change it before I release it.

I suggest harpoon until 40, cage until 85, harpoon till 99. It doesn't matter much.
06-13-2010, 05:24 PM
masterBB

It sometimes just quit with no reason, after walking back to the fishing spots. It stands next to the fishing spots and logs out... Really odd.
06-13-2010, 05:25 PM
3Garrett3

Quote:

Originally Posted by masterBB

It sometimes just quit with no reason, after walking back to the fishing spots. It stands next to the fishing spots and logs out... Really odd.

That's an error I'm aware of. I'm working on a really gross network of failsafes for it right now actually.

E: Something to do with the check to see if it's at the dock. It checks for the fishing spot, and for some reason it isn't finding the fishing spot at all times. I'm making a couple more failsafes, haha. It has around 5 already.
06-13-2010, 05:37 PM
masterBB

PHP Code:

procedure WaitForFish; var fails:Integer; begin repeat wait(100); if(GetAnimation = -1) then fails := fails +1; until(fails > 4); end;

I suggest using a procedure like this one. Its a lot faster than your check.
06-13-2010, 05:45 PM
3Garrett3

Quote:

Originally Posted by masterBB

PHP Code:

procedure WaitForFish; var fails:Integer; begin repeat wait(100); if(GetAnimation = -1) then fails := fails +1; until(fails > 4); end;

I suggest using a procedure like this one. Its a lot faster than your check.

My check for what? :\

The fail is coming in Reflection's minor messups where it does not think that there is a fishing spot anywhere on the client, but it is clearly there.

The check for if it is fishing has no effect on if it fails, AFAIK. If it is failing after it starts fishing for you, then I will have to fix something else. For me, it just doesn't think that there is a fishing spot on the map, so it quits.
06-13-2010, 06:00 PM
masterBB

It wasn't related to those fails. But your check for the fishing spot sometimes bugs a little, between every animation there is short time where your animation is -1. You wait for a random range from 1250 to 1500ms. But there still is change that it is -1 again and than it will click for no reason. When you level up or the fishing spot disappears, than your char will wait for 1250 to 1500 ms. With my function 500. Thats why I suggest my function over yours. I improve all the scripts I download, and this is just some feedback.
06-13-2010, 06:03 PM
3Garrett3

Quote:

Originally Posted by masterBB

It wasn't related to those fails. But your check for the fishing spot sometimes bugs a little, between every animation there is short time where your animation is -1. You wait for a random range from 1250 to 1500ms. But there still is change that it is -1 again and than it will click for no reason. When you level up or the fishing spot disappears, than your char will wait for 1250 to 1500 ms. With my function 500. Thats why I suggest my function over yours. I improve all the scripts I download, and this is just some feedback.

Ohh. I'm stressing about this fishing failure thing, sorry.

I can see the logic in that. I'll update it with something similar to what you suggested :)
06-13-2010, 06:07 PM
masterBB

Is there any reason why set the run thing on false when walking to the stiles/shop? It is faster to set it on true, I got enough energie for it...

Sometimes this scripts works for a long time, really nice script:D
06-13-2010, 06:14 PM
3Garrett3

Quote:

Originally Posted by masterBB

Is there any reason why set the run thing on false when walking to the stiles/shop? It is faster to set it on true, I got enough energie for it...

Sometimes this scripts works for a long time, really nice script:D

I have it set to not run to the store, and run back. I figured that having a load of fish would deplete the energy a large amount, and wouldn't allow it to run the whole way back. It's not a big deal really, autoing isn't always as fast as legit players ;).

If you could post a proggy I'd be mighty happy ;).

I'm still working on the fishing spot failure btw.
06-13-2010, 06:16 PM
masterBB

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 56 Minutes and 52 Seconds
Fished : 168 Total Fish
Fished : 101 Tuna
Fished : 67 Swords
*********************************************
0: upah | 168 Fish | 7 Loads | 0 Levels | 14620 Experience|
-ended with random

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 1 Hours, 3 Minutes and 47 Seconds
Fished : 192 Total Fish
Fished : 101 Tuna
Fished : 91 Swords
*********************************************
-ended with known fishing bug
06-13-2010, 08:33 PM
gamer716

Code:

3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 36 Minutes and 50 Seconds Fished : 125 Total Fish Fished : 65 Tuna Fished : 60 Swords ********************************************* 0: reat | 125 Fish | 5 Loads | 0 Levels | 11200 Experience| [15:13:10] Fishing Failed

The biggest issue is finding the fishing spot
06-13-2010, 09:17 PM
3Garrett3

Quote:

Originally Posted by gamer716

Code:

3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 36 Minutes and 50 Seconds Fished : 125 Total Fish Fished : 65 Tuna Fished : 60 Swords ********************************************* 0: reat | 125 Fish | 5 Loads | 0 Levels | 11200 Experience| [15:13:10] Fishing Failed

The biggest issue is finding the fishing spot

There is a rather large update in the making that will hopefully fix that.
06-13-2010, 09:52 PM
masterBB

HTML Code:

3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 1 Hours, 40 Minutes and 39 Seconds Fished : 288 Total Fish Fished : 156 Tuna Fished : 132 Swords ********************************************* 0: upah | 288 Fish | 12 Loads | 1 Levels | 24280 Experience|

It got a random while fishing...

HTML Code:

[23:58:31] Fishing Spot not found [23:58:31] Fishing Failed 1.8602576494216919E+0002 True [23:58:34] Walking To Shop/Trade [23:58:36] Distance to Shop/Trade := 2117 3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 6 Minutes and 17 Seconds Fished : 24 Total Fish Fished : 9 Tuna Fished : 15 Swords ********************************************* 0: upah | 24 Fish | 1 Loads | 0 Levels | 1620 Experience| 3.5442422389984131E+0002 False
06-13-2010, 09:55 PM
3Garrett3

Quote:

Originally Posted by masterBB

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 1 Hours, 40 Minutes and 39 Seconds
Fished : 288 Total Fish
Fished : 156 Tuna
Fished : 132 Swords
*********************************************
0: upah | 288 Fish | 12 Loads | 1 Levels | 24280 Experience|

Failed because of fishing error?

PHP Code:

3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 1 Hours, 31 Minutes and 50 Seconds Fished : 250 Total Fish Fished : 106 Tuna Fished : 69 Swords Fished : 75 Lobsters *********************************************

Hasn't failed yet, with the new failsafes I've added.
06-13-2010, 10:01 PM
masterBB

I will download the new version. But there is/was something wrong with your random checks... it thought it needed to go to stiles during a random ^^ See my post above
06-13-2010, 10:03 PM
3Garrett3

Quote:

Originally Posted by masterBB

I will download the new version. But there is/was something wrong with your random checks... it thought it needed to go to stiles during a random ^^ See my post above

I haven't updated the first post yet. I will in a few more minutes of tinkering, especially since for some reason it didn't check randoms.. There is definitely a random check while fishing and before walking.

E: A nice sized update :)

E2: Updated it again. Fixed netting. For an accurate proggy, change "Version" in the constants that aren't meant to be touched to '0.25' or it will still say 0.1.

E3: Proggy. Manually stopped to apply the fixes I've added.

PHP Code:

3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 4 Hours, 24 Minutes and 36 Seconds Fished : 500 Total Fish Fished : 205 Tuna Fished : 145 Swords Fished : 150 Lobsters ********************************************* 0: | 350 Fish | 16 Loads | 2 Levels | 30060 Experience| 1: | 150 Fish | 7 Loads | 2 Levels | 12780 Experience| 2: | 0 Fish | 13 Loads | 12 Levels | 1830 Experience| Successfully executed.
06-14-2010, 03:38 PM
masterBB

HTML Code:

3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 3 Hours, 21 Minutes and 1 Seconds Fished : 300 Total Fish Fished : 171 Tuna Fished : 129 Swords Rested: 1 Times Rested for: 30 Minutes and 58 Seconds ********************************************* 0: upah | 300 Fish | 12 Loads | 1 Levels | 26320 Experience|

Stopped myself, 300 fish!:D
06-14-2010, 09:19 PM
3Garrett3

Quote:

Originally Posted by masterBB

HTML Code:

3Garrett3's Fisherer 0.1 Progress Report ********************************************* Ran for: 3 Hours, 21 Minutes and 1 Seconds Fished : 300 Total Fish Fished : 171 Tuna Fished : 129 Swords Rested: 1 Times Rested for: 30 Minutes and 58 Seconds ********************************************* 0: upah | 300 Fish | 12 Loads | 1 Levels | 26320 Experience|

Stopped myself, 300 fish!:D

:). Mine ran for 7 hours last night, but I forgot to add sleeping in the proggy, so I don't know how long it actually ran.

Oh, BTW, there will be sleeping in the next version ;). Basically every X hours it will rest for Y hours, as if you were taking a break. It does it regardless of the amount of active players, where resting is only one active player. The user gets final say in how often and how long, and whether to even use it :)

Edit:

V 0.5 is being tested tonight. We'll see how it goes. There is ~ 1200 lines of code right now. Six fail safes for the fishing spot. More organized code IMO, and the "Highest" option will actually work in theory now, I messed it up in the last version.
06-15-2010, 07:16 AM
kingarabian

It wont note my lobbies. It walks to the dude, clicks on him, and when the part to confirm exchanging the fishies, it starts walking back to the dock.

Edit: It's working properly now.

Show 40 post(s) from this thread on one page