Herblore PRO

Hey, back in SRL, made new script:

~Herblore PRO~


Features:

Makes Unfs/Potions and cleans herbs!
Supports almost all unfs and most common potions.
Unfs/Cleans:

PHP Code:

---

Guam, Marrentill, Tarromin, Harralander, Ranarr, Toadflax, Irit, Wergali,
Avantoe, Kwuarm, Snapdragon, Dwarf, Torstol, Cadantine, Lantadyme 


---

Potsions:

PHP Code:

---

Attack, Strength, Restore potion, Energypotion, Defence potion, Prayer,
Crafting, Super attack, Super antipoison, Super strength, Super restore,
Super defence, Ranging potion, Magic potion, Saradomin brew 


---

Setup:
Setup in GUI:
http://img228.imageshack.us/img228/623/111110121533.png

note: Try to keep similar herbs/unfs in other tabs, like Guam/torstol etc. for smooth perfomance...

To Do List:
1. Add Extremes and Ovl
2. Need better Proggy
3. Need paint in SMART.


Post reports/suggestions/bugs, Thanks.

Looks great! Could you maybe add an option for antifire potions? (Lantadyme(Unf) + ground dragon scales I think?)

Rep+.

nice that you encode the pass and stuff:P

Quote:

---

Originally Posted by Flight

Looks great! Could you maybe add an option for antifire potions? (Lantadyme(Unf) + ground dragon scales I think?)

Rep+.

---

Yeah, starting to work on Extremes soon, then I add it, and Ovls also, few things alos in "under construction" atm.

Thanks for the release. Rep + :)
It working really great and the form is very nice to :)

One thing I would suggest, is that you make it stop and log off when it runs out of herbs or vials.

Can do the first trip nicely, but messes up at loop. Any chance of a fix? :)

Quote:

---

Originally Posted by Chpp

Can do the first trip nicely, but messes up at loop. Any chance of a fix? :)

---

What you "mean messes up"?

Quote:

---

Originally Posted by tico2

One thing I would suggest, is that you make it stop and log off when it runs out of herbs or vials.

---

Fixed, Thanks :P

I'm making super attacks out of irit unf potions. It usually does the first inventory well, however, after that, it withdraws 14 eys of newt, closes bank, deposits all, withdraws 14 eyes of newt and loops that circle.

May be a problem with my client setup, I'm new here. I did all the steps introduced at the threads, but it still does that. Any ideas?

Btw, greetings from estonia :P

Quote:

---

Originally Posted by Chpp

I'm making super attacks out of irit unf potions. It usually does the first inventory well, however, after that, it withdraws 14 eys of newt, closes bank, deposits all, withdraws 14 eyes of newt and loops that circle.

May be a problem with my client setup, I'm new here. I did all the steps introduced at the threads, but it still does that. Any ideas?

Btw, greetings from estonia :P

---

Hmm, looks like it doesn't find irit unf, made new DTM for it, maybe the color was off, try redownloading version 1.1, and see if that works

The form looks awesome! :)

Thanks for the release, I'm sure to use this when taking up on herblore in the next couple of weeks.

It wasnt able to find the al karad bank when i started it, moving to varrock to see if that solves the problem. Script looks great otherwise.

UPDATE: Yeh works flawlessly so far at West Varrock Bank

Seems like it works. Thanks for the update man.

//Edit: It worked for about 8 minutes and then stopped working, now restarting says out of supplies even tho i have 5k irit unf's and 9k eyes of newt.

Edit 2: Moved ingredients to bank slots 1&2, worked for 1h 18min and then stopped for unknown reason (didn't specify in console and i wasn't at the computer).

Good enough for me :)

There's a bug in your MakePotions script:

Simba Code:

repeat
    FindNormalRandoms;
    Failsafe:= 0;
    LevelUp;
    Wait(500 + Random(300));
    Inc(Failsafe);
    if (FailSafe = 5) or (FailSafe = 10) then
      AntiBan;
  until  (not(FindDTM(First, x1, y1, MIX1, MIY1, MIX2, MIY2))) or (Failsafe = 20);

Take a close look at the Failsafe variable. First you set it to 0 and increment one (so it will be 1), then you compare to see if it is 5, 10, or 20. But as it's always 1, those are useless thus your loop might just be infinite and your antiban won't work. You might just want to fix that :)

Form looks good! Might wish to add that if the user presses the close (X) button, it just frees and terminates script instead of starting to do stuff. You could also disable resizing of the form and fix the Exit button to work.

Bank function might also have a bug:

Simba Code:

if (not(BankScreen)) then
    begin
      if (not(OpenBank(WBank, False, False))) then
        WriteLn('Error: Cant open bank');
      Wait(200 + Random(300));
      if BankScreen then
        Wait(200 + Random(300));
        FixBank;
        if (not(InvEmpty)) then
          DepositAll;
    end;

Either your indention is off (after the if bankscreen part) or you forgot a begin/end. Also, just writing there's an error and then continuing happily also doesn't yield expected results. Get some proper failsafes there! You did it right with the WithdrawItems.

Hope this might help you with improving your script. Don't forget to keep up the good work! I didn't actually run the script but these were the few things I saw first.

Awesome notes Markus, Thanks!

Yes, changed few things dramatically before the relese, thatswhy the bank function is way off...

Tere, tere, kaasmaalane! :)

Kiidan tööd! :) Ega ei ole lähiajal plaanis herb cleanerit teha? :)
Keep up the good work!!
~Eerik.

Quote:

---

Originally Posted by Heavenzeyez1

Tere, tere, kaasmaalane! :)

Kiidan tööd! :) Ega ei ole lähiajal plaanis herb cleanerit teha? :)
Keep up the good work!!
~Eerik.

---

Heh, Tere!
Kle plaan lisada see siia scripti, vaatab kuidas aega saab :P Extremes veel vaja ennem lisada :P
Tänud :P

hi guys

I am new here and just getting up to speed. I am after a Unf pot maker.

may i ask first how many Pots can this make an hour?

many thanks#
Ghola

I will be testing this soon, and going for 99 herb if works well.

ill try it out

Quote:

---

Originally Posted by Heavenzeyez1

Tere, tere, kaasmaalane! :)

Kiidan tööd! :) Ega ei ole lähiajal plaanis herb cleanerit teha? :)
Keep up the good work!!
~Eerik.

---

Gotta love eesti keel. It's weird after decades and decades we still find Estonian funny.

Greetings from Finland.

Sorry for offtopic, I just had to. :p

I have been having some problems lately. I've tried searching around the forums but I haven't found any solutions. When I start the script, I fill out the form, but SMART won't launch. I've tried reinstalling my simba but it still happens. Any ideas?

Quote:

---

Originally Posted by tico2

I have been having some problems lately. I've tried searching around the forums but I haven't found any solutions. When I start the script, I fill out the form, but SMART won't launch. I've tried reinstalling my simba but it still happens. Any ideas?

---

Hmm, it takes ~20-30 seconds for SMART to pop out...

This script works flawless except for one thing...lol im not sure if im not correct or not..but with the scroll of cleansing it just waits for the herb to be finished and when it doesnt, it just simply logs out...

False alarm...it works flawless :)

Hi Neeger

I am having an issue with it finding Clean irits in slot 1 when they are there

I am using 1.1 (and tried 1.2) but I get this message.

http://puu.sh/8lUL

If I put them in the inventory it works but then stops again
it has found the Vials, see it hovering over the combat bracelet..

http://puu.sh/8lVf

I can't seem to get it into Software mode, is this the problem? I am running it in Safe mode

many thanks
Ghola

Quote:

---

Originally Posted by neeger

Hmm, it takes ~20-30 seconds for SMART to pop out...

---

I usually wait around 5-10 minutes, and it still doesn't start. I get it to work like every 20 tries.

Quote:

---

Originally Posted by The Ghola

Hi Neeger

I am having an issue with it finding Clean irits in slot 1 when they are there

I am using 1.1 (and tried 1.2) but I get this message.

http://puu.sh/8lUL

If I put them in the inventory it works but then stops again
it has found the Vials, see it hovering over the combat bracelet..

http://puu.sh/8lVf

I can't seem to get it into Software mode, is this the problem? I am running it in Safe mode

many thanks
Ghola

---

I think problem is that you have 5k irits :p Fixed that, try redownloading 1.2 and see if that works.
P.S Little tip: move vials and herbs to right side of bank, it works faster that way, mouse has to "travel" less distance ;)

** Warning in WithdrawItem: Could not Find dtm in Bank. [Uptext: a]**
Out of supply?

it finds it about 5 runs and than always this, with 4 different potions of unf

super restore banks while still working, does 12 and opens bank

Thanks for that neeger

I have downloaded the new version and moved the items to the right

and it is working fine so far after about 100 of them.

Many thanks for the quick response and resolution

Ghola

Quote:

---

Originally Posted by Spelletje

** Warning in WithdrawItem: Could not Find dtm in Bank. [Uptext: a]**
Out of supply?

it finds it about 5 runs and than always this, with 4 different potions of unf

super restore banks while still working, does 12 and opens bank

---

What RS graphic settings you use?
USe this:
http://img845.imageshack.us/img845/5...1101124709.png

ANd seems Jagex has relesed some anti color botting system-items change color/shape, but atm script still works.

Jep that is what I use. Would it not be easier to add a line where the user should specify the locations of the items needed to do the job

for example tab ,7 box 2, box 3

Would that not make it easier for the script, it would not need to look for the items just use what is in the locations specified.

Hi Neeger

Another issue to report

Update: this has happened 5/6 times today so far

I run it for a while and then it stops with this info

http://puu.sh/8nhy

Good news is tho that it has done 3400 of the 5000 irits I have.

Please can you help

Regards
Ghola

PS, i hope this is helping you in some may. I have an ISEB Testing Practioner qualification and have managed testing phases of projects. Currently training as Project Manager with PRINCE2

Hey, The Ghola

Hmm, its not my script, It's something to do with SRL, does a new tab pop out if you get that error?

Yes, it does,

Here is a full screenie:

http://puu.sh/8nDh

It's stopping working at all for me now, wont withdraw the Irits.

It seems to be stuck in a loop withdrawing and depositing in the 14 Vials

this is all with the same message above

Hello there, love this script but having a few problems. After a random amount of loads, sometimes 1, sometimes 10, sometimes 20, etc., it logs out and I'm given the same error as what the Ghola is getting. "DTMs were not freed: [SRL - Lamp bitmap, 1] and so on. Just reporting the same bug here. Thanks!

Something is wrong with SRL, some bug, I look into it.

Quote:

---

Originally Posted by neeger

Something is wrong with SRL, some bug, I look into it.

---

Awesome. Also, I'm using 1.0 right now and it seems to be working better than 1.2, just letting you know.

thanks Neeger

I am trying v1.0 now and it is workign but it start by just withdrawing the vials only I had to stop it and put the herbs into the Invent manually then restart it and it has worked.

All a bit peculiar

Good luck
GHola