iCleaner [Herblore] [Grimy herb cleaner]

Hey, this is my first script, feel free to give me your opinions or if you do script your self please review how I'm doing so far xD.

No need to input what herb you want to clean, just select your banking settings and it will do the herb in the slot you choose, just make sure that other herbs are not visible, otherwise it will not detect being out of herbs and stop.

Has a basic anti-ban and also 15 different cleaning paths, i will add more when i get time, and cleans roughly 3800 herbs per hour :)

Instructions inside script.

Enjoy! :spot:

---

Got me 50 - 70 herblore to far :), going to do a complete re-write of this script soon.


~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 12:02:17
Herbs cleaned: 45808
Loads cleaned: 1636
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This procedure is blank, why?

Simba Code:

Procedure setDTM;
begin




end;

You don't need this if you are using SMART. :)

Simba Code:

ActivateClient;

You shouldn't use global variables. You should use local variables as much as you can.

Simba Code:

var
HERB, X, Y, BankTabOfHerb, BankSlotX, BankSlotY, ISlot, HERBS_CLEANED:Integer;
DTMString:String;
UseAntiban:Boolean;
Pattern, Clock:TIntegerArray;

You need to work on your standards.

Other than that, this is a great first script. :) I'm very excited to see what you create in the future and what you make of this script!

Quote:

---

Originally Posted by RISK

This procedure is blank, why?

Simba Code:

Procedure setDTM;
begin




end;

You don't need this if you are using SMART. :)

Simba Code:

ActivateClient;

You shouldn't use global variables. You should use local variables as much as you can.

Simba Code:

var
HERB, X, Y, BankTabOfHerb, BankSlotX, BankSlotY, ISlot, HERBS_CLEANED:Integer;
DTMString:String;
UseAntiban:Boolean;
Pattern, Clock:TIntegerArray;

You need to work on your standards.

Other than that, this is a great first script. :) I'm very excited to see what you create in the future and what you make of this script!

---

Oh yeah, i forgot to delete that method, i was going to try making a GUI and that was going to be the method to set the DTM, didn't make it in the end or need it in and forgot to remove it.

Thanks for pointing those things out too. helps me learn.

Also could you explain to me what the benefits are of using local variables :)?

Code:

---

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
 Time running: 1:7:26
Herbs cleaned: 4988
Loads cleaned: 178
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

---

Nice job man. Worked flawlessly. Although, once it's done, it will start withdrawing whatever was in the set bank slot. Just a suggestion, but adding in a check for the uptext wouldn't hurt.

Quote:

---

Originally Posted by TsterT

Code:

---

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
 Time running: 1:7:26
Herbs cleaned: 4988
Loads cleaned: 178
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

---

Nice job man. Worked flawlessly. Although, once it's done, it will start withdrawing whatever was in the set bank slot. Just a suggestion, but adding in a check for the uptext wouldn't hurt.

---

Thanks for the feedback :D

That usually happens when another herb is visible in bank, will sort this out soon :)

Looks like a very nice script, do you make any cash off it? Or do you lose some?

Quote:

---

Originally Posted by Gushers

Looks like a very nice script, do you make any cash off it? Or do you lose some?

---

http://runescape.wikia.com/wiki/Calc...Herblore/Herbs
Check profits/losses here :), although i suggest trialling them before you do them, buy, clean, sell, grand exchange fluctuates a lot.

does this script support soul wars bank?
Gratz on first script btw :p

lovely script mate its clean 20k cads for me today

Quote:

---

Originally Posted by lordvolt

does this script support soul wars bank?
Gratz on first script btw :p

---

Only supports NPC banks at the moment, will add an option soon, im working on a safe cracker at the moment though :)

Quote:

---

Originally Posted by walsh145

lovely script mate its clean 20k cads for me today

---

Nice one, proggie would have been sexy xD

stopped the script so no proggy just making them into unfin cad pots gonna takes ages lol then do another 20k after sold pots

Quote:

---

Originally Posted by walsh145

stopped the script so no proggy just making them into unfin cad pots gonna takes ages lol then do another 20k after sold pots

---

Nice, that must be some nice profits rite there, I might make an option to make unfinished potions after cleaning all of the herbs. I also want to make a GUI.

Gonna load out 400k - 500k herbs of some sort now, I'll post what happens in a few days.

If all goes well, I'll retest with a million. See how it turns out. Endurance testing is the best :)

Oh, forgot to mention, I'm spreading the herbs over 5 member accounts, standing in 5 different worlds from 5 different computers, 5 different banks and 5 different herb types, just incase they try to ban them :D

Bank Pin could be added too:

Simba Code:

Players[0].Pin :='';//Bank pin

Underneath the active player.

going to try out this script, would i get banned useing it ?

Quote:

---

Has a basic anti-ban

---

:duh:

Good stuff man, I'm tryna hoan on m pascal language as we speak lol.

(:

Good luck karter :D, post a couple proggies.

--

fagex, it has an anti-ban, but its not all down to the anti-ban, its how you use it, your more likely to get banned if you get reported multiple times, that's like 80% of jagex's banning system :P, so i suggest its a fairly populated place (So theres less change of people talking to you out of a larger amount of people) or a quickchat world.

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 0:57:48
Herbs cleaned: 4284
Loads cleaned: 153
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Around 4350 Herbs an hour man, good so far. I started this bot first, the other 4 took a while because of my incompetence to store my account details so I'll post them when I wake up.

Looks good though, they're avantoe's I'm cleaning. Thats a profit of:

4350 / hour = 565K / HOUR!!!!

Seriously, bot nuke on reflection and injection was amazing for things like herbs. 130 profit per avantoe, I'm level 65 herb on my secondary account now.

I don't merchant, cannot wait until other prices deflate too!

Quote:

---

Originally Posted by iCURiP

Only supports NPC banks at the moment, will add an option soon, im working on a safe cracker at the moment though :)

---

k, would be very nice to see sw :p.

Quote:

---

Originally Posted by lordvolt

k, would be very nice to see sw :p.

---

Got chest banking done, although iv already updated the script to SRL-5 so it will be released when that is released.
Also now has a paint.

I was reading through your code, and I realized something: I was reading through your code! This is the first script I looked through and understood without having to analyze everything 10 times! I am stoked.

Btw, I am using this script as we speak. 67-70 herblore through cleaning grimy cadantines. I will post a proggy for you, as well as any bugs I see.

works great!

thanks (:

Time running: 0:39:1
Herbs cleaned: 2729
Loads cleaned: 97

You planning adding unfinished potions? I've modified mine to do them but it isn't anti-ban (just goes 1 and 15, 2 and 16, 3 and 17, etc)

oh, and here's a 12 hour update

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 12:02:17
Herbs cleaned: 45808
Loads cleaned: 1636
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Profit of 5,955,040 or about 6 million gp.

Thanks bro.

Found a bug: occasionally, the camera rotates as an antiban and the cursor cannot find the banker again, resulting in random antibans and cursor movements all over.

Edit: I am running this at the G E. So the roof of the little exchange area is blocking the banker. I am not sure if this would affect actual banks.

Quote:

---

Originally Posted by Grihmm

Found a bug: occasionally, the camera rotates as an antiban and the cursor cannot find the banker again, resulting in random antibans and cursor movements all over.

Edit: I am running this at the G E. So the roof of the little exchange area is blocking the banker. I am not sure if this would affect actual banks.

---

If this is a problem then remove line 75, saying this:

Simba Code:

3: RandomMovement;

This will stop the arrow keys so the camera won't move. The other four anti-ban features should take care of it.

Oh and you should run it at something like Tree Gnome Village. It's far away from any activity, and I'd run it on a quick-chat world too. Less risk of any reports from anyone :)

Quote:

---

Originally Posted by karter50

If this is a problem then remove line 75, saying this:

Simba Code:

3: RandomMovement;

This will stop the arrow keys so the camera won't move. The other four anti-ban features should take care of it.

Oh and you should run it at something like Tree Gnome Village. It's far away from any activity, and I'd run it on a quick-chat world too. Less risk of any reports from anyone :)

---

Exactly what i was going to say lol.

Also explain what you modified again i didn't really understand.

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:8:16
Herbs cleaned: 2876
Loads cleaned: 102
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It has been 3 minutes and Runescape is not yet ready... Terminating.
Make sure your settings are set to fixed screen
Successfully executed.
The following DTMs were not freed: [2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131,

I was at G E and it self-terminated. I believe because of the camera angle changing.

People having issues at GE just run a little south to varrock west :p

Quote:

---

Originally Posted by iCURiP

People having issues at GE just run a little south to varrock west :p

---

i can confirm that varrok west works great!

I am using it now. Btw, the Gnome Stronghold bank didn't work for me. Then again, gnome bankers are different than human ones.

Good script.

Average ~4200 herbs cleaned

I added MouseKeys to the cleaning procedure and well report back how many an hour it can do.

Quote:

---

Originally Posted by imaloser

Good script.

Average ~4200 herbs cleaned

I added MouseKeys to the cleaning procedure and well report back how many an hour it can do.

---

sure that's safe lol, of course mouse keys are legit but surely its a bit risky?

nice script man

try using things like:

Simba Code:

Procedure BankDoesNotContainHerb;
var
  i: integer;
begin
  For i := 0 to 4 do
    if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
      begin
        writeln('OUT OF HERBS, LOGGING OUT!');
        CloseBank;
        Logout;
        TerminateScript;
      end else
        break;
end;

instead of:

Simba Code:

Procedure BankDoesNotContainHerb;
begin
    if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
    if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
    if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
    if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
    if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
    writeln('OUT OF HERBS, LOGGING OUT!');
    CloseBank;
    Logout;
    TerminateScript;

end;

orr something like that u know
avoid typing the same line multiple times

Quote:

---

Originally Posted by iCURiP

Exactly what i was going to say lol.

Also explain what you modified again i didn't really understand.

---

I added two things:

1) A bank pin option.

2) Ability to make unfinished potions out of the cleaned herbs in the bank (but yeah it's your script with some stuff changed)

NOTE: TARROMINS ARE NOW THE BEST HERB TO DO FOR PROFIT, SIMPLY BECAUSE AVANTOES ARE SO HARD TO BUY!

Quote:

---

Originally Posted by iCURiP

sure that's safe lol, of course mouse keys are legit but surely its a bit risky?

---

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:30:46
Herbs cleaned: 12546
Loads cleaned: 231
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

http://images1.wikia.nocookie.net/__...keys%2Bkey.png

Quote:

---

Originally Posted by imaloser

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:30:46
Herbs cleaned: 12546
Loads cleaned: 231
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

http://images1.wikia.nocookie.net/__...keys%2Bkey.png

---

Nice :P, I know its legit but mouse keys are tricky to 100% simulate, if you get it off a bit then your screwed :/

Quote:

---

Originally Posted by Grihmm

I am using it now. Btw, the Gnome Stronghold bank didn't work for me. Then again, gnome bankers are different than human ones.

---

Gnome Bankers don't work, sorry about that :3 Although if they did it's the best place to do it.

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:21:23
Herbs cleaned: 5778
Loads cleaned: 206
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

:)

Finished the 500k and made 66m, thanks :D

Closer to my 100b target nao :D