Printable View
Ill take a look one second.Quote:
Originally Posted by chan1146
Youre right I dont see one. Ask NATHAN if he can add it. Im sure he will be happy to help. When he signs in and looks at the thread he will acknowledge the problem and quickly fix it. If you can fix it go right ahead otherwise you will have to wait.
Alright thanks for checking :D.Quote:
Originally Posted by kevin33
Nathan!!!!!! Please add it!!!!! :DD
EDIT: This Script is very good, just needs to have bank pin.
Ooh, I hadn't even realized I didn't include bank pin support, I don't have one, next release will have it.
Plans for next release:
Bank pin support
Dynamic waiting for those with laggier connections
Any other suggestions?
New bank spot maybe?^
If you can give me a valid reason on why this is a good idea I will. At soul wars there are no randoms, so thats a pretty tough reason to use it to beat...Quote:
Originally Posted by IbotI
Thank you for creating this script! Huge Thanks!
Hey! This script is absolutely wonderful! Great job! So far I've had no problems, but I did want a "Planks/hour" added to the progress report. I thought about coming to suggest it, but instead I just figured it out on my own and it just showed me even more how great this script is!
Here's a small proggy with the planks/hour in it
http://i40.tinypic.com/fsbrn.jpg
Here's the part for planks/hr if anyone wants it or anything:
Simba Code:Writeln('Planks Made: ' + inttostr(GainedXP/90) + ' || ' + XPPerHour(GetTimeRunning,GainedXP/90) + ' Planks/hour ');
EDIT:
Also, some people were complaining about the Bank Slot, so here's a quick fix for that... I didn't really mess with it too much, mainly because I'm not completely educated, but here's what I came up with.
I made it so that the user can put in the bank slot that they want to use by putting in the column and row numbers
Simba Code:const
//*****************Edit*********************//
SERVER = 6; //Set a server here.
INVENTORIES_TODO = 1968; // How many loads should we go through?
GAIN_PER_CAST =108; // How much do we make or lose per cast?
BankCol=0; //log col in bank
BankRow=0; //log row in bank
And for the procedure, I just edited what you already had, took away, and added some. I'm not sure how efficient this portion is, but I guess it just needs some testing. Anyways, here's what I have for that.
This may also fix that small bug for the laggy users.
Simba Code:procedure WithdrawLogs;
begin
if(BankScreen) then
begin
FixBank;
WithdrawEx(BankCol,BankRow,0,['any logs']); //Withdraws logs from specified slot
Wait(1000+random(20));
if InvFull then
end else
begin;
OpenChest();
DepositAllButRunes;
WithdrawLogs;
end;
invFinished:=false;
end;
Hey, that's pretty impressive for someone with 3 posts! I like what you did with the progress report, I'll probably stick that in the next version. I don't really feel the bank thing is that necessary, putting it in a specific slot shouldn't be a big deal. But the main reason is because the built in srl function won't do any better than what I did for lagginess. Still impressed though!Quote:
Originally Posted by Fwd Motion
I'm busy getting 95 prayer today, but after that I'll be coding the next version that has the laginess fixed in it!
I just joined yesterday and I'm very intrigued by this community and I'm doing everything I can to learn to script. I messed with your script like all night last night, I think I'm going to try to write a simple script today.Quote:
Originally Posted by [Nathan]
Anyways, I honestly don't see the need for a specific bank slot either, but I was just challenging myself to see if I could figure it out.
Anyways, great script! (:
***************Nathan's Magic Planker***************
********** Inventories: 47 Planks: 1203 **********
************************************************** **
Running for: 1 Hours, 7 Minutes and 57 Seconds
Missclicks (on purpose): 33 || 0.70212765957446 avg/inventory
Random waits: 34 || 0.72340425531914 avg/inventory
Antiban actions: 28 || 0.59574468085106 avg/inventory
Exp Gained: 108270 || 95602 exp/hour
We have made/lost: -116691 gp || -103038 gp/hour
Restarted to add more loads, gonna run it overnight, works flawless, awesome antiban :D
Im planning on some scripting soon, could i copy your sw bank script? Ill credit it to you, of course.
375 loads complete. Switching to next player!
NextPlayer(False
********** Inventories: 265 Planks: -297342 **********
************************************************** **
Running for: 6 Hours, 3 Minutes and 25 Seconds
Missclicks (on purpose): 205 || 0.77358490566037 avg/inventory
Random waits: 137 || 0.51698113207547 avg/inventory
Antiban actions: 138 || 0.52075471698113 avg/inventory
Exp Gained: -26760782 || -84813 exp/hour
We have made/lost: 18582340 gp || -83595 gp/hour
SRL and MSI got updated overnight. might explain the buggy proggy, anyway: 7k planks done, ty :D
EDIT 2: I really enjoy the explainations in your script :D. This allows me to read what the script does, so i can learn from it!
Alright, so I frequently get the "Out Of Range at line 446" error, for some reason and I've tried a few way to try and stop it, but no luck...
The problem seems to be when it somehow exits the bank without logs then clicks the magic tab, then the magic spell, but there's no logs to click on, so it brings up this error. I tried adding failsafes, like using "if not invfull then" but it somehow managed to get around that.
I've given up trying, sometimes it will run for hours, but other times it will run for 10 minutes. I'm not so sure why this is happening.
EDIT:
Okay, so after watching it for a while, it will also shut down if it failed to deposit the planks. So I have created a pretty failproof procedure (while I'm sure it could be better written) to solve this, just added it to the Main Loop, along with a CloseBank; command before this procedure.
Here is it:
Simba Code:procedure CheckInv;
begin
sleep(150+random(100));
if not InvFull then
begin;
OpenChest();
DepositAllButRunes;
WithdrawLogs;
CheckInv;
end;
if InvFull then
begin;
MMouseItem(1);
sleep(250+random(100));
while not(IsUpText('any logs')) do
begin;
OpenChest();
DepositAllButRunes;
WithdrawLogs;
CloseBank;
sleep(200);
CheckInv;
end;
end;
end;
EDIT2:
I also noticed that because of the camera angle and compass settings, the script would sometimes misclick and click on that npc walking around (can't remember the name), so I just changed the compass to 'S' and added "SetAngle(0);" and it made clicking the bank chest significantly faster.
BTW, thanks so much for this script! I'm getting closer and closer to 99 mage! (:
Working pretty much flawless for me so far
***************Nathan's Magic Planker***************
********** Inventories: 261 Planks: 6681 **********
************************************************** **
Running for: 5 Hours, 14 Minutes and 13 Seconds
Missclicks (on purpose): 68 || 0.26053639846743 avg/inventory
Random waits: 164 || 0.62835249042145 avg/inventory
Antiban actions: 146 || 0.55938697318007 avg/inventory
Exp Gained: 601290 || -112996 exp/hour
We have made/lost: 594609 gp || 113541 gp/hour
http://img716.imageshack.us/img716/9341/81094544.png
Thanks Nathan!
Wow! Congratulations, chan1146! :o
7k planks til 99 for me
Thanks so much NATHAN! (:
Doesn't work for me, script doesn't take out the logs just puts the mouse over them, then closes the bank and do plank make on nothing in inventory :P. Please fix :), will post 99 mage prog (96 atm)
Did you fill out everything in the script?Quote:
Originally Posted by santa wewt
You can help it getting started by disabling smart and then cast 1 spell, bank, etc, get everything started and then enabling again.
- Try reloading the script, problems like these occur to me from time to time too, just reload it couple of times, and help it going. I usually start with logs in invent, seems to allow an easier start.
***************Nathan's Magic Planker***************
********** Inventories: 46 Planks: 1153 **********
************************************************** **
Running for: 1 Hours, 3 Minutes and 54 Seconds
Missclicks (on purpose): 48 || 1.04347826086956 avg/inventory
Random waits: 25 || 0.54347826086956 avg/inventory
Antiban actions: 22 || 0.47826086956521 avg/inventory
Exp Gained: 103770 || 97436 exp/hour
We have made/lost: 112994 gp || 106097 gp/hour
still running / same run / afking all the way, i love this script nearly 98 mage now :D
***************Nathan's Magic Planker***************
********** Inventories: 105 Planks: 2687 **********
************************************************** **
Running for: 2 Hours, 28 Minutes and 45 Seconds
Missclicks (on purpose): 109 || 1.03809523809523 avg/inventory
Random waits: 61 || 0.58095238095238 avg/inventory
Antiban actions: 54 || 0.51428571428571 avg/inventory
Exp Gained: 241830 || 97544 exp/hour
We have made/lost: 263326 gp || 106215 gp/hour
I got 99 mage!
Last run was for six hours straight!
Gratz FWD :D
***************Nathan's Magic Planker***************
********** Inventories: 77 Planks: 1922 **********
************************************************** **
Running for: 1 Hours, 48 Minutes and 3 Seconds
Missclicks (on purpose): 63 || 0.81818181818181 avg/inventory
Random waits: 33 || 0.42857142857142 avg/inventory
Antiban actions: 30 || 0.38961038961039 avg/inventory
Exp Gained: 172980 || 96055 exp/hour
We have made/lost: 188356 gp || 104593 gp/hour
Error: Out Of Range at line 458
The following DTMs were not freed: [0, SRL - Lamp bitmap, 2]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap]
Highlighted: MouseItem(invArray[click],1); (line 458)
This happens to me pretty often, it logs the character into lobby. Whenever it happens is random: sometimes within 15 mins, sometimes after like 2 hours and i've also managed an 6hr run.
EDIT #2: after skimming your code i expect it is due to a antiban occuring after the last log is used, or something. Anyway when i logged in i found only runes in my inventory, with logs / planks banked.
***************Nathan's Magic Planker***************
********** Inventories: 95 Planks: 2475 **********
************************************************** **
Running for: 2 Hours, 16 Minutes and 52 Seconds
Missclicks (on purpose): 79 || 0.83157894736842 avg/inventory
Random waits: 54 || 0.56842105263157 avg/inventory
Antiban actions: 41 || 0.43157894736842 avg/inventory
Exp Gained: 222750 || 97649 exp/hour
We have made/lost: 242550 gp || 106329 gp/hour
98 mage now: 1150k xp to go :D
Edit #3: Just noticed that te script always clicks on the outer edge of the "inventory item slot box" or whatever you call it. So it never clicks on the middle of the log, or in between. Most players do click on around the middle of the log. The script would be more humanlike if the script would not only randomly click the outer edge, but also, and most of the times, in the middle of the log.
edit #4: the above stated bug happens when the script needs to click a log in the inventory while there ain't logs. This occasionally can happen due to banklag -> the script clicks withdraw logs, but the game lags. Then the script closes the bank without logs -> gives this error. Wait(200)with random 100 could give the computer only 0,1 second to withdraw logs. That can couse this bug if the pc is laggy at that moment.
My guess would be to add an if function to check if there are logs in the inventory, if not then restart the WithdrawLogs function.
u make 10gb profit with every cast, if u bought everything at med price
so kinda this method loses money
but still thanks for the great script! How can i make mouse movement faster?
HUMAN_MOUSESPEED = 12; // 10-17 are good, the higher the faster, use what seems humanlike to you
Line 68 in the script: wouldn't put it higher as 15-16, it doesn't matter much anyway: the script has to wait before it can click plank make again (like 3-4 game ticks).
Edit to my prev post: I mentioned line 458 for that invArray bug. It is probably line 448 or near for you, thats as i used crashSMART in the script.
script is broken :/
The script always moves the mouse to the xp counter after every cast, it'll be better if it checked mage exp once in a while and after making a plank it's better of having the mouse ready to make another plank rather than on the xp counter to make it more human-like.
if not(IsXPBarOpen) then //Need XP bar for progress reports
The script doesn't compile.
Hey again guys! Here comes my error:
SRL Compiled in 0 msec
SMART Initialized.
Loaded: Server 114, Members: True, Signed: False, Super Detail: False.
Welcome to Runescape.
Setup beginning
Error: Out Of Range at line 446
The following DTMs were not freed: [0, SRL - Lamp bitmap, 2]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap]
also this line gets marked with orange:
MouseItem(invArray[click],1);
thanks :)
This is quite flawless but i'm losing money now instead because the resources to run the script is going up and mahogany plank takes a while to sell at mid but really to sell at MID!
Y u no add pin? That some anti-leecher technique? Unless I am blind, and there is a place to add my bank-pin somewhere. Not hard to fix, mind you, but odd.
Fantastic bot. Ran it for a few hours to see how it works. Like everyone else says it could seriously use a bank pin, but I understand you are adding that in a later release.
Ran it for a few hours, managed to plank about 5k in a sitting, no problems.
Awesome script by the way. Plank make + Hati paws = 300k xp per hour. :whistles:
I dont get why mine crashes and theirs work perfectly :S
I'll post the crash reasen when it crashes again for me.
I dont think hati paws works with this spell. Only with combat my understanding.
Hati does work^
My fault i always get:
Please help.;)Quote:
Compiled successfully in 2000 ms.
SRL Compiled in 15 msec
SMART Initialized.
Loaded: Server 114, Members: True, Signed: False, Super Detail: False.
Setup beginning
Error: Out Of Range at line 457
The following DTMs were not freed: [0, SRL - Lamp bitmap, 2]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap]
Please add bank pin support
94 Mage so far thank youu :))
Hati works as im using it right now! It really screws with the xp/hr and planks made. It thinks i've done twice as many planks as i really have. 190k xp per hour and rising every cast!
~FallenSabre
Why doesn't my signature show up?
To fix pin issue try replacing the declare player section with this:
Simba Code:Procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
with Players[0] do
begin
Name := '';
Pass := '';
Pin := '';
Loc := 'ready';
{ready = anywhere with inv set up}
BoxRewards := ['XP','xp','lamp'];
LampSkill := 'Runecrafting';
Active := True;
end;
end;
That wouldn't work because I don't use SRL banking. Now that I'm back at school my time active has shrunk has sunk significantly, I'll work on it as I get timeQuote:
Originally Posted by lilpjer
sorry but that script is not very stable :(
***************Nathan's Magic Planker***************
********** Inventories: 27 Planks: 1446 **********
************************************************** **
Running for: 39 Minutes and 46 Seconds
Missclicks (on purpose): 23 || 0.85185185185185 avg/inventory
Random waits: 9 || 0.33333333333333 avg/inventory
Antiban actions: 10 || 0.37037037037037 avg/inventory
Exp Gained: 130170 || 196400 exp/hour
We have made/lost: -140294 gp || -211675 gp/hour
Heres a proggy before it crashed on me. Numbers are off because I was using Hati paws.