Smurg's QuickHerblore (Cleans/Unf) ~13k/hr *Fastest*

It doesn't work for me, I'm trying to clean avantoes, I've tried 0,0 and 1,1 as a place in the bank, the herbs have been placed on the 1st place and the 1st place in a new, separate tab, I can't find of anything else to try, help please? It just tries to withdraw but all it does is rightclick the grimy herbs, wait and get the error message "Failed to withdraw, adding 1 to count" then when it reaches the highest possible count it logs out and say it failed..

Edit:
It right-click the grimy avantoe, says:
29952 (probably confirming the ID number of the herb)
Added 1 to Fail Count: Could not withdraw correctly!
29952
Added 1 to Fail Count: Could not withdraw correctly!
29952
Added 1 to Fail Count: Could not withdraw correctly!
29952
Then it just fails, just have the withdraw menu open and I know it's nothing wrong with the row and column 'cause otherwise it wouldn't right click the herb, mright?

Code:

---

AccountLogin = '**';        // Runescape Account Login
 AccountPassword = '**';    // Runescape Account Password
 AccountPIN = '****';          // Runescape Bank Pin
 CleanOrPots = 'Clean';    // 'Clean' : Grimy Herbs are firstMaterial
                          // 'Pots' : (Unf) Clean Herbs are firstMaterial, Water Vials secondMaterial
                          //          (Finished) Non-edidable ingredient is firstMaterial
 ClickingWait = 20;        // Wait time for clicking for cleaning herbs
 DebugMode = True;
 World = 84;

Procedure DeclarePlayers;
begin
                            // [Row, Column] starts at 0, 0 in Bank
  firstMaterial := [0, 0];  // [Row, Column] in Bank
  WhereToBank := SRL_BANK_SW;  // Bank where you want to run it at
                                // Full list added below
  // --- If doing pots ---
  secondMaterial := [0, 1];  // [Row, Column] in Bank

---

These are my settings, I have also tried to swap first mat to 1,1 (although I know it's wrong).

why am I cleaning only 7400 herbs/hour when my clickwait constant is default 20? I want it to clean 10-12k+ / hour

Quote:

---

Originally Posted by Cinkupis

why am I cleaning only 7400 herbs/hour when my clickwait constant is default 20? I want it to clean 10-12k+ / hour

---

If you want it to run faster, you need to DECREASE the click wait then? :garfield:

Quote:

---

Originally Posted by blindguard

It doesn't work for me, I'm trying to clean avantoes, I've tried 0,0 and 1,1 as a place in the bank, the herbs have been placed on the 1st place and the 1st place in a new, separate tab, I can't find of anything else to try, help please? It just tries to withdraw but all it does is rightclick the grimy herbs, wait and get the error message "Failed to withdraw, adding 1 to count" then when it reaches the highest possible count it logs out and say it failed..

Edit:
It right-click the grimy avantoe, says:
29952 (probably confirming the ID number of the herb)
Added 1 to Fail Count: Could not withdraw correctly!
29952
Added 1 to Fail Count: Could not withdraw correctly!
29952
Added 1 to Fail Count: Could not withdraw correctly!
29952
Then it just fails, just have the withdraw menu open and I know it's nothing wrong with the row and column 'cause otherwise it wouldn't right click the herb, mright?

These are my settings, I have also tried to swap first mat to 1,1 (although I know it's wrong).

---

Always use the first "everything" tab. Don't stick them in other tabs (you can but I think some banking functions in SRL reset the bank to the first tab).

Just use 0, 0 and put it in the first spot in the main tab.

Quote:

---

Originally Posted by Cinkupis

why am I cleaning only 7400 herbs/hour when my clickwait constant is default 20? I want it to clean 10-12k+ / hour

---

Quote:

---

Originally Posted by Deus

If you want it to run faster, you need to DECREASE the click wait then? :garfield:

---

You would think playing with the click wait would be obvious. I make user editable settings for a reason. Decrease it until it starts dragging herbs, then put it back up a tad. :stirthepot:

man thanks to this script grimy's are way over in g.e plus cleans dont even sell... luckily i used this script for a week now, and bought grimys at mid, sold cleans at 15% higher. whatever thanks for this script mate

Quote:

---

Originally Posted by smurg

Always use the first "everything" tab. Don't stick them in other tabs (you can but I think some banking functions in SRL reset the bank to the first tab).

Just use 0, 0 and put it in the first spot in the main tab.

---

Ye, I have tried that.

Great script. Only thing I would change/add is for the script to move on to the next stack on herbs once one is below 28. For example, if I have 10k herbs in slot 1 (bank slot 1), and another 10k of another herb in slot 2, that the script would recognize slot 1 has less than 28, then try slot 2.

It's difficult to stock up on more than 10K at a time because of buy limits, especially if you're being careful not to get burned on prices changing. This update would make it easier to get a lot of herbs done at once as you could buy different varieties and still let the script go without having to come back every hour.

Quote:

---

Originally Posted by thatoneguy

Great script. Only thing I would change/add is for the script to move on to the next stack on herbs once one is below 28. For example, if I have 10k herbs in slot 1 (bank slot 1), and another 10k of another herb in slot 2, that the script would recognize slot 1 has less than 28, then try slot 2.

It's difficult to stock up on more than 10K at a time because of buy limits, especially if you're being careful not to get burned on prices changing. This update would make it easier to get a lot of herbs done at once as you could buy different varieties and still let the script go without having to come back every hour.

---

Ya I planned on doing something like that next.

____________Smurgs QuickHerblore V1.04_______________

Pots Mixed: 10248 (2205 pots/hr)
Time running: 4 Hours, 38 Minutes and 50 Seconds
Time until break: 51 Minutes and 4 Seconds
__________________________________________________ ___

Win (:

Here's another proggy.

____________Smurgs QuickHerblore V1.04_______________

Pots Mixed: 24710 (2535 pots/hr)
Time running: 9 Hours, 44 Minutes and 45 Seconds
Time until break: 5 Hours, 45 Minutes and 54 Seconds
__________________________________________________ ___

Thx again. ;)

Quote:

---

Originally Posted by N3mo

Here's another proggy.

____________Smurgs QuickHerblore V1.04_______________

Pots Mixed: 24710 (2535 pots/hr)
Time running: 9 Hours, 44 Minutes and 45 Seconds
Time until break: 5 Hours, 45 Minutes and 54 Seconds
__________________________________________________ ___

Thx again. ;)

---

How'd you get so many pots/hr? :O

It runs very smoothly for me now, the only problem is that it often moves the character one tile West of the bank, so it takes a good amount of time to click the bank again as the pointer searches only 1 tile north for the bank chest until a fail safe (I assume) re-sets it back.

____________Smurgs QuickHerblore V1.04_______________

Herbs Cleaned: 32844 (9584 herbs/hr)
Time running: 3 Hours, 25 Minutes and 36 Seconds
Time until break: 2 Hours, 1 Minutes and 8 Seconds
__________________________________________________

Quote:

---

Originally Posted by ashihtaka

It runs very smoothly for me now, the only problem is that it often moves the character one tile West of the bank, so it takes a good amount of time to click the bank again as the pointer searches only 1 tile north for the bank chest until a fail safe (I assume) re-sets it back.

____________Smurgs QuickHerblore V1.04_______________

Herbs Cleaned: 32844 (9584 herbs/hr)
Time running: 3 Hours, 25 Minutes and 36 Seconds
Time until break: 2 Hours, 1 Minutes and 8 Seconds
__________________________________________________

---

That'd be the SRL banking function doing that.

V1.01 running flawless for me still :P

____________Smurgs QuickHerblore V1.01_______________

Unf Mixed: 2240 (1942 unf/hr)
Time running: 1 Hours, 9 Minutes and 12 Seconds
Time until break: 4 Hours, 36 Minutes and 24 Seconds

Thanks smurg :D

Brilliant. Amazing. Completely flawless. 91/99 so far :) Thanks Smurg!!

Already 75 Herblore with this script... Umm.. Smurg.. You are my hero mate ;P

New to SLR, old botter with reflection/IDs etc...

This script has convinced me to never go back, it is amazingly fast and stable:

____________Smurgs QuickHerblore V1.04_______________

Pots Mixed: 5782 (2600 pots/hr)
Time running: 2 Hours, 13 Minutes and 25 Seconds
Time until break: 3 Hours, 12 Minutes and 39 Seconds
_________________________________________________

AND STILL GOING, got 20k+ pots left to make :)

____________Smurgs QuickHerblore V1.04_______________

Pots Mixed: 7952 (2787 pots/hr)
Time running: 2 Hours, 51 Minutes and 10 Seconds
Time until break: 2 Hours, 40 Minutes and 4 Seconds
__________________________________________________ ___

This proggy was so sweet I had to post it lol.


____________Smurgs QuickHerblore V1.02_______________

Unf Mixed: 23772 (2727 unf/hr)
Time running: 8 Hours, 43 Minutes and 5 Seconds
Time until break: 7 Hours, 13 Minutes and 36 Seconds
__________________________________________________ ___

And still going.

I've already used this bot to get me from 66-83 herblore. Took quite a few days to do ~20k unfs, I'm having a hard time getting the bot to run for longer than an hour. It's probably just my computer. Will start an overnight run and see what happens. Thanks so much for this!

Thanks a bunch, could you add a failsafe for when the bot accidentally moves away from the bank (when banking at SW, the client sometimes lags and the bot clicks away a few steps and doesn't return)? This would help the script out a ton to become flawless!

When the bot moves so that the bank is still on screen, it banks. However, when farther away the script returns the code:

Code:

---

Warning! You passed a wrong xs to a finder function: -16. That is below 0, thus out of bounds. Setting the value to 0 for now.
Warning! You passed a wrong ys to a finder function: -5. That is below 0, thus out of bounds. Setting the value to 0 for now.

---

http://s7.postimage.org/em3h13iij/Stupid.png
(Or closer to the portal)



Thanks again mate; for your troubles, another proggy, doing unf:

____________Smurgs QuickHerblore V1.04_______________

Pots Mixed: 36617 (2732 pots/hr)
Time running: 13 Hours, 24 Minutes and 11 Seconds
Time until break: 2 Hours, 3 Minutes and 49 Seconds
__________________________________________________ ___

^ how much money did you make?

Any way to make this script not take breaks?

Quote:

---

Originally Posted by Im New Sry

^ how much money did you make?

---

Making the unf potions to cut down the cost to level herblore (making avantoe unf for super energy potions). So none because I'm making them into finished pots.

lol decided to see how much I could ramp up the script, getting over 17k/hr :stirthepot: . I love the simplicity and use of the include for the script, very nice.

Quote:

---

Originally Posted by thatoneguy

Any way to make this script not take breaks?

---

Not sure if serious. It only breaks @ 5.5 hours for like 2 min to avoid the logout token error.

Every time it logs out it doesn't log back in. I'd like to run it all night while I'm at work, but I always come home to the logout token error and plenty of ingredients remaining?

Quote:

---

Originally Posted by thatoneguy

Every time it logs out it doesn't log back in. I'd like to run it all night while I'm at work, but I always come home to the logout token error and plenty of ingredients remaining?

---

Use SMART Manager, search the forum for it.

Can't believe I'm just finding this now =/

Thanks Smurg.

thanks man looking great so far

Wow, got around 120k xp/hour cleaning grimy cadantines. Too bad they don't sell on the GE after you buy around 20k of them, lol

____________Smurgs QuickHerblore V1.04_______________

Herbs Cleaned: 8736 (9699 herbs/hr)
Time running: 54 Minutes and 2 Seconds
Time until break: 4 Hours, 35 Minutes and 41 Seconds
__________________________________________________ ___

Runs great. Gotta wonder if there was anyone banned for using this though, it cleans herbs at inhuman speeds.

any chance of adding an item detection so it terminates the script whenever you run out of supplies?

Quote:

---

Originally Posted by Theron

any chance of adding an item detection so it terminates the script whenever you run out of supplies?

---

It does.

Quote:

---

Originally Posted by smurg

It does.

---

It never terminates whenever i run out of supplies, it just continues to open and close the bank along with the occasional antiban..

So it says I'm getting 10.5k an hour but really it's around 6k since it's not clicking all of them. Does anyone else have this problem?

Quote:

---

Originally Posted by redwall777

So it says I'm getting 10.5k an hour but really it's around 6k since it's not clicking all of them. Does anyone else have this problem?

---

Could try reading the OP, reading other replies, looking at settings you can change within the script.

All answers to that question.

You seem to know a bit Smurg, so I'll ask this here:

Howcome most scripts that I use tend to fail (or log out due to not being able to complete) random events? Seems like my guy tends to fail even the scripts that are listed as working in the random event thread. Wondering if you have any insight on this?

This doesn't apply to this script, as I use it at SW.

Quote:

---

Originally Posted by thatoneguy

You seem to know a bit Smurg, so I'll ask this here:

Howcome most scripts that I use tend to fail (or log out due to not being able to complete) random events? Seems like my guy tends to fail even the scripts that are listed as working in the random event thread. Wondering if you have any insight on this?

This doesn't apply to this script, as I use it at SW.

---

Randoms aren't to do with the script. FindNormalRandoms will cover these. If they can be solved it will try. If not it will logout to prevent being stuck.

Which randoms is it failing?

I can't say for sure, but I've come home nearly every night to find it's logged out of a random or failed one altogether. Pretty certain it fails the sandwich lady and frog princess randoms quite often.

If you look in the log in simba it should say which random it starts. But as I said this isn't the scripts fault so head to the SRL randoms section and make a thread there :)