Printable View
################################################## #####
Shantay Bank Chest Bonfire
################################################## #####
Logs / Hour : 893
Logs Done : 1120
Fire Spirit : 14
Running for : 1 Hours, 15 Minutes and 11 Seconds
Not to bad :D.. Had a few other 1+ hour runs, went from 15 fm to 60 tonight! Great script.
Sorry, but I won't give credits to you nor Imanoobbot. Yes, you guys indeed did provide accounts for me to test and script this bot, but not one line of code is written by you. If you did contribute like posting a function or procedure that is useful and not in the script, then I will give credits. If not, other people that help posting bugs / reports will also need to be given credit? You got your name shown with the biggest font size on the first post, should be satisfied with that. Sorry to burst your bubble, but really, no offence. Just clearing things out.Quote:
Originally Posted by ajmehta21
As for the proggies, I'll just use the ones that are in this thread. Since people got the proggy out of the new version, not the old one. You could post yours too. Will update the thread maybe tomorrow.
It will only add the spirit found count if it actually collected the rewards. So if you're getting that much, it isn't a false number.Quote:
Originally Posted by ajmehta21
Thanks :)Quote:
Originally Posted by Ucantseemebot
Thanks. And the purpose of this script was to bot among that 100000000 people. People light up logs for you, so you can just find nearby fire and add logs. Main point of the script only supporting shantay pass bank chest.Quote:
Originally Posted by k9thebeast
I believe I said it in the instructions at the first post. As for the XP counter, I made that the script opens it up if its not on yet. Not sure if it will be firemaking or not, but it will work if its opened.Quote:
Originally Posted by Farmess
Will try to fix that in the next update.Quote:
Originally Posted by k9thebeast
Nice, and thanks :)Quote:
Originally Posted by Kimber1911
Please be noticed. It has been more than 30 hours since I woke up, and I need to get some rest now that I got back from exam. I hope everyone read posts. I will update again when I get up. And I think I know the problem why is the character going to bank before logs is finished. I just accidently reset my XP counter when I try to make it firemaking. And the search box for the XP didn't reach if people had their counter at 0.
EDIT: I just tested. Even when the XP starts at 0, it detects perfectly fine. So probably have something to do with DTM.
Good script, however it sometimes fails finding the bank, it doesn't even try to find bank, it just sits 'doing antiban, doing antiban'. Whenever I get a good progress report I'll post it here.
Btw: I'm going to run this script for at least 6 hours, and I'm keeping track of all the charms I get from spirits :) will be interesting to see how many charms you can get from the spirits.
That is weird. It should find the bank if the bank chest IS ON SCREEN. Sometimes people plant flowers, making your character finding fire further away from bank chest, making the bank chest not seen on screen, then script fails. But if its out of logs, debug should say "Finding chest" or something, not doing antiban.Quote:
Originally Posted by Horatio
Updated! Even though I am so tired that I wanted to jump onto my bed so badly, I still updated the script LOL. For people that say it isn't detecting the spirit, just let it wait until it detect the spirit itself. It will search for the spirit every 4 seconds, until the color is found.
New version looks great so far! :)Quote:
Originally Posted by CephaXz
Will instantly test it when Im back home.
Latest version is very much stable now. Doing a very good amount of logs per hour for willows. 4 hours and still running!
http://i231.photobucket.com/albums/e...aXz/proggy.png
Great! I am thinking about how much exp you are gaining per log in which level. Do you know how to add the exp/h into the proggy. Was thinking about that in the last hours. You are getting more exp per log as higher your level is and if there are more then 4 people on 1 fire then you are getting another 4% bonus.Quote:
Originally Posted by CephaXz
Probably can be done with calculating the XP bar. Reset the XP counter when script starts, and get the ending XP total after each bank. I'm gonna try doing that, see if it works.Quote:
Originally Posted by Imanoobbot
EDIT: 5 hours, guess it wouldnt have any problem running 6 hours. I'm gonna stop it and try making xp gained and xp/hour for the progress report.
################################################## #####
Shantay Bank Chest Bonfire
################################################## #####
Logs / Hour : 770
Logs Done : 3864
Fire Spirit : 26
Running for : 5 Hours, 47 Seconds
-------------------------------------------------------
EDIT2: Successfully added. Didn't know I could learn adding it so fast lol.
################################################## #####
Shantay Bank Chest Bonfire
################################################## #####
Logs / Hour : 760
Logs Done : 56
Fire Spirit : 0
EXP Gained : 6115
EXP / Hour : 83071
Running for : 4 Minutes and 24 Seconds
-------------------------------------------------------
Would like to say that this is a great script. I'm getting close to 150k xp an hour doing maples @ level 60 fire making. Could use some more work with detecting the fire spirit thing.Seen it miss acouple. Other then that its a great script.
Updated again. Added Xp gain count in the progress report.
Thanks. It would take some time before it could detect a spirit, it never failed for me yet though.Quote:
Originally Posted by vmike
couldnt get 1h+ since always logs out
some ppl light a fire like 5 steps away, bot goes there and adds logs to the bonfire there, then goes to bank, doesnt open it and just logs out (v4)
but firespirits are working great,
trying v5 now
great script got me 79 fm :D
Because bank chest are not on screen anymore, so it couldn't find it. It's fixed in the new version. I added walking to the bank chest if it couldn't find it.Quote:
Originally Posted by a7564321
Post proggies if you have :DQuote:
Originally Posted by Bennyp12
Good to know the flower planting wont affect us anymore! Thanks mate!
The fact that you actively listen to problems and fix them is amazing dude, thats called quality scripting. I couldn't use 4.u1 overnight cause of bugs, but then I wake up and there is a new version ready to be tested :) Testing now.Quote:
Originally Posted by CephaXz
better random detection is the only thing i recommend
Quote:
Originally Posted by Jonno
Thanks. Hope you enjoy using the script. Post a proggy if you have one :)Quote:
Originally Posted by k9thebeast
It is already detecting random events.Quote:
Originally Posted by Xert
Wrong :(Quote:
Originally Posted by CephaXz
The trolling nerd will get bored and i think this is not effecting the script anymore. ;)Quote:
Originally Posted by omglawlzyougotpw
Gimme proof.Quote:
Originally Posted by Moron
I don't think this stops the script.Quote:
Originally Posted by omglawlzyougotpw
Just believe me that for randoms it says something is not activated and it logs me out....Quote:
Originally Posted by CephaXz
Then you would have to blame the developer of Simba. It shows that message, means it DETECTED the random.Quote:
Originally Posted by Moron
ive had constant problems over the past hour. There are no failsafes if the script attempts to withdraw logs from the first slot and then closes bank. It just logs out. I think this script needs to retry at least 2x to withdraw logs and not say no logs found. I think my script tries to withdraw the logs too fast sometimes resulting in the script saying no logs found and it logging out. If this could be fixed it would help. I can confirm that this script does not do many randoms yet. 4 randoms none done: frog, 10x clicking ring, leatherhorsen. Otherwise still a great script
in that case, just for testing purposes add to the mainloop:Quote:
Originally Posted by ajmehta21
FindNormalRandoms;
exactly where I posted on here: http://villavu.com/forum/showpost.ph...7&postcount=61
*edit*
I forgot he has updated since last time... place it here from line 472 till 490:
Simba Code:begin
SetupLogin;
SMART_ClearCanvas;
AddOnTerminate('EndDTM');
StartDTM;
repeat
if not BankScreen then
begin
FindNormalRandoms;
FindChest;
end;
OpeningBank;
BonBon;
if WaitingLogsFinish then
begin
IncEx(Players[CurrentPlayer].Integers[3], 28);
end;
PlayerStats;
until not LoggedIn;
end.
I found that the script ends itself from being out of logs after a short period of time (10-30 minutes)
I'm using yew logs, and it goes to the bank and doesn't see them. I have it set to slot one and the logs are in slot one.
Is anyone else having this problem?
Double post sorry other then above bug great script :)
What's 10x clicking ring and leatherhorsen? Did it say Random not activated? Randoms are handled by the client, not me.Quote:
Originally Posted by ajmehta21
Is there logs withdrawed from your bank when it says no logs found?
How is it too fast? It will only start withdrawing when it found the bank screen.
I'll test out 200 yews in a minute.Quote:
Originally Posted by Bag of WTF
EDIT: Oh wait, I didn't have an account to try that :\
EDIT2: I bought 500 yews just for testing for you guys. It burn all of them without any problem. But I got into random event, the function is not detecting it. I removed all my procedures and only put FindNormalRandoms in the main loop. Its still not detecting the random event. So maybe you should report it to the devs, give them account stuck in randoms and such.
EDIT3: I closed my bonfire script and opened my cosmic crafter and run it. It detected the random event, but still saying random event not activated because it might be not working at the dev side at the moment. It will only detect the random event when it is in conversation with the random event NPC. So I added a few more FindNormalRandoms in the script. And also, added the banking failsafe in case it says cant find logs. Will do the banking for 3 times before it terminate the script now.
Download the new version.
What was the random that got you? I was aware SRL randoms failed to detect some randoms in the desert.
Will run this overnight. Just did 99 magic. This is next on my list.
It was the graveyard random, I believe it couldn't detect because my character moved and cancelled the chat with NPC. If the chat with NPC is on screen, it will detect the random, but will logout since its not activated.Quote:
Originally Posted by Er1k
Interesting. maybe you should post in the Randoms section about that. I believe some of the randoms sometimes don't detect very well, but I cant remember which.
By the way, the bonfire adding is XP based or what? I am looking over it and cleaning your code, but I just want to make sure.
What do you mean by XP based? It just find the log DTM in your inventory and left click it, and choose the option to add logs to nearby fire.
Also, it uses color to check the XP to check whether you're still doing firemaking. If it doesn't, XP counter will not +EXP.
You said it. It's based on XP counter, so it's checking XP gain.
I am just wondering which is better - checking inventory decrease vs. checking xp gain. Perhaps I will mod your script and see for myself the results.
Probably checking inventory decrease is better. Because I'm a noob that doesn't know how to do that LOL. Teach me :pQuote:
Originally Posted by Er1k
I think the function is this - CountItemsIn. Haven't got time to look into it, gonna sleep in 10 mins, but I am sure you can figure something out.
Basically you check for decrease of logs in set time, maybe 5-10 secs intervals depending on firemaking level. If inventory did not decrease, it's a good idea to assume you need to add to logs again.
Just a suggestion anyway. I believe the current method works fine.
Then it might be the same, since the XP gained fades away after like 5-7 seconds. But will surely look into this function. Thanks!
Keep randomly getting Logs not Found for some reason and script stops.
Bonbonbonbonbonbonbon
bon
bon
bonbonbon
ty 99 fm <3 < 3 <3
bon bon bon bon
bon,
if WaitFunc(@BankScreen, 6000, 12000) thenQuote:
Originally Posted by bgxsaer
begin
if not InvEmpty then
begin
DepositAll;
end;
writeln('Withdrawing logs');
wait (1000+Random(2000));
MouseBankSlot(LOGS_BANKSLOT, mouse_Right);
WaitOption('All', 2000);
CloseBank;
Added that wait time, seems like it shouldn't give that issue anymore, most likely due to lag.