EoC - AIO Herblore

I just decided to post one of my scripts here. I noticed there was no working herblore script at the moment so I decided to share mine. It's the first "real" script that I share publicly.

Setup
- Add your account information on your script, your choice of action (Pot or Clean).
- Have grimy herb/vial at the first bank slot.
- Have clean herb or secondary ingredient at the second bank slot.
- Have following ingredients in the subsequent slots if you want to do multiple tasks.

Features
- Currently only designed to work at GE.
- Clean herbs, make unfinished potions and finished potions.
- Will terminate by itself when you run out of ingredient, yet not subject to lag causing a messed up withdrawl.
- Can clean different type of herbs without having to start the script again.
- Same with unfinished potions.
- Antiban.

To be added IF THERE IS A DEMAND
- If there is a demand for it, I can make a progress report procedure. I personally never use those, but I won't mind spending 5 minutes on it if it's asked.
- Add other locations. Same comment as above.

Known bug
- None script based at the moment.

Version history
v2:
- Added Brown booth banking.
- Optimized banking speed.
- Fixed a small bug. Shouldn't log on to non member worlds anymore.
v2.1:
- Added a little something to forcekill the client after 5 hours 30 minutes and start a new one. Worked very well with small scale tests. Tell me how it goes.
v3:
- Added basic GE support to purchase supplies upon login and pick up these new supplies when you run low on ingredients. Beware the new basic anti-leech.

Credits to
- NKN for a few functions of the script. Mostly the general frame as well as the antiban which I just copied (with his permission).
- Everyone that helped me at one time or another by answering my questions.

Enjoy!

You seem to love using records :p

Quote:

---

Originally Posted by Shay

You seem to love using records :p

---

Haha, I realize it does seem to be "over the top" for such a simple script, but I find records for customized object finding to really help tidying up everything. It makes editing the script so much easier.

Yup, this is nothing big nor important but you have an unused variable in a function.
Find it!

I actually have a completely unused function... MakeDone. It's a function that was meant to click by itself when the production bar is done, but for some very unknown reason, sometimes, it clicked before the colour even changed to green, leaving 1-2 items not transformed.

The "i" at line 42 also is never used. I imagine that's the one you're referring to. Forgot to remove that one. The "i" was used before EoC though, I promise!

EDIT: For other people, don't try to find it. I removed it now =).

Haha kk mate, keep releasing them scripts :p

Nice work and keep it up.

Looks great, will test it out asap. Btw do you think you could add soul wars bank chest?

Quote:

---

Originally Posted by Nufineek

Looks great, will test it out asap. Btw do you think you could add soul wars bank chest?

---

I certainly could, but you have to convince me if the usefulness of that. People went to soul wars because they couldn't get into randoms at that place... but there are no more randoms now. If what you want is one click banking then any bank counter around runescape would do.

Looking good mate, keep it up! :)

Stable and works great, finally won't have to relog to mix different herbs.

Any idea on what the unfs/hour is?

Edit: consider adding a login method as right now the script bounces between non-member/member worlds.

Quote:

---

Originally Posted by Wardancer

I certainly could, but you have to convince me if the usefulness of that. People went to soul wars because they couldn't get into randoms at that place... but there are no more randoms now. If what you want is one click banking then any bank counter around runescape would do.

---

What about Varrok west then? The GE banking is extremely slow

This looks good. I'll give it a test sometime this week.

Nice first public script :)

Nice script!
Working great and stable.
Had my own herblore script, but wasn't very stable, so thank you very much for making this! :)

damn I was going to release a herb script too :(

Quote:

---

Originally Posted by hackingislol133

Stable and works great, finally won't have to relog to mix different herbs.

Any idea on what the unfs/hour is?

Edit: consider adding a login method as right now the script bounces between non-member/member worlds.

---

I didn't bother to find out what the unf/hour is and would like if no one posts it here as I know it's slower than before EoC and I'd like not to get depressed.

The issue with non-member world should now be resolved. Please try version 2.0.

Quote:

---

Originally Posted by Nufineek

What about Varrok west then? The GE banking is extremely slow

---

Added a banking option for brown bank booths. Please refer to version 2.0. I have to warn you though. One click banking can be somewhat glitchy. I added a few failsafes, but I didn't have time to test them thoroughly. Please let me know if the script fails to bank because it has a herb selected or if you run around too much.

Also, banking has been optimized. The actual banking procedure was very fast, but a silly waiting time was slowing things. I suggest you to try GE banking again.

EDIT: Would like feedback on what I should add next. Eventually, I'd like to add both features, but as I have little time to work on this script and it'd take a few hours to polish, I want to tackle these issues one at a time.

Suggestion 1:
- Possibility to program multiple tasks beforehand and switch of mode (pot and unf) without having to touch the script. You would have the choice between doing a task until resources are depleted for this particular item or a set number has been made.
- What would I need to add to the script:
> DTMs for all potions, ingredients and herbs (if someone wants to make those DTMs or let me use theirs, it'd save a lot of time and these features would be available soon)
> Precise progress report
> A record for tasks

Suggestion 2:
- Grand exchange support, allowing automatic purchase and recovery of items. The public version would only support manual input of the price as a variable in the script (wouldn't want this feature to be abused).
- What would I need to add to the script:
> Over a dozen of already written GE functions and procedures I have.
> Thorough testing of these functions.

What would follow:
- The merge of the two ideas.
> Possibility to program tasks ahead and plan multiple purchases from the GE to go along with the task system.
> Recovered items from GE could be used right away without having to have them at a predetermined slot.
> Possibility to sell items you just made without needing them at a specific bank slot before the withdraw.

Please let me know what you'd like to see first. The suggestion 2 would be much faster for me if I let you guys do the testing.

Suggestion 2:
- Grand exchange support, allowing automatic purchase and recovery of items. The public version would only support manual input of the price as a variable in the script (wouldn't want this feature to be abused).
- What would I need to add to the script:
> Over a dozen of already written GE functions and procedures I have.
> Thorough testing of these functions.


This 1 defenitely in my opinion.
This would be so epic, and I think you would be the first one to implement it into a simba script!


Ps: V2 made it faster, great job on that.

I'd love to test the new version but I started getting this error:

[Error] C:\Simba\Includes\SRL/SRL/core/gametab.simba(68:20): 'BEGIN' expected at line 67
Compiling failed.

Can anyone help?

Quote:

---

Originally Posted by Nufineek

I'd love to test the new version but I started getting this error:

[Error] C:\Simba\Includes\SRL/SRL/core/gametab.simba(68:20): 'BEGIN' expected at line 67
Compiling failed.

Can anyone help?

---

Do you have the latest version of Simba/SRL?
Try to update both to the latest version.
Also i get that sometime, and sometimes it is because i clicked the play button too fast after opening the script. Sounds weird, but try to wait 5 secs after opening the script, and then click on play.

Minor bug: Stopped working for no particular reason.
I don't have more info, but just saying. Pausing the script, and clicking on play after fixed it.

Quote:

---

Originally Posted by Faab68

Do you have the latest version of Simba/SRL?
Try to update both to the latest version.
Also i get that sometime, and sometimes it is because i clicked the play button too fast after opening the script. Sounds weird, but try to wait 5 secs after opening the script, and then click on play.

Minor bug: Stopped working for no particular reason.
I don't have more info, but just saying. Pausing the script, and clicking on play after fixed it.

---

I'm all up to date, I also sometimes get it for no reason or starting it too fast but now I've tried it many times and I still get this error, no idea what could it be :/

Quote:

---

Originally Posted by Nufineek

I'm all up to date, I also sometimes get it for no reason or starting it too fast but now I've tried it many times and I still get this error, no idea what could it be :/

---

Try downloading the gametab from the Srl from the github.

https://github.com/SRL/SRL-5

Replace the downloaded gametab with the gametab you have at the moment.
I don't really know if it would work, but just thinking out loud here.

Also did you download the file in this thread, or just copied the script into simba? Try downloading the file in the thread.

Quote:

---

Originally Posted by Faab68

Try downloading the gametab from the Srl from the github.

https://github.com/SRL/SRL-5

Replace the downloaded gametab with the gametab you have at the moment.
I don't really know if it would work, but just thinking out loud here.

Also did you download the file in this thread, or just copied the script into simba? Try downloading the file in the thread.

---

Ty for answer, idk what the issue was but just reinstalling simba helped :P

Quote:

---

Originally Posted by Faab68

Minor bug: Stopped working for no particular reason.
I don't have more info, but just saying. Pausing the script, and clicking on play after fixed it.

---

What bank option were you using? I spent very little time (almost none) picking the colour for the bank booth so I wouldn't be surprised if many issues happened with this.

Quote:

---

Originally Posted by Wardancer

I didn't bother to find out what the unf/hour is and would like if no one posts it here as I know it's slower than before EoC and I'd like not to get depressed.

The issue with non-member world should now be resolved. Please try version 2.0.

Added a banking option for brown bank booths. Please refer to version 2.0. I have to warn you though. One click banking can be somewhat glitchy. I added a few failsafes, but I didn't have time to test them thoroughly. Please let me know if the script fails to bank because it has a herb selected or if you run around too much.

Also, banking has been optimized. The actual banking procedure was very fast, but a silly waiting time was slowing things. I suggest you to try GE banking again.

EDIT: Would like feedback on what I should add next. Eventually, I'd like to add both features, but as I have little time to work on this script and it'd take a few hours to polish, I want to tackle these issues one at a time.

Please let me know what you'd like to see first. The suggestion 2 would be much faster for me if I let you guys do the testing.

---

Tyvm for adding the bank option, but the GE banking works very well with the update althought it's still possible to fastern it a bit more, especially the waiting time after making the pots, before clicking on a banker. Atm it makes about 1600 unf pots/hour which is quite decent after the update. Not sure about cleaning herbs. I'll keep posting reports.

But the script is really nice! keep on :)

Quote:

---

Originally Posted by Wardancer

What bank option were you using? I spent very little time (almost none) picking the colour for the bank booth so I wouldn't be surprised if many issues happened with this.

---

I was using Varrock west bank, because for some reason, Ge didn't work for me anymore.
I would advise to let the bot click ''done'' faster, because it will fail quite alot.
It does so by pressing where ''done'' was, but the interface already closed, so it would let the character 1 step to the right, and after that it will bank.
Looks bott'ish though, so i would suggest, clicking the button faster, or don't click the button at all.


Edit: I would suggest adding progress reports, because that can give you pointers on when to reload Smart, so you won't get bothered by 6h relog

Quote:

---

Originally Posted by Faab68

I was using Varrock west bank, because for some reason, Ge didn't work for me anymore.
I would advise to let the bot click ''done'' faster, because it will fail quite alot.
It does so by pressing where ''done'' was, but the interface already closed, so it would let the character 1 step to the right, and after that it will bank.
Looks bott'ish though, so i would suggest, clicking the button faster, or don't click the button at all.

---

Replace the line 168 with "WaitFunc(@MakeDone, 10, 20000);". This will click on done and it's colour based. The only problem I was having is that it clicks before it's over, leaving 1-2 items unchanged, but that would solve your problem.

Quote:

---

Originally Posted by Wardancer

Replace the line 168 with "WaitFunc(@MakeDone, 10, 20000);". This will click on done and it's colour based. The only problem I was having is that it clicks before it's over, leaving 1-2 items unchanged, but that would solve your problem.

---

Oki, thanx for fix.
I've editted my last message but i'll type it again:
I would suggest adding progress reports, because it's alot easyer to restart Smart at the right time, avoiding the 6h log.

Quote:

---

Originally Posted by Faab68

Oki, thanx for fix.
I've editted my last message but i'll type it again:
I would suggest adding progress reports, because it's alot easyer to restart Smart at the right time, avoiding the 6h log.

---

I never considered using progress reports this way (I don't look at other people's scripts much). Thank you for this bright idea. Should be quite simple to MarkTime... I'll look into this soon. I'm not familiar with smart commands.

I might as well advertise for another script I just posted. Was a short project I decided to work on today. I just wanted to test a few things. I consider it to be fairly low quality, but it might be of use to some. It's a tanner: http://villavu.com/forum/showthread....18#post1132918

saw your post:
http://villavu.com/forum/showthread....25#post1130525


Is there any way to implement this in the script, and if there is, could u teach me?
I'm trying to understand the simba language, but I am not really good at it.
As told before, 2 days ago I managed to tweak a script, but it wasn't really stable.
Plus it would be awsome to have this in the script.


Btw thank you for giving me the fix for the ''done'' button. script works like a charm now!

Btw, it still walks quite alot when banking at GE

Quote:

---

Originally Posted by Nufineek

Btw, it still walks quite alot when banking at GE

---

Make sure that the banker isn't covered by anything. I don't have this issue on my side.

I absolutely cannot get it to enter my bank pin, and it also fails to X out of the squeal of fortune popup when you log in. perhaps this is due to my own stupidity

Quote:

---

Originally Posted by Paradox122

I absolutely cannot get it to enter my bank pin, and it also fails to X out of the squeal of fortune popup when you log in. perhaps this is due to my own stupidity

---

I have no account to test the pin with. There might be some issue with SRL that I'm unaware of or you simply wrote the pin at the wrong place. Add the following code at line 128 and see if that solves your problem:

Simba Code:

if PinScreen then
    begin
      if (Players[CurrentPlayer].Pin <> '') then
        InPin(Players[CurrentPlayer].Pin);
    end;

As for the squeal of fortune, the script usually closes it, but it's never been an issue when it doesn't. What matters is getting rid of the extra spins. I should add an option to destroy them rather than click them...hmm.

During long run periods, sometimes runs to the the top of the booths and is unable to access the bank.

Quote:

---

Originally Posted by hackingislol133

During long run periods, sometimes runs to the the top of the booths and is unable to access the bank.

---

Thank you for letting me know. However, I won't be working on optimizing bank booths anytime soon as I'm currently focusing development on incorporating GE elements. I'll eventually get to this issue though, but for now I consider it "normal" to have issues with these.

On a brighter note, I posted version 2.1. Just a little tweak to allow the bot to run for longer periods of time.

Quote:

---

Originally Posted by Wardancer

I have no account to test the pin with. There might be some issue with SRL that I'm unaware of or you simply wrote the pin at the wrong place. Add the following code at line 128 and see if that solves your problem:

Simba Code:

if PinScreen then
    begin
      if (Players[CurrentPlayer].Pin <> '') then
        InPin(Players[CurrentPlayer].Pin);
    end;

As for the squeal of fortune, the script usually closes it, but it's never been an issue when it doesn't. What matters is getting rid of the extra spins. I should add an option to destroy them rather than click them...hmm.

---

Worked like a charm, it does the bank pin now, but i had to add it to line 135, not 128. for some reason it would not compile when i put it on line 128. Squeal of fortune thing sometimes works after all, guess i just caught it at a bad time. Nice script man and good luck on the GE updates, i look forward to seeing how u will script that. Also i dont have a proggie but i cleaned 4000 herbs in just a few hours. ^^

Edit: I have also been playing with the version 3, and it doesnt clean herbs, it just goes into the GE and buys 1 grimy tarromin then looks in my bank, and repeats. I switched back to version 2 after that haha.

There is an anti-leech added to version 3 as it has basic GE support. I also decided not to put instructions as to how to use it. I expect people to figure it out by themselves.

not working for me, i started script, player logged in after few seconds smart restart and then over and over again

Quote:

---

Originally Posted by vladko78

not working for me, i started script, player logged in after few seconds smart restart and then over and over again

---

Hint: anti-leech.

great script, thanks for putting the time in to make it! :)

edit: sometimes it cant find the banker so I added a simple loop until the bank is open