[EoC] DannyRS RangeGuildTrainer

http://img845.imageshack.us/img845/2...uildbanner.png

About

Currently very buggy, update coming in the near future
Due to Requests i decided to give this a go

This script is working for me mostly, so if you have problems, turn Debug to true in the settings and post whats going wrong for you and ill try to help fix.

If you spot any bugs please post em and I'll work on a fix ASAP, Thanks, screenshot and or detailed description appreciated

Needs testers to try it :)


Feature's

• Anti-Ban

• Some Fail Safe's

• De Bugging Mode

Credits

• Ashaman88 - Read through alot of his work to learn / used some methods

• Benland100 - S.M.A.R.T and his mouse script

• Flight - Mouse scripting

Please follow setup before starting.


SetUp

Minimize your EoC Action Bar for best results or if having problems

start standing on the exact tile in Pic, have enough coins for a long time

• 1. Graphic's setup as Simba recommends, RS zoomed out to max

• 2. Requires using S.M.A.R.T v8.0+ (MAY NOT COMPILE ON 7.2)

• 3. Fill in the script variables (has some preferences)

• 4. Start Here !!!!!!!!!!!!!:

http://i.imgur.com/rNgco.png

Known Bugs

Code:

---

• May not see judge till he moves if hes in rare spot
  May fail to reset tile position if judge runs away on talk

---

Things to Do

• More Anti-Ban (can never have enough :))

• Bring The Standard of Coding Up

• Bank Pin and or Login Support

• More Failsafe's and Lag Recovery

• Add a Progress Report

Versions

Code:

---

V1.0 - Initial BETA Release
V1.1 - Added a few more filsafes and adjusted some variables may be more unstable than previous version
V2.0 - Major re-write, Added a progress report, best version yet
V2.0a - Minor loop fix for 2.0
V2.1 - Different Judge Detection, More Optimization, Login Support, If not working well use 2.0a

---

If You Do Not Read The SetUp Before Posting a Bug I Will Not Help You!

Proggy's

Code:

---


By: [PRO]metheus
=========RangeGuildTrainer============
=========Version: V2.1===============
Time Running: 6 Hours, 2 Minutes and 52 Seconds
Experience Earned: 126285
Experience/Hour: 20881
================================

By: Deadlast
=========RangeGuildTrainer==============
=========Version: V2.1================
Time Running: 5 Hours, 53 Minutes and 10 Seconds
Experience Earned: 152002
Experience/Hour: 25823
==================================

---

This is good man. Keep it up, sorry I can't test it but I might one of these days.

Quote:

---

Originally Posted by Silentcore

This is good man. Keep it up, sorry I can't test it but I might one of these days.

---

NP silent, as usual, work in progress :) ty for the support

Edit- while now lying in bed having a good think, i can improve some of the logic a bit, i'll take a look tomorrow :D

I have been waiting for one of these scripts. I tried revising a dead one, furthest i got was compiling it and clicking the target; but it then got stuck from a misclick on the tree in the background.

Plan to use this soon!

Quote:

---

Originally Posted by MMOE

I have been waiting for one of these scripts. I tried revising a dead one, furthest i got was compiling it and clicking the target; but it then got stuck from a misclick on the tree in the background.

Plan to use this soon!

---

Be sure to post any errors or bugs you find, guna be doing more tweaking tomoz but always good to have as much data as possible :)

Quote:

---

Originally Posted by DannyRS

Be sure to post any errors or bugs you find, guna be doing more tweaking tomoz but always good to have as much data as possible :)

---

I will start it up right now. Seeing as I am at home, will switch it off before bed just in case any errors do happen.

Ok great, im going to try and fall asleep before you post anything otherwise i wont get any sleep tonight :) !

Welcome to RangeGuildTrainer V1.0 by Dannyrs
Starting in 3...
Starting in 2...
Starting in 1...
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge

It paid the judge, now it is standing there right clicking him.
When i self-fixed, the script shoots the targets very slowly. It must close down the score display box before shooting another instead of just spamming the target.

EDIT: Only shoots slowly when right click method is turned off. After the self-fix [Disabling smart, and clicking through the dialog box that says "you pay the judge and receive ten arrows"] The script then runs by itself for a while and then gets stuck again on the "TalkJudge" procedure.

Also, the script does not fully detect when the round is over, midway through a round, it right clicks the judge before the round is complete. The round still finished, but a fix would result in higher xp.

The error is most likely in the block of the script; I see it repeats the procedure of checking if the judge has been paid with all the "end else" and then looping to another check of the judge.

Code:

---

Procedure TalkJudge;
Var
  x,y,attempts: Integer;
  Check: Boolean;

Begin
  Check:=False;

  repeat begin
  if not(FindColorSpiralTolerance(x, y, 10092288, 402, 163, 465, 193, 20))then
    begin
      //Target View Screen
      Wait(563+Random(193));
      if(Debug)then begin Writeln('Talking To Judge'); end;
      DragMouseSpot(193, 191, 221, 253);
      If IsUpTextMultiCustom(['Talk-to','alk-to']) then
      begin
        ClickCurrent(False);
        if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
        else begin ShootTarget; Exit; end;
      end else
      begin
        Wait(163+Random(193));
        DragMouseSpot(185, 210, 207, 283);
        If IsUpTextMultiCustom(['Talk-to','alk-to']) then
        begin
          ClickCurrent(False);
          if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
          else begin ShootTarget; Exit; end;
        end else
        begin
          Wait(163+Random(193));
          DragMouseSpot(243, 168, 264, 228);
          If IsUpTextMultiCustom(['Talk-to','alk-to']) then
          begin
            ClickCurrent(False);
            if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
            else begin ShootTarget; Exit; end;
          end else
        begin
          Wait(163+Random(193));
          DragMouseSpot(256, 218, 277, 277);
          If IsUpTextMultiCustom(['Talk-to','alk-to']) then
          begin
            ClickCurrent(False);
            if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
            else begin ShootTarget; Exit; end;
          end;
        end;
        end;
      end;
    end else begin CloseTVUp; end;
    //Wait(563+Random(193));
  end; until (Check) or (FindDTMRotated(ChatDTM, x, y, 170, 380, 308, 480, -Pi/4, Pi/4, Pi/60, aFound))

  Check:=False;
  Wait(1463+Random(193));

  repeat begin
    LeftClickSpot(220, 450, 229, 464);
    Wait(563+Random(193));
    if (FindColorSpiralTolerance(x, y, 938795, 281, 466, 285, 470, 20)) then
    begin
      Check:=True;
    end;
  end; until (FindColorSpiralTolerance(x, y, 938795, 281, 466, 285, 470, 20))
End;

---

Yea i recommend using right click method, as timing is much easier to do with that, i'll take a look tomorrow and see whats up, but i was running it fine before i uploaded it :(

Thanks for trying it anyway hopefully i can fix it soon

Edit - that procedure should just be to find the judge with istextup function, shouldent really cause problems or atleast not be the root of the problem, weird, i'll have a good look through it tomorrow though

Quote:

---

Originally Posted by DannyRS

Yea i recommend using right click method, as timing is much easier to do with that, i'll take a look tomorrow and see whats up, but i was running it fine before i uploaded it :(

Thanks for trying it anyway hopefully i can fix it soon

Edit - that procedure should just be to find the judge with istextup function, shouldent really cause problems or atleast not be the root of the problem, weird, i'll have a good look through it tomorrow though

---

Then again, i did change "Equip arrows before shooting" to false. I'm not sure if that is the source of the problem? I will go back and check if anything changes.

EDIT: Problem fixed, i changed the equip arrows to true. This automatically closes the dialog box and continues the script. Works perfect now; with the exception of not fully knowing when the round is ended. Not a major concern as so far it is running great.
The main problem was most likely just the dialog box? Somehow it affected the script from continuing. If the "equip arrows before shooting" is set to false, maybe a procedure could close the dialog box to continue the script.

Quote:

---

Originally Posted by MMOE

Then again, i did change "Equip arrows before shooting" to false. I'm not sure if that is the source of the problem? I will go back and check if anything changes.

---

Shouldent be, i added the option to actually use those arrows after lol, are you using the lowest graphics stuff and are you definetly zoomed out to the max, EoC actionbar minimzed etc?

And are you in the exact spot in the picture? The judge normally to the left or above you?

Wow cant believe that causes a problem rofl,

I musta messed up the copy pasting somewhere awfully

great job on finding the cause though, now i can easily fix this :)

And i'll work on perfecting the round detection logic to increase xp/ph :) i started doing it but got too tired (and still cant actually sleep >.< damn my insomnia)

Quote:

---

Originally Posted by DannyRS

Shouldent be, i added the option to actually use those arrows after lol, are you using the lowest graphics stuff and are you definetly zoomed out to the max, EoC actionbar minimzed etc?

And are you in the exact spot in the picture? The judge normally to the left or above you?

---

Ha unlike most people, i did read the OP. Everything was setup correctly. It runs great now. It was just the dialog box. I'm trying to add a progress report from Ashaman's scripting.
ALL CREDIT TO ASHAMAN! I am just moving some of his script into yours.

Code:

---

Procedure PrintSmart;
Begin
  SMART_ClearCanvas;
  SMART_DrawText(30,252,StatChars, '========DannyRSRangeGuild=========', 65280);
  SMART_DrawText(30,264,StatChars, '==========Version: '+ScriptVersion+'===========', 65280);
  SMART_DrawText(30,275,StatChars, 'Time Running: ' + TimeRunning, 65280);
  SMART_DrawText(30,288,StatChars, 'Experience Earned: ' + ToStr(XP), 65280);
  SMART_DrawText(30,302,StatChars, 'Experience/Hour: ' + ToStr(XPH), 65280);
  SMART_DrawText(30,314,StatChars, '==============================', 65280);
End;

Procedure ProgressReport;
Var
  TTB: Integer;
Begin

  TTB := GetTimeRunning;

  XP := (GetXPBarTotal - StartingExperience);
  XPH := Round(XP * (3600.0 / (GetTimeRunning / 1000.0)));
  MarkTime(Timeout);

  Writeln('========DannyRSRangeGuild=========');
  Writeln('==========Version: '+ScriptVersion+'==========');
  Writeln('Time Running: ' + TimeRunning);
  Writeln('Experience Earned: ' + ToStr(XP));
  Writeln('Experience/Hour: ' + ToStr(XPH));
  Writeln('=================================');

  PrintSmart;
End;

---

I got it to compile with the progress report, i just need to alter a few more things to get it all to tie in. I will finish this later on though i have finals tomorrow and need to start cramming D:

Final thoughts: Works great, proggy would be nice to show off your script, consider adding the six hour fix to avoid shutdown. I didn't see the sixhourfix in the setup procedure.

EDIT: Simple addition for the SixHourFix to get some long ass proggies when I incorporate the progress report system.

Code:

---

Procedure Setup;
var loggedingame: Boolean;
var x,y: Integer;
Begin
  {$IFDEF SIMBAMAJOR980}
    SMART_SERVER := 10;
    SMART_MEMBERS := TRUE;
    SMART_SIGNED := TRUE;
    SMART_SUPERDETAIL := FALSE;
  {$ELSE}
    SRL_SIXHOURFIX := TRUE;    //ADDED HERE
    SMART_FIXSPEED := TRUE;
  {$ENDIF}

---

EDIT2:
http://i.imgur.com/KSFkD.jpg
Got stuck after a possible misclick. Returned to computer and i wasn't at the targets. No problems in the debug, only fix for this would be a failsafe to check position.

I'll have to add login and bank pin support before the 6hour fix, i can add the progress report for you fairly easy, so no worries :), i know how im going to fix that missclick too :)

Ill look at fixing this today

Quote:

---

Originally Posted by DannyRS

I'll have to add login and bank pin support before the 6hour fix, i can add the progress report for you fairly easy, so no worries :), i know how im going to fix that missclick too :)

Ill look at fixing this today

---

whooh! 99 range here i come :D

working on V2.0 now, majour re-write, think i have it flawless now, just testing before upload :)

Updated, V2.0 - Major re-write, Added a progress report, best version yet,

setup and spot remain the same

Thanks for the script! Does this do both activities?

Quote:

---

Originally Posted by Voyaging

Thanks for the script! Does this do both activities?

---

only targets atm, whats the other activity?

Quote:

---

Originally Posted by DannyRS

Updated, V2.0 - Major re-write, Added a progress report, best version yet,

setup and spot remain the same

---

Gonna go fire this back up :D

Quote:

---

Originally Posted by MMOE

Gonna go fire this back up :D

---

Let me know how it does :)

It shut down two hours in :(
I probably should have turned debug on :P
When i logged in, i was in the correct spot still, everything was okay. I guess to many errors made it fail? Or maybe it couldn't find the judge?

The two other bots there were still running when i logged back on, and normally that place is empty :P I'm assuming they were using your script! So I will give it another go with debug on.

Quote:

---

Originally Posted by MMOE

It shut down two hours in :(
I probably should have turned debug on :P
When i logged in, i was in the correct spot still, everything was okay. I guess to many errors made it fail? Or maybe it couldn't find the judge?

The two other bots there were still running when i logged back on, and normally that place is empty :P I'm assuming they were using your script! So I will give it another go with debug on.

---

Aww darn, must be a pesky Exit; in a place no longer needed, i shall hunt him down :)

EDIT- couldent see anything, as a temp fix change bottom of script from

Code:

---

begin
  Setup;
  ActivateClient;
  ClearDebug;
  MainLoop;
  LogOutGame;
end.

---

to

Code:

---

begin
  Setup;
  ActivateClient;
  ClearDebug;
  repeat begin MainLoop; end;
  until keepalive;
  LogOutGame;
end.

---

and line 8 to

Code:

---

stop, keepalive: Boolean;

---

running this now. First comments:
1) alot of unused varibles but I think this is just because your in the middle of some updates
2)Possible addition could be an option to not equip the arrows (would save time, would require having 1k or so arrows already equiped
3)Good script, Noticed your releasing a lot of scripts (did ashman give u his script making script? ;)) keep up the good work!

Quote:

---

Originally Posted by The Killer

running this now. First comments:
1) alot of unused varibles but I think this is just because your in the middle of some updates
2)Possible addition could be an option to not equip the arrows (would save time, would require having 1k or so arrows already equiped
3)Good script, Noticed your releasing a lot of scripts (did ashman give u his script making script? ;)) keep up the good work!

---

There should be a variable at the top for the arrow equpping! :)

I'm really enjoying the script making, so as one reaches completion the next begins!

The variables are because i copy / paste my functions alot and modify them, next release i'll remove them :)

Quote:

---

Originally Posted by DannyRS

There should be a variable at the top for the arrow equpping! :)

I'm really enjoying the script making, so as one reaches completion the next begins!

The variables are because i copy / paste my functions alot and modify them, next release i'll remove them :)

---

ok :)
and yeah just spotted the const.....
feeling dull now, o well :P

Quote:

---

Originally Posted by The Killer

ok :)
and yeah just spotted the const.....
feeling dull now, o well :P

---

kinda forgot about this script a bit :)

is it still working ok? i guess somethings going right because the latest version has like 50 views or something and nobody complained

I have had it running for about 20 minutes and its been going well. I will keep an eye on it and let you know how it goes!

nice script btw :D

Update: Every now and then it will get stuck on the target view screen and the debug just says "waiting for arrow to hit". I just manually exited out and it ran well until it happens again. Also, if on a crowded world and the right click brings up a bunch of player names, it sits for a a couple of minutes but sorts itself out. Other than those two things its been running pretty well.

Quote:

---

Originally Posted by garyman

I have had it running for about 20 minutes and its been going well. I will keep an eye on it and let you know how it goes!

nice script btw :D

Update: Every now and then it will get stuck on the target view screen and the debug just says "waiting for arrow to hit". I just manually exited out and it ran well until it happens again. Also, if on a crowded world and the right click brings up a bunch of player names, it sits for a a couple of minutes but sorts itself out. Other than those two things its been running pretty well.

---

Sounds like a lag / delay issue, and as for the crowded worlds, its causing too much calculation from the ChoseOption include, so i would find an empty world for best xp, maybe i can update the efficiency of the waiting for arrow to hit, so that its faster xp, thanks alot for the feedback and test :),

Glad its actually running ok and the failsafes are working as intended :)

how much exp/hour can i expect to get from this @ 80 range?

Just started the script it loads up to were it inputs the username and just does nothing. Followed your setup guide just is not working for me.

Quote:

---

Just started the script it loads up to were it inputs the username and just does nothing. Followed your setup guide just is not working for me.

---

I had this issue for a bit. I start the script then disable SMART, log in and stop the script. Then i walk around just a little bit, then go back to the start spot, re-enable SMART, and hit the play button and it goes.

That Target arrow screen (for me at least) happens pretty frequently.This will be a great script once that gets handled. you deserve the Promising Newcomer cup for sure! thanks for the great script and glad I could help! :D

Thanks for the response working nicely great script.

Going to go start this and let you know how it goes :D

EDIT: Having issues. I got logged and then the debug says the script is still looking for the judge.http://i.imgur.com/3FLlZ.png

Quote:

---

EDIT: Having issues. I got logged and then the debug says the script is still looking for the judge

---

Did the ashaman proggy show up when you tried to run this?
try what i suggested a few posts up and see if it starts correctly that way.

Danny- If I just let it sit it runs perfect, If i try and watch the client while its running it gets stuck at the Target View Screen. I have no idea why this is.

Quote:

---

Originally Posted by garyman

Did the ashaman proggy show up when you tried to run this?
try what i suggested a few posts up and see if it starts correctly that way.

Danny- If I just let it sit it runs perfect, If i try and watch the client while its running it gets stuck at the Target View Screen. I have no idea why this is.

---

Ha the ashaman doesn't go away for me until i close the client and open a new one. I was doing agility before i went to range guild. The first time i used the script, using agility prior to, did not affect the script.

I'll take a look at a better way to detect target screen when im home,

As for getting logged, you'll have to add your own log in, i'll add it sometime, but its low prio atm :D

This script is exactly what I have been looking for. Thanks DannyRS. It's working perfectly for me.

Quote:

---

Originally Posted by podmore999

This script is exactly what I have been looking for. Thanks DannyRS. It's working perfectly for me.

---

glad to hear its what you needed, like everything i do, its going to be improved as i discover better ways to accomplish things :)