Printable View
Hello,
I was wondering if there was anyone out there that would be interested in helping me with my fishing script. It is currently one that fishes in Shilo Village and i am having issues trying to figure out how to find fish in all the different locations on the river.
If there is anyone out there to help me, please let me know.
You can just ask, and i will happily share what i have got so far and you can help me! XD
Thanks!
This post is for iSpy. Anybody? Help would be nice.
Maybe post screenshots of the different locations you want to fish at.
Here are the screen shots. I would like to find a way to get to these spots. I tried DDTMs, but those dont seem to like me. I have also tried SPS, but that doesnt seem to be working. Unless it has been changed a ton recently.Quote:
Originally Posted by BMWxi
Attachment 20165Attachment 20166Attachment 20167
Try finding the Runescape surface maps of the area in the SPS/Img/Runescape_Surface folders and use SPS for them. There are very informative and easy to understand tuts on SPS in the tutorials section. SPS is my favorite way of walking in all of my scripts.
E: By the way, I just use paint and cut out the parts I need in order to combine different maps, ect. Cut/Paste the areas together. Then use a pathmaker found here: http://villavu.com/forum/showthread.php?t=62360. You can also find others, and you'll have to experiment to find the one you like the most.
I used to LOVE SPS, but now i cant seem to ever get it right...Quote:
Originally Posted by Sawyer
You got a link to a newer tutorial?
I used it mainly last year at about May. lol. So im a bit out of date...
I'll find one, just a second.
Edit: I learned SPS from Google's guide here: http://villavu.com/forum/showthread....+create+custom
You don't need to even make your own snipits for the map if it's a surface area. Simply open it in Microsoft paint/ Any other image editing program and cut out the areas you need.
Awesome! Ill look into that! Oh! And this is my 200th post! lol. Yeah!Quote:
Originally Posted by Sawyer
Congratulations! On your way to Junior SRL Membership I see :)
Lol. Yup! Thats the goal! Its fun to try to get there. Ha ha. XDQuote:
Originally Posted by Sawyer
Now, would you know anyway to not click another spot while fishing? Ive tried pixelshift but that doesnt seem to work...
Well, good question. I would try to use a method of detecting if you're xp went up in a certain amount of time. If it does, then you are fishing. If it doesn't, then you are not. Here's a quick procedure Function you could use:
Code:Function IsFishing: Boolean;
var
XPA,T: Integer; //The variables we would use.
begin
Result := False; // The starting result.
if not LoggedIn then
Exit;
XPA := GetXPBar(1); // This will get the xp from your 1st spot on the xp bar. An SRL procedure.
MarkTime(T); //This will mark the time from this procedure and count it.
Repeat
if InvFull then
exit;
if not LoggedIn then
Exit;
if (GetXPBar(1) <> XPA) then //This will break the procedure and the result will be true if you gain xp.
break;
Until(TimeFromMark(T) > randomrange(11000, 13000)) //11-13 seconds to wait in finding the result
Result := (GetXPBar(1) <> XPA); //If your xp increases in this, the result will be true.
end;
Hmm... Any idea on how i could make that work?Quote:
Originally Posted by Sawyer
I've edited my post above with a commented code example you can use :) Read the comments to see the method.
Interesting... did you write that?Quote:
Originally Posted by Sawyer
I initially wrote it, and Flight helped me revise it a while ago on one of my Fishing scripts.
Interesting. Well, i will be sure to credit you in my script, if you dont mind me using it.Quote:
Originally Posted by Sawyer
Also, i am having more issues. Are you up to helping me solve them? lol
Yes, you can sure use it :) And Yes if I am on, I'll gladly help. It's almost 11 here now though, so I'm going to sleep :pQuote:
Originally Posted by StickToTheScript
Ok. Feel free to go to sleep when you wish! lol.Quote:
Originally Posted by Sawyer
But when you have the time, could you seem to figure this out for me?
I seem to always run into an issue that when i try to run to the shilo bank, it always seems to just skip over my procedure when i clearly tell it to go through it.
My Procedure is this:
Simba Code:procedure WalkToBank;
begin
if sps_walkpath(ToBank) then
status := 'walking to the Bank.'
else begin
status :='failed walking to the Bank.';
end;
end;
and my mainloop looks something like:
Simba Code:begin
repeat
WalkToFishSpot;
Fishing;
WalkToBank;
FindBankers;
DepositFish;
until AllPlayersInactive;
end;
And my path is this:
Simba Code:ToBank := [Point(3249, 4723), Point(3229, 4760), Point(3204, 4788)];
Any thoughts?
Give ODTMs a try, with all those trees and bushes on the minimap you have it should be easy to get a good path :)Quote:
Originally Posted by StickToTheScript
Ok. I will see. But do you know any good way to get to those places. What i mean is that when the player is not fishing for a certain amount of time, it changes location, searches, if finds nothing, changes to another location, etc.Quote:
Originally Posted by BMWxi
What I do in my Lumbridge Fly Fisher is similar to what you want I think. In Lumbridge, there are two different areas where salmon and trout can be caught. I have a location checking function that returns the string of my area (The EocBox bit is what I use in banking so I use that to check if I successfully teleported to the bank, you can ignore it) :Quote:
Originally Posted by StickToTheScript
So then if I can't find the fishing spot because it ran out, I useSimba Code:function MyLocation:string;
begin
if ObjDTM_InArea('80:80:5:1:7:102:41:1:7:103:57:1:7:83:48:1:7:137:57:1:7:41:88:4:68:74:95:74:92:115:73:113', true) then
begin
if Debug then
WriteLn('In SouthBox!');
result := 'SouthSpot';
Exit;
end;
if ObjDTM_InArea('80:80:6:1:7:111:31:1:7:104:56:1:7:103:72:1:7:83:63:1:7:38:104:1:7:140:72:4:59:43:67:91:94:88:83:43', true) then
begin
if Debug then
WriteLn('In NorthBox!');
result := 'NorthSpot';
Exit;
end;
if ObjDTM_InArea('80:80:6:10:7:84:32:10:7:68:31:10:7:63:39:10:7:59:55:10:7:75:48:10:7:35:43:4:51:50:51:91:101:91:101:50', true) then
begin
if Debug then
WriteLn('In EocBox!');
result := 'EocBank';
end;
end;Simba Code:if (MyLocation = 'NorthSpot') then
begin
WriteLn('Walking to SouthSpot');
WalkToSouthSpot;
FishFish;
Exit;
end;
if (MyLocation = 'SouthSpot') then
begin
WriteLn('Walking to NorthSpot');
WalkToNorthSpot;
FishFish;
Exit;
end;
This checks if I'm in an area, then if I am I walk to the area I'm not in.
You could do this for many areas if you wanted to :)
Hmm.. Ok. I get it now. So, do you mind if i borrow a bit of that and change it up? Lol. XDQuote:
Originally Posted by BMWxi
That's fine, just credit me :)Quote:
Originally Posted by StickToTheScript
Happily! Lol. Now, how did you make it switch between the spots? Did you write a procedure/function that woudl go to a different spot after a certain amount of time not fishing?Quote:
Originally Posted by BMWxi
I use Pixelshift to find out if I'm still fishing, when I'm not fishing I look for another spot using the procedure that I use to click the fishing spot. If it can't find one then I use the thing I posted above to move to a new spot. (I use SPS to actually walk though)Quote:
Originally Posted by StickToTheScript
Interesting.. alright. So do you mind if i PM you what ive got so far and see if you can help me solve like 1 or 2 more things? If not, anyone else up for it?Quote:
Originally Posted by BMWxi
Go for it :)Quote:
Originally Posted by StickToTheScript
Ok. Cool. Thanks for everything so far! XDQuote:
Originally Posted by BMWxi
Possibly make your SPS Maps bigger for SPS Walking. Or ODTM's, which Euphamism has a nice guide on here:http://villavu.com/forum/showthread....highlight=odtm
I use the Runescape Surface when i do SPS walking tho.Quote:
Originally Posted by Sawyer
Ah. You could possibly make larger paths, or paths which contain points that are close together.
Yeah. I tried that. I still couldn't get it to walk certain places tho.Quote:
Originally Posted by Sawyer
How long are your paths, and where do you want them to walk to? Most of my paths are very long, here is an example from one of my woodcutting scripts:
Simba Code:Procedure Paths;
begin
//FromBankToSouthtree := [Point(298, 162), Point(294, 162), Point(288, 159), Point(281, 156), Point(277, 156), Point(272, 154), Point(266, 152), Point(262, 151), Point(255, 150), Point(249, 149), Point(242, 149), Point(236, 148), Point(230, 146), Point(225, 144), Point(219, 144), Point(210, 143), Point(205, 143), Point(197, 140), Point(191, 138), Point(186, 136), Point(179, 132), Point(171, 130), Point(166, 129), Point(159, 127), Point(152, 125), Point(148, 123), Point(143, 121), Point(139, 118), Point(135, 116), Point(132, 113), Point(129, 111), Point(128, 110)];
FrombankToSouthTree := [Point(308, 162), Point(304, 162), Point(300, 159), Point(293, 158), Point(281, 157), Point(274, 154), Point(265, 154), Point(252, 154), Point(243, 151), Point(232, 148), Point(219, 146), Point(205, 144), Point(190, 142), Point(176, 136), Point(157, 129), Point(142, 123), Point(135, 115), Point(135, 109)];
FromBankToNorthtree := [Point(247, 227), Point(246, 226), Point(242, 223), Point(240, 221), Point(236, 219), Point(231, 215), Point(227, 213), Point(221, 206), Point(221, 206), Point(218, 202), Point(215, 196), Point(213, 194), Point(212, 189), Point(209, 182), Point(206, 178), Point(202, 174), Point(199, 171), Point(197, 168), Point(190, 164), Point(187, 162), Point(185, 161), Point(180, 158), Point(178, 156), Point(173, 153), Point(171, 150), Point(166, 146), Point(163, 141), Point(161, 137), Point(159, 135), Point(158, 132), Point(156, 127), Point(152, 123), Point(148, 118), Point(143, 114), Point(138, 113), Point(138, 112), Point(137, 106), Point(135, 101), Point(134, 96), Point(133, 91), Point(132, 84), Point(130, 79), Point(129, 75), Point(128, 72), Point(128, 72)];
BetweenSouthTreeToNorthTree := [Point(94, 161), Point(94, 161), Point(95, 157), Point(96, 153), Point(98, 148), Point(99, 144), Point(100, 138), Point(101, 133), Point(102, 128), Point(104, 123), Point(106, 118), Point(107, 112), Point(110, 106), Point(112, 101), Point(113, 96), Point(115, 92), Point(116, 88), Point(119, 82), Point(122, 79), Point(123, 76), Point(124, 73)];
betweenNorthTreeToSouthTree := [Point(124, 74), Point(124, 77), Point(124, 82), Point(122, 87), Point(117, 93), Point(117, 96), Point(113, 102), Point(111, 108), Point(108, 117), Point(107, 125), Point(105, 133), Point(104, 139), Point(102, 146), Point(98, 152), Point(95, 156), Point(95, 158), Point(91, 163), Point(90, 167)];
//TobankfromSouthtree := [Point(128, 110), Point(129, 111), Point(132, 113), Point(135, 116), Point(139, 118), Point(143, 121), Point(148, 123), Point(152, 125), Point(159, 127), Point(166, 129), Point(171, 130), Point(179, 132), Point(186, 136), Point(191, 138), Point(197, 140), Point(205, 143), Point(210, 143), Point(219, 144), Point(225, 144), Point(230, 146), Point(236, 148), Point(242, 149), Point(249, 149), Point(255, 150), Point(262, 151), Point(266, 152), Point(272, 154), Point(277, 156), Point(281, 156), Point(288, 159), Point(294, 162), Point(298, 162)];
ToBankFromSouthTree := [Point(134, 107), Point(135, 117), Point(140, 119), Point(149, 122), Point(163, 130), Point(174, 138), Point(183, 145), Point(195, 148), Point(212, 153), Point(228, 151), Point(245, 153), Point(259, 155), Point(272, 160), Point(288, 164), Point(300, 164)];
tobankfromNorthTree := [Point(123, 73), Point(123, 73), Point(127, 79), Point(129, 83), Point(131, 87), Point(134, 93), Point(135, 97), Point(137, 104), Point(139, 110), Point(141, 115), Point(145, 122), Point(149, 127), Point(152, 131), Point(156, 137), Point(162, 145), Point(167, 151), Point(170, 154), Point(173, 159), Point(178, 166), Point(181, 171), Point(183, 177), Point(189, 186), Point(192, 191), Point(196, 199), Point(196, 200), Point(200, 207), Point(201, 210), Point(204, 213), Point(210, 216), Point(215, 218), Point(219, 221), Point(225, 223), Point(230, 225), Point(237, 226), Point(240, 227), Point(242, 228)];
ToBank := [Point(92, 174), Point(92, 174), Point(93, 171), Point(96, 163), Point(99, 157), Point(101, 151), Point(105, 142), Point(107, 135), Point(111, 124), Point(115, 113), Point(117, 104), Point(118, 96), Point(121, 90), Point(123, 85), Point(128, 77), Point(129, 74), Point(137, 82), Point(141, 88), Point(146, 94), Point(148, 96), Point(150, 99), Point(154, 104), Point(159, 111), Point(164, 118), Point(167, 121), Point(169, 124), Point(171, 127), Point(174, 131), Point(178, 136), Point(181, 140), Point(185, 146), Point(189, 151), Point(192, 156), Point(196, 161), Point(199, 165), Point(202, 169), Point(206, 175), Point(210, 179), Point(213, 183), Point(215, 187), Point(219, 192), Point(223, 198), Point(227, 202), Point(231, 207), Point(232, 209), Point(233, 210), Point(238, 213), Point(242, 216), Point(245, 219), Point(249, 221), Point(251, 222), Point(255, 222), Point(255, 222)];
end;
NOt quite as long, but around 5-8 points each. But my main issues is location finding. I am working with ODTMs and they are hating me so much right now! Any ideas?Quote:
Originally Posted by Sawyer
Well, maybe symbol grabbing on the minimap. Otherwise, Maybe use SPS_GetAreaCoords and see if they match within a tolerance for that map?
Quote:
Originally Posted by Sawyer
OOO! we may be on to something... SPS_GetAreaCoords is used how?
SPS_GetMyPos is what I tried I believe, although when I used it it took over a second and was inaccurate, although according to Olly (I think) usually it works fine. :)Quote:
Originally Posted by StickToTheScript
Haven't used SPS_GetAreaCoords before but that could be worth trying. Maybe look in the SPS includes to find out how to use it.
Eh.. I have never used it. The documentation doesn't give an example either.. Maybe @BMWxi knows?
Alrighty. I will see what i can find and edit this post with my results.
Edit: Alright. So i looked at the possibilities, and they are: SPS_GetAreaCoords, SPS_GetMyPos, and SPS_BlindWalk.
I think i could actually use blind walk. lol. Although, i do not know how to use either of the 3. Anybody have examples from other scripts, etc.?
What is the progress on this script? I would be very interested in it.