Results 1 to 15 of 15

Thread: GE vial filler

  1. #1
    Join Date
    Jul 2014
    Posts
    204
    Mentioned
    4 Post(s)
    Quoted
    125 Post(s)

    Default GE vial filler

    My first script Works pretty well, running for a few hours now.
    known problems:
    Sometimes doesn't click banker ( I have tried many things to fix this )
    No antiban ( looking for a tutorial on how to make one)

    Simba Code:
    program vialfiller;
    {$DEFINE SMART}
    {$I SRL-6/SRL.simba}
    {$I SPS/lib/SPS-RS3.Simba}

    var
       i : integer;

    procedure Clickbank();
     var
      x, y: integer;
    begin

    if mainscreen.findObject(x, y, 1398387, 55, colorSetting(2, 0.07, 0.15), mainscreen.playerPoint, 30, 50, 50, ['ank Banker'], MOUSE_LEFT) then
    begin
    wait(randomRange(540, 861));
    writeLn('bank opened!');
    wait(randomRange(531, 712));
    bankScreen.quickDeposit(QUICK_DEPOSIT_INVENTORY);
    wait(randomRange(540, 861));
    bankScreen.withdraw(1, WITHDRAW_AMOUNT_ALL, ['ial']);
    wait(randomRange(512, 1312));
    bankScreen.close();
    end;
    end;



    procedure fillvials();
     var
      x, y: integer;

    begin
     tabBackPack.mouseSlot(1, MOUSE_LEFT);  //clicks vial in backpack
     if mainscreen.findObject(x, y, 12757145, 25, colorSetting(2, 0.07, 0.15), mainscreen.playerPoint, 30, 50, 50, ['se Vial'], MOUSE_LEFT) then //clicks fontain
    begin
    wait(randomRange(2000, 3000));
    mouse(391, 338, 5, 20, MOUSE_MOVE); //click Fill
    fastClick(MOUSE_LEFT);
    wait(randomRange(17001, 18005));
    writeLn('Fountain clicked!')
    end;
    end;

    procedure walkfontain();
    var
       pathfontain: TPointArray;
       begin
        pathfontain := [Point(192, 205), Point(158, 223), Point(140, 249)]

      if SPS.walkPath(pathfontain) then
        minimap.waitPlayerMoving()
      else
        writeLn('We failed to walk to the mine');
           end;

           procedure walkbank();
    var
       pathbank: TPointArray;
       begin
    pathbank := [Point(140, 249), Point(158, 223), Point(192, 205)]

      if SPS.walkPath(pathbank) then
        minimap.waitPlayerMoving()
      else
        writeLn('We failed to walk to the mine');
           end;


    begin
       // initialize and prepare things
       //
       addOnTerminate('scriptTerminate');
       ClearDebug();
       smartEnableDrawing := true;
       SetupSRL();
       Players.Setup(['lol'], 'lol');
       currentPlayer := 0;
       SPS.setup('GEmap', RUNESCAPE_OTHER);  // Setup our map
       for i := 0 to high(players) do
       begin
          players[i].isActive := true;
       end;
       // do the work
       //
        while (players.getActive() > 0) do
       begin
          if (not isLoggedIn()) then
          begin
             if (not players[currentPlayer].login()) then break;
             mainscreen.setangle(MS_ANGLE_HIGH);
             exitSquealOfFortune();
          end;
          Clickbank();
          walkfontain();
          fillvials();
          walkbank();
        end;
    end.

  2. #2
    Join Date
    Jul 2014
    Location
    Europe
    Posts
    182
    Mentioned
    7 Post(s)
    Quoted
    103 Post(s)

    Default

    I'm still a noob, I just discovered Simba a few days ago, but I can tell your script does look good. You probably learned scripting by following The Mayor's guides, right? (that's what I'm doing atm )

    I suggest you replace this:
    Simba Code:
    exitSquealOfFortune();

    By this:
    Simba Code:
    exitTreasure();

    Why? Because from what I've read the squeel of fortune doesn't exist anymore in RS3 and is now replaced by treasure hunter, correct me if I'm wrong.

    For the antiban I advise you to explore the following link. You don't have to listen to me because I'm really just a beginner but that's what I would do.

    http://docs.villavu.com/srl-6/antiban.html

  3. #3
    Join Date
    Jul 2014
    Location
    Europe
    Posts
    182
    Mentioned
    7 Post(s)
    Quoted
    103 Post(s)

    Default

    Although I'm a noob myself this looks like a pretty good script to begin with. You probably learned all of this from Mayor's guides, right? I can see it by the style you made this script (I'm following his AIO guide at the moment).

    You probably want to edit the writeLn lines at your walkfountain() and walkbank() procedures. It's saying something about mines while this script is clearly not about mining. I also suggest you to enter tabs at some places so it would look more organized. You should go to the following link (The Mayor's AIO guide). Do CTRL+F and type 'Indentation standards' so you would know what I'm talking about.
    Link: villavu.com/forum/showthread.php?t=107757

    I also advise you to change the following:
    Simba Code:
    exitSquealOfFortune();

    Into:
    Simba Code:
    exitTreasure();

    Why? Because the squeal of fortune is changed into treasure hunter in RS3, correct me if I'm wrong.

    You don't have to do anything what I'm saying because I'm also a total beginner (I actually started to get into Simba a few days ago), but I think I could help you with the knowledge I've already achieved. I also recommend you to check out the following link about the antiban:
    Link: docs.villavu.com/srl-6/antiban.html

    Good job so far and keep up the good work!

  4. #4
    Join Date
    Dec 2011
    Location
    East Coast, USA
    Posts
    4,231
    Mentioned
    112 Post(s)
    Quoted
    1869 Post(s)

    Default

    Quote Originally Posted by Spaceblow View Post
    I also advise you to change the following:
    Simba Code:
    exitSquealOfFortune();

    Into:
    Simba Code:
    exitTreasure();

    Why? Because the squeal of fortune is changed into treasure hunter in RS3, correct me if I'm wrong.

    You don't have to do anything what I'm saying because I'm also a total beginner (I actually started to get into Simba a few days ago), but I think I could help you with the knowledge I've already achieved. I also recommend you to check out the following link about the antiban:
    Link: docs.villavu.com/srl-6/antiban.html

    Good job so far and keep up the good work!
    exitSquealOfFortune() is now a wrapper for exitTreasure(). The reason behind this is that the transition from SoF to Treasure Hunter only required a small update to SRL-6, and it would have been silly to remove the old routine, as that would have broken all the RS3 scripts. So it was left in.

    Other than that, you're right, OP you've got some weird naming discrepancies in your script and the standards aren't quite up to par. Fix those and this will be a golden first script.

    You may also want to look into tabBackpack.clickDtm() instead of .clickSlot(), it'll be more accurate & stable
    GitLab projects | Simba 1.4 | Find me on IRC or Discord | ScapeRune scripts | Come play bot ScapeRune!

    <BenLand100> we're just in the transitional phase where society reclassifies guns as Badâ„¢ before everyone gets laser pistols

  5. #5
    Join Date
    Jun 2007
    Location
    The land of the long white cloud.
    Posts
    3,702
    Mentioned
    261 Post(s)
    Quoted
    2006 Post(s)

    Default

    Nice first script, although you can use more some SRL6 functions to replace what you have for filling the vials. The production screen is the one where you select what you want to make and press staft/fill etc, and the progress screen is the one that pops up while your player making something.

    You could change this:

    Simba Code:
    procedure fillvials();
    var
      x, y: integer;
    begin
      tabBackPack.mouseSlot(1, MOUSE_LEFT);  //clicks vial in backpack

      if mainscreen.findObject(x, y, 12757145, 25, colorSetting(2, 0.07, 0.15), mainscreen.playerPoint, 30, 50, 50, ['se Vial'], MOUSE_LEFT) then //clicks fontain
      begin
        wait(randomRange(2000, 3000));
        mouse(391, 338, 5, 20, MOUSE_MOVE); //click Fill
        fastClick(MOUSE_LEFT);
        wait(randomRange(17001, 18005));
        writeLn('Fountain clicked!')
      end;

    end;

    To something like:

    Simba Code:
    procedure fillvials();
    var
      x, y: integer;
    begin
      tabBackPack.mouseSlot(1, MOUSE_LEFT);

      if mainscreen.findObject(x, y, 12757145, 25, colorSetting(2, 0.07, 0.15), mainscreen.playerPoint, 30, 50, 50, ['se Vial'], MOUSE_LEFT) then //clicks fountain
      begin
        writeLn('Clicked fountain!');

        if productionScreen.isOpen(5000) then
        begin
          writeLn('Production screen is open - pressing fill');
          productionScreen.clickStart(true);

          if progressScreen.isOpen(5000) then
          begin
            writeLn('Progress screen is open - waiting');

            repeat
              //antiBan(); //call your antiban procedure here
              wait(randomRange(500, 1000));
            until (progressScreen.getButton() < 1);

          end else
            writeLn('Progress screen didn''t appear within 5 sec');

        end else
          writeLn('Production screen didn''t appear within 5 sec');

      end else
        writeLn('Didn''t find the fountain');
    end;

  6. #6
    Join Date
    Jul 2014
    Posts
    204
    Mentioned
    4 Post(s)
    Quoted
    125 Post(s)

    Default

    Quote Originally Posted by The Mayor View Post
    Nice first script, although you can use more some SRL6 functions to replace what you have for filling the vials. The production screen is the one where you select what you want to make and press staft/fill etc, and the progress screen is the one that pops up while your player making something.

    You could change this:

    Simba Code:
    procedure fillvials();
    var
      x, y: integer;
    begin
      tabBackPack.mouseSlot(1, MOUSE_LEFT);  //clicks vial in backpack

      if mainscreen.findObject(x, y, 12757145, 25, colorSetting(2, 0.07, 0.15), mainscreen.playerPoint, 30, 50, 50, ['se Vial'], MOUSE_LEFT) then //clicks fontain
      begin
        wait(randomRange(2000, 3000));
        mouse(391, 338, 5, 20, MOUSE_MOVE); //click Fill
        fastClick(MOUSE_LEFT);
        wait(randomRange(17001, 18005));
        writeLn('Fountain clicked!')
      end;

    end;

    To something like:

    Simba Code:
    procedure fillvials();
    var
      x, y: integer;
    begin
      tabBackPack.mouseSlot(1, MOUSE_LEFT);

      if mainscreen.findObject(x, y, 12757145, 25, colorSetting(2, 0.07, 0.15), mainscreen.playerPoint, 30, 50, 50, ['se Vial'], MOUSE_LEFT) then //clicks fountain
      begin
        writeLn('Clicked fountain!');

        if productionScreen.isOpen(5000) then
        begin
          writeLn('Production screen is open - pressing fill');
          productionScreen.clickStart(true);

          if progressScreen.isOpen(5000) then
          begin
            writeLn('Progress screen is open - waiting');

            repeat
              //antiBan(); //call your antiban procedure here
              wait(randomRange(500, 1000));
            until (progressScreen.getButton() < 1);

          end else
            writeLn('Progress screen didn''t appear within 5 sec');

        end else
          writeLn('Production screen didn''t appear within 5 sec');

      end else
        writeLn('Didn''t find the fountain');
    end;
    after using your code, it runs back with only a few vials filled. progressScreen is the screen that opens after filling the vials? Cus it doesn't open , I think I disabled it somewhere in the setting but I don't find where.

    edit: enabled the progressScreen again.
    changing
    if progressScreen.isOpen(5000) then
    to
    if progressScreen.isOpen(16000) then
    works, but isn't there a way to let it wait till progressScreen is closed?

    and when productionScreen opens, it clicks Fill really fast, not human like, I'm adding a random wait there.

    anyway, I'm really suprised I'm not banned yet, botting money making method like 6 hours a day without antiban. Is this normal ? or I'm just really lucky? I'm used to get banned after botting 2 hours using the most popular rs bot ...
    Last edited by lanadekat; 08-03-2014 at 10:48 AM.

  7. #7
    Join Date
    Jun 2007
    Location
    The land of the long white cloud.
    Posts
    3,702
    Mentioned
    261 Post(s)
    Quoted
    2006 Post(s)

    Default

    Quote Originally Posted by lanadekat View Post
    progressScreen is the screen that opens after filling the vials?
    No, it is the screen that appears while filling the vials. You have to enable 'make x progress window' in interface settings.

    Quote Originally Posted by lanadekat View Post
    edit: enabled the progressScreen again.
    changing
    if progressScreen.isOpen(5000) then
    to
    if progressScreen.isOpen(16000) then
    works, but isn't there a way to let it wait till progressScreen is closed?
    This doesn't actually work. It's not detecting the progress screen is open, so it doesn't enter the repeat loop. You are just telling it to wait 16 seconds for the progress screen to be open. If you've enabled it in the interface settings but it's still not working (you can tell if it prints the message) then reset your interfaces to oldschool.

    Quote Originally Posted by lanadekat View Post
    but isn't there a way to let it wait till progressScreen is closed?
    It does, this code repeats until it cannot see the red cancel button anymore

    Simba Code:
    repeat
      //antiBan(); //call your antiban procedure here
      wait(randomRange(500, 1000));
    until (progressScreen.getButton() < 1);



    Quote Originally Posted by lanadekat View Post

    and when productionScreen opens, it clicks Fill really fast, not human like, I'm adding a random wait there.

    anyway, I'm really suprised I'm not banned yet, botting money making method like 6 hours a day without antiban. Is this normal ? or I'm just really lucky? I'm used to get banned after botting 2 hours using the most popular rs bot ...
    productionScreen.clickStart(true);

    The true means it will actually press spacebar. Set it to false if you actually want to click the button. Because your script isn't flawless, you're the only one using it, and more importantly you're using colour (your script can only see what a human can see), why would you expect to be banned? This isn't powerbot.

  8. #8
    Join Date
    Jul 2014
    Posts
    204
    Mentioned
    4 Post(s)
    Quoted
    125 Post(s)

    Default

    Quote Originally Posted by The Mayor View Post
    No, it is the screen that appears while filling the vials. You have to enable 'make x progress window' in interface settings.



    This doesn't actually work. It's not detecting the progress screen is open, so it doesn't enter the repeat loop. You are just telling it to wait 16 seconds for the progress screen to be open. If you've enabled it in the interface settings but it's still not working (you can tell if it prints the message) then reset your interfaces to oldschool.



    It does, this code repeats until it cannot see the red cancel button anymore

    Simba Code:
    repeat
      //antiBan(); //call your antiban procedure here
      wait(randomRange(500, 1000));
    until (progressScreen.getButton() < 1);





    productionScreen.clickStart(true);

    The true means it will actually press spacebar. Set it to false if you actually want to click the button. Because your script isn't flawless, you're the only one using it, and more importantly you're using colour (your script can only see what a human can see), why would you expect to be banned? This isn't powerbot.
    I'm not the only one botting this. And jagex doesn't like goldfarming bots. And on pb forum they say jagex detects mouse movement and stuff like that.

    progressScreen didn't apear after 5 second:
    http://prntscr.com/493kpn

    anyway, the script is stable right now, and I would like to make a proggy.
    like:
    time ran:
    vials filled:
    loads done:
    vials p/h:
    is there a tutorial or something else to learn it?
    Last edited by lanadekat; 08-03-2014 at 12:20 PM.

  9. #9
    Join Date
    Dec 2011
    Location
    Hyrule
    Posts
    8,662
    Mentioned
    179 Post(s)
    Quoted
    1870 Post(s)

    Default

    just wait for the inventory pixel change in slot 28... see my herb or fletch script for an example..... basically there is an srl function that detects pixel changes by slot. You could also just have it wait for the blue color in the last slot... lots of different ways to do it.

  10. #10
    Join Date
    Jun 2007
    Location
    The land of the long white cloud.
    Posts
    3,702
    Mentioned
    261 Post(s)
    Quoted
    2006 Post(s)

    Default

    Quote Originally Posted by lanadekat View Post
    I'm not the only one botting this. And jagex doesn't like goldfarming bots. And on pb forum they say jagex detects mouse movement and stuff like that.

    progressScreen didn't apear after 5 second:
    http://prntscr.com/493kpn

    anyway, the script is stable right now, and I would like to make a proggy.
    like:
    time ran:
    vials filled:
    loads done:
    vials p/h:
    is there a tutorial or something else to learn it?
    progress screen must not work for vials ?? Do what ashaman said and wait for slot 28 to change colour. Easiest way is:

    tabBackpack.waitSlotPixelChange(28, 15000);


    RE then progress report, read the progress report part in my AIO tutorial, it shows you how to calculate the variables you want.

  11. #11
    Join Date
    Jul 2014
    Posts
    204
    Mentioned
    4 Post(s)
    Quoted
    125 Post(s)

    Default

    Quote Originally Posted by The Mayor View Post
    progress screen must not work for vials ?? Do what ashaman said and wait for slot 28 to change colour. Easiest way is:

    tabBackpack.waitSlotPixelChange(28, 15000);


    RE then progress report, read the progress report part in my AIO tutorial, it shows you how to calculate the variables you want.
    ok, thanks a lot for your help and your tutorials!

    Simba Code:
    repeat
              //antiBan(); //call your antiban procedure here
              wait(randomRange(500, 1000));
            until tabBackpack.waitSlotPixelChange(28, 15000);

    this does it I hope.
    I can't test cus I think bankScreen.isOpen(); broke by update notification
    I will try it in 25 min

    edit: doesn't work lol, just using wait for now, It doesn't need to be failsafe, it's for goldfarming and if it crashes I restart it, this also helps against bans xD
    And wait does the same thing , it just waits a second more ...
    Last edited by lanadekat; 08-04-2014 at 07:16 PM.

  12. #12
    Join Date
    Jun 2007
    Location
    The land of the long white cloud.
    Posts
    3,702
    Mentioned
    261 Post(s)
    Quoted
    2006 Post(s)

    Default

    Quote Originally Posted by lanadekat View Post

    edit: doesn't work lol, just using wait for now, It doesn't need to be failsafe, it's for goldfarming and if it crashes I restart it, this also helps against bans xD
    And wait does the same thing , it just waits a second more ...
    It works, you must have implemented it wrong

  13. #13
    Join Date
    Jul 2014
    Posts
    204
    Mentioned
    4 Post(s)
    Quoted
    125 Post(s)

    Default

    Quote Originally Posted by The Mayor View Post
    It works, you must have implemented it wrong
    Now I see, it doesn't detect the progressScreen so it doesn't enter the repear-untill loop.
    I'm gonna try to rewrite that part.

    edit: yes it works now, thanks!
    Last edited by lanadekat; 08-04-2014 at 08:51 PM.

  14. #14
    Join Date
    Nov 2012
    Location
    N/A
    Posts
    185
    Mentioned
    2 Post(s)
    Quoted
    19 Post(s)

    Default

    Obviously my script is really outdated, and since i have made it, theirs been a lot more better functions and procedures invented since, but if you like you can use parts of it if needed as well:

    https://villavu.com/forum/showthread.php?t=95571

  15. #15
    Join Date
    Oct 2013
    Posts
    7
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    gonna test this script

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •