Page 1 of 2 12 LastLast
Results 1 to 25 of 38

Thread: [release]Herblore Master[firstscript]

  1. #1
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Thumbs up [firstscript]Herblore Master[firstscript]

    Features

    .Banks At All Supported Locations
    .Anti Ban
    .Break System
    .Makes All Potions
    .Cleans All Herbs
    .Uses Quick Presets
    .Fail-safes
    .Prodigy System
    .Added Stats by Grats!

    Setup

    .Be sure to have your quick load layout on old school , action bar minimize,and the xp counter in the correct spot.
    .Fill out lines 7 - 14 to set up the bank,camera angle,bankpin,break handler, and antiban.
    .Set preset 1 for herbs and preset 2 for making potions.
    Preset 1
    c498eb6c4a.jpg
    Preset 2
    Have Primary Item in the first 14 slots.
    42f2d3ab8e.jpg
    .Put the xp counter here.
    5b1b2b4ed9.jpg
    .Hit the play button and fill out the form.

    Doesn't Have

    .Profit Calc
    .Familiar support
    Progress Reports

    You have made runs 681 out of 900 and have Made 9520 Unfs Your script stopped because Out of supplies And Total Breaks 3 and ran for 7 hr 30 min 23 sec

    You have made runs 286 out of 900 and have Cleaned 7980 Herbs Your script stopped because Out of supplies And Total Breaks 1 and ran for 2 hr 56 min 31 sec

    This was before i updated the prodigy to smart.

    Progress report by nero_dante


    Bugs

    .sometimes the xp gained bugs out just restart the script.
    .Very rarely drinks potions maybe 1/1500 hopfully fixed in V1b
    .overload potions bugged , hopefully fixed in v1.a - fixed

    Overload Setup

    Have items in Preset 2, the first 8 of them are the Clean torstol the rest are the 4 of each of the extreme potions.
    922d8df037.jpg


    99's With this script

    nero_dante

    Please Post any ideas on how to improve the code, or what could be added.
    Attached Files Attached Files
    Last edited by goodgamescript; 06-19-2015 at 06:07 PM. Reason: Added New Version

  2. #2
    Join Date
    Mar 2013
    Posts
    42
    Mentioned
    0 Post(s)
    Quoted
    9 Post(s)

    Default

    Hey man grats on ur first script. Might check this out tomorrow.
    Do you have any proggies yet?

  3. #3
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Quote Originally Posted by Fr3akNL View Post
    Hey man grats on ur first script. Might check this out tomorrow.
    Do you have any proggies yet?
    Added some.

  4. #4
    Join Date
    May 2012
    Posts
    499
    Mentioned
    23 Post(s)
    Quoted
    228 Post(s)

    Default

    Good job on the release!
    I think the script has quite a bit of unneeded code currently though. I have a similar script in the junior member section and it is around 200 lines.

    Example is this code:
    Simba Code:
    repeat
        wait(randomrange(300, 500));
      until (bankScreen.isOpen());

    This loop has no exit, what if the script logs out? Also the bankScreen.isOpen() has a max time integer, so it's rather useless to repeat that wait.
    You could just use 'bankScreen.isOpen(randomRange(5000,10000));'


    I recommened having a quick glance at my tutorial:
    https://villavu.com/forum/showthread.php?t=112779

    It should help you clean up your code I'm sure.
    If you want I'll also PM you the latest version of my script in the jr section.

  5. #5
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Thanks for the tip =D and sure you can pm me it, i will look at how the code is written and learn from it=D
    Last edited by goodgamescript; 05-06-2015 at 06:55 PM.

  6. #6
    Join Date
    May 2012
    Posts
    499
    Mentioned
    23 Post(s)
    Quoted
    228 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    Thanks for the tip =D and sure you can pm me it, i will look at how the code is written and learn from it=D
    Sent you a PM. I have been running the script for over 1k hours so far I think. Only thing I don't like is how I repeat the antiban as sometimes it can postpone the banking for new items.

    OP in the Jr section:

    Hey,

    This script could be used for making potions, combining battlestaffs, making wines,...
    Start at at any SRL supported bank, the script banks using preset 1.
    Have preset 1 setup so you have 1 of each item in slot 1 and 2 because it combines slot 1 on slot 2.
    It will repeat the antiban untill no item in slot 27 (this allows for faster restocking of items), so make sure the last slots will be cleared from items. (Mainly important if combining potions with scroll of cleansing).

    Example:
    Attachment 25718

    Keeping this in the junior section untill I receive more feedback and bugs.

  7. #7
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Quote Originally Posted by lovebotter View Post
    Sent you a PM. I have been running the script for over 1k hours so far I think. Only thing I don't like is how I repeat the antiban as sometimes it can postpone the banking for new items.

    OP in the Jr section:

    Hey,

    This script could be used for making potions, combining battlestaffs, making wines,...
    Start at at any SRL supported bank, the script banks using preset 1.
    Have preset 1 setup so you have 1 of each item in slot 1 and 2 because it combines slot 1 on slot 2.
    It will repeat the antiban untill no item in slot 27 (this allows for faster restocking of items), so make sure the last slots will be cleared from items. (Mainly important if combining potions with scroll of cleansing).

    Example:
    Attachment 25718

    Keeping this in the junior section untill I receive more feedback and bugs.
    i notice in your combine script that it has very few anitbans, does that really matter in a non-walking type of script?

  8. #8
    Join Date
    May 2012
    Posts
    499
    Mentioned
    23 Post(s)
    Quoted
    228 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    i notice in your combine script that it has very few anitbans, does that really matter in a non-walking type of script?
    I've ran the script over 1k hours. I don't think it matters much, feel free to add more antiban if you please.

  9. #9
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Im shorting the code on my script a bit, i have like over 50 lines of anti-ban i can remove then.

  10. #10
    Join Date
    May 2012
    Posts
    499
    Mentioned
    23 Post(s)
    Quoted
    228 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    Im shorting the code on my script a bit, i have like over 50 lines of anti-ban i can remove then.
    I wouldn't remove the antiban if it doesn't bother you.

  11. #11
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    True does fastClick() always click at the same rate or should i be using it at all?

  12. #12
    Join Date
    May 2012
    Posts
    499
    Mentioned
    23 Post(s)
    Quoted
    228 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    True does fastClick() always click at the same rate or should i be using it at all?

    Simba Code:
    (*
    fastClick
    ~~~~~~~~~

    .. code-block:: pascal

        procedure fastClick(button: integer);

    Quickly click the mouse with any button.

    .. note::

        - by Flight

    Example:

    .. code-block:: pascal

        fastClick(MOUSE_LEFT);

    *)

    procedure fastClick(button: integer);
    var
      x, y: integer;
    begin
      if (button = MOUSE_MOVE) then
        Exit;

      getMousePos(x, y);
      holdMouse(x, y, button);

      wait(randomRange(60, 150));

      getMousePos(x, y);
      releaseMouse(x, y, button);
    end;
    So it holds click down a little random yes.

  13. #13
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    hey how did u get the overload making to work?

  14. #14
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    sorry for the late response, and does it work lol i don't have the required herblore lvl to do em so the timing might be off a little. I notice a couple of bugs and is should be releasing another version with in the next week or so.

  15. #15
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    sorry for the late response, and does it work lol i don't have the required herblore lvl to do em so the timing might be off a little. I notice a couple of bugs and is should be releasing another version with in the next week or so.
    Well, the bot will bring out the items to start making the overloads, but then it doesnt try and put them all together, just stands there.

  16. #16
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Quote Originally Posted by nero_dante View Post
    Well, the bot will bring out the items to start making the overloads, but then it doesnt try and put them all together, just stands there.
    Alright try this new version and follow the overload setup and when you make overloads you do get the production screen?

  17. #17
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    Alright try this new version and follow the overload setup and when you make overloads you do get the production screen?
    I'll try it out when i get back home from work

  18. #18
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Quote Originally Posted by nero_dante View Post
    I'll try it out when i get back home from work
    Everything work ok?

  19. #19
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    Everything work ok?
    I been doing so many quests haven't gotten round to checking. I'll probably check it later on tonight

  20. #20
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    Everything work ok?
    yeah using now and with the preset that you told me to set it works I'll see if it runs for however long. I got 4k overloads to make :P

  21. #21
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    lasted an hour then randomly stopped doing anything even though the script is still running lol

    https://gyazo.com/9b1041caddf900214bbd249aa804393e


    EDIT: I left it for a few minutes and then it just started working again haha xD

  22. #22
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    that screenshot is nice as well lets people see that the script can get you about 1m/hr xp which is not bad. about 800 pots hour i think it is

  23. #23
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Quote Originally Posted by nero_dante View Post
    lasted an hour then randomly stopped doing anything even though the script is still running lol

    https://gyazo.com/9b1041caddf900214bbd249aa804393e


    EDIT: I left it for a few minutes and then it just started working again haha xD
    lol idk maybe it just took a long break there is a couple times will it wait for a little bit and thanks for the testing =D

  24. #24
    Join Date
    Aug 2014
    Posts
    172
    Mentioned
    2 Post(s)
    Quoted
    77 Post(s)

    Default

    Quote Originally Posted by goodgamescript View Post
    lol idk maybe it just took a long break there is a couple times will it wait for a little bit and thanks for the testing =D
    np, I'm going bed now and I'll just leave it on because fuck it xD lool. Hopefully it will do the other 3k torstols and get me 99 herblore over night :P

  25. #25
    Join Date
    Mar 2014
    Posts
    195
    Mentioned
    4 Post(s)
    Quoted
    92 Post(s)

    Default

    Hopefully it works out lol

Page 1 of 2 12 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •