It is the Item ID for burnt fish (salmon, trout as well as a few others).Code:Self.Fish := ['Raw trout', 'Raw salmon', 'Trout', 'Salmon', 343];
For now I'd really suggest avoiding lumbridge with this script, it just handles ducks poorly. Barbarian village on the other hand for salmon/trout is basically perfect (for powerfishing anyways, I don't bank ever). There probably needs to be a specific backup check for like last xp drop or item in inventory to determine whether you're still fishing in lumbridge so it doesn't change fishing spots when it doesn't need to.
https://www.osrsbox.com/tools/item-search/ is the tool to match ID to name/picture
Edit:
Most of these might be relevant up to fly fishing/cooking ['Raw Trout', 'Raw Salmon', 'Trout', 'Salmon', 'Raw Shrimps', 'Raw anchovies', 'Shrimps', 'Anchovies', 'Burnt Shrimp', 323, 343, 357, 367, 369, 20854, 23873]
Version 1.25 released
- Draynor walking reworked
- Failsafe to shutdown the script if too many failures while walking / spot-switching
- Added cooking support for Barbarian Village (credit to ineedbot)
- Minnow fishing functioning once again
- Improved efficiency for minnow fishing
This took far longer than it should have but I had such terrible luck acquiring the angler outfit just so I could return to the platform and patch minnow-fishing mode.
Last edited by Flight; 09-27-2021 at 10:43 AM.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
Right right. I'll get around to scouting this area this weekend I hope. I suppose I haven't heard of many bans at the Otto's Grotto. I've never had a ban there myself, but I understand the concern and the desire to fish in a more secluded area.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
Hi Flight - i finally got all the reqs for minnows. Outfit is a pain lol. Might have noticed a bug. Currently it re-clicks the minnows spot twice every time. What happens is it finds the spot, clicks it, puts the square outline box around it, that box goes away a few seconds later, after which it clicks the spot again. Does this at every spot.
Do i perhaps have my set up wrong or its supposed to click everything twice? I tested it with the minnows themselves in slot 2 and with nothing in slot 2 in the back pack. Dont want to run it for a long period of time yet as the multi clicking is very bot like. thanks and let me know how i can help!
Over 10m exp so far with this script, will update when 99.
Glad you got this sorted out and it's running smooth for you now. I myself alternate between minnows and heavy rod-fishing each day.
Wonderful! It's been some time since someone else has gotten 99 with one of my scripts (or at least that cared to share it). However I'm very pleased to know the script has helped you hit that goal. I've also passed 99 on my ironman while developing this script, before walking failures in the Mining Guild got me. Now a throw away account just hit 90. Slower progress there as I'm also attempting tackle a Slayer script with that account.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
I am noticing that about 25% of the runs i do, it kills itself with the spot switching failure error. What zoom do you usually leave it at? i went super zoomed to disallow it from clicking the other pool but perhaps that is causing this issue if you are not experiencing it.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
I've been tweaking the main fishing procedure in regards to minnow-fishing and even though I've not experienced the issue you're having, I may have solved your problem. Try replacing your entire procedure TScript.StartFishing(); with this one and see if it helps:
As a result I personally saw a gain in speed from 36k XP/hour to 42k XP/hour while fishing minnows.Simba Code:procedure TScript.StartFishing();
var
i,h,ms,XP,C: Int32;
myPos: TPoint;
T: TCountdown;
Spots: TPointArray;
begin
if (not RSClient.IsLoggedIn) then Exit;
Self.ClearMS();
if (Self.RSW.GetMyPos().DistanceTo(Self.BankTile) <= 25) then
if (not Self.HandleWalking('Fishing spots')) then
begin
Self.WriteMsg('Failed to walk to the fishing spots');
Exit;
end
if (not Self.HasTools) then
begin
Self.WriteMsg('Fishing equipment not found!');
Exit;
end;
if Self.UseSpec then
if Random() < 0.90 then
Self.EnableBoost();
if Self.FishingFor = 'Minnow' then
begin
T.Init(1300);
while T.TimeRemaining > 0 do
begin
Spots := Self.GetSpotsIn(Mainscreen.Bounds);
if Spots.Len > 1 then break;
end;
if Spots.Len < 2 then Exit;
end else
begin
Spots := Self.GetSpotsIn(Mainscreen.Bounds, 500);
if (Spots.Len < 1) then
begin
if (Self.Location = 'Piscatoris') then
Self.WalkSearch := True;
if (not Self.HandleWalking('Fishing spots')) then
Self.WriteMsg('Failed to walk to the fishing spots');
Spots := Self.GetSpotsIn(Mainscreen.Bounds, 500);
if (Spots.Len < 1) then
begin
Self.ChangeSpots();
Exit;
end;
end;
end;
Spots.Sort([Mainscreen.GetPlayerBox.Middle.X, Mainscreen.GetPlayerBox.Y2]);
if Self.ChangeSpot then
begin
Self.ChangeSpot := False;
h := 1;
end;
ms := Mouse.Speed;
if (Self.Location = 'Piscatoris') then
Mouse.Speed := Random(23, 27);
myPos := Self.RSW.GetMyPos();
for i:=h to high(Spots) do
begin
if (Self.Location = 'Guild') then
if (not RSW.MSInMMArea(myPos, Spots[i], [2188,2733], [2234,2776])) then Continue;
Mouse.HumanMove(Spots[i]);
if MainScreen.IsUpText(Self.SpotUpText) then
break;
end;
if (Self.Location = 'Piscatoris') then
Mouse.Speed := ms;
if (not MainScreen.IsUpText(Self.SpotUpText)) then
if (Self.Location = 'Guild') then
begin
Antiban.RandomRotate;
Exit;
end else
begin
Self.ChangeSpots();
Exit;
end;
if (Self.Mode = Harpoon) then
begin
ChooseOption.Open();
if not ChooseOption.Select(['Harpoon']) then
begin
ChooseOption.Close();
Exit;
end;
end else
begin
Mouse.Click(MOUSE_LEFT);
if (not MainScreen.DidRedClick) then Exit;
end;
Self.WalkAttempts := 0;
Self.WalkSearch := False;
if WaitUntil(Minimap.IsPlayerMoving(300), 75, 2300) then
Minimap.WaitPlayerMoving(300, 3000);
XP := XPBar.Read();
Self.CompassAng := Minimap.GetCompassAngle();
myPos := Self.RSW.GetMyPos();
Self.PrevTile := myPos;
C := Inventory.Count();
if Self.FishingFor <> 'Minnow' then
begin
T.Init(SRL.NormalRange(2900, 3300));
repeat
if Self.PopulatedAdjacentTile() then Break;
case SRL.Dice(50) of
True: Minimap.SetCompassAngle(Minimap.GetCompassAngle() - SRL.TruncatedGauss(5, 35, 3));
False: Minimap.SetCompassAngle(Minimap.GetCompassAngle() + SRL.TruncatedGauss(5, 35, 3));
end;
wait(250);
until(T.IsFinished);
end;
if DEBUGMODE then
Self.DisplayMSTile(Self.SpotTile);
T.Init(Self.Timeout);
while (not T.IsFinished) do
begin
if (not RSClient.IsLoggedIn) then Exit;
if Inventory.IsFull() then Exit;
if Chat.ClickContinue(False) then
T.Restart;
if (Chat.GetChat.Pos('suitable bait') > 0) or
Chat.FindMessage('suitable bait') then
begin
Self.WriteMsg('Out of feathers!');
Terminatescript;
end;
if XPBar.Read() > XP then
begin
T.Restart;
XP := XPBar.Read();
end;
if Inventory.Count() > C then
begin
T.Restart;
C := Inventory.Count();
end;
if DEBUGMODE then
Self.DisplayMSTile(Self.SpotTile);
if (Self.Mode = Lure) then
begin
if (not Self.PopulatedAdjacentTile(600)) then
break;
if Self.FindFishingPole(Self.SpotTile.Expand(2)) then
T.Restart;
end else
begin
if Self.PopulatedAdjacentTile() then
begin
if (Self.FishingFor = 'Minnow') then
if XPBar.Read() > XP then
begin
T.Restart;
XP := XPBar.Read();
end;
if (Self.FishingFor <> 'Minnow') then
if SRL.PercentShift(MainScreen.GetPlayerBox(), 300) >= SHIFTTHRESHOLD then
T.Restart;
end;
end;
if (Self.FishingFor = 'Minnow') then
if Self.FindFlyingFish() then
begin
Self.WriteMsg('Flying fish found!');
Self.ChangeSpot := True;
Exit;
end;
if Self.DoAB() then
T.Restart;
wait(75);
end;
Self.ClearMS();
end;
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
Hi Flight,
Thanks for an incredible script, just thought I would share some feedback on my experience with it so far. I've used it from 60-84 fishing so far with basically no issues, just a few minor quirks that I guess could be seen as bot-like. When fishing Minnows, sometimes when both fishing spots are in the middle of the rectangle instead of clicking the spot as it moves east it will click the one diagonal to where it was fishing. This causes the character to be constantly running back and forth which would be very unlikely for a normal player. Also depending on how zoomed in/what the camera angle is at, it will switch between the east and the west minnow spots which is also very bot-like.
I ran the bot initially from 60-82 at the Grotto in basically one session with breaks and did not receive a ban, and waited a few days before I got the fishing outfit so I think the anti-bans you have on it are pretty top notch!
Cheers
Thought this might be worth a post too!
b3ed419ec4.png
Hi,
Trying out this script for fun and some feedback so far:
1. Walking to bank in Draynor seems strange. Keeps clicking only a few squares away from the character to walk, which isn't really optimal imo. A legit player would never walk like this. Just one click on the minimap to bank would suffice.
2. About an hour into fishing shrimps at Draynor the script shut itself down. Something to do with walking failure (sadly don't have the exact wording anymore). Inventory was full and I was just behind the willow tree closest to the water.
3. In Barb village fishing trouts the script keeps clicking on the spot every ~5 seconds. When the cyan colored square appears then the script clicks again.
4. In Barb village when a fishing spot moves to another location the script will follow the spot. However there is a current spot right next to the character and the script runs to the farthest one.
5. I wasn't able to get this to run on Runelite. Probably my own wrong settings. I know default client is recommended, but has anyone got this script to work with Runelite?
Will continue fishing for a bit.
// Okay the script seems to work without problems at Barb village now when I restarted it again. However the script doesn't drop Beginner clues when powerfishing is selected.
//Ran for some more time now.
+---| STATS |----------------------------------------
|- Script Runtime : 02h 58m 27s
|- XP gained : 82580(27765 / hr)
|- Fishing for : Trout
|- Fish caught : 1454(489 / hr)
|- Until shutdown : 01h 15m 47s
+----------------------------------------------------
[Bot]: Changing spots
[Bot]: Too many failed spot-switching attempts, shutting down
Terminating: Spot-switching failure
[Bot]: Thanks for using Flight's AIO Fisher!
Succesfully executed in [03:04:56].
Got lost while moving from one spot to another. Probably should've rotated the screen or just click on the minimap to find the fishing spot.
Last edited by inkw10; 11-10-2021 at 08:43 PM.
Thank you for the feedback. This has been improved upon with version 1.3, hopefully erased for for good. The minnow spots are a bit tricky when they're very near with each other, depending on the game camera angle.
That's an amazing progress report, well done! Even given the anti-ban included in the script, I'm still surprised you're able to get away with running it for over 2 days straight. I'd tread lightly if I were you.
Excellent feedback and issue reporting. The walking issues you have in Draynor is simply using screen-walking as opposed to minimap-walking. You can adjust this at line 23 I believe:
The other problems you had are addressed regarding spot-switching have been fixed in the upcoming version 1.3. Running this in Runelite is possible but you'll want to disable any overlays for fishing spots as well as mouse-over text. Be warned, running this script on anything other than the OEM client will take control of your mouse and keyboard.Simba Code:MSWalking = True;
I'm doing a bit more testing to make sure my recent changes to the script function correctly across all fishing styles and locations. I'll merge snippets from the script into the SRL-OSR include and update that on my GitHub page, so going forward with this script (and others soon to be released) I'll require using my version of SRL-OSR. It's not yet released but when it is I'll be sure to include instructions on how to download the include.
Last edited by Flight; 11-12-2021 at 02:35 PM.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
Figured worth a post. Got 99 successfully with this script running it twice a day for 6 hour segments (including break time), all basically at minnows. Script is pretty flawless man, great job!!
On another note, I mashed together your crab and fishing script to create a AIO monster fighter that just requires the user to find the ACA colors and input. Looks like you are going to release a super awesome Slayer script so not much use for it but lemme know if you want the mashed up code. If i could add a drop pick up feature, you could use it at any monster and pick up specific drops. Sort of chill. Anyway, thanks again bro.
Wonderful to hear of your success, and congratulations on your cape! As for a Slaying script; it's quite a complex endeavor and given that I've neglected that project lately I must say there won't be any releases any time in the near future. However I may come into some free time in December in which I'll try to dedicate to this project.
Version 1.3 released.
- Fishing spots sorted now according to player's tile rather than middle of the screen
- Efficiency improvement for minnow fishing
- Reworked cooking
- New location: Entrana (shrimp/anchovies & trout/salmon) (powerfish)
- Added cooking for Entrana
- New location: Mount Quidamortem (leaping fish) (powerfish)
- Improved boat boarding/disembarking for Karamja
- Spot-changing improvement
- Fly-fishing detection improvement
Beginning with version 1.3, all versions of the script will require my custom SRL-OSR (SRL-F) to run. I've also updated my guide on setting up Simba & SRL-OSR to include instructions on installing SRL-F. If you've any problems installing SRL-F or issues with the script feel free to tag me here or via a private message.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
There are currently 2 users browsing this thread. (0 members and 2 guests)