Page 1 of 4 123 ... LastLast
Results 1 to 25 of 86

Thread: iCleaner [Herblore] [Grimy herb cleaner]

  1. #1
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Post iCleaner [Herblore] [Grimy herb cleaner]

    Hey, this is my first script, feel free to give me your opinions or if you do script your self please review how I'm doing so far xD.

    No need to input what herb you want to clean, just select your banking settings and it will do the herb in the slot you choose, just make sure that other herbs are not visible, otherwise it will not detect being out of herbs and stop.

    Has a basic anti-ban and also 15 different cleaning paths, i will add more when i get time, and cleans roughly 3800 herbs per hour

    Instructions inside script.

    Enjoy!

    ---

    Got me 50 - 70 herblore to far , going to do a complete re-write of this script soon.


    ~~~~~~~~~iCleaner~~~~~~~~~~~~~~
    Time running: 12:02:17
    Herbs cleaned: 45808
    Loads cleaned: 1636
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Last edited by iCURiP; 01-02-2012 at 06:56 PM.

  2. #2
    Join Date
    Jan 2010
    Posts
    1,414
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    This procedure is blank, why?
    Simba Code:
    Procedure setDTM;
    begin




    end;

    You don't need this if you are using SMART.
    Simba Code:
    ActivateClient;

    You shouldn't use global variables. You should use local variables as much as you can.
    Simba Code:
    var
    HERB, X, Y, BankTabOfHerb, BankSlotX, BankSlotY, ISlot, HERBS_CLEANED:Integer;
    DTMString:String;
    UseAntiban:Boolean;
    Pattern, Clock:TIntegerArray;

    You need to work on your standards.

    Other than that, this is a great first script. I'm very excited to see what you create in the future and what you make of this script!

  3. #3
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by RISK View Post
    This procedure is blank, why?
    Simba Code:
    Procedure setDTM;
    begin




    end;

    You don't need this if you are using SMART.
    Simba Code:
    ActivateClient;

    You shouldn't use global variables. You should use local variables as much as you can.
    Simba Code:
    var
    HERB, X, Y, BankTabOfHerb, BankSlotX, BankSlotY, ISlot, HERBS_CLEANED:Integer;
    DTMString:String;
    UseAntiban:Boolean;
    Pattern, Clock:TIntegerArray;

    You need to work on your standards.

    Other than that, this is a great first script. I'm very excited to see what you create in the future and what you make of this script!
    Oh yeah, i forgot to delete that method, i was going to try making a GUI and that was going to be the method to set the DTM, didn't make it in the end or need it in and forgot to remove it.

    Thanks for pointing those things out too. helps me learn.

    Also could you explain to me what the benefits are of using local variables ?
    Last edited by iCURiP; 12-29-2011 at 02:38 AM.

  4. #4
    Join Date
    Dec 2011
    Posts
    124
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Code:
    ~~~~~~~~~iCleaner~~~~~~~~~~~~~~
     Time running: 1:7:26
    Herbs cleaned: 4988
    Loads cleaned: 178
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Nice job man. Worked flawlessly. Although, once it's done, it will start withdrawing whatever was in the set bank slot. Just a suggestion, but adding in a check for the uptext wouldn't hurt.

  5. #5
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by TsterT View Post
    Code:
    ~~~~~~~~~iCleaner~~~~~~~~~~~~~~
     Time running: 1:7:26
    Herbs cleaned: 4988
    Loads cleaned: 178
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Nice job man. Worked flawlessly. Although, once it's done, it will start withdrawing whatever was in the set bank slot. Just a suggestion, but adding in a check for the uptext wouldn't hurt.
    Thanks for the feedback

    That usually happens when another herb is visible in bank, will sort this out soon

  6. #6
    Join Date
    Dec 2011
    Posts
    209
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    Looks like a very nice script, do you make any cash off it? Or do you lose some?

  7. #7
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Gushers View Post
    Looks like a very nice script, do you make any cash off it? Or do you lose some?
    http://runescape.wikia.com/wiki/Calc...Herblore/Herbs
    Check profits/losses here , although i suggest trialling them before you do them, buy, clean, sell, grand exchange fluctuates a lot.

  8. #8
    Join Date
    Dec 2011
    Location
    Belgium
    Posts
    623
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    does this script support soul wars bank?
    Gratz on first script btw

    Made by P1ng

  9. #9
    Join Date
    Nov 2011
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    lovely script mate its clean 20k cads for me today

  10. #10
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by lordvolt View Post
    does this script support soul wars bank?
    Gratz on first script btw
    Only supports NPC banks at the moment, will add an option soon, im working on a safe cracker at the moment though

  11. #11
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by walsh145 View Post
    lovely script mate its clean 20k cads for me today
    Nice one, proggie would have been sexy xD

  12. #12
    Join Date
    Nov 2011
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    stopped the script so no proggy just making them into unfin cad pots gonna takes ages lol then do another 20k after sold pots

  13. #13
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by walsh145 View Post
    stopped the script so no proggy just making them into unfin cad pots gonna takes ages lol then do another 20k after sold pots
    Nice, that must be some nice profits rite there, I might make an option to make unfinished potions after cleaning all of the herbs. I also want to make a GUI.

  14. #14
    Join Date
    Dec 2011
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Gonna load out 400k - 500k herbs of some sort now, I'll post what happens in a few days.

    If all goes well, I'll retest with a million. See how it turns out. Endurance testing is the best

    Oh, forgot to mention, I'm spreading the herbs over 5 member accounts, standing in 5 different worlds from 5 different computers, 5 different banks and 5 different herb types, just incase they try to ban them

    Bank Pin could be added too:

    Simba Code:
    Players[0].Pin :='';//Bank pin

    Underneath the active player.
    Last edited by karter50; 12-30-2011 at 05:37 AM.
    99 Fletching 99 Cooking 99 Woodcutting 99 Magic 99 Firemaking 99 Crafting 99 Fishing 1770 Total Level and 104m XP

    Working on: 99 Herblore (Purely through cleaning!) and a 50b cash pile (currently 22b) would be nice!

  15. #15
    Join Date
    Nov 2011
    Location
    ireland
    Posts
    71
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    going to try out this script, would i get banned useing it ?

  16. #16
    Join Date
    Dec 2011
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Has a basic anti-ban
    99 Fletching 99 Cooking 99 Woodcutting 99 Magic 99 Firemaking 99 Crafting 99 Fishing 1770 Total Level and 104m XP

    Working on: 99 Herblore (Purely through cleaning!) and a 50b cash pile (currently 22b) would be nice!

  17. #17
    Join Date
    Dec 2006
    Location
    Georgia
    Posts
    84
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Good stuff man, I'm tryna hoan on m pascal language as we speak lol.

    (:

  18. #18
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Good luck karter , post a couple proggies.

    --

    fagex, it has an anti-ban, but its not all down to the anti-ban, its how you use it, your more likely to get banned if you get reported multiple times, that's like 80% of jagex's banning system :P, so i suggest its a fairly populated place (So theres less change of people talking to you out of a larger amount of people) or a quickchat world.

  19. #19
    Join Date
    Dec 2011
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ~~~~~~~~~iCleaner~~~~~~~~~~~~~~
    Time running: 0:57:48
    Herbs cleaned: 4284
    Loads cleaned: 153
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    Around 4350 Herbs an hour man, good so far. I started this bot first, the other 4 took a while because of my incompetence to store my account details so I'll post them when I wake up.

    Looks good though, they're avantoe's I'm cleaning. Thats a profit of:

    4350 / hour = 565K / HOUR!!!!

    Seriously, bot nuke on reflection and injection was amazing for things like herbs. 130 profit per avantoe, I'm level 65 herb on my secondary account now.

    I don't merchant, cannot wait until other prices deflate too!
    99 Fletching 99 Cooking 99 Woodcutting 99 Magic 99 Firemaking 99 Crafting 99 Fishing 1770 Total Level and 104m XP

    Working on: 99 Herblore (Purely through cleaning!) and a 50b cash pile (currently 22b) would be nice!

  20. #20
    Join Date
    Dec 2011
    Location
    Belgium
    Posts
    623
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Quote Originally Posted by iCURiP View Post
    Only supports NPC banks at the moment, will add an option soon, im working on a safe cracker at the moment though
    k, would be very nice to see sw .

    Made by P1ng

  21. #21
    Join Date
    Dec 2011
    Posts
    128
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by lordvolt View Post
    k, would be very nice to see sw .
    Got chest banking done, although iv already updated the script to SRL-5 so it will be released when that is released.
    Also now has a paint.

  22. #22
    Join Date
    Dec 2011
    Posts
    484
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I was reading through your code, and I realized something: I was reading through your code! This is the first script I looked through and understood without having to analyze everything 10 times! I am stoked.

    Btw, I am using this script as we speak. 67-70 herblore through cleaning grimy cadantines. I will post a proggy for you, as well as any bugs I see.

  23. #23
    Join Date
    Nov 2011
    Location
    Sacramento, California
    Posts
    366
    Mentioned
    4 Post(s)
    Quoted
    85 Post(s)

    Default

    works great!

    thanks (:

    Time running: 0:39:1
    Herbs cleaned: 2729
    Loads cleaned: 97

  24. #24
    Join Date
    Dec 2011
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    You planning adding unfinished potions? I've modified mine to do them but it isn't anti-ban (just goes 1 and 15, 2 and 16, 3 and 17, etc)

    oh, and here's a 12 hour update

    ~~~~~~~~~iCleaner~~~~~~~~~~~~~~
    Time running: 12:02:17
    Herbs cleaned: 45808
    Loads cleaned: 1636
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    Profit of 5,955,040 or about 6 million gp.

    Thanks bro.
    Last edited by karter50; 12-30-2011 at 06:03 PM.
    99 Fletching 99 Cooking 99 Woodcutting 99 Magic 99 Firemaking 99 Crafting 99 Fishing 1770 Total Level and 104m XP

    Working on: 99 Herblore (Purely through cleaning!) and a 50b cash pile (currently 22b) would be nice!

  25. #25
    Join Date
    Dec 2011
    Posts
    484
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Found a bug: occasionally, the camera rotates as an antiban and the cursor cannot find the banker again, resulting in random antibans and cursor movements all over.

    Edit: I am running this at the G E. So the roof of the little exchange area is blocking the banker. I am not sure if this would affect actual banks.
    Last edited by Grihmm; 12-30-2011 at 06:15 PM. Reason: Being more complete.

Page 1 of 4 123 ... LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •