Results 1 to 25 of 25

Thread: JJ's Thieving Guild Chest Thiever

  1. #1
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default JJ's Thieving Guild Chest Thiever

    Video on setting it up and showing how it works, etc.
    http://www.youtube.com/watch?v=VZsZExKnCjE

    Hello,

    Thanks for taking your time to check out my script. This is the first script I've written myself and I'm proud to have it finished. As far as I know it works flawless, except for handling random. I will add more features in the future. You currently have to log-in manually.

    This script should be getting around 50.000 thieving experience per hour.

    How to set it up and what are the requirements?
    • GAME MODE: ALL (not on filter or anything else)
    • 35 thieving
    • Buyers and Cellars quest
    • Lockpick


    This script is opening the gates/doors and looting the chests are spot number 4 on this map:


    Once you have positioned your character there you can choose to run this script with SMART, which works but is a bit harder to set up.. or you can choose to let Simba control your mouse and choose your desired RuneScape screen with the "Select a client"-tool built in to Simba.

    Your brightness should be turned all the way up, and your graphics should be on the lowest possible.

    The script:
    Simba Code:
    program ThievingGuildChests;
    {$DEFINE SMART}
    {$i srl/srl.simba}

    Function OpenChest:Boolean;
    Var
      X, Y, t: Integer;

    begin
    MarkTime(t);
      repeat

        X:=MSCX;
        Y:=MSCY;
        if FindObjTPA(X, Y, 7376552, 15, 1, 4, 9, 20, ['ract']) then
          begin;
            Writeln('We found the chest');
            GetMousePos(X, Y);

              Case Random(4) of
              0..2: begin;
                      Mouse(X, Y, 5, 5, True);
                      Writeln('We clicked the chest');
                    end;

              3:    begin;
                      Mouse(X, Y, 5, 5, False);
                      WaitOption('Open', 300);
                      Writeln('We clicked the chest');
                    end;
              end;

            Wait(1500+random(1000));
            Writeln('We are waiting to complete the thieving');
          end;

        begin;
          repeat
          Wait(200+random(200));
          until FindChatBoxText('fail', 8, clBlack) or FindChatBoxText('open', 8, clBlack) or FindChatBoxText('reach', 8, clBlack) or (TimeFromMark(t) >= 10000);
        end;

        begin;
          if FindChatBoxText('fail', 8, clBlack) then
          Wait(300+random(200));
        end;

        begin;
          if FindChatBoxText('open', 8, clBlack) then
          Wait(2000+random(500));
        end;

        begin
          if FindChatBoxText('reach', 8, clBlack) then
          WriteLn('Time to open the doors');
          Wait(300+random(200));
        end;

      until FindChatBoxText('reach', 8, clBlack) or (TimeFromMark(t) >= 15000);
    end;


    function OpenGate:Boolean;
    var
      X, Y, a, t, z: Integer;

    begin
    z:=0
    t:=0
    a:=0
    MarkTime(t);

      repeat
        X:=MSCX;
        Y:=MSCY;
        z:=0
         if FindObjTPA(X, Y, 1252637, 5, 1, 3, 3, 6, ['pen']) then
            begin;
              Writeln('We found the chest');
              GetMousePos(X, Y);

              Case Random(4) of
              0..2: begin;
                      Mouse(X, Y, 2, 2, True);
                      Writeln('We clicked the gate');
                    end;

              3:    begin;
                      Mouse(X, Y, 2, 2, False);
                      WaitOption('Open', 300);
                      Writeln('We clicked the gate');
                    end;
              end;

              Writeln('We are waiting to open the gate');
              Wait(2000+random(1000));
            end;

            begin;
              repeat
                Wait(200+random(200));
              until FindChatBoxText('swings', 8, clBlack) or FindChatBoxText('bornly', 8, clBlack) or (TimeFromMark(t) >= 10000);
            end;

            begin;
              if FindChatBoxText('bornly', 8, clBlack) then
              WriteLn('We failed to open the gate');
              Wait(200+random(200));
            end;

            begin;
              if FindChatBoxText('swings', 8, clBlack) then
              a:=a+1
            end;

            begin;
              if (TimeFromMark(z) >= 10000) then
              WriteLn('Time exceeded');
            end;

       until FindChatBoxText('swings', 8, clBlack) or (TimeFromMark(t) >= 20000);
    end;


    begin
      SetUpSRL;
      ActivateClient;
        repeat
          repeat OpenChest;
          until(FindChatBoxText('reach', 8, clBlack));
            OpenGate;
        until(False);
    end.

    Be sure to leave some feedback to help me to improve the script!
    Auto log-in, antiban and other features will be added in the future.

    Greetz,

    JJ.
    Last edited by J J; 03-02-2012 at 10:42 PM. Reason: Made everything more clear.

    Script source code available here: Github

  2. #2
    Join Date
    Feb 2012
    Posts
    93
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    One thing I'd fix is getting stuck inside the gate. Not a big deal just gotta turn camera a bit to the left.

  3. #3
    Join Date
    Jan 2012
    Posts
    1
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    it works fine for me i just wish it did the chests on south wall more than the ones on the north wall

  4. #4
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by InH View Post
    One thing I'd fix is getting stuck inside the gate. Not a big deal just gotta turn camera a bit to the left.
    Does it actually get stuck or does it have a hard time to get outside of the gate? And which gate are we talking about? I'll test it today and see if I can fix it. I will also be adding anti-ban and anti-randoms today or tomorrow! Weekend!


    Quote Originally Posted by k1ng91 View Post
    it works fine for me i just wish it did the chests on south wall more than the ones on the north wall
    Good to hear. I think I'll modify it in the future to hop worlds, open all gates and open the three south chests for maximum xp/h. My first focus is releasing version 1.1 which will have anti-ban/anti-randoms and probably some other add ons!

    Script source code available here: Github

  5. #5
    Join Date
    Nov 2011
    Posts
    194
    Mentioned
    0 Post(s)
    Quoted
    11 Post(s)

    Default

    how mch exp an hour is it supposed to get? all it does for me is unlock the north and south chest over and over which only gives like 30 exp

  6. #6
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by phamxboa View Post
    how mch exp an hour is it supposed to get? all it does for me is unlock the north and south chest over and over which only gives like 30 exp
    It should be opening the gates which gave 210 xp/ea. The south chests which gave 180 xp/ea and the northern chests which gave 30 xp/ea. I will be rewriting the script in a couple variants to only open the gates and hop worlds and only open south chests/gates.

    Right now it should be opening a combination of all.

    Script source code available here: Github

  7. #7
    Join Date
    Nov 2011
    Posts
    194
    Mentioned
    0 Post(s)
    Quoted
    11 Post(s)

    Default

    Have you calculated how much exp/hour it gets?

  8. #8
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by phamxboa View Post
    Have you calculated how much exp/hour it gets?
    Yeah it was getting me around 50k xp/h, but it was mainly thieving the south chests. I will be rewriting this script so that it will only be thieving the south chests and the gates for optimal xp. In the future I will probably rewrite it again to let it hop world to open the gates.

    Script source code available here: Github

  9. #9
    Join Date
    Dec 2011
    Posts
    27
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    can you add a self login future???? so i dont have to babysit

  10. #10
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by Kabouterplop View Post
    can you add a self login future???? so i dont have to babysit
    Once I have a members account again I will add some new features. Currently working on perfecting my other script and working on a script for SRL Member appliance.

    Script source code available here: Github

  11. #11
    Join Date
    Aug 2009
    Location
    Albuquerque, New Mexico
    Posts
    48
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Testing it now, will post proggie in a hour. Also props for the vid.

    Edit:Pretty good. Only thing i saw was just speed. Also maybe a if their was a option to choose which side chests you wanna pick lock? like north or south. then have the script focus on just those three. Also if its possible to have a counter for when you open a door, ill know when it closes so ill be ready to click on it to open it again.

    GREAT WORK MAN!! KEEP IT UP!!!
    Last edited by Darkcorn; 03-15-2012 at 09:09 PM. Reason: proggie
    Ku Ku Ca Chu!

  12. #12
    Join Date
    Mar 2012
    Posts
    2
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Works like a dream, nice work.

  13. #13
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by Darkcorn View Post
    Testing it now, will post proggie in a hour. Also props for the vid.

    Edit:Pretty good. Only thing i saw was just speed. Also maybe a if their was a option to choose which side chests you wanna pick lock? like north or south. then have the script focus on just those three. Also if its possible to have a counter for when you open a door, ill know when it closes so ill be ready to click on it to open it again.

    GREAT WORK MAN!! KEEP IT UP!!!
    Thanks If I have a p2p account again that can access the Thieving Guild I will work on some new options like thieving all chests or just the south ones. I could try to make a counter, but I think the closing of the doors also depends on the population of the world, thus, it wouldn't be 100% accurate to know when they will close.

    However, with my new knowledge I can probably detect if it's open or closed much easier. Using Auto Color Aid and TPA's.

    Quote Originally Posted by hellot View Post
    Works like a dream, nice work.
    Thanks!

    Script source code available here: Github

  14. #14
    Join Date
    Jan 2012
    Posts
    468
    Mentioned
    3 Post(s)
    Quoted
    200 Post(s)

    Default

    Love the Script!

  15. #15
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by Rules of Joe View Post
    Love the Script!
    Thanks

    Script source code available here: Github

  16. #16
    Join Date
    Feb 2012
    Location
    The Netherlands
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Works flawless!
    Last edited by RubenPriest; 04-02-2012 at 08:58 AM.

  17. #17
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by RubenPriest View Post
    Works flawless!
    Good to know that it still works Some day I might make an advanced version using new techniques I learned.

    Script source code available here: Github

  18. #18
    Join Date
    Jan 2012
    Posts
    246
    Mentioned
    3 Post(s)
    Quoted
    91 Post(s)

    Default

    always tries to open the chests even before the gates have been opened.

  19. #19
    Join Date
    Jul 2011
    Location
    /home/litoris
    Posts
    2,226
    Mentioned
    0 Post(s)
    Quoted
    159 Post(s)

    Default

    Please don't add world hop publicly, it will kill the method with tons of people hopping. I've had problems when there was one other person that hopped around for xp when doing this legit.
    Miner & Urn Crafter & 07 Chicken Killer
    SPS BlindWalk Tutorial

    Working on: Nothing

    teacher in every art, brought the fire that hath proved to mortals a means to mighty ends

  20. #20
    Join Date
    Jan 2012
    Posts
    77
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    how do you get the script off the page without a file to click on? Ive tried copying and pasting to an empty simba but it allends up in one line

  21. #21
    Join Date
    Jun 2012
    Posts
    45
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Running this script as we speak, set up was easy. Not sure what other user is talking about with the copy/paste. Just delete lines on new simba and paste should format itself. Will edit to include proggy after one hour.

  22. #22
    Join Date
    Jun 2012
    Location
    Portugal
    Posts
    125
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    when opens a chest it clicks to open another chest but the door to that chest is closed. the script do this every time.
    Making Money Guide 15-20m hour (no requirements):

    http://www.youtube.com/watch?v=oHg5SJYRHA0


  23. #23
    Join Date
    Jun 2012
    Location
    Portugal
    Posts
    125
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Theron View Post
    always tries to open the chests even before the gates have been opened.
    Same here
    Making Money Guide 15-20m hour (no requirements):

    http://www.youtube.com/watch?v=oHg5SJYRHA0


  24. #24
    Join Date
    Sep 2012
    Location
    Legolan, Ireland
    Posts
    542
    Mentioned
    0 Post(s)
    Quoted
    50 Post(s)

    Default

    JJ you should revamp this script.
    Have you felt the whale lately?
    .__________.
    Whale so hard.

  25. #25
    Join Date
    Feb 2006
    Location
    Tracy/Davis, California
    Posts
    12,631
    Mentioned
    135 Post(s)
    Quoted
    418 Post(s)

    Default

    Moved to outdated.
    If it becomes updated report it so mods can handle it.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •