Results 1 to 14 of 14

Thread: FindNormalRandoms broken

  1. #1
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default FindNormalRandoms broken



    Just FYI.

    Simba Code:
    const
      DD_NPC_DEMON = 'SergeantDamien';


    function DD_Detect(): boolean;
    begin
      result := (getNPCChatName() = DD_NPC_DEMON) and (not tabExists(TAB_MAGIC));
    end;

    FindNormalRandoms should be returning true?

    Will look into this now.

    Edit: Solved. Pull request incomming!
    Last edited by Justin; 03-07-2013 at 06:17 AM.

    Forum account issues? Please send me a PM

  2. #2
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    What was the problem?


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  3. #3
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default


    Forum account issues? Please send me a PM

  4. #4
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Justin View Post
    Ah, I'm guessing it was just disabled because randoms have been gone so long?


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  5. #5
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default

    Quote Originally Posted by DannyRS View Post
    Ah, I'm guessing it was just disabled because randoms have been gone so long?
    Yep, simple fix

    Forum account issues? Please send me a PM

  6. #6
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Justin View Post
    Yep, simple fix
    Great

    Don't suppose we're so lucky that any of the SRL5 random solvers still work?, were the any major graphics changes before randoms were removed?


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  7. #7
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default

    Well unlike in 2013 RS, When you logged in and you had a random event, the NPC would talk to you again, making it easy to detect (Using getNPCChatName) but in 07, If you get a random event (EG Drill Demon as seen in the photo) if you re-log you won't get the chat dialogue, meaning getNPCChatName will return '', So we can't exactly rely on getNPCChatName to detect what random.

    Forum account issues? Please send me a PM

  8. #8
    Join Date
    Feb 2006
    Location
    Amsterdam
    Posts
    6,136
    Mentioned
    28 Post(s)
    Quoted
    17 Post(s)

    Default

    Quote Originally Posted by DannyRS View Post
    Don't suppose we're so lucky that any of the SRL5 random solvers still work?, were the any major graphics changes before randoms were removed?
    nope. The SRL-4 ones should still work I guess.
    SRL is a Library of routines made by the SRL community written for the Program Simba.
    We produce Scripts for the game Runescape.

  9. #9
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by WT-Fakawi View Post
    nope. The SRL-4 ones should still work I guess.
    Was having a look through it, problem is there seems to be some scar stuff not in simba anymore? Maybe it just looks so different in scar I had trouble reading it


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  10. #10
    Join Date
    Oct 2011
    Posts
    422
    Mentioned
    15 Post(s)
    Quoted
    116 Post(s)

    Default

    hehe i was the one who sent a patch for it to be disabled.. i guess that carried over to SRL-OSR

  11. #11
    Join Date
    Dec 2011
    Location
    Hyrule
    Posts
    8,662
    Mentioned
    179 Post(s)
    Quoted
    1870 Post(s)

    Default

    nice job justin, maybe do an if not result then.... check something on the minimap or music tab for if it had logged out

  12. #12
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Ashaman88 View Post
    nice job justin, maybe do an if not result then.... check something on the minimap or music tab for if it had logged out
    Alot of random stuff will be upto the scripter to use it properly, but we could check music on every login or something, minimap checking would be a huge hastle, Mordaut's music is: "School's out" for example and it just loops forever,

    Are there any kidnap randoms that don't have their own music track?


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  13. #13
    Join Date
    Dec 2011
    Location
    Hyrule
    Posts
    8,662
    Mentioned
    179 Post(s)
    Quoted
    1870 Post(s)

    Default

    Quote Originally Posted by DannyRS View Post
    Alot of random stuff will be upto the scripter to use it properly, but we could check music on every login or something, minimap checking would be a huge hastle, Mordaut's music is: "School's out" for example and it just loops forever,

    Are there any kidnap randoms that don't have their own music track?
    Not sure about all the music, but if we did something like if not result then if missing tabs then check for music? That way if it finds the text no reason to check the music and it will only check the music if the tabs are missing and it doesn't find the chat text

  14. #14
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Ashaman88 View Post
    Not sure about all the music, but if we did something like if not result then if missing tabs then check for music? That way if it finds the text no reason to check the music and it will only check the music if the tabs are missing and it doesn't find the chat text
    Yea perfect

    Also, I'm not sure how quickly OCR can get the last 8 chat messages, but we could also check them for strings along the lines of, "Welcome to ScapeRune", "to be retuned to where you were", theres various messages that they give when nabbing you (trying to screenshot as many as I can get ), viable to do that you think?

    Thanks too for the SW lady picks btw


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •