Hi Flight,
Been lurking for about 3 weeks now, debating how to contribute and increase my post count.
An occasion finally presented itself, but first I'd like to thank you for this great library. I'm also extremely grateful for the public scripts you released, they were great learning tools and your finite-state machine approach is brilliant.
Now on to my reason for posting, I encountered a bug in the misc/connection/ItemInfo getGEPrice function. Zero was always being returned when I ran it for low value items.
A useful feature I like from Simba is the ability to jump directly to function implementations and I was able to fix the issue.
I forked your repository, made the changes and sent you a pull request. Here's a summary of those changes taken from the commit message:
getGEPrice was always returning 0 for items which didn't have an abbreviation unit in their price
- tweaked JSON parsing to not always expect quoted values
- added default result assignment so one is returned when no abbreviation is found
- separated stringToID call in an overloaded function and refactored getGEPrice to take itemID as input
- added support for billion abbreviation (somewhat useless since only 1 item falls into this case)