Page 5 of 7 FirstFirst ... 34567 LastLast
Results 101 to 125 of 173

Thread: [AIO] vAgility

  1. #101
    Join Date
    Oct 2014
    Posts
    22
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    Working for me at Varrock after I applied the fix mentioned above.
    Proggy for you guys.
    Thanks for a banging script once again
    40b97155ab4743dbb1265c55943ebe3e.png
    EDIT: The marks aren't being calculated right but that's not a major thing, to me at least.

  2. #102
    Join Date
    Mar 2013
    Location
    Argentina
    Posts
    758
    Mentioned
    27 Post(s)
    Quoted
    365 Post(s)

    Default

    for the ones having problems with marks of grace not being picked up replace the lootmark function with this: (it has a few changes)

    Simba Code:
    function lootMark(): Boolean;
    var
      i, id: Integer;
      strArr: TStringArray;
      gItems: TReflectGroundItemArray;
    begin
      if (Course = 'Draynor') then
      begin
        gItems.GetAll(10);
      end
      else if (Course = 'Falador') then
      begin
        gItems.GetAll(4);
      end
      else if (Course = 'Seers') then
      begin
        gItems.GetAll(15);
      end
      else if (Course = 'Varrock') then
      begin
        gItems.GetAll(15);
      end
      if length(gItems) = 0 then
        Exit;
      setArrayLength(strArr, 1);
      strArr := ['mark of grace'];
      for i := 0 to high(gItems) do
        if inStrArrEx(gItems[i].GetName, strArr, id) then
        begin
          Reflect.Compass.MakePitch(3 + Random(3));
          if (findObject(691624, 3, 20, 0.02, 0.36)) then
          begin
            Draw('Found Mark');
            case random(10) of
              0..8:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptextmulti(['Mark of grace', 'ark','grace','Grace'], randomrange(50, 300)) then
                    fastClick(mouse_left);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
              9..10:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptextmulti(['Mark of grace', 'ark','grace','Grace'], randomrange(50, 300)) then
                    fastClick(mouse_Right);
                  chooseoptionmulti(['Take', 'Mark of grace']);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
            end;
            if (didYellowClick()) then
            begin
              sleep(random(150, 300));
            end;
          end
          else
            inc(markCount);
        end
    end;

    I changed the colours and added uptextMULTI.

    other changes i've made to the default:

    - Mousespeed is (35-65). I believe 35 is to slow and 65 is way to fast, i know it tends to go to the middle but i've put it on 45-55.
    - default breaks are way to long.

    EDIT: varrock eats on every lap, health reading is wrong for me atleast. it is: MyPlayer.GetHealth and should be getCurrentHealth(). change it on procedure "walktoWallV" and it'll fix the overeating
    Formerly known as Undorak7

  3. #103
    Join Date
    Oct 2014
    Posts
    22
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    Quote Originally Posted by Lipcot View Post
    for the ones having problems with marks of grace not being picked up replace the lootmark function with this: (it has a few changes)

    Simba Code:
    function lootMark(): Boolean;
    var
      i, id: Integer;
      strArr: TStringArray;
      gItems: TReflectGroundItemArray;
    begin
      if (Course = 'Draynor') then
      begin
        gItems.GetAll(10);
      end
      else if (Course = 'Falador') then
      begin
        gItems.GetAll(4);
      end
      else if (Course = 'Seers') then
      begin
        gItems.GetAll(15);
      end
      else if (Course = 'Varrock') then
      begin
        gItems.GetAll(15);
      end
      if length(gItems) = 0 then
        Exit;
      setArrayLength(strArr, 1);
      strArr := ['mark of grace'];
      for i := 0 to high(gItems) do
        if inStrArrEx(gItems[i].GetName, strArr, id) then
        begin
          Reflect.Compass.MakePitch(3 + Random(3));
          if (findObject(691624, 3, 20, 0.02, 0.36)) then
          begin
            Draw('Found Mark');
            case random(10) of
              0..8:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptextmulti(['Mark of grace', 'ark','grace','Grace'], randomrange(50, 300)) then
                    fastClick(mouse_left);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
              9..10:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptextmulti(['Mark of grace', 'ark','grace','Grace'], randomrange(50, 300)) then
                    fastClick(mouse_Right);
                  chooseoptionmulti(['Take', 'Mark of grace']);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
            end;
            if (didYellowClick()) then
            begin
              sleep(random(150, 300));
            end;
          end
          else
            inc(markCount);
        end
    end;

    I changed the colours and added uptextMULTI.

    other changes i've made to the default:

    - Mousespeed is (35-65). I believe 35 is to slow and 65 is way to fast, i know it tends to go to the middle but i've put it on 45-55.
    - default breaks are way to long.

    EDIT: varrock eats on every lap, health reading is wrong for me atleast. it is: MyPlayer.GetHealth and should be getCurrentHealth(). change it on procedure "walktoWallV" and it'll fix the overeating
    Thank you, I will try it out!

    EDIT: It didn't work, made my Fally course and detect/pick anything up.
    Last edited by teddi; 07-03-2016 at 02:42 AM.

  4. #104
    Join Date
    Jan 2012
    Posts
    468
    Mentioned
    3 Post(s)
    Quoted
    200 Post(s)

    Default

    The Fally course has way to much fail safes looking and right clicking on every jump. thats so bot like.

  5. #105
    Join Date
    Nov 2011
    Posts
    79
    Mentioned
    0 Post(s)
    Quoted
    25 Post(s)

    Default

    Mine just sits at the beginning of the Draynor course unable to find anything.

  6. #106
    Join Date
    Jan 2012
    Location
    Sweden
    Posts
    32
    Mentioned
    0 Post(s)
    Quoted
    20 Post(s)

    Default

    This looks bloody awesome! Can it teleport to Camelot bank if the Kandarin Hard diary is completed? That's how you get max efficiency.

  7. #107
    Join Date
    Apr 2013
    Posts
    680
    Mentioned
    13 Post(s)
    Quoted
    341 Post(s)

    Default

    Quote Originally Posted by Heterodox View Post
    This looks bloody awesome! Can it teleport to Camelot bank if the Kandarin Hard diary is completed? That's how you get max efficiency.
    This can easily be added if it is not and vouche this a solid script

    <------------------>



  8. #108
    Join Date
    Apr 2012
    Posts
    33
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    Fixed, seems to be very botlike @ seers. Yeah couldn't run it, it couldnt find the rope

  9. #109
    Join Date
    Jan 2015
    Posts
    98
    Mentioned
    1 Post(s)
    Quoted
    41 Post(s)

    Default

    Totally awesome dude, I am trying to fix the mark of grace bug but you should totally update the script! It's probably an easy fix for you.

    Unrelated question: Is this forum dead?

  10. #110
    Join Date
    Oct 2012
    Posts
    1,258
    Mentioned
    40 Post(s)
    Quoted
    588 Post(s)

    Default

    Quote Originally Posted by Enigmatic View Post
    Unrelated question: Is this forum dead?
    No. It's not very active either, but it's been like that for a while.

  11. #111
    Join Date
    Mar 2012
    Posts
    96
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    I got solution for the mark of grace bug (it doesnt pick up the marks)
    Just start the script with your skills tab open, not inventory. Its picking up for me that way. Running on Draynor roof for like 1 hour and it picked up all of the marks.

  12. #112
    Join Date
    May 2013
    Posts
    98
    Mentioned
    1 Post(s)
    Quoted
    33 Post(s)

    Default

    to fix marks, replace your lootmarks() function with this:
    Edit:Checking with ID seems to be temperamental as-well, I'll comment it out for the meantime.

    Simba Code:
    function lootMark(): Boolean;
    var
      i, id: Integer;
      gItems: TReflectGroundItemArray;
    begin
      if (Course = 'Draynor') then
      begin
        gItems.GetAll(10);
      end
      else if (Course = 'Falador') then
      begin
        gItems.GetAll(6);
      end
      else if (Course = 'Seers') then
      begin
        gItems.GetAll(15);
      end
      else if (Course = 'Varrock') then
      begin
        gItems.GetAll(15);
      end
      if length(gItems) = 0 then
        Exit;
      for i := 0 to high(gItems) do

    //untested, credit for this fix to hakishakataki.
      if InIntArray([gItems[i].getid], 1) then
        begin
          Reflect.Compass.MakePitch(3 + Random(3));
          if (findObject(1417655, 3, 20, 0.06, 0.16)) then
          begin
            Draw('Found Mark');
            case random(10) of
              0..8:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_left);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
              9..10:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_Right);
                  chooseoptionmulti(['Take', 'Mark of grace']);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
            end;
            if (didYellowClick()) then
            begin
              sleep(random(150, 300));
            end;
          end
          else
            inc(markCount);
        end
    end;

  13. #113
    Join Date
    Mar 2013
    Posts
    167
    Mentioned
    7 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by BigRedJapan View Post
    The Fally course has way to much fail safes looking and right clicking on every jump. thats so bot like.
    Quote Originally Posted by Sigma View Post
    Fixed, seems to be very botlike @ seers. Yeah couldn't run it, it couldnt find the rope
    A few bot-like movements outweighs the risk of the script getting stuck. I am fairly certain the bot-like moments on this script are not detected by Jagex, whereas sitting in one place for 6 hours and being reported 100 times is a certain ban.
    Last edited by Vusn; 09-19-2016 at 07:28 PM.
    "To sleep, perchance to dream"

  14. #114
    Join Date
    Sep 2016
    Posts
    3
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Where is version 1.4?

  15. #115
    Join Date
    Mar 2012
    Posts
    96
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    Quote Originally Posted by charmanderinhd View Post
    Where is version 1.4?
    Download vAgility.simba at the top

  16. #116
    Join Date
    Mar 2012
    Posts
    96
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    For me it gets stuck at Seers A LOT, does not worth running the script at there

  17. #117
    Join Date
    Apr 2014
    Posts
    323
    Mentioned
    0 Post(s)
    Quoted
    131 Post(s)

    Default

    Quote Originally Posted by EZ41 View Post
    to fix marks, replace your lootmarks() function with this:
    Edit:Checking with ID seems to be temperamental as-well, I'll comment it out for the meantime.

    Simba Code:
    function lootMark(): Boolean;
    var
      i, id: Integer;
      gItems: TReflectGroundItemArray;
    begin
      if (Course = 'Draynor') then
      begin
        gItems.GetAll(10);
      end
      else if (Course = 'Falador') then
      begin
        gItems.GetAll(6);
      end
      else if (Course = 'Seers') then
      begin
        gItems.GetAll(15);
      end
      else if (Course = 'Varrock') then
      begin
        gItems.GetAll(15);
      end
      if length(gItems) = 0 then
        Exit;
      for i := 0 to high(gItems) do
      //if InIntArray([gItems[i].getid], 11849) then
        begin
          Reflect.Compass.MakePitch(3 + Random(3));
          if (findObject(1417655, 3, 20, 0.06, 0.16)) then
          begin
            Draw('Found Mark');
            case random(10) of
              0..8:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_left);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
              9..10:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_Right);
                  chooseoptionmulti(['Take', 'Mark of grace']);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
            end;
            if (didYellowClick()) then
            begin
              sleep(random(150, 300));
            end;
          end
          else
            inc(markCount);
        end
    end;
    Using item id's might be a problem because Marks, as they appear on the course, are 'ground items' - which have a different ID than when you have picked it up.
    Their ground item ID is '1.'
    If all pork-chops were perfect, we wouldn't have hot-dogs.

  18. #118
    Join Date
    Apr 2014
    Posts
    323
    Mentioned
    0 Post(s)
    Quoted
    131 Post(s)

    Default

    Quote Originally Posted by rkh3544 View Post
    hey guys. I used this script again yesterday. I tried to get the marks of grace pickup working. It seems like once it gets into the loop that says "for i = 0 to high(gitems) do" it never passes the if statement that says "if instrarrex(gitems[i].getName, str, .....". That if statement checks if the name of the items on the ground matches 'Mark of grace'. For some reason it's not working lol. Anyone fix it?
    How did you figure out where where it was getting stuck?
    If all pork-chops were perfect, we wouldn't have hot-dogs.

  19. #119
    Join Date
    Feb 2013
    Location
    Belgium
    Posts
    86
    Mentioned
    6 Post(s)
    Quoted
    35 Post(s)

    Default

    Quote Originally Posted by hakishakataki View Post
    Using item id's might be a problem because Marks, as they appear on the course, are 'ground items' - which have a different ID than when you have picked it up.
    Their ground item ID is '1.'
    This seems to have fixed it for me!

  20. #120
    Join Date
    Apr 2014
    Posts
    323
    Mentioned
    0 Post(s)
    Quoted
    131 Post(s)

    Default

    Quote Originally Posted by Wooty View Post
    This seems to have fixed it for me!
    Awesome that it fixed it! Nice work!

    EDIT: I'm testing it out. I will report back.

    EDIT2: It's not working . It detects that there is something on the ground but It's not going past this line
    Code:
    if InIntArray([gItems[i].getid], 1) then
    As I'm noobish at debugging.. I've rewritten the procedure to write things when it gets to certain points so that I know what it's doing - it seems to be working.

    Code:
    function lootMark(): Boolean;
    var
      i, id: Integer;
      gItems: TReflectGroundItemArray;
    begin
      if (Course = 'Draynor') then
      begin
        gItems.GetAll(10);
      end
      else if (Course = 'Falador') then
      begin
        gItems.GetAll(6);
      end
      else if (Course = 'Seers') then
      begin
        gItems.GetAll(15);
      end
      else if (Course = 'Varrock') then
      begin
        gItems.GetAll(15);
      end
      if length(gItems) = 0 then
        WriteLn('There arent any ground items... Exiting');
        Exit;
      for i := 0 to high(gItems) do
    
    //untested, credit for this fix to hakishakataki.
      if InIntArray([gItems[i].getid], 1) then
        begin
          WriteLn('Changing compass!');
          Reflect.Compass.MakePitch(3 + Random(3));
          if (findObject(1056406, 4, 4, 0.08, 0.62)) then
          begin
            WriteLn('We have found a mark!');
            Draw('Found Mark');
            case random(10) of
              0..8:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_left);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
              9..10:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_Right);
                  chooseoptionmulti(['Take', 'Mark of grace']);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
            end;
            if (didYellowClick()) then
            begin
              sleep(random(150, 300));
            end;
          end
          else
            inc(markCount);
        end
    end;
    I'm going to check the previous script versions to see what changes were made and If I can garner anything from them about looting marks.

    EDIT 3: We have a break through! So I was messing with the script in front of the seers bank and I found out that it takes a few seconds for the script and smart to correctly pull the ID's of ground items. This gave me the thought that 'maybe the script isn't given enough time to actually 'ID' the marks of grace on the ground.' Soooo, I added a line of code to tell the script to wait a few seconds if it detects any items on the ground...
    Code:
     if length(gItems) > 0 then
        Wait(3000);
    right after
    Code:
    if length(gItems) = 0 then exit;
    and all of a sudden the script began telling me that it was detecting marks of grace! This was exciting because I haven't had the script get the the part where it detects mark of grace yet but it was also confusing because there weren't any marks of grace on the ground. What was happening was that people were training firemaking in front of the bank and the ashes were triggering the line
    Code:
    if InIntArray([gItems[i].getid], 1) then
    and the colour of the fire was triggering the line of code, if
    Code:
    (findObject(1056406, 4, 4, 0.08, 0.62)) then
    .

    Apparently ashes also have the 'Ground ID' of '1'... which is why it was triggering the first line of code.

    EDIT 4: After tinkering around for a while, I found a way to get the code to pick up Marks of Grace reliable without getting stuck on other items. I'll post the code shortly.

    EDIT 5: Here's the code for picking up marks of grace. I've only tested it on the Seers course but so far it's working flawlessly.
    Code:
    function lootMark(): Boolean;
    var
      i, id: Integer;
      gItems: TReflectGroundItemArray;
    begin
      if (Course = 'Draynor') then
      begin
        gItems.GetAll(10);
      end
      else if (Course = 'Falador') then
      begin
        gItems.GetAll(6);
      end
      else if (Course = 'Seers') then
      begin
        gItems.GetAll(15);
      end
      else if (Course = 'Varrock') then
      begin
        gItems.GetAll(15);
      end
      if (reflect.Tiles.getplane = 0) then
        Exit;
      if length(gItems) = 0 then
        Exit;
      if length(gItems) > 0 then
        Wait(3000);
      for i := 0 to high(gItems) do
      if InIntArray([gItems[i].getid], 1) then
        begin
          WriteLn('Changing compass!');
          Reflect.Compass.MakePitch(9 + Random(1));
          if (findObject(1418170, 12, 50, 0.11, 0.89)) then // yellow
          begin
            WriteLn('We have found a mark!');
            Draw('Found Mark');
            case random(10) of
              0..8:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_left);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
              9..10:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptext('Mark of grace', randomrange(50, 300)) then
                    fastClick(mouse_Right);
                  chooseoptionmulti(['Take', 'Mark of grace']);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
            end;
            if (didYellowClick()) then
            begin
              sleep(random(150, 300));
            end;
          end
          else
            Exit;
        end
    end;
    Last edited by hakishakataki; 11-19-2016 at 12:45 AM.
    If all pork-chops were perfect, we wouldn't have hot-dogs.

  21. #121
    Join Date
    Nov 2014
    Posts
    7
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Hm failing falador :/

  22. #122
    Join Date
    Oct 2009
    Posts
    98
    Mentioned
    0 Post(s)
    Quoted
    17 Post(s)

    Default

    Quote Originally Posted by Lipcot View Post
    for the ones having problems with marks of grace not being picked up replace the lootmark function with this: (it has a few changes)

    Simba Code:
    function lootMark(): Boolean;
    var
      i, id: Integer;
      strArr: TStringArray;
      gItems: TReflectGroundItemArray;
    begin
      if (Course = 'Draynor') then
      begin
        gItems.GetAll(10);
      end
      else if (Course = 'Falador') then
      begin
        gItems.GetAll(4);
      end
      else if (Course = 'Seers') then
      begin
        gItems.GetAll(15);
      end
      else if (Course = 'Varrock') then
      begin
        gItems.GetAll(15);
      end
      if length(gItems) = 0 then
        Exit;
      setArrayLength(strArr, 1);
      strArr := ['mark of grace'];
      for i := 0 to high(gItems) do
        if inStrArrEx(gItems[i].GetName, strArr, id) then
        begin
          Reflect.Compass.MakePitch(3 + Random(3));
          if (findObject(691624, 3, 20, 0.02, 0.36)) then
          begin
            Draw('Found Mark');
            case random(10) of
              0..8:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptextmulti(['Mark of grace', 'ark','grace','Grace'], randomrange(50, 300)) then
                    fastClick(mouse_left);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
              9..10:
                begin
                  randomMouseInput(position, 3, 3);
                  if waituptextmulti(['Mark of grace', 'ark','grace','Grace'], randomrange(50, 300)) then
                    fastClick(mouse_Right);
                  chooseoptionmulti(['Take', 'Mark of grace']);
                  waitMove(900);
                  inc(markCount);
                  exit(true);
                end;
            end;
            if (didYellowClick()) then
            begin
              sleep(random(150, 300));
            end;
          end
          else
            inc(markCount);
        end
    end;

    I changed the colours and added uptextMULTI.

    other changes i've made to the default:

    - Mousespeed is (35-65). I believe 35 is to slow and 65 is way to fast, i know it tends to go to the middle but i've put it on 45-55.
    - default breaks are way to long.

    EDIT: varrock eats on every lap, health reading is wrong for me atleast. it is: MyPlayer.GetHealth and should be getCurrentHealth(). change it on procedure "walktoWallV" and it'll fix the overeating
    your edits helped me with the over eating but it didnt help with picking, it just ignores the marks

  23. #123
    Join Date
    Mar 2013
    Location
    Argentina
    Posts
    758
    Mentioned
    27 Post(s)
    Quoted
    365 Post(s)

    Default

    Quote Originally Posted by Gruntzer View Post
    your edits helped me with the over eating but it didnt help with picking, it just ignores the marks
    change the colour of the marks, it searches for the wrong one if dont remember incorrectly
    Formerly known as Undorak7

  24. #124
    Join Date
    Apr 2014
    Posts
    9
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Hi.
    Been using the script for a while now. Im running it in Seers and its doing pretty well.
    When its running from the church to the bank it always runs to the same spot between two houses.
    Some diversity in the movements would be cool thing to add.
    Its not picking all the marks, but that isn't that big of a deal in my opinion.

  25. #125
    Join Date
    Nov 2016
    Posts
    1
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Doesn't work at all in Draynor. Will click onto the first roof and will hover over a tree root attempting to click it as if its the rope.

Page 5 of 7 FirstFirst ... 34567 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •