Originally Posted by
Kyle
OK cool, good reports. Yeah if you want to submit a pull request for them I will merge it. Just make sure the standards match the includes standards. If not, after I get done with exams in a week or so I'll take a look at them
@Kyle;
I finally did something: https://github.com/KyleHunter/OSR-Reflection/pull/105
This is what I did (I think everything I did is documented here...)
Code:
[Reflection Update # 26]
[Adds]
Adds TReflectionInterface
Adds TReflectionShop
Adds TReflectionText.OptionExistsMulti and ChooseOptionMulti
Adds TReflectInvItem.Interact
Adds SmartUserAgent
Adds Reflect.Antiban.HoverSkill
Adds Reflect.Smart.getJavaPath
Adds Reflect.Chat.doConversation
Adds some depositbox functions and procedures to Bank.Simba and improvements
Adds TReflectLocalPlayer.GetName
Adds TReflectionGametab.ClickNorth
Adds TReflectionInventory.CountQuantities
Adds extra optional arguments to TReflectObjectArray.GetAll, TReflectInvItemArray.GetAll and TReflectionTiles.inPolygon
[Fixes]
Fixes TReflectLocalPlayer.SetRun to work when orbs is disabled
Fixes Reflect.Text.GetUpText possible access violation
Fixes Reflect.Smart.GetWorld to get a better world
Fixes Reflect.Chat.NpcChooseOption to choose an option
Fixes TReflectLocalPlayer.FFlag where it might hault entire script
Fixes TReflectObject.GetAt where cache would be free'd before exiting the proc
Fixes TReflectGameTab.Current to work with all tabs
Fixes TReflectLocalPlayer.Logout to work when world switcher is selected
[Changes]
Changes all .Find and .Get and .Count functions to work with variant arrays
Changes World to SmartWorld
Changes TReflectWornEquipment to be more consitant with other item types
Various house keeping with Globals.Simba and GetIndex, GetSlot
[ToDo]
Fix TReflectAnyArray.Sort ommitting recurring tile renderables
Fix TReflectionTiles.inPolygon not including end tiles
Update all definitions
Fix TReflectionChat.GetChatIndices
Add TReflectionBank deposit box functions to deposit items
Add activate special attack
Possibly add break handler and randoms handler
[End]
I kept to the include's standards and tried to make my code blend as much as possible.