This script is a Lumbridge River fisher and banker. The script:
- Walk to the fishing spots
- Finds the fishing bubbles
- Fishes until a full inventory
- Walks to the bank
- Deposits
- Starts over.
- Has antiban
- Uses ACA, TPA, and ATPA to find fishing spot
- 40k fishing xp/hr
- Banks 53.8k xp/hr worth of fish!
- for ironmen/women needing 99 fishing and cooking
Credits To:
- @The Mayor; for his tutorials and isinpolygon SPS function
- @Coh3n; for his tutorials
- @KeepBotting; for his Karamja Fisher (used some of his coding) and his recommendation to fix a function
- @Ashaman88; for helping me understanding "case" in antiban (from his scripts)
- NOTE: No plans on public release of a working script. Possible Jr. member release once I rewrite everything after finals.
Unfortunately, the script is one failsafe away from working for long periods of time. At the Lumbridge fishing spot, there are only two bubble "spots", and they can spawn off screen. The "spots" can either be at the north part of the river, or the south part of the river. The script works fine until both fishing "spots" are off screen. The original path of walking to the river gets me to the north side. When the two bubble "spots" move to the south side, the script gets stuck and eventually the player is logged out for being idle too long.
I tried fixing this by adding a procedure that walks to the south side of the river, to use in case the bubble "spot" was not found. But, then I thought, what if the bubbles move again? So I tried creating a procedure that would walk to the opposite side of the river, if the bubble color is not present. This is where I am stuck. My original attempt (script version 1.0) was using if..then..else statements, which did not end up working the way I used them. The player just stood idle when the bubble colors were not found I then tried to use another method.
The second method (version 1.1) I used was to check if my player was on the north part of the river, if he was, I would walk to the south part of the river. If the player was not at the north part of the river, he would walk to the north part. That way he would walk to the opposite side if the bubbles were not found. He still stood idle.
HOWEVER, I then changed the color of what was being searched (to make the color automatically not on the screen). For version 1.0 the player remained idle, for version 1.1 he ran to the south side of the river, but did not run back to the north. If someone could please look over my procedure to see what I did wrong, I would greatly appreciate it. I've marked the location to where the procedures I mentioned are (line 168 for version 1.0 and line 187 for version 1.1). If you feel one method is better than the other, review that specific script only.
Version 1.2 is working. Willing to PM to people that are interested in helping me improve it. It's still barebones. :
================================================== ======
Sephiroths Lumbridge FishAndBank
Time Ran: 4 Hours, 57 Minutes and 34 Seconds
Fish Caught: 3078
Loads Done: 114
Catches Per Hour: 621
Experience Gained: 178524
Experience Per Hour: 35997
================================================== ======
================================================== ======
Sephiroths Lumbridge FishAndBank
Time Ran: 4 Hours, 55 Minutes and 28 Seconds
Fish Caught: 3159
Loads Done: 117
Catches Per Hour: 641
Experience Gained: 183222
Experience Per Hour: 37206
================================================== ======
Version 1.3 has fixed colors and better wait times.
================================================== ======
Sephiroths Lumbridge FishAndBank
Time Ran: 5 Hours, 54 Minutes and 26 Seconds
Fish Caught: 4158
Loads Done: 154
Catches Per Hour: 704
Experience Gained: 241164
Experience Per Hour: 40825
================================================== ======
Version 2.0 Plans:
- Increased failsafes
- Better colors to improve speed
- Better detection of fishing spot moved while fishing
- Playerform GUI
- Break system
- 6 hour fix
- Pretty painted proggy