Page 1 of 2 12 LastLast
Results 1 to 25 of 40

Thread: SRL: March 30th, 2013 ~ Small mouse & Radial walk fixes

  1. #1
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default SRL: March 30th, 2013 ~ Small mouse & Radial walk fixes

    Thanks to this cool guy @core and @Hobbit;

    • Randomness added to the mouse will now randomly add OR subtract the amount, previously randomness only added. - reverted.
    • Changes to increase the performance of the mouse function by 40.000545453450606%.
    • Radial walk should now function correctly
    • Added compass directions to RadialWalkEx, ex. 'n', 's', etc.


    Note: This affects both SRL5 and OSR-SRL
    Last edited by Olly; 04-02-2013 at 01:52 PM.

  2. #2
    Join Date
    Dec 2011
    Location
    Toronto, Ontario
    Posts
    6,424
    Mentioned
    84 Post(s)
    Quoted
    863 Post(s)

    Default

    Randomness added to the mouse will now randomly add OR subtract the amount, previously randomness only added.
    About time! Great work all of you!

  3. #3
    Join Date
    Sep 2010
    Posts
    5,762
    Mentioned
    136 Post(s)
    Quoted
    2739 Post(s)

    Default

    Good to hear I saw a couple people said radial didn't work

  4. #4
    Join Date
    Dec 2011
    Posts
    164
    Mentioned
    4 Post(s)
    Quoted
    23 Post(s)

    Default

    Wonderful! Finally a walking method that will work for RS07!

    Great work!

  5. #5
    Join Date
    Jan 2012
    Posts
    468
    Mentioned
    3 Post(s)
    Quoted
    200 Post(s)

    Default

    Quote Originally Posted by Ollybest View Post
    Thanks to this cool guy @core and @Hobbit;

    • Randomness added to the mouse will now randomly add OR subtract the amount, previously randomness only added.
    • Changes to increase the performance of the mouse function by 40.000545453450606%.
    • Radial walk should now function correctly
    • Added compass directions to RadialWalkEx, ex. 'n', 's', etc.


    Note: This affects both SRL5 and OSR-SRL
    Wow finally I have waited to test this out! SPS just sucks! And so do DTMS!

  6. #6
    Join Date
    Nov 2008
    Location
    Melbourne, Australia
    Posts
    2,240
    Mentioned
    3 Post(s)
    Quoted
    11 Post(s)

    Default

    The new mouse change has ruined my scripts. Is there anyway I can use the mouse function prior to this update? I do not have it saved anywhere as SRL automatically updated.
    Click here to find out how to get full screen without members! | Click here to check out my Ultimate Bitmap Tutorial! Edited to work with Simba! |

  7. #7
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    Quote Originally Posted by cycrosism View Post
    The new mouse change has ruined my scripts. Is there anyway I can use the mouse function prior to this update? I do not have it saved anywhere as SRL automatically updated.
    I was surprised that the pull request got accepted for this exact reason not only users scripts but also some of SRL was broken.

  8. #8
    Join Date
    Jan 2007
    Posts
    8,876
    Mentioned
    123 Post(s)
    Quoted
    327 Post(s)

    Default

    Wow, yeah, that mouse matter has been around for years now and we have always settled on it being too much a hassle to change all scripts if we do this..
    Why was it pulled now?

  9. #9
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    Maybe @Hobbit can enlighten us

  10. #10
    Join Date
    Oct 2006
    Location
    ithurtsithurtsithurtsithurts
    Posts
    2,930
    Mentioned
    7 Post(s)
    Quoted
    135 Post(s)

    Default

    Yeah, I remember being part of a discussion a while ago about whether or not we should do this, and the consensus was "no, it'll break too many things."

  11. #11
    Join Date
    Feb 2007
    Location
    PA, USA
    Posts
    5,240
    Mentioned
    36 Post(s)
    Quoted
    496 Post(s)

    Default

    Any bitmap clicking procedures/functions are now broken?

  12. #12
    Join Date
    Jan 2012
    Posts
    468
    Mentioned
    3 Post(s)
    Quoted
    200 Post(s)

    Default

    No wonder I was getting mouse errors on all my scripts! Uhh!

  13. #13
    Join Date
    Mar 2006
    Posts
    13,241
    Mentioned
    228 Post(s)
    Quoted
    267 Post(s)

    Default

    Quote Originally Posted by Ollybest View Post
    I was surprised that the pull request got accepted for this exact reason not only users scripts but also some of SRL was broken.
    How

    Quote Originally Posted by Zyt3x View Post
    Wow, yeah, that mouse matter has been around for years now and we have always settled on it being too much a hassle to change all scripts if we do this..
    Why was it pulled now?
    Where

    Quote Originally Posted by Rules of Joe View Post
    No wonder I was getting mouse errors on all my scripts! Uhh!
    This wouldn't actually cause any errors... Purely a functional thing.
    STOP PM'ING ME

  14. #14
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    Quote Originally Posted by Hobbit View Post
    How



    Where



    This wouldn't actually cause any errors... Purely a functional thing.
    https://github.com/SRL/SRL-5/commit/...258aaec48113b5

    for years mouse randomness only added, like Zyt3x was saying it was always kept like this because it would be a huge hassle because it would break alot of things.

  15. #15
    Join Date
    Mar 2006
    Posts
    13,241
    Mentioned
    228 Post(s)
    Quoted
    267 Post(s)

    Default

    Quote Originally Posted by Ollybest View Post
    https://github.com/SRL/SRL-5/commit/...258aaec48113b5

    for years mouse randomness only added, like Zyt3x was saying it was always kept like this because it would be a huge hassle because it would break alot of things.
    I know which commit it is, I commited it.

    How exactly does it break things?

    Ex:
    Mouse(x,y,6,6, mouse_Left)
    This will still work the same, 6 is still the total amount of randomness added to the point, however it actually makes sense now because its possibly +3 or -3, but still same amount of randomness.
    STOP PM'ING ME

  16. #16
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    Quote Originally Posted by Hobbit View Post
    I know which commit it is, I commited it.

    How exactly does it break things?

    Ex:
    Mouse(x,y,6,6, mouse_Left)
    This will still work the same, 6 is still the total amount of randomness added to the point, however it actually makes sense now because its possibly +3 or -3, but still same amount of randomness.
    Yeah it makes sense now but thing still need changing mostly in peoples scripts, such as if a bitmap is returned it finds the top left point, and now mouse(x, y, 15, 15, MOUSE_LEFT) could possibly click off the bitmap, an example in SRL was that closeBank was broken, its fixed now though but im sure there's more.

  17. #17
    Join Date
    Mar 2006
    Posts
    13,241
    Mentioned
    228 Post(s)
    Quoted
    267 Post(s)

    Default

    Then revert it? And if you thought it was such an issue why didn't you bring it up when you posted this thread.
    Still not an issue IMO but do whatever.
    STOP PM'ING ME

  18. #18
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    I did this in SRL6 effectively letting the scripter decide whether to add or subtract the randomness, but allowing for either one. This is helpful, and nearly necessary as it allows for the scripter to specify in which direction to add randomness.
    Simba Code:
    function TPoint.rand(xx, yy : Integer): TPoint;
    var
      nx, ny, rx, ry: integer;
    begin
      nx := xx div abs(xx);   //div by self to determine positive or negative
      ny := yy div abs(yy);

      rx := random(xx) * nx;
      ry := random(yy) * ny;

      result.x := x + rx;
      result.y := y + ry;
    end;
    I know I've been gone for a bit, but this particular change probably could have waited until SRL6 is released.

    Everything else seems to be all well though. Nice job everyone!

  19. #19
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    Quote Originally Posted by Hobbit View Post
    Then revert it? And if you thought it was such an issue why didn't you bring it up when you posted this thread.
    Still not an issue IMO but do whatever.
    When I posted this I didn't really think that it could break stuff until I started seeing complaints about closeBank not working, and IMO it is far better as it actually makes sense but people need to be warned that this update happened.

  20. #20
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Ollybest View Post
    When I posted this I didn't really think that it could break stuff until I started seeing complaints about closeBank not working, and IMO it is far better as it actually makes sense but people need to be warned that this update happened.
    SRL5 as a whole will need to be adjusted then, as well as ALL scripts. Is this really worth the effort considering people will have do update EVERYTHING again once SRL6 is pushed out? I'm not sure of SRL6's exact status as I've been away, but I can't imagine it's far off; especially now that I'll be back around

  21. #21
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    SRL5 as a whole will need to be adjusted then, as well as ALL scripts. Is this really worth the effort considering people will have do update EVERYTHING again once SRL6 is pushed out? I'm not sure of SRL6's exact status as I've been away, but I can't imagine it's far off; especially now that I'll be back around
    Well its up to hobbit or a srl dev to make the decision on that , but now your back around get that mapwalk finished!

  22. #22
    Join Date
    Nov 2008
    Location
    Melbourne, Australia
    Posts
    2,240
    Mentioned
    3 Post(s)
    Quoted
    11 Post(s)

    Default

    Could we please get rid of this change and bring back the good mouse procedure? The new one is just awful. Since I have started the mouse procedure was always the randomness added on, which was good. Because for bitmaps (Which I use heavily in my scripts) it adds on from the very top left of the bitmap. If it takes randomness OFF, then it is going to completely miss the bitmap. I was wondering why the hell my script kept missing the bitmap when I realised that it wasn't my script, it was something in SRL that had broken my scripts.

    Please change it back.
    Click here to find out how to get full screen without members! | Click here to check out my Ultimate Bitmap Tutorial! Edited to work with Simba! |

  23. #23
    Join Date
    Dec 2011
    Location
    Hyrule
    Posts
    8,662
    Mentioned
    179 Post(s)
    Quoted
    1870 Post(s)

  24. #24
    Join Date
    Mar 2006
    Posts
    13,241
    Mentioned
    228 Post(s)
    Quoted
    267 Post(s)

    Default

    Bank update shouldn't need to be reverted, makes more sense now also.

    STOP PM'ING ME

  25. #25
    Join Date
    Jan 2012
    Posts
    468
    Mentioned
    3 Post(s)
    Quoted
    200 Post(s)

    Default

    @Hobbit It is causing Errors Because P07Incude is having MMouse Errors and I looked through the code and doesnt look wrong!

Page 1 of 2 12 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •