Results 1 to 14 of 14

Thread: Bank.simba; updated [12-9-2013]

  1. #1
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,421
    Mentioned
    268 Post(s)
    Quoted
    1442 Post(s)

    Default Bank.simba; updated [17-10-2013]

    Heya,

    So a few hours ago OSRS was updated with some extra features added to bank accounts in-game and it might have broken some of your scripts. So I took a bit of time and updated a couple things to handle all the changes they made. A handful of functions updated and some new procedures added. Here's what was updated in-game:



    And here's what I fixed/added:
    • BankScreen function fixed
    • WithdrawEx updated to use pre-defined X amounts
    • Notes procedure updated
    • SearchBank procedure added
    • Added QuickDeposit pocedure
    • Added getBankItemCount function
    • Handling of 'Withdraw-All-but-one'


    -Install instructions-
    Simply replace your current "bank.simba" with the one I attached to this post. You'll find it in "Includes > SRL-OSR > SRL > core > bank.simba".

    Edit:
    Oh yes, whoever maintains the SRL-OSR include via Github, verify this and add it to the include ASAP.
    Attached Files Attached Files
    Last edited by Flight; 10-17-2013 at 02:49 PM.

    Current projects:
    [ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


  2. #2
    Join Date
    Sep 2012
    Location
    Netherlands
    Posts
    2,752
    Mentioned
    193 Post(s)
    Quoted
    1468 Post(s)

    Default

    thanks flight!

    btw: hooks are not changed this update

  3. #3
    Join Date
    Feb 2012
    Location
    UK
    Posts
    909
    Mentioned
    10 Post(s)
    Quoted
    191 Post(s)

    Default

    Great work and super fast. Cheers Flight.
    Good news about the hooks too.
    Solar from RiD.

  4. #4
    Join Date
    Aug 2011
    Posts
    14
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Thanks!
    I fixed some global constants too, cause i use BankIndexToMSBox() func.
    Global constants that have to be changed are MBX1,MBX2,MBY1,MBY1,MBCX,MBCY.
    these are my vals:
    MBX1 = 73;
    MBY1 = 71;
    MBX2 = 446;
    MBY2 = 280;

  5. #5
    Join Date
    Aug 2012
    Posts
    13
    Mentioned
    0 Post(s)
    Quoted
    4 Post(s)

    Default

    Thank you! Much appreciated, very very nice of you

  6. #6
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,421
    Mentioned
    268 Post(s)
    Quoted
    1442 Post(s)

    Default

    Quote Originally Posted by repahu View Post
    Thanks!
    I fixed some global constants too, cause i use BankIndexToMSBox() func.
    Global constants that have to be changed are MBX1,MBX2,MBY1,MBY1,MBCX,MBCY.
    these are my vals:
    Thank you, I didn't know notice they needed to be change. If you've verified that they're correct then I'll update the OP with your changes.

    Current projects:
    [ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


  7. #7
    Join Date
    Aug 2011
    Posts
    14
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Quote Originally Posted by Flight View Post
    Thank you, I didn't know notice they needed to be change. If you've verified that they're correct then I'll update the OP with your changes.
    They work fine for me. There can be 1px diff, cause my mouse moves 2px steps even if i set the mouse DPI to minimal.
    You might have noticed, that 1 row has been removed and the gap between the slots have been changed on the Y axis. So in bank.simba(your version) line 521 needs some correction.
    Result := Point(MBX1 + ((Index mod 8) * 48), MBY1 + (44 * (Index div 8)));

  8. #8
    Join Date
    Sep 2008
    Posts
    754
    Mentioned
    8 Post(s)
    Quoted
    275 Post(s)

    Default

    Needs to be committed to the official include as well.

    Nice work flight.

  9. #9
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    @Flight

    Thought id give 07 some love.... https://github.com/SRL/SRL-OSR/commi...c146d5cb9d36b8

    Only added your bank.simba, but if anything else needs adding feel free to pm/posthere just make sure works

  10. #10
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,421
    Mentioned
    268 Post(s)
    Quoted
    1442 Post(s)

    Default

    Quote Originally Posted by Olly View Post
    @Flight

    Thought id give 07 some love.... https://github.com/SRL/SRL-OSR/commi...c146d5cb9d36b8

    Only added your bank.simba, but if anything else needs adding feel free to pm/posthere just make sure works
    Awesome, thank you. I'll drop you a line if I come across anything else for sure.

    Current projects:
    [ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


  11. #11
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,421
    Mentioned
    268 Post(s)
    Quoted
    1442 Post(s)

    Default

    The recent update broke the current Bank.simba so I've updated it to work with the current RS. It should now once again correctly handle withdrawing items. Also "Withdraw-All-but-one" was included in this patch, to use this option simply set "-1" as the amount to be withdrawn.

    Current projects:
    [ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


  12. #12
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

  13. #13
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,421
    Mentioned
    268 Post(s)
    Quoted
    1442 Post(s)

    Default

    Very good, thank you once again Mr Olly.

    Current projects:
    [ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


  14. #14
    Join Date
    Nov 2011
    Location
    Australia
    Posts
    418
    Mentioned
    2 Post(s)
    Quoted
    86 Post(s)

    Default

    Good job Flight, thanks for this

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •