Page 1 of 2 12 LastLast
Results 1 to 25 of 39

Thread: [Catherby] Fisher [Lobsters]

  1. #1
    Join Date
    Jan 2013
    Location
    Finland
    Posts
    130
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default [Catherby] Fisher [Lobsters]

    Simple as it gets, catherby fisher. For lobsters.
    You may have seen my RSPS scripts which are similar.

    How it works ?
    Start near bank
    Checks if you have cage, if not then logs out does nothing and reports the lack of cage!
    Walks to fishing spot
    Finds fishing spot, somewhat intelligent since it does not click whirlpools
    Starts fishing
    Does antibans (Randomly right clicks, moves screen around and so on)
    Checks if you are fishing
    If you are not fishing then checks for cage option again, if not found then moves on to next spot
    When inventory is full walks to deposit box and empties inventory (Needs better way to find the deposit box, works now fine though) (Needs to be improved, currently checks if there is lobster on last spot of inventory)
    Starts again

    Things that need to be worked on
    Need better method for finding fishing spot,maybe?
    Need better method for finding deposit box
    Perhaps better proggy?
    Better check for full inventory
    Add check for randoms!
    Add check for having level

    REQUIRES
    Smart 8.3 - http://villavu.com/forum/showthread.php?t=105548
    Reflection - http://villavu.com/forum/showthread.php?t=107698
    SRL-OSR - http://villavu.com/forum/showthread.php?t=99577
    These might help with problems
    http://villavu.com/forum/showthread.php?t=106693
    http://villavu.com/forum/showthread.php?t=47714

    Coming soon
    Check if not running, starts running
    Check your current hp, runs to bank if facing danger
    More antibans
    Random support

    Currently seems to work pretty much fine, except when facing randoms.
    I personally do recommend babysitting since no support for randoms, but will fish until facing randoms.

    I DO take suggestions towards the script, if you have one feel free to post
    If you are so lucky that it runs longer periods please take print screen/copy of the proggy!
    Seriously would appreciate to see how its working
    Attached Files Attached Files

  2. #2
    Join Date
    Feb 2014
    Posts
    1
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Looks like a nice script but i'm having the following error when i try to start up:
    Exception in Script: Unable to find file 'SRL-OSR/SRL/Reflection/Reflection.simba' used from 'C:\Simba\Scripts\LobsterFisher.simba'

  3. #3
    Join Date
    Jan 2013
    Location
    Finland
    Posts
    130
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

  4. #4
    Join Date
    Feb 2013
    Location
    Narnia
    Posts
    615
    Mentioned
    8 Post(s)
    Quoted
    252 Post(s)

    Default

    nice release! simple and clean code. good job

    improvements/suggestions:
    use variables that are easier to understand/know whats going on. later youre going to come back to this script to improve it and you might forget what c v b m z meant.

    deposit box issue could be resolved by using the same function you used to find the fishing spots rather then a bitmap

    make sure you free your dtms all the way. add this where you declare all your setups

    AddOnTerminate('FreeBitmaps');

    View my OSR Script Repository!


    Botted to max
    Guides: How to Report Bugs to the Scripter
    ~~~~ Moved to Java. Currently Lurking ~~~~

  5. #5
    Join Date
    Jan 2013
    Location
    Finland
    Posts
    130
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Thanks, was aiming for cleaner code but was too lazy. Will make more clear later

    Idea is nice to use variables, has some work but nothing that cant be done!

    Well im using same system for finding the deposit as finding the boxes. Bitmaps im using for finding the actual lobster and deposit option after right clicking the fish.

  6. #6
    Join Date
    Jan 2013
    Location
    Finland
    Posts
    130
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Updated, new version in original post
    First test run with new changes, so far so good. No randoms faced.


  7. #7
    Join Date
    Feb 2006
    Location
    Australia
    Posts
    628
    Mentioned
    15 Post(s)
    Quoted
    105 Post(s)

    Default

    Cool script, I like that you used reflection
    Standards were a bit whack though

  8. #8
    Join Date
    Jan 2013
    Location
    Finland
    Posts
    130
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Standards?

    Little explanation would help, english is not my native language !

  9. #9
    Join Date
    Feb 2006
    Location
    Australia
    Posts
    628
    Mentioned
    15 Post(s)
    Quoted
    105 Post(s)

    Default

    Quote Originally Posted by joulaha View Post
    Standards?

    Little explanation would help, english is not my native language !
    Standards, basically it's indentation.. But it can also mean to prefer more optimised declarations over crude structure..
    Here's a link to basic pascal standards, it's not quite pascalscript, but it's very similar..
    http://www.gnu-pascal.de/h-gpcs-en.html

  10. #10
    Join Date
    Feb 2013
    Location
    United States
    Posts
    53
    Mentioned
    2 Post(s)
    Quoted
    12 Post(s)

    Default

    Thank you for posting your script.

    Apparently my account cannot post new threads due to a bug on the website (something to do with javascript) I took the liberty of taking your ideas and completely rewriting your script to be a little (i think) better.

    Now, my guy is not yet level 40 fishing so I adapted it to fish tuna, but if you take the time to read through it i think you'll find you can easily apply my idea to any other fishing pool. Feel free to take the code and update your own however you'd like.

    This script requires the same things yours did. Does:
    Randoms
    Fishes stuff
    goes to bank when full
    checks if your fishing tool is there
    will withdraw new tool from first bank slot if lost

    does not:
    no real concrete whirlpool (taken straight from yours no additions) but mine has not lost his fishing tool once yet
    does not find tool if thrown away

    Code:
    program Fisher;
    {$DEFINE SMART8}
    {$I SRL-OSR/SRL.Simba}
    {$I SRL-OSR/SRL/Reflection/Reflection.simba}
    {$i SRL-OSR/SRL/misc/al_functions.simba}
    
    var
      X,Y,TriedTimes,currentspot,fuckups: Integer;
      pin,tool:string;
      myloc:tpoint;
    
    Procedure DeclarePlayers;
    Begin
      HowManyPlayers := 1;
      NumberOfPlayers(HowManyPlayers);
      CurrentPlayer := 0;
      Players[0].Name :='';
      Players[0].Pass :='';
      Players[0].Nick :='';
      Players[0].Active:=True;
      pin:='';
      SetScreenName(Players[CurrentPlayer].Nick);
    End;
    
    procedure initvars;
    begin
      currentspot:=1;
      fuckups:=0;
      tool:='Harpoon';
    end;
    
    function checkTool: boolean;
    begin
      invmouse(1,3);        //assumes tool is in first slot of inv, playa
      if(isuptext(tool)) then
      begin
        result:=true;
      end
      else
        result:=false;
    end;
    
    Procedure TurnOnRun;
    begin
      if (GameTab(tab_Options)) then
      begin
        if (CountColorTolerance(2369440, 649, 415, 680, 446, 20)<1) then
          MouseBox(654, 420, 677, 443, mouse_left);
      end;
    end;
    
    procedure withdrawTool;
    begin
      Withdraw(0, 0, 1);// TOOL in first slot of bank, must be scrolled up all the way bruh
    end;
    
    Procedure Antiban;
    begin
      case random(45) of
        1: HoverSkill(randomrange(1,17), False);
        2: HoverOnlineFriend;
        3: compassmovement(100,150,false);
        4..7: BoredHuman;
        8: Turnonrun;
        9: RandomFKeys(false);
        10: MMouseOffClient('random');
        11: PressKey(randomrange(1,4));
        12..15: AL_HumanRandomMouse;
      end;
    end;
    
    procedure OpenBank1;
    var x, y: integer;
    begin
      MakeCompass('n');
      writeln('openbank');
      Repeat
        If(not Bankscreen and FindObj(x, y, 'ank booth', 9145751, 10)) then
        begin
          wait(randomrange(600,1000));
          Mouse(RandomRange(X - 5, x + 5), RandomRange(Y - 5, Y + 5), random(3), random(3), false);
          wait(randomrange(600,1000));
          ChooseOptionMulti(['Bank']);
          wait(randomrange(2000,2500));
          if(pinpending) then
            confirmpin;
          if(pinscreen) then
            inpin(pin);
        end
        else
        begin
          if(((myloc.x<2806) or (myloc.x>2812)) or ((myloc.y>3441) or (myloc.y<3438))) then    //not in bank (coordinates)
          begin
            writeln('Bank contingency.');
            R_BlindWalk(Point(2811, 3440));
          end;
          compassmovement(100,150,false);
          fuckups:=fuckups+1;
        end;
      until(BankScreen or (fuckups>20))
    end;
    
    function checkPool : boolean;    //checks if right kinda patch, ya dig  ???
    begin
      if(OptionsExist(['Cage Fishing spot'], false) and OptionsExist(['Harpoon Fishing spot'], true)) then
      begin
        result:=true;
      end
      else
        result:=false;
    end;
    
    procedure gotobank;
    begin
      turnonrun;
      currentspot:=1;
      R_BlindWalk(Point(2810, 3440));
      wait(randomrange(1000,1500));
      myloc:=R_GetTileGlobal;
      if(((myloc.x<2806) or (myloc.x>2812)) or ((myloc.y>3441) or (myloc.y<3438))) then    //not in bank (coordinates)
      begin
        writeln('Bank contingency.');
        R_BlindWalk(Point(2811, 3440));
      end;
    end;
    
    procedure NextSpot;
    begin
      turnonrun;
      case (currentspot) of
        1:
        begin
           R_BlindWalk(Point(2845, 3428));//Spot2
           currentspot:=2;
        end;
        2:
        begin
           R_BlindWalk(Point(2854, 3422));//Spot3
           currentspot:=3;
        end;
        3:
        begin
           R_BlindWalk(Point(2860, 3426));//Spot4
           currentspot:=4;
        end;
        4:
        begin
           R_BlindWalk(Point(2837, 3430));//Spot1
           currentspot:=1;
        end;
      end;
    end;
    
    procedure gotofish;
    begin
      turnonrun;
      currentspot:=1;
      R_BlindWalk(Point(2837, 3430));//Spot1
    end;
    
    procedure FindFish;
    begin
      wait(800+random(200));
      if (FindObjCustom(x,y,['Cage','age','Cag'],[4597535, 14597268, 15123625, 14398100, 15058085],15) and (not clicktocontinue)) then
      begin
        Wait(randomrange(600,800));
        mouse(x,y,3,3,false);
        if(checkPool) then
        begin
          chooseoptionmulti(['Harpoon','arpoon']);
          TriedTimes:=0;
          wait(randomrange(1000,1400));
        end
        else
        begin
          chooseoptionmulti(['Cancel','ancel']);
          TriedTimes:=TriedTimes+1;
        end;
      end
      else
      begin
        if(clicktocontinue) then
        begin
          if(not checktool) then
          begin
            writeln('checktool failed');
            gotobank;
            openbank1;
            deposit(2,28,true);
            withdrawtool;
            closebank;
            gotofish;
          end;
        end;
        compassmovement(100,150,false);
        TriedTimes := TriedTimes + 1;
        fuckups:=fuckups+1;
      end;
      if(triedTimes>1)then
      begin
        Nextspot;
        wait(randomrange(1500,2000));
      end;
    end;
    
    procedure StartBotting;
    begin
      repeat
        findnormalrandoms;
        findnoninventoryrandoms;
        solvebox;
    
        if(invfull)then
        begin
          gotobank;
          openbank1;
          if(bankscreen) then
          begin
            fuckups:=0;
            deposit(2,28,true);
          end;
          closebank;
          gotofish;
        end;
        if((not invfull) and (not r_isanimating) and (not al_playerwalking))  then
        begin
          if(not clicktocontinue) then  //incase popup chat that says inv is full
          begin
            findfish;
          end
          else
          begin
            if(not checktool) then
            begin
              writeln('Tool not found, lost or wrong uptext found');
              gotobank;
              openbank1;
              withdrawtool;
              closebank;
              currentspot:=1;
              gotofish;
            end;
          end;
        end
        else
        begin
          if(r_isanimating) then
            antiban;
        end;
      until((not LoggedIn) or (fuckups>20));
      if(fuckups>20) then
      begin
        writeln('ya dun fucked up');
        terminatescript;
      end;
    end;
    
    begin
      activateclient;
      SetupSrl;
      SetupReflection;
      DeclarePlayers;
      SetScreenName(Players[CurrentPlayer].Nick);
      ActivateClient;
      ClearDebug();
      initvars;
      AddOnTerminate('srl_FreeBitmaps');
      if(not loggedin) then
        loginplayer;
      StartBotting;
    end.


    what makes the mothafucka so damn fresh
    Last edited by vizzyy; 02-21-2014 at 10:41 PM.

  11. #11
    Join Date
    Feb 2014
    Posts
    1
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    as soon as i click start the first thing it says is no fishing cage? but theres a lobster pot in my inventory?

  12. #12
    Join Date
    Jan 2013
    Location
    Finland
    Posts
    130
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Do you have it first slot, highest brightness?
    And keep inventory tab open when you start script!

  13. #13
    Join Date
    Mar 2014
    Posts
    1
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    [Error] C:\Simba\Includes\SRL-OSR\SRL\Reflection\AntiRandoms\R_ForesterSolve.sim ba(65:10): Unknown identifier 'R_FindFreeNpc' at line 65
    Compiling failed.
    i get this what does it mean?

  14. #14
    Join Date
    Oct 2012
    Posts
    32
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    Exception in Script: Plugin(libsmartremote32) has not been found


    Where will i find the script?

  15. #15
    Join Date
    Jan 2012
    Posts
    537
    Mentioned
    1 Post(s)
    Quoted
    16 Post(s)

    Default

    it gets stuck alot when going to the bank since he moves the camera alot
    Last edited by wister1; 04-08-2014 at 01:53 PM.

  16. #16
    Join Date
    Mar 2012
    Location
    The Netherlands
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Its getting stuck when it opens the deposit box!

  17. #17
    Join Date
    Apr 2014
    Posts
    46
    Mentioned
    1 Post(s)
    Quoted
    27 Post(s)

    Default

    it doesent seem to work for me.i can't find where to put the name/pass in.can someone please walk me through the process?

  18. #18
    Join Date
    Mar 2012
    Location
    The Netherlands
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Quote Originally Posted by goswag View Post
    it doesent seem to work for me.i can't find where to put the name/pass in.can someone please walk me through the process?
    It doesn't have the automatic login support

    1.Run the script
    2.Login
    3.Run it again (End it, run it again and don't close Smart)
    4.???
    5.Profit

    also a tip check regulary your bot because this script doesn't support random events and it get sometimes stuck at the bank!

  19. #19
    Join Date
    Oct 2012
    Location
    Australia, Sydney
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    It's getting stuck everytime at the bank for me? :/

    Nice script otherwise, Any ideas on a fix?
    I WILL RIDE TILL I DIE

  20. #20
    Join Date
    May 2014
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Not working for me this is what it says when trying to boot up: Exception in Script: Unable to find file 'SRL-OSR/SRL/misc/al_functions.simba'

  21. #21
    Join Date
    May 2014
    Posts
    1
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Saucy, you need that include file.

    Get it here: http://villavu.com/forum/showthread.php?t=108415

  22. #22
    Join Date
    Nov 2011
    Posts
    6
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    fixed
    Last edited by dojo; 05-11-2014 at 03:05 PM.

  23. #23
    Join Date
    Mar 2013
    Posts
    24
    Mentioned
    0 Post(s)
    Quoted
    13 Post(s)

    Default

    Can we get one of these script geniuses to make this thing fish sharks as well? I'm not qualified. EDIT : JK all I had to do was copy paste Vizzyy's modified version to fish Tunas, and change the 'cage' options to 'net', and it works pretty well, but I can't get it to bank them at all. It gets to the bank and opens the bank booth, and then hovers over various items in my bank and never continues past that point, if somebody has a quickfix for that problem
    Last edited by Stick1234; 05-15-2014 at 01:02 AM.

  24. #24
    Join Date
    Jun 2014
    Posts
    6
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    I really like this script but sadly i cannot leave it, i must keep my eye on it.

    What i have noticed is that i loves to bank my lobsters in the bank. But just sometimes he goes to the deposit box insted, and gets stuckt, or he banks everything including my cage and then gets stuckt. Or he dosent bank at all.
    But for me it always seems to end there, i tried to restart the script a few times but its really that issue only.

    Otherwise 5/5 i like it, it fishes does its job. Just gets stuckt a few times, but if your around and can keep an eye on it. Sure its a great script! GJ!

  25. #25
    Join Date
    Feb 2013
    Posts
    2
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Help please, I keep getting the following error messagE:
    Exception in Script: Operator expected at line 394, column 26 in file "C:\Simba\Includes\SRL-OSR\SRL\Reflection\Core\Tiles.simba"

Page 1 of 2 12 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •